public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libstdc++/13369] __verify_grouping (and __add_grouping?) not correct
2003-12-09 14:15 [Bug libstdc++/13369] New: __verify_grouping (and __add_grouping?) not correct paolo at gcc dot gnu dot org
@ 2003-12-09 14:15 ` paolo at gcc dot gnu dot org
2003-12-09 14:30 ` paolo at gcc dot gnu dot org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: paolo at gcc dot gnu dot org @ 2003-12-09 14:15 UTC (permalink / raw)
To: gcc-bugs
--
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Ever Confirmed| |1
Last reconfirmed|0000-00-00 00:00:00 |2003-12-09 14:15:28
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13369
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/13369] New: __verify_grouping (and __add_grouping?) not correct
@ 2003-12-09 14:15 paolo at gcc dot gnu dot org
2003-12-09 14:15 ` [Bug libstdc++/13369] " paolo at gcc dot gnu dot org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: paolo at gcc dot gnu dot org @ 2003-12-09 14:15 UTC (permalink / raw)
To: gcc-bugs
This is one those internal memos...
I'm comparing 22.2.3.1.2, p3 to our current implementation, some things seem
wrong. For instance, in __verify_grouping, when __j == __len, we exit the for
loop, then enter it again with __j reset to zero and do the for loop again.
This is not ok: instead, we should from now on keep __j fixed at __len - 1.
Example: "\04\03\02", means that 12,34,56,789,0123 is ok, that is, the final
\02 matches any number of initial two digits groups.
Also, if a group has value <= 0 it means an unlimited size for the group (of
course it's meaningful only as the last group) and should match *any* possible
length for the first parsed group.
--
Summary: __verify_grouping (and __add_grouping?) not correct
Product: gcc
Version: 3.4
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: libstdc++
AssignedTo: paolo at gcc dot gnu dot org
ReportedBy: paolo at gcc dot gnu dot org
CC: gcc-bugs at gcc dot gnu dot org
GCC host triplet: Any
GCC target triplet: Any
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13369
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/13369] __verify_grouping (and __add_grouping?) not correct
2003-12-09 14:15 [Bug libstdc++/13369] New: __verify_grouping (and __add_grouping?) not correct paolo at gcc dot gnu dot org
2003-12-09 14:15 ` [Bug libstdc++/13369] " paolo at gcc dot gnu dot org
2003-12-09 14:30 ` paolo at gcc dot gnu dot org
@ 2003-12-09 14:30 ` paolo at gcc dot gnu dot org
2003-12-30 11:41 ` cvs-commit at gcc dot gnu dot org
2003-12-30 11:44 ` paolo at gcc dot gnu dot org
4 siblings, 0 replies; 6+ messages in thread
From: paolo at gcc dot gnu dot org @ 2003-12-09 14:30 UTC (permalink / raw)
To: gcc-bugs
--
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |3.4
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13369
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/13369] __verify_grouping (and __add_grouping?) not correct
2003-12-09 14:15 [Bug libstdc++/13369] New: __verify_grouping (and __add_grouping?) not correct paolo at gcc dot gnu dot org
2003-12-09 14:15 ` [Bug libstdc++/13369] " paolo at gcc dot gnu dot org
@ 2003-12-09 14:30 ` paolo at gcc dot gnu dot org
2003-12-09 14:30 ` paolo at gcc dot gnu dot org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: paolo at gcc dot gnu dot org @ 2003-12-09 14:30 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From paolo at gcc dot gnu dot org 2003-12-09 14:30 -------
A value of CHAR_MAX for a group also means an unlimited group, and it's more
interesting than zero, since the latter *cannot* actually occur in the stored
grouping: \0 delimits the string returned by __nl_langinfo_l(GROUPING, __cloc);
--
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Last reconfirmed|2003-12-09 14:15:28 |2003-12-09 14:30:09
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13369
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/13369] __verify_grouping (and __add_grouping?) not correct
2003-12-09 14:15 [Bug libstdc++/13369] New: __verify_grouping (and __add_grouping?) not correct paolo at gcc dot gnu dot org
` (2 preceding siblings ...)
2003-12-09 14:30 ` paolo at gcc dot gnu dot org
@ 2003-12-30 11:41 ` cvs-commit at gcc dot gnu dot org
2003-12-30 11:44 ` paolo at gcc dot gnu dot org
4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2003-12-30 11:41 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2003-12-30 10:44 -------
Subject: Bug 13369
CVSROOT: /cvs/gcc
Module name: gcc
Changes by: paolo@gcc.gnu.org 2003-12-30 10:43:54
Modified files:
libstdc++-v3 : ChangeLog
libstdc++-v3/include/bits: locale_facets.tcc
Added files:
libstdc++-v3/testsuite/22_locale/num_get/get/char: 13.cc
libstdc++-v3/testsuite/22_locale/num_get/get/wchar_t: 13.cc
Log message:
2003-12-30 Paolo Carlini <pcarlini@suse.de>
PR libstdc++/13369
* include/bits/locale_facets.tcc (__verify_grouping):
Fix to deal properly with __grouping_tmp.size() >
__grouping.size().
* testsuite/22_locale/num_get/get/char/13.cc: New.
* testsuite/22_locale/num_get/get/wchar_t/13.cc: Ditto.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/ChangeLog.diff?cvsroot=gcc&r1=1.2190&r2=1.2191
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/bits/locale_facets.tcc.diff?cvsroot=gcc&r1=1.160&r2=1.161
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/22_locale/num_get/get/char/13.cc.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/22_locale/num_get/get/wchar_t/13.cc.diff?cvsroot=gcc&r1=NONE&r2=1.1
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13369
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/13369] __verify_grouping (and __add_grouping?) not correct
2003-12-09 14:15 [Bug libstdc++/13369] New: __verify_grouping (and __add_grouping?) not correct paolo at gcc dot gnu dot org
` (3 preceding siblings ...)
2003-12-30 11:41 ` cvs-commit at gcc dot gnu dot org
@ 2003-12-30 11:44 ` paolo at gcc dot gnu dot org
4 siblings, 0 replies; 6+ messages in thread
From: paolo at gcc dot gnu dot org @ 2003-12-30 11:44 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From paolo at gcc dot gnu dot org 2003-12-30 10:45 -------
Fixed for 3.4.0.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13369
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2003-12-30 10:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-12-09 14:15 [Bug libstdc++/13369] New: __verify_grouping (and __add_grouping?) not correct paolo at gcc dot gnu dot org
2003-12-09 14:15 ` [Bug libstdc++/13369] " paolo at gcc dot gnu dot org
2003-12-09 14:30 ` paolo at gcc dot gnu dot org
2003-12-09 14:30 ` paolo at gcc dot gnu dot org
2003-12-30 11:41 ` cvs-commit at gcc dot gnu dot org
2003-12-30 11:44 ` paolo at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).