[Bug pch/12480] New: PCH prevents "compilation of header file requested" warning

[Bug pch/12480] New: PCH prevents "compilation of header file requested" warning

[levon at movementarian dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12480

           Summary: PCH prevents "compilation of header file requested"
                    warning
           Product: gcc
           Version: 3.4
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: pch
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: levon at movementarian dot org
                CC: gcc-bugs at gcc dot gnu dot org

[moz@lambent moz]$ /usr/local/gcc-cvs/bin/gcc -v 2>&1 | grep ^gcc
gcc version 3.4 20030925 (experimental)
[moz@lambent moz]$ /usr/local/gcc-cvs/bin/gcc /usr/include/malloc.h
/usr/include/malloc.h:1: fatal error: can't open /usr/include/malloc.h.gch:
Permission denied
compilation terminated.
[moz@lambent moz]$ gcc /usr/include/malloc.h
gcc: compilation of header file requested

This is a regression.

[Bug pch/12480] PCH prevents "compilation of header file requested" warning

[pinskia at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12480


pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID


------- Additional Comments From pinskia at gcc dot gnu dot org  2003-10-01 17:47 -------
This is the way to "compile" a header for PCH so this is not a bug.

[Bug pch/12480] PCH prevents "compilation of header file requested" warning

[levon at movementarian dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12480


levon at movementarian dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |minor


------- Additional Comments From levon at movementarian dot org  2003-10-01 18:02 -------
How is it not a bug ?

A QoS issue, perhaps, but nonetheless. Suddenly a standard build
of GCC means you can never get the helpful error any more, and you
get some meaningless crap (meaningless to someone who does not know
what .gch is used for).

[Bug pch/12480] PCH prevents "compilation of header file requested" warning

[pinskia at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12480



------- Additional Comments From pinskia at gcc dot gnu dot org  2003-10-01 18:08 -------
It is documented: <http://gcc.gnu.org/onlinedocs/gcc/Precompiled-
Headers.html#Precompiled%20Headers> so still not a bug.

[Bug pch/12480] PCH prevents "compilation of header file requested" warning

[zack at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12480


zack at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|INVALID                     |


------- Additional Comments From zack at gcc dot gnu dot org  2003-10-01 18:29 -------
Just because something is documented does not make it not a bug.  The
documentation may well be wrong.

I would tend to agree with the original poster that this is a QoI regression.
The logical thing to do, here, would be to make the error message on failure to
write a PCH a bit more friendly.

Arguably creation of a PCH is an unusual operation and should require a special
switch such as --gen-pch.

[Bug pch/12480] PCH prevents "compilation of header file requested" warning

[levon at movementarian dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12480



------- Additional Comments From levon at movementarian dot org  2003-10-01 18:40 -------
In particular, the error should make some reference to what .gch is all
about.

With an explicit flag as suggested, it's reasonable that the user has
read the PCH docs. Without, perhaps something like :

fatal error: can't open /usr/include/malloc.h.gch for pre-compiled header
output: Permission denied

would help.

[Bug pch/12480] PCH prevents "compilation of header file requested" warning

[levon at movementarian dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12480



------- Additional Comments From levon at movementarian dot org  2003-10-01 18:57 -------
Created an attachment (id=4876)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=4876&action=view)
Provide more useful error messages for PCH

Currently untested patch. This should clarify what GCC is trying to do
when giving these error messages. For consistency I changed -Winvalid-pch
ones too, even though that would imply that the user knew what PCH was.

[Bug pch/12480] pch error messages do say they for PCH.

[pinskia at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12480


pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
           Keywords|                            |diagnostic
   Last reconfirmed|0000-00-00 00:00:00         |2003-10-02 18:15:47
               date|                            |
            Summary|PCH prevents "compilation of|pch error messages do say
                   |header file requested"      |they for PCH.
                   |warning                     |
   Target Milestone|---                         |3.4


------- Additional Comments From pinskia at gcc dot gnu dot org  2003-10-02 18:15 -------
I argue with you the error messages should mention PCH.

[Bug pch/12480] pch error messages do not say they for PCH.

[geoffk at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2003-11-18 07:38:08         |2003-12-16 18:28:19
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12480

[Bug pch/12480] pch error messages do not say they for PCH.

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2003-12-17 22:04 -------
Subject: Bug 12480

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	geoffk@gcc.gnu.org	2003-12-17 22:04:34

Modified files:
	gcc            : ChangeLog c-pch.c 

Log message:
	PR 12480
	* c-pch.c (pch_init): Improve error message when precompiled
	header can't be written.
	
	PR 12606
	* c-pch.c (pch_init): Make a PCH file appear invalid while it's
	being written.
	(c_common_write_pch): Make it valid once it's done.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.2023&r2=2.2024
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-pch.c.diff?cvsroot=gcc&r1=1.18&r2=1.19



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12480

[Bug pch/12480] pch error messages do not say they for PCH.

[geoffk at gcc dot gnu dot org]

------- Additional Comments From geoffk at gcc dot gnu dot org  2003-12-17 22:07 -------
Now says:
/usr/include/malloc/malloc.h:1: fatal error: can't create precompiled header /usr/include/malloc/
malloc.h.gch: Permission denied


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12480