[Bug pch/13419] New: Clarification of invoke.texi requested

[Bug pch/13419] New: Clarification of invoke.texi requested

[bangerth at dealii dot org]

I hit something that I'd say is described somewhat unclearly in  
invoke.texi: for pch in conjunction with precompiling the same 
header more than once, there is a paragraph in the manual saying 
-------- 
If you need to precompile the same header file for different 
languages, targets, or compiler options, you can instead make a 
@emph{directory} named like @file{all.h.gch}, and put each precompiled 
header in the directory.  (It doesn't matter what you call the files 
in the directory, every precompiled header in the directory will be 
considered.)  The first precompiled header encountered in the 
directory that is valid for this compilation will be used; they're 
searched in no particular order. 
-------- 
 
I tried that, having a header file x.h, creating a directory 
x.h.gch, and then compiling the header file: 
  gcc -c x.h 
 
What happened is this error message: 
g/x> /home/bangerth/bin/gcc-3.4-pre/bin/c++ -c x.h 
x.h:1: fatal error: can't open x.h.gch: Is a directory 
compilation terminated. 
 
It took me a while to understand what's going on, since of course 
x.h.gch is a directory. What would be needed is a clarification of 
above paragraph to state that one should place the precompiled 
header into this directory *by using '-o x.h.gch/something'*. If 
one does that, it of course succeeds. Alternatively, a different 
error message could also be helpful. 
 
W. 
 
 
Here's how to reproduce this: 
  echo "int i;" > x.h 
  mkdir x.h.gch 
  gcc -c x.h

-- 
           Summary: Clarification of invoke.texi requested
           Product: gcc
           Version: 3.4
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: pch
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: bangerth at dealii dot org
                CC: gcc-bugs at gcc dot gnu dot org,geoffk at gcc dot gnu
                    dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13419

[Bug pch/13419] Clarification of invoke.texi requested

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2003-12-16 18:56 -------
Confirmed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
           Keywords|                            |documentation
   Last reconfirmed|0000-00-00 00:00:00         |2003-12-16 18:56:56
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13419

[Bug pch/13419] Clarification of invoke.texi requested

[geoffk at gcc dot gnu dot org]

------- Additional Comments From geoffk at gcc dot gnu dot org  2003-12-17 23:06 -------
The wording of the error message has changed, it now says "can't create precompiled header 
foo.h.gch: Is a directory".  Does this solve your problem?

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13419

[Bug pch/13419] Clarification of invoke.texi requested

[bangerth at dealii dot org]

------- Additional Comments From bangerth at dealii dot org  2003-12-18 10:31 -------
I think I would prefer if the thing about "-o something" were 
put into the manual, since my problem arose when I tried to 
follow the steps listed there. If the manual had this wording, 
the error message would be easier to understand as well. 
 
W. 

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13419

[Bug pch/13419] Clarification of invoke.texi requested

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW
   Last reconfirmed|2003-12-16 18:56:56         |2003-12-19 13:36:40
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13419

[Bug pch/13419] Clarification of invoke.texi requested

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |minor
   Last reconfirmed|2003-12-19 13:36:40         |2004-04-01 13:33:29
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13419

[Bug pch/13419] Clarification of invoke.texi requested

[geoffk at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |geoffk at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13419

[Bug pch/13419] Clarification of invoke.texi requested

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-04-08 23:41 -------
Subject: Bug 13419

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	geoffk@gcc.gnu.org	2004-04-08 23:41:09

Modified files:
	gcc            : ChangeLog c-pch.c 
	gcc/doc        : invoke.texi 
	gcc/testsuite  : ChangeLog 
Added files:
	gcc/testsuite/gcc.dg/pch: valid-1.c valid-1.hs valid-1b.c 
	                          valid-1b.hs valid-2.c valid-2.hs 
	                          valid-3.c valid-3.hs valid-4.c 
	                          valid-4.hs valid-5.c valid-5.hs 
	                          valid-6.c valid-6.hs 

Log message:
	2004-04-08  Geoffrey Keating  <geoffk@apple.com>
	
	PR pch/13419
	PR pch/14137
	Radar #: 3315288
	* doc/invoke.texi (Precompiled Headers): Suggest -o
	to put an output file in a particular place.  Be more detailed
	about which options affect PCH validity and which options
	might not work.
	* c-pch.c (pch_matching): New.
	(MATCH_SIZE): New.
	(struct c_pch_validity): New field 'match'.
	(pch_init): Handle pch_matching.
	(c_common_valid_pch): Check pch_matching.
	
	Index: testsuite/ChangeLog
	2004-04-08  Geoffrey Keating  <geoffk@apple.com>
	
	* gcc.dg/pch/valid-1.c, gcc.dg/pch/valid-2.c, gcc.dg/pch/valid-3.c,
	gcc.dg/pch/valid-4.c, gcc.dg/pch/valid-5.c, gcc.dg/pch/valid-6.c,
	gcc.dg/pch/valid-1.hs, gcc.dg/pch/valid-2.hs, gcc.dg/pch/valid-3.hs,
	gcc.dg/pch/valid-4.hs, gcc.dg/pch/valid-5.hs, gcc.dg/pch/valid-6.hs:
	New tests.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.3370&r2=2.3371
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-pch.c.diff?cvsroot=gcc&r1=1.21&r2=1.22
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/doc/invoke.texi.diff?cvsroot=gcc&r1=1.441&r2=1.442
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.3662&r2=1.3663
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pch/valid-1.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pch/valid-1.hs.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pch/valid-1b.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pch/valid-1b.hs.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pch/valid-2.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pch/valid-2.hs.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pch/valid-3.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pch/valid-3.hs.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pch/valid-4.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pch/valid-4.hs.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pch/valid-5.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pch/valid-5.hs.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pch/valid-6.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pch/valid-6.hs.diff?cvsroot=gcc&r1=NONE&r2=1.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13419

[Bug pch/13419] Clarification of invoke.texi requested

[geoffk at gcc dot gnu dot org]

------- Additional Comments From geoffk at gcc dot gnu dot org  2004-04-08 23:45 -------
Fixed by patch.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13419

[Bug pch/13419] Clarification of invoke.texi requested

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |3.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13419