[Bug other/13485] New: [3.4 regression] Generated files no longer get messages extracted

[Bug other/13485] New: [3.4 regression] Generated files no longer get messages extracted

[jsm28 at gcc dot gnu dot org]

With generated files no longer in the source directory, the messages from
them no longer get extracted by exgettext for gcc.pot (unless old generated
files were lying around in the build directory).

A proper fix probably involves each Make-lang.in listing the generated files
in that language from which messages should be extracted (so that the
dependencies on those files, which never were right, can be correct) and
Makefile.in then passing the list of all those files (and options.c, currently
handled specially) to exgettext.

-- 
           Summary: [3.4 regression] Generated files no longer get messages
                    extracted
           Product: gcc
           Version: 3.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: other
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: jsm28 at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org,kcook at gcc dot gnu dot
                    org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13485

[Bug other/13485] [3.4 regression] Generated files no longer get messages extracted

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2003-12-24 20:24 -------
Confirmed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2003-12-24 20:24:31
               date|                            |
   Target Milestone|---                         |3.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13485

[Bug other/13485] [3.4 regression] Generated files no longer get messages extracted

[steven at gcc dot gnu dot org]

------- Additional Comments From steven at gcc dot gnu dot org  2004-01-14 13:57 -------
Makefile.in has: 
 
# Make-lang.in should add dependencies of po-generated on any generated 
# files which need to be scanned by gettext (usually Yacc-generated parsers). 
po-generated: $(parsedir)/c-parse.c options.c 
 
And the Make-lang.ins have a po-generated target too. 
 
Joseph, isn't this what proposed we should do? 

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13485

[Bug other/13485] [3.4 regression] Generated files no longer get messages extracted

[jsm at polyomino dot org dot uk]

------- Additional Comments From jsm at polyomino dot org dot uk  2004-01-14 14:16 -------
Subject: Re:  [3.4 regression] Generated files no longer
 get messages extracted

On Wed, 14 Jan 2004, steven at gcc dot gnu dot org wrote:

> # Make-lang.in should add dependencies of po-generated on any generated 
> # files which need to be scanned by gettext (usually Yacc-generated parsers). 
> po-generated: $(parsedir)/c-parse.c options.c 
>  
> And the Make-lang.ins have a po-generated target too. 
>  
> Joseph, isn't this what proposed we should do? 

po-generated has the *dependencies* - but the lists of files in
po-generated's dependency lists never get passed to exgettext.  When the
generated files were in the source directory, the dependencies meant they
were generated before exgettext was called, which was enough as it
searches the source directory for files to extract messages from.  Now the
generated files aren't in the source directory, exgettext needs to know
which generated files from the build directory to search for messages.  
At present options.c is hard-coded in exgettext, but passing a last of all
the relevant files on the command line (rather than hardcoding options.c)
is the right solution.



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13485

[Bug other/13485] [3.4 regression] Generated files no longer get messages extracted

[kcook at gcc dot gnu dot org]

------- Additional Comments From kcook at gcc dot gnu dot org  2004-01-14 17:04 -------
Let me preface this by commenting that I have never looked at the translation
portion of GCC before.  Nevertheless, I've looked over this bug and I have a
question.

How often is po/gcc.pot supposed to be regenerated?

If it is only upon every {pre-,}release then it doesn't seem that we have a
problem since {pre-,}releases are run via --enable-generated-files-in-srcdir.  

If this is correct, then without any difficulty we could add options.c to the
list of generated-files-in-srcdir so we could eliminate its hardcoding in exgetext.

And we could then easily add po/${PACKAGE}.pot to the recently proposed srcextra
(along with a few new dependencies for po/${PACKAGE}.pot) which would have the
side benefit of causing the new version of gcc.pot to be copied to the source
directory when it is released.

Thinking further this could be followed by a automagic cvs commit of po/gcc.pot
by the gcc_release script.

Would this proposal solve the problems?

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2003-12-24 20:24:31         |2004-01-14 17:04:38
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13485

[Bug other/13485] [3.4 regression] Generated files no longer get messages extracted

[jsm at polyomino dot org dot uk]

------- Additional Comments From jsm at polyomino dot org dot uk  2004-01-14 17:21 -------
Subject: Re:  [3.4 regression] Generated files no longer
 get messages extracted

On Wed, 14 Jan 2004, kcook at gcc dot gnu dot org wrote:

> How often is po/gcc.pot supposed to be regenerated?
> 
> If it is only upon every {pre-,}release then it doesn't seem that we have a
> problem since {pre-,}releases are run via --enable-generated-files-in-srcdir.  

It is regenerated whenever a new release branch is created (long before
any prereleases), and the first branch snapshot (not a prerelease) is
submitted to the TP.  It is also regenerated from time to time on
mainline, including when there have been changes to translation machinery
improving the set of messages that get extracted.  Mainline gcc.pot
doesn't *at present* get submitted to the TP, but it might in future
(though they don't want automated submission of weekly snapshots): they
can handle having multiple lines of development, each of which is relevant
for translation, it may just dilute translator effort.  It is also 
regenerated just before releases.  See translation.html, releasing.html, 
branching.html.

Automatic generation in the release script would need to be done from the
*first* checkout - the one that updates the ChangeLogs - to get the
release tag on the correct version in CVS.  At present this first checkout
doesn't get built at all.  (The RM can regenerate gcc.pot simply by doing
an ordinary manual build - probably not using
--enable-generated-files-in-srcdir - interrupting it once the gcc
directory is building and doing make gcc.pot.)

In general rebuilding gcc.pot should be considered an ordinary maintainer 
action, though most maintainers may not do it much, that should work from 
any ordinary build rather than requiring special configure options.  In 
particular it shouldn't require maintainers to clutter up their CVS 
checkouts with various generated files.

> If this is correct, then without any difficulty we could add options.c to the
> list of generated-files-in-srcdir so we could eliminate its hardcoding in exgetext.

There's no normal need for it in srcdir (as we do reasonably require GCC
builders to have awk).

I hope that changing

po-generated: ...

to

po_generated += ...

should be the main part of what's needed to fix the problem without making
it more difficult to regenerate gcc.pot.

> Thinking further this could be followed by a automagic cvs commit of po/gcc.pot
> by the gcc_release script.

As noted, that sort of thing would require the script to run a build from
the first checkout as well as the second.



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13485

[Bug other/13485] [3.4/3.5 regression] Generated files no longer get messages extracted

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-02-06 02:47 -------
Fixed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13485