[Bug java/13020] New: zip-style comments

[Bug java/13020] New: zip-style comments

[swhite at decisionsoft dot com]

fastjar complains about 'Error in JAR file format. zip-style comment?' on some
jar files, such as that distributed by 'ygaurd' (which does appear to contain a
zip comment).  I haven't read the specification for jar files, but it would
appear that Sun's tools work with this jar file, so in the interests of
interoperability I think fastjar should too.

Tested using 3.3.2 and CVS Head (which is the 3.4 branch unless I'm mistaken).

-- 
           Summary: zip-style comments
           Product: gcc
           Version: 3.4
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: java
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: swhite at decisionsoft dot com
                CC: gcc-bugs at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13020

[Bug java/13020] zip-style comments

[swhite at decisionsoft dot com]

------- Additional Comments From swhite at decisionsoft dot com  2003-11-12 12:46 -------
Created an attachment (id=5122)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=5122&action=view)
Possible fix based on gcc/libjava/java/util/zip/ZipFile.java

I haven't actually looked at the format for ZIP files, so this patch is simply
based on the code in ZipFile.java.  There may be better ways to do this.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13020

[Bug other/13020] zip-style comments

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|java                        |other


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13020

[Bug other/13020] zip-style comments

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2003-11-18 05:59 -------
Can you provide the broken jar, also note that fastjar is not part of gcc:
from  fastjar/README:
This directory contains the FastJar package, which is not part of GCC but
shipped with GCC as convenience.
I would send your patch upstream.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13020

[Bug other/13020] zip-style comments

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2003-11-23 19:36 -------
Created an attachment (id=5196)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=5196&action=view)
test jar

For some reason people like to send things directly to me.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13020

[Bug libgcj/13020] zip-style comments

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|other                       |libgcj


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13020

[Bug fastjar/13020] zip-style comments

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|libgcj                      |fastjar


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13020

[Bug fastjar/13020] zip-style comments

[wmahan at gmail dot com]

------- Additional Comments From wmahan at gmail dot com  2005-08-28 22:18 -------
Hi, I submitted a different patch to the upstream FastJar sources at
http://sourceforge.net/tracker/index.php?func=detail&aid=1275036&group_id=426&atid=300426
 before I noticed this bug. (It doesn't apply to the gcc tree, but it would be
simple to make a patch if desired.)

When a zip-style comment is present, the patch by Stephen White searches
backwards from the end for the central-header-end section to read the offset of
the central header, while my patch parses through the file from the beginning to
find the central header. 

Either approach should fix the problem. My fix might be a little less efficient,
but I think Stephen's patch would fail if the comment happens to contain the
magic string 0x06054b50. I'm not sure if that ever happens in practice.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13020

[Bug fastjar/13020] zip-style comments

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-08-29 04:54:14
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13020