public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug c++/13316] New: g++ does not follow mangling ABI for pointer to qualified member function
@ 2003-12-05 15:08 ian at airs dot com
  2003-12-05 23:44 ` [Bug c++/13316] [ABI] " pinskia at gcc dot gnu dot org
                   ` (13 more replies)
  0 siblings, 14 replies; 15+ messages in thread
From: ian at airs dot com @ 2003-12-05 15:08 UTC (permalink / raw)
  To: gcc-bugs

g++ does not follow the rules described in the mangling ABI.  The mangling ABI
can be found at http://www.codesourcery.com/cxx-abi/abi.html#mangling.  The
problem is when using a pointer to a qualified member function, as in `int
(G::*) const'.  g++ does not treat the qualified function type as a substitution
candidate, as is required by the ABI.

The mangling ABI says that whenever the grammar uses <substitution>, that is a
substitution candidate (with some restrictions which are not relevant here). 
The grammar includes these productions:
    <type> ::= <substitution>
    <pointer-to-member-type> ::= M <type> <type>
This clearly suggests that the second <type> in <pointer-to-member-type> is a
substitution candidate.

However, g++ does not work that way.  Only the base type of the second <type> is
a substitution candidate.  If the second <type> is CV-qualified, the fully
qualified type is not a substitution candidate.

The ABI specifies that any CV-qualifiers on the second <type> are qualifiers for
the member function which is being pointed to.  So the second <type> is slightly
unusual.  But the ABI does not say that those CV-qualifiers are not themselves a
substitution candidate as is indicated by the grammar.

In the code in cp/mangle.c, see write_function_type().  For a
pointer-to-member-function, it writes out the CV qualifiers for the first
parameter to the function type, and it passes the function type to
write_bare_function_type(), but it never calls add_substitution() for the
qualified type.  This is understandable, since it does not have the correct type
to pass to add_substitution().  But to me it looks like a violation of the
mangling ABI.

Here is a test case:

class G { int g; }; class H { int h; };
template<class t> class what { int w1; };
template<class t> class what2 { int w2; };
void r(int (G::*)(), int (G::*)() const, G, int (H::*)(), int (G::*)(),
       what<G const>, what2<G const>, int (G::*)() const) {}

The mangled name of the function r is
    _Z1rM1GFivEMS_KFivES_M1HFivES1_4whatIKS_E5what2IS8_ES3_
which demangles into
    r(int (G::*)(), int (G::*)() const, G, int (H::*)(), int (G::*)(), what<G
const>, what2<G const>, int (G::*)() const)

Breaking this down, we get (substitution candidates are labelled with
SUB and the substitution index):

_Z                   (prefix)
 1r                  (name 'r')
 M                   (pointer to member)
  1G                 (name 'G') (SUB 0)
  F                  (function)
   i                 (int--return type)
   v                 (void--no parameters)
  E                  (end function) (fn is SUB 1) (ptr-to-mem is SUB 2)
 M                   (pointer to member)
  S_                 (substitution 0 == name 'G')
  K                  (const)
   FivE              (function as above) (fn is SUB 3) (p-to-m is SUB 4) ***
 S_                  (substitution 0 == name 'G')
 M1HFivE             (pointer to member as above)
                     ('H' is SUB 5) (fn is SUB 6) (p-to-m is SUB 7)
 S1_                 (substitution 2 == first ptr-to-mem above)
 4what               (name 'what') (SUB 8)
  I                  (template arguments follow)
   K                 (const)
    S_               (substitution 0 == name 'G') (SUB 9)
  E                  (end template arguments)
 5what2              (name 'what2') (SUB 10)
  I                  (template arguments follow)
   S8_               (substitution 9 == 'G const')
  E                  (end template arguments)
 S3_                 (substitution 4 == second ptr-to-mem above)

So, if you followed all that, look closely at the line with ***. There you see
that the function FivE is a substitution candidate, and the full pointer to
member MS_KFivE is a substitution candidate. However, by the reading of the
grammar, the qualified type KFivE should also be a substitution candidate. 
However, it is not.  If it were, the rest of the name would be mangled
incorrectly, because the references to substitution 4 and 9 would refer to the
incorrect types.

One way to fix this would be to change g++ to follow the mangling ABI correctly.

Another way to fix this would be to change the mangling ABI itself.  I think the
ABI fix would be simple; just change <pointer-to-member-type> to be this:
    <pointer-to-member-type> ::= M <type> <CV-qualifers> <type>
That would clarify that the <CV-qualifiers> do not form a substitution candidate
with the second <type>.

Either way, I think this is a moderately serious issue which should be
addressed.  The point of a mangling ABI is to permit interoperability.  When a
compiler does not follow the ABI, interoperability is lost.  Then there is
little point to having an ABI at all.

-- 
           Summary: g++ does not follow mangling ABI for pointer to
                    qualified member function
           Product: gcc
           Version: 3.4
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: ian at airs dot com
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: i686-pc-linux-gnu
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: i686-pc-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13316


^ permalink raw reply	[flat|nested] 15+ messages in thread
end of thread, other threads:[~2004-02-23 18:51 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-12-05 15:08 [Bug c++/13316] New: g++ does not follow mangling ABI for pointer to qualified member function ian at airs dot com
2003-12-05 23:44 ` [Bug c++/13316] [ABI] " pinskia at gcc dot gnu dot org
2003-12-26 23:26 ` [Bug c++/13316] " pinskia at gcc dot gnu dot org
2003-12-29 22:42 ` pinskia at gcc dot gnu dot org
2004-01-10 16:10 ` pinskia at gcc dot gnu dot org
2004-01-11 21:19 ` dberlin at gcc dot gnu dot org
2004-01-11 22:32 ` giovannibajo at libero dot it
2004-01-11 22:32 ` giovannibajo at libero dot it
2004-01-11 22:50 ` ian at airs dot com
2004-01-11 22:57 ` ian at wasabisystems dot com
2004-01-11 23:19 ` giovannibajo at libero dot it
2004-01-12  0:24 ` ian at wasabisystems dot com
2004-01-12  1:18 ` giovannibajo at libero dot it
2004-02-20  8:51 ` mmitchel at gcc dot gnu dot org
2004-02-23 18:51 ` ian at wasabisystems dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).