[Bug c/7544] #pragma weak problem

[Bug c/7544] #pragma weak problem

[pinskia@physics.uc.edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7544


pinskia@physics.uc.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING


------- Additional Comments From pinskia@physics.uc.edu  2003-05-26 04:12 -------
3.1.1 is an old version, can you retry this with a newer version, 3.3 is nice?



------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug c/7544] #pragma weak problem

[poulot@wanadoo.fr]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7544



------- Additional Comments From poulot@wanadoo.fr  2003-05-26 14:05 -------
Subject: Re: [Bug c/7544] #pragma weak problem

"pinskia@physics.uc.edu" <gcc-bugzilla@gcc.gnu.org> writes:

> PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.
> 
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7544
> 
> 
> pinskia@physics.uc.edu changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>              Status|UNCONFIRMED                 |WAITING
> 
> 
> ------- Additional Comments From pinskia@physics.uc.edu  2003-05-26 04:12 -------
> 3.1.1 is an old version, can you retry this with a newer version, 3.3 is nice?

The bug is still present in gcc-3.3 :

        $ gcc-3.3 bug.c -S -o -
        .file   "bug.c"
        .ident  "GCC: (GNU) 3.3 20030509 (Debian prerelease)"

  -- Benoit




------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug c/7544] #pragma weak problem

[pinskia@physics.uc.edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7544


pinskia@physics.uc.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|2003-03-05 00:00:00         |2003-05-26 14:22:57
               date|                            |


------- Additional Comments From pinskia@physics.uc.edu  2003-05-26 14:22 -------
bug still present in 3.3



------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug c/7544] #pragma weak problem

[pinskia@physics.uc.edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7544


pinskia@physics.uc.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|2003-05-26 14:22:57         |2003-06-02 03:43:41
               date|                            |


------- Additional Comments From pinskia@physics.uc.edu  2003-06-02 03:43 -------
I thought I marked this as `NEW'



------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug c/7544] [3.3/3.4 Regression] #pragma weak problem

[pinskia at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7544


pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|2003-06-02 03:43:41         |2003-08-09 16:13:22
               date|                            |
            Summary|#pragma weak problem        |[3.3/3.4 Regression] #pragma
                   |                            |weak problem
   Target Milestone|---                         |3.3.2


------- Additional Comments From pinskia at gcc dot gnu dot org  2003-08-09 16:13 -------
This is a regression but I do not know what the expected behaviour is as #pragma weak 
is not really documented that much.

[Bug c/7544] [3.3/3.4 Regression] #pragma weak problem

[mmitchel at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7544


mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.3.2                       |3.3.3


------- Additional Comments From mmitchel at gcc dot gnu dot org  2003-10-16 09:44 -------
Postponed until GCC 3.3.3.

[Bug c/7544] [3.3/3.4 Regression] #pragma weak problem

[gdr at gcc dot gnu dot org]

------- Additional Comments From gdr at gcc dot gnu dot org  2003-12-21 18:07 -------
This will not be fixed in 3.3.x.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WONTFIX


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7544

[Bug c/7544] [3.3/3.4 Regression] #pragma weak problem

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2003-12-21 18:11 -------
But will it get fixed for 3.4?

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|WONTFIX                     |
   Target Milestone|3.3.3                       |3.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7544

[Bug c/7544] [3.3/3.4 Regression] #pragma weak problem

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2003-12-21 20:54 -------
Still happens on the mainline.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |NEW


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7544

[Bug c/7544] #pragma weak problem

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-01-12 06:49 -------
I think we all agruee that this is a progression and not really a regression, in fact this 
should be reject.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|wrong-code                  |accepts-invalid
            Summary|[3.3/3.4 Regression] #pragma|#pragma weak problem
                   |weak problem                |
   Target Milestone|3.4.0                       |---


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7544

[Bug c/7544] #pragma weak problem

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-11-24 00:44 -------
After rereading the thread which talked about this, this should be closed as not a bug.
The thread starts here:
http://gcc.gnu.org/ml/gcc/2004-01/msg00660.html
And the email which comments on why this is not a bug is here:
http://gcc.gnu.org/ml/gcc/2004-01/msg00665.html
"
> Newer GCCs do not write the weak symbol:

Correct.  The the assembly above is meaningless.  It "works" in that it
assembles, but it doesn't do anything useful.  One could even argue that
it's a bug that it assembles.
"

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |INVALID


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7544

[Bug c/7544] [3.3/3.4/4.0 regression] #pragma weak problem

[jsm28 at gcc dot gnu dot org]

------- Additional Comments From jsm28 at gcc dot gnu dot org  2004-11-24 01:27 -------
The bug, as described, is a bug and is still present.  The thread
referenced talks about the case where foo isn't declared, but the bug
is about the case where bar isn't declared.  Where bar isn't declared, but
foo is defined in that translation unit, 2.95 generates output which assembles
to an object file with a weak alias, while current GCC doesn't.  Per Sun's
specification <http://docs.sun.com/source/817-5064/sun.specific.html#48658>,
this is a bug.

#pragma weak bar = foo
void foo(void) {}

generates symbols

00000000 W bar
00000000 T foo
00000000 t gcc2_compiled.

with 2.95,

00000000 W bar
00000000 T foo

with 3.0, but just

00000000 T foo

with later versions.  The manual referred to in the referenced thread is
an old C++ manual and so irrelevant to this bug.

Setting milestone to 4.0.0 as not expecting to fix this on earlier branches.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jsm28 at gcc dot gnu dot org
             Status|RESOLVED                    |REOPENED
         Resolution|INVALID                     |
            Summary|#pragma weak problem        |[3.3/3.4/4.0 regression]
                   |                            |#pragma weak problem
   Target Milestone|---                         |4.0.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7544

[Bug c/7544] [3.3/3.4/4.0 regression] #pragma weak problem

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-11-24 01:28 -------
JSM did you read what RTH wrote?

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7544

[Bug c/7544] [3.3/3.4/4.0 regression] #pragma weak problem

[joseph at codesourcery dot com]

------- Additional Comments From joseph at codesourcery dot com  2004-11-24 01:40 -------
Subject: Re:  [3.3/3.4/4.0 regression] #pragma weak problem

On Wed, 24 Nov 2004, pinskia at gcc dot gnu dot org wrote:

> JSM did you read what RTH wrote?

What RTH wrote was discussing the over-simplified testcase

#pragma weak bar = foo

with nothing else in the source file.  If you read the bug description and 
not just the oversimplified testcase, the salient feature is that bar is 
undeclared.  But what makes that translation unit useless is that it 
doesn't define foo - not that it doesn't declare bar.

Consider the two translation units

(1)
#pragma weak bar
void bar(void);
int main(void) { bar(); return 0; }

(2)
#pragma weak bar = foo
void foo(void) {}

You can compile and link them together.  With 2.95.x and 3.0.x, bar is a 
weak alias to foo and the program executes successfully.  With later 
versions, bar is an undefined weak symbol and so the program dumps core.

Think about bugs before closing them just because of a comment about a 
single testcase that doesn't cover all issues described in the bug.



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7544

[Bug c/7544] [3.3/3.4/4.0 regression] #pragma weak problem

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-11-24 01:45 -------
JSM, that is a different bug than what this bug was about, read comment #0 again.  The sources in 
question:
                $ cat bug.c
#pragma weak bar = foo

                $ gcc-3.1 bug.c -S
                $ cat bug2.c
#pragma weak bar = foo
void bar();

                $ gcc-3.1 bug2.c -S

So the orginal problem in this bug as questioned is really not a problem.  Now your testcases shows 
a different problem.

RTH was talking about the bug in question and not your testcases sorry but file a new bug for this as 
the orginal bug is invalid.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |INVALID


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7544

[Bug c/7544] [3.3/3.4/4.0 regression] #pragma weak problem

[jsm28 at gcc dot gnu dot org]

------- Additional Comments From jsm28 at gcc dot gnu dot org  2004-11-24 02:00 -------
The bug reporter's specification of the bug was:

    When using '#pragma weak bar = foo', gcc does not output anything, unless
    bar is declared.

Although a bug can be specified by "this source file doesn't compile as
expected", this bug was "feature X doesn't work in this range of
circumstances".  That is, the bug describes all cases with that pragma and
bar undeclared, whether or not foo is declared.  Only a subset of those cases,
those where foo is not defined in the source file, can be considered INVALID.

INVALID means "The problem described is not a bug.".  The problem was described
by the sentence I quote, and it is a bug even though the submitter's example
was over-simplified.  The example source file should be considered purely
illustrative rather than being the complete specification of the problem;
the sentence I quote describes a problem with an infinite family of source
files and inevitably only a finite subset can be given as examples.

I repeat: the bug report is *not* that a particular incorrect source file
has a problem, it is a more general problem description about all source files
with a given property, and the source file merely an attempt to show one
such source file - which happens to have another problem, but this does not
render the family empty; the family of correct illustrations is still infinite.
Do not close bug reports merely because an illustrative example has a problem,
or because an illustrative example has been fixed; close them because
everything about the bug as specified by the reporter and any subsequent
commenter has been fixed.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|INVALID                     |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7544

[Bug c/7544] [3.3/3.4/4.0 regression] #pragma weak problem

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-11-29 18:54 -------
Subject: Bug 7544

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	jsm28@gcc.gnu.org	2004-11-29 18:54:06

Modified files:
	gcc            : ChangeLog Makefile.in c-lang.c c-pragma.c 
	                 c-pragma.h 
	gcc/cp         : ChangeLog Make-lang.in decl2.c 
	gcc/objc       : ChangeLog Make-lang.in objc-act.c 
	gcc/testsuite  : ChangeLog 
Added files:
	gcc/testsuite/g++.dg/ext: weak1.C 
	gcc/testsuite/gcc.dg/weak: weak-10.c 
	gcc/testsuite/objc.dg: weak-1.m 

Log message:
	2004-11-29  Daniel Jacobowitz  <dan@codesourcery.com>
	
	PR c/7544
	* Makefile.in (c-lang.o): Update dependencies.
	* c-lang.c: Include "c-pragma.h".
	(finish_file): Call maybe_apply_pending_pragma_weaks.
	* c-pragma.c (maybe_apply_pending_pragma_weaks): New function.
	* c-pragma.h (maybe_apply_pending_pragma_weaks): New prototype.
	
	cp:
	2004-11-29  Daniel Jacobowitz  <dan@codesourcery.com>
	
	* Make-lang.in (cp/decl2.o): Update dependencies.
	* decl2.c (finish_file): Call maybe_apply_pending_pragma_weaks.
	
	objc:
	2004-11-29  Joseph Myers  <joseph@codesourcery.com>
	
	* Make-lang.in (objc/objc-act.o): Update dependencies.
	* objc-act.c (objc_finish_file): Call
	maybe_apply_pending_pragma_weaks if not OBJCPLUS.
	
	testsuite:
	2004-11-29  Joseph Myers  <joseph@codesourcery.com>
	
	* g++.dg/ext/weak1.C, gcc.dg/weak/weak-10.c, objc.dg/weak-1.m: New
	tests.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.6625&r2=2.6626
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/Makefile.in.diff?cvsroot=gcc&r1=1.1425&r2=1.1426
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-lang.c.diff?cvsroot=gcc&r1=1.136&r2=1.137
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-pragma.c.diff?cvsroot=gcc&r1=1.81&r2=1.82
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-pragma.h.diff?cvsroot=gcc&r1=1.44&r2=1.45
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/ChangeLog.diff?cvsroot=gcc&r1=1.4503&r2=1.4504
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/Make-lang.in.diff?cvsroot=gcc&r1=1.197&r2=1.198
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/decl2.c.diff?cvsroot=gcc&r1=1.758&r2=1.759
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/objc/ChangeLog.diff?cvsroot=gcc&r1=1.19&r2=1.20
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/objc/Make-lang.in.diff?cvsroot=gcc&r1=1.75&r2=1.76
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/objc/objc-act.c.diff?cvsroot=gcc&r1=1.256&r2=1.257
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.4676&r2=1.4677
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/ext/weak1.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/weak/weak-10.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/objc.dg/weak-1.m.diff?cvsroot=gcc&r1=NONE&r2=1.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7544

[Bug c/7544] [3.3/3.4/4.0 regression] #pragma weak problem

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-11-29 19:22 -------
Fixed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7544