public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "zack at codesourcery dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/13722] [3.4/3.5 regression] [ia64] ICE in push_secondary_reload Date: Sat, 24 Jan 2004 01:36:00 -0000 [thread overview] Message-ID: <20040124013600.23954.qmail@sources.redhat.com> (raw) In-Reply-To: <20040117230657.13722.schwab@suse.de> ------- Additional Comments From zack at codesourcery dot com 2004-01-24 01:35 ------- Subject: Re: PR 13722 candidate fix Jim Wilson <wilson@specifixinc.com> writes: > On Fri, 2004-01-23 at 00:47, Zack Weinberg wrote: >> Re-revised patch. > > On the REG/SUBREG issue, I was looking at your latest patch. In the > full context of the previous patch, I see you already handle most of > these issues by having a default switch case that aborts. Yes. I think there are good /a priori/ reasons to assume that we won't ever get SUBREGs here, so I think this is adequate. (A SUBREG in the operand itself could only be paradoxical, and shouldn't survive this far; a SUBREG in the MEM expression would either be paradoxical, and again shouldn't have survived this far, or would take it out of Pmode and therefore indicate a bug elsewhere.) > The only real issue I see here is in the POST_MODIFY code where you > have > + if (GET_CODE (XEXP (offset, 1)) == REG) > ... > + else if (INTVAL (XEXP (offset, 1)) < -256 + 8) > which assumes without checking that the offset is a CONST_INT if it > isn't a REG. I put in an abort to see if this ever happens, but I doubt > that it does. The theory here was that INTVAL would trigger an RTL checking abort if offset wasn't a CONST_INT, so there was no need for an explicit check. I now remember that RTL checking isn't on by default, so an explicit check would probably be wise. > I see you have another modified patch. I can try this when my current > build finishes. I would appreciate that. zw -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13722
next prev parent reply other threads:[~2004-01-24 1:36 UTC|newest] Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top 2004-01-17 23:07 [Bug bootstrap/13722] New: [3.4/3.5 regression] [ia64] Ada bootstrap failure schwab at suse dot de 2004-01-17 23:09 ` [Bug bootstrap/13722] " pinskia at gcc dot gnu dot org 2004-01-18 2:13 ` zack at codesourcery dot com 2004-01-18 10:50 ` charlet at act-europe dot fr 2004-01-18 19:44 ` zack at codesourcery dot com 2004-01-18 21:32 ` charlet at act-europe dot fr 2004-01-18 21:42 ` zack at codesourcery dot com 2004-01-18 21:48 ` charlet at act-europe dot fr 2004-01-18 22:29 ` zack at codesourcery dot com 2004-01-18 22:31 ` charlet at act-europe dot fr 2004-01-18 22:33 ` zack at codesourcery dot com 2004-01-18 22:34 ` charlet at act-europe dot fr 2004-01-19 13:14 ` debian-gcc at lists dot debian dot org 2004-01-20 14:12 ` schwab at suse dot de 2004-01-21 13:16 ` rakdver at gcc dot gnu dot org 2004-01-21 14:13 ` [Bug target/13722] [3.4/3.5 regression] [ia64] ICE in push_secondary_reload schwab at suse dot de 2004-01-21 16:54 ` dhazeghi at yahoo dot com 2004-01-22 2:13 ` wilson at specifixinc dot com 2004-01-22 2:26 ` zack at codesourcery dot com 2004-01-22 5:21 ` wilson at specifixinc dot com 2004-01-22 8:23 ` zack at codesourcery dot com 2004-01-22 20:14 ` zack at gcc dot gnu dot org 2004-01-22 20:20 ` zack at codesourcery dot com 2004-01-22 22:05 ` rth at redhat dot com 2004-01-22 22:17 ` wilson at specifixinc dot com 2004-01-23 8:24 ` rth at redhat dot com 2004-01-23 8:35 ` zack at codesourcery dot com 2004-01-23 21:33 ` schwab at suse dot de 2004-01-23 21:51 ` zack at codesourcery dot com 2004-01-23 22:05 ` schwab at suse dot de 2004-01-23 22:18 ` zack at codesourcery dot com 2004-01-23 22:55 ` wilson at specifixinc dot com 2004-01-23 22:58 ` schwab at suse dot de 2004-01-23 23:22 ` wilson at specifixinc dot com 2004-01-24 0:04 ` schwab at suse dot de 2004-01-24 0:19 ` wilson at specifixinc dot com 2004-01-24 0:29 ` rth at redhat dot com 2004-01-24 1:28 ` zack at codesourcery dot com 2004-01-24 1:36 ` zack at codesourcery dot com [this message] 2004-01-24 1:52 ` zack at codesourcery dot com 2004-01-24 1:57 ` schwab at suse dot de 2004-01-24 2:20 ` zack at codesourcery dot com 2004-01-24 3:31 ` wilson at specifixinc dot com 2004-01-24 3:35 ` zack at codesourcery dot com 2004-01-24 3:55 ` wilson at specifixinc dot com 2004-01-24 14:10 ` schwab at suse dot de 2004-01-24 17:38 ` wilson at specifixinc dot com 2004-01-24 20:17 ` wilson at specifixinc dot com 2004-01-25 4:10 ` wilson at specifixinc dot com 2004-01-25 22:33 ` zack at codesourcery dot com 2004-01-26 8:14 ` Arnaud Charlet 2004-01-26 8:15 ` charlet at act-europe dot fr 2004-01-26 18:03 ` zack at codesourcery dot com 2004-01-27 0:08 ` wilson at specifixinc dot com 2004-01-27 17:51 ` ahs3 at fc dot hp dot com 2004-01-27 18:13 ` zack at codesourcery dot com 2004-01-27 18:43 ` ahs3 at fc dot hp dot com 2004-01-27 20:00 ` schwab at suse dot de 2004-01-28 18:13 ` zack at codesourcery dot com 2004-01-28 20:07 ` doko at cs dot tu-berlin dot de 2004-01-28 21:27 ` wilson at specifixinc dot com 2004-01-28 21:39 ` zack at gcc dot gnu dot org 2004-01-28 22:08 ` wilson at specifixinc dot com 2004-01-29 6:47 ` doko at cs dot tu-berlin dot de 2004-01-30 2:25 ` wilson at specifixinc dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20040124013600.23954.qmail@sources.redhat.com \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).