[Bug libstdc++/13462] New: Non-standard conformed type set::pointer

[Bug libstdc++/13462] New: Non-standard conformed type set::pointer

[eugeny dot klementev at intel dot com]

Your set::pointer defined as:
> public:
>   typedef typename _Rep_type::const_pointer pointer;
>   typedef typename _Rep_type::const_pointer const_pointer;
Where _Rep_type::const_pointer is:
> typedef const value_type* const_pointer;

But c++ standard 23.3.3 [lib.set] describes set::pointer as non-const pointer:
> typedef typename Allocator::pointer pointer;
> typedef typename Allocator::const_pointer const_pointer;

This inconsistency raise inpossibility of implicit casting "set<char, 
less<char>, allocator<char> >::pointer" to "allocator<char>::pointer".

-- 
           Summary: Non-standard conformed type set::pointer
           Product: gcc
           Version: 3.2
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: libstdc++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: eugeny dot klementev at intel dot com
                CC: gcc-bugs at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13462

[Bug libstdc++/13462] Non-standard conformed type set::pointer

[eugeny dot klementev at intel dot com]

------- Additional Comments From eugeny dot klementev at intel dot com  2003-12-22 10:55 -------
Created an attachment (id=5352)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=5352&action=view)
Test case to demonstrate bug


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13462

[Bug libstdc++/13462] Non-standard conformed type set::pointer

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2003-12-22 15:55 -------
Confirmed, looks like a simple typo that has not been changed yet, I will submit a patch and your 
testcase.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pinskia at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2003-12-22 15:55:50
               date|                            |
   Target Milestone|---                         |3.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13462

[Bug libstdc++/13462] Non-standard conformed type set::pointer

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2003-12-22 16:20 -------
A patch is here: <http://gcc.gnu.org/ml/gcc-patches/2003-12/msg01895.html>.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13462

[Bug libstdc++/13462] Non-standard conformed type set::pointer

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2003-12-22 18:51 -------
Updated patch also fixes reference: <http://gcc.gnu.org/ml/gcc-patches/2003-12/
msg01905.html>.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13462

[Bug libstdc++/13462] Non-standard conformed type set::pointer

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2003-12-22 19:32 -------
Subject: Bug 13462

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	pinskia@gcc.gnu.org	2003-12-22 19:32:34

Modified files:
	libstdc++-v3   : ChangeLog 
	libstdc++-v3/include/bits: stl_multiset.h stl_set.h 
	libstdc++-v3/include/ext: hash_set 

Log message:
	2003-12-22  Andrew Pinski  <pinskia@physics.uc.edu>
	
	PR libstdc++/13462
	* include/bits/stl_multiset.h (__gnu_norm::multiset): Define pointer
	as allocator's pointer, likewise for reference, const_pointer, and
	const_reference.
	* include/bits/stl_set.h (__gnu_norm::set): Likewise.
	* include/ext/hash_set (__gnu_ext::hash_set): Likewise.
	(__gnu_ext::hash_multiset): Likewise.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/ChangeLog.diff?cvsroot=gcc&r1=1.2179&r2=1.2180
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/bits/stl_multiset.h.diff?cvsroot=gcc&r1=1.16&r2=1.17
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/bits/stl_set.h.diff?cvsroot=gcc&r1=1.16&r2=1.17
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/ext/hash_set.diff?cvsroot=gcc&r1=1.16&r2=1.17



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13462

[Bug libstdc++/13462] Non-standard conformed type set::pointer

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2003-12-22 19:34 -------
Fixed for 3.4.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13462

[Bug libstdc++/13462] Non-standard conformed type set::pointer

[pcarlini at suse dot de]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.4.0                       |3.3.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13462

[Bug libstdc++/13462] Non-standard conformed type set::pointer

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-01-28 16:34 -------
Subject: Bug 13462

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_3-branch
Changes by:	paolo@gcc.gnu.org	2004-01-28 16:34:08

Modified files:
	libstdc++-v3   : ChangeLog 
	libstdc++-v3/include/bits: stl_multiset.h stl_set.h 
	libstdc++-v3/include/ext: hash_set 

Log message:
	2004-01-28  Andrew Pinski  <pinskia@physics.uc.edu>
	
	PR libstdc++/13462
	* include/bits/stl_multiset.h (std::multiset): Define pointer
	as allocator's pointer, likewise for reference, const_pointer, and
	const_reference.
	* include/bits/stl_set.h (std::set): Likewise.
	* include/ext/hash_set (__gnu_cxx::hash_set): Likewise.
	(__gnu_cxx::hash_multiset): Likewise.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.1464.2.174&r2=1.1464.2.175
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/bits/stl_multiset.h.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.11&r2=1.11.38.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/bits/stl_set.h.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.11&r2=1.11.38.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/ext/hash_set.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.12&r2=1.12.14.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13462