[Bug target/14064] New: -fdata-sections triggers ICE

[Bug target/14064] New: -fdata-sections triggers ICE

[berndtrog at yahoo dot com]

/* begin test.c */
int test_1;
/* end   test.c */

$ avr-gcc -c -fdata-sections test.c

test.c:2: internal compiler error: in avr_unique_section, at config/avr/avr.c:4369
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://gcc.gnu.org/bugs.html> for instructions.


gcc version 3.4.0 20040207 (prerelease)
(gcc-3.3.2 has the same problem)

Note:

-ffunction-sections works realy great!

-- 
           Summary: -fdata-sections triggers ICE
           Product: gcc
           Version: 3.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: target
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: berndtrog at yahoo dot com
                CC: gcc-bugs at gcc dot gnu dot org
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: avr


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14064

[Bug target/14064] -fdata-sections triggers ICE

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-02-07 19:00 -------
Confirmed, not a regression as the abort/fatal go all the way back from when it was added to the CVS.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
           Keywords|                            |ice-on-valid-code
   Last reconfirmed|0000-00-00 00:00:00         |2004-02-07 19:00:19
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14064

[Bug target/14064] -fdata-sections triggers ICE

[berndtrog at yahoo dot com]

------- Additional Comments From berndtrog at yahoo dot com  2004-03-06 18:55 -------
Hello,
David Gay suggested the removal of

#undef TARGET_ASM_UNIQUE_SECTION
#define TARGET_ASM_UNIQUE_SECTION avr_unique_section

in avr.c on the avr-gcc list.

This works very well for me!
I don't think it will cause any regressions with existing code.

Would this be OK for 3.4.0?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14064

[Bug target/14064] -fdata-sections triggers ICE

[ericw at evcohs dot com]

------- Additional Comments From ericw at evcohs dot com  2004-07-20 18:56 -------
Could somebody take a look at the suggestion in comment #2? Would this be ok for
3.4.2?

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14064

[Bug target/14064] -fdata-sections triggers ICE

[ericw at evcohs dot com]

------- Additional Comments From ericw at evcohs dot com  2004-08-31 17:48 -------
Confirmed that the following patch works for 3.4.1:

--- gcc/config/avr/avr.c.orig2	2004-08-31 10:09:19.367125000 -0600
+++ gcc/config/avr/avr.c	2004-08-31 10:09:46.351500000 -0600
@@ -236,8 +236,6 @@
 #define TARGET_ASM_FUNCTION_EPILOGUE avr_output_function_epilogue
 #undef TARGET_ATTRIBUTE_TABLE
 #define TARGET_ATTRIBUTE_TABLE avr_attribute_table
-#undef TARGET_ASM_UNIQUE_SECTION
-#define TARGET_ASM_UNIQUE_SECTION avr_unique_section
 #undef TARGET_INSERT_ATTRIBUTES
 #define TARGET_INSERT_ATTRIBUTES avr_insert_attributes
 #undef TARGET_SECTION_TYPE_FLAGS

Since this only affects the AVR target, can this patch be approved for 3.4.3?

Thanks
Eric Weddington

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14064

[Bug target/14064] -fdata-sections triggers ICE

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-09-02 01:04 -------
Subject: Bug 14064

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	wilson@gcc.gnu.org	2004-09-02 01:04:23

Modified files:
	gcc            : ChangeLog 
	gcc/config/avr : avr.c 

Log message:
	Make -fdata-sections work for AVR port.
	PR target/14064
	* config/avr/avr.c (avr_unique_section): Delete prototype and
	definition.
	(TARGET_ASM_UNIQUE_SECTION): Delete.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.5201&r2=2.5202
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/avr/avr.c.diff?cvsroot=gcc&r1=1.120&r2=1.121



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14064

[Bug target/14064] -fdata-sections triggers ICE

[wilson at gcc dot gnu dot org]

------- Additional Comments From wilson at gcc dot gnu dot org  2004-09-02 01:04 -------
The suggested change is reasonable.  The AVR avr_unique_section function
predates the default_unique_section function in varasm.c which is much better,
and the avr_unique_section function has no AVR specific features, so we should
just use the default one instead.

The suggested patch is incomplete though.  There are 3 things that need to be
done.  Delete the avr_unique_section prototype, delete the avr_unique_section
function definition, and delete the TARGET_ASM_UNIQUE_SECTION definition.  Plus
the patch needs to be mailed to the gcc-patches list.

I have taken care of this, and checked in the patch to mainline.

I have not added the patch to the gcc-3.4.x branch, because technically it is
not a regression.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |wilson at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14064

[Bug target/14064] -fdata-sections triggers ICE

[berndtrog at yahoo dot com]

------- Additional Comments From berndtrog at yahoo dot com  2004-09-24 15:25 -------
>I have taken care of this, and checked in the patch to mainline.

Thanks!

>I have not added the patch to the gcc-3.4.x branch, because technically it is
>not a regression.

If it can't go into the gcc-3.4.x branch this PR should be closed, right?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14064

[Bug target/14064] -fdata-sections triggers ICE

[giovannibajo at libero dot it]

------- Additional Comments From giovannibajo at libero dot it  2004-09-26 22:21 -------
Mark,

I would very like to have this patch into 3.4. It affects only the AVR backend, 
and fixes an ICE on -fdata-section which has always been there. -fdata-section 
is very important for embedded targets, so it is an important fix for the AVR 
port. The fix does look very safe, because default_unique_section in varasm.c 
is surely much more stable.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |giovannibajo at libero dot
                   |                            |it, mmitchel at gcc dot gnu
                   |                            |dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14064

[Bug target/14064] -fdata-sections triggers ICE

[mmitchel at gcc dot gnu dot org]

------- Additional Comments From mmitchel at gcc dot gnu dot org  2004-09-27 06:04 -------
This patch is OK for 3.4.3 if approved by the AVR maintainer.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14064

[Bug target/14064] -fdata-sections triggers ICE

[giovannibajo at libero dot it]

------- Additional Comments From giovannibajo at libero dot it  2004-09-27 11:14 -------
Thanks Mark. Denis, is it ok to apply this to 3.4?

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |denisc at overta dot ru


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14064

[Bug target/14064] -fdata-sections triggers ICE

[denisc at overta dot ru]

------- Additional Comments From denisc at overta dot ru  2004-09-27 17:40 -------
Subject: Re:  -fdata-sections triggers ICE


OK to apply. Please commit it.

Denis.



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14064

[Bug target/14064] [3.4 only] -fdata-sections triggers ICE

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|-fdata-sections triggers ICE|[3.4 only] -fdata-sections
                   |                            |triggers ICE
   Target Milestone|---                         |3.4.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14064

[Bug target/14064] [3.4 only] -fdata-sections triggers ICE

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-09-28 01:13 -------
Subject: Bug 14064

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_4-branch
Changes by:	giovannibajo@gcc.gnu.org	2004-09-28 01:13:55

Modified files:
	gcc            : ChangeLog 
	gcc/config/avr : avr.c 

Log message:
	PR target/14064
	Backport from mainline
	2004-09-01  James E Wilson  <wilson@specifixinc.com>
	* config/avr/avr.c (avr_unique_section): Delete prototype and
	definition.
	(TARGET_ASM_UNIQUE_SECTION): Delete.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=2.2326.2.636&r2=2.2326.2.637
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/avr/avr.c.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.108.4.2&r2=1.108.4.3



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14064

[Bug target/14064] [3.4 only] -fdata-sections triggers ICE

[giovannibajo at libero dot it]

------- Additional Comments From giovannibajo at libero dot it  2004-09-28 01:14 -------
Fixed now in both GCC 3.4.3 and GCC 4.0.0.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14064