From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28372 invoked by alias); 14 Feb 2004 19:45:44 -0000 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org Received: (qmail 28365 invoked by alias); 14 Feb 2004 19:45:43 -0000 Date: Sat, 14 Feb 2004 19:45:00 -0000 Message-ID: <20040214194543.28364.qmail@sources.redhat.com> From: "cvs-commit at gcc dot gnu dot org" To: gcc-bugs@gcc.gnu.org In-Reply-To: <20040125173917.13858.peturr02@ru.is> References: <20040125173917.13858.peturr02@ru.is> Reply-To: gcc-bugzilla@gcc.gnu.org Subject: [Bug libstdc++/13858] Bad error handling in basic_filebuf::imbue X-Bugzilla-Reason: CC X-SW-Source: 2004-02/txt/msg01487.txt.bz2 List-Id: ------- Additional Comments From cvs-commit at gcc dot gnu dot org 2004-02-14 19:45 ------- Subject: Bug 13858 CVSROOT: /cvs/gcc Module name: gcc Branch: gcc-3_4-branch Changes by: paolo@gcc.gnu.org 2004-02-14 19:45:34 Modified files: libstdc++-v3 : ChangeLog libstdc++-v3/include/bits: fstream.tcc libstdc++-v3/testsuite/27_io/basic_filebuf/overflow/char: 9182-2.cc libstdc++-v3/testsuite/27_io/basic_filebuf/seekoff/wchar_t: 3.cc libstdc++-v3/testsuite/27_io/basic_filebuf/seekpos/wchar_t: 1.cc libstdc++-v3/testsuite/27_io/basic_filebuf/sync/char: 9182-1.cc Added files: libstdc++-v3/testsuite/27_io/basic_filebuf/overflow/char: 13858.cc libstdc++-v3/testsuite/27_io/basic_filebuf/overflow/wchar_t: 13858.cc Log message: 2004-02-14 Paolo Carlini PR libstdc++/13858 * include/bits/fstream.tcc (basic_filebuf<>::_M_convert_to_external): In case of conversion errors, throw ios_failure; simplify. * testsuite/27_io/basic_filebuf/overflow/char/13858.cc: New. * testsuite/27_io/basic_filebuf/overflow/wchar_t/13858.cc: Ditto. * testsuite/27_io/basic_filebuf/overflow/char/9182-2.cc: Tweak, previously we didn't throw in case of conversion errors, instead just returned eof(). * testsuite/27_io/basic_filebuf/seekoff/wchar_t/3.cc: Ditto. * testsuite/27_io/basic_filebuf/seekpos/wchar_t/1.cc: Ditto. * testsuite/27_io/basic_filebuf/sync/char/9182-1.cc: Ditto. * include/bits/fstream.tcc (basic_filebuf<>::overflow): Trivial simplification of a conditional. Patches: http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.2224.2.34&r2=1.2224.2.35 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/bits/fstream.tcc.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.116.4.2&r2=1.116.4.3 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/27_io/basic_filebuf/overflow/char/13858.cc.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=NONE&r2=1.1.2.1 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/27_io/basic_filebuf/overflow/char/9182-2.cc.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.2&r2=1.2.12.1 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/27_io/basic_filebuf/overflow/wchar_t/13858.cc.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=NONE&r2=1.1.2.1 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/27_io/basic_filebuf/seekoff/wchar_t/3.cc.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.1&r2=1.1.12.1 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/27_io/basic_filebuf/seekpos/wchar_t/1.cc.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.1&r2=1.1.12.1 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/27_io/basic_filebuf/sync/char/9182-1.cc.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.2&r2=1.2.12.1 -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13858