[Bug target/14041] New: H8300-elf unaligned word/longword access of zero initialized variables

[Bug target/14041] New: H8300-elf unaligned word/longword access of zero initialized variables

[dhananjayd at kpitcummins dot com]

Try code below with h8300-elf toolchain

----------------bug.c ---------------------

typedef struct {
	char a;
	char b;
}S1;

typedef struct {
	S1 d;
	void* ptr;
}S2;

static char tmp[1] = {0};
S2 test[1] = {0};

char func(S1 st) {}

int main() 
{
	return( func(test[1].d) );
}


----------------bug.c ---------------------

Compile with 

h8300-elf-gcc -ms -O2 bug.c

The dump with
h8300-elf-objdump -d a.out 

shows 

00000202 <_main>:
     202:       01 00 6d f6     01 00 6d f6       mov.l er6,@-er7
     206:       0f f6           0f f6             mov.l er7,er6
     208:       6b 20 00 00     6b 20 00 00 1e f1 mov.w @0x1ef1:32,r0 ******
     20c:       1e f1
     20e:       17 70           17 70             extu.l        er0
     210:       5e 00 01 f2     5e 00 01 f2       jsr   @0x1f2:0
     214:       17 50           17 50             extu.w        r0
     216:       01 00 6d 76     01 00 6d 76       mov.l @er7+,er6
     21a:       54 70           54 70             rts

The instruction 
     208:       6b 20 00 00     6b 20 00 00 1e f1 mov.w @0x1ef1:32,r0

has unaligned word access.

-- 
           Summary: H8300-elf unaligned word/longword access of zero
                    initialized variables
           Product: gcc
           Version: 3.3.3
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: target
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: dhananjayd at kpitcummins dot com
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: i686-pc-linux-gnu
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: h8300-unknown-elf


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14041

[Bug target/14041] H8300-elf unaligned word/longword access of zero initialized variables

[dhananjayd at kpitcummins dot com]

------- Additional Comments From dhananjayd at kpitcummins dot com  2004-02-06 06:44 -------
Also exits on mainline and 3.4


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14041

[Bug target/14041] H8300-elf unaligned word/longword access of zero initialized variables

[dhananjayd at kpitcummins dot com]

------- Additional Comments From dhananjayd at kpitcummins dot com  2004-02-06 06:56 -------
Subject: Re:  New: H8300-elf unaligned word/longword access of zero initialized variables 

This requires ASM_OUTPUT_ALIGNED_BSS to be defined.

-Dhananjay

2004-02-06  Dhananjay Deshpande  <dhananjayd@kpitcummins.com>

        PR target/14041
        * config/h8300/h8300.h (ASM_OUTPUT_ALIGNED_BSS): Define.


--- old/gcc/config/h8300/h8300.h	Thu Jun 12 17:37:10 2003
+++ gcc-3.3/gcc/config/h8300/h8300.h	Wed Feb  4 21:54:03 2004
@@ -1247,6 +1247,20 @@ struct cum_arg
 #define ASM_OUTPUT_BSS(FILE, DECL, NAME, SIZE, ROUNDED)		\
   asm_output_bss ((FILE), (DECL), (NAME), (SIZE), (ROUNDED))
 
+/* Like `ASM_OUTPUT_BSS' except takes the required alignment as a
+   separate, explicit argument.  If you define this macro, it is used
+   in place of `ASM_OUTPUT_BSS', and gives you more flexibility in
+   handling the required alignment of the variable.  The alignment is
+   specified as the number of bits.
+
+   Try to use function `asm_output_aligned_bss' defined in file
+   `varasm.c' when defining this macro.  */
+#ifndef ASM_OUTPUT_ALIGNED_BSS
+#define ASM_OUTPUT_ALIGNED_BSS(FILE, DECL, NAME, SIZE, ALIGN) \
+  asm_output_aligned_bss (FILE, DECL, NAME, SIZE, ALIGN)
+#endif
+
+
 /* This says how to output an assembler line
    to define a local common symbol.  */
 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14041


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14041

[Bug target/14041] H8300-elf unaligned word/longword access of zero initialized variables

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-02-06 07:01 -------
Confirmed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
           Keywords|                            |patch, wrong-code
   Last reconfirmed|0000-00-00 00:00:00         |2004-02-06 07:01:40
               date|                            |
   Target Milestone|---                         |3.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14041

[Bug target/14041] H8300-elf unaligned word/longword access of zero initialized variables

[kazu at cs dot umass dot edu]

------- Additional Comments From kazu at cs dot umass dot edu  2004-02-09 17:06 -------
Could you post your patch to gcc-patches without the comment and #ifndef?

For a testcase, you can probably look for .align 2 in the assembly
of the following piece of code.

struct s {
  char a, b;
  long c;
};

struct s s = {0};


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14041

[Bug target/14041] H8300-elf unaligned word/longword access of zero initialized variables

[dhananjayd at kpitcummins dot com]

------- Additional Comments From dhananjayd at kpitcummins dot com  2004-02-10 04:58 -------
Subject: RE:  H8300-elf unaligned word/longword access of zero initialized variables



> -----Original Message-----
> From: kazu at cs dot umass dot edu [mailto:gcc-bugzilla@gcc.gnu.org]
> ------- Additional Comments From kazu at cs dot umass dot edu 
>  2004-02-09 17:06 -------
> Could you post your patch to gcc-patches without the comment 
> and #ifndef?

Updated patch - 

2004-02-10  Dhananjay Deshpande  <dhananjayd@kpitcummins.com>

        PR target/14041
        * config/h8300/h8300.h (ASM_OUTPUT_ALIGNED_BSS): Define.

====================================================================
--- config/h8300/h8300.h.old	Tue Feb 10 15:51:47 2004
+++ config/h8300/h8300.h	Tue Feb 10 15:52:31 2004
@@ -1157,6 +1157,9 @@ struct cum_arg
 #define ASM_OUTPUT_BSS(FILE, DECL, NAME, SIZE, ROUNDED)		\
   asm_output_bss ((FILE), (DECL), (NAME), (SIZE), (ROUNDED))
 
+#define ASM_OUTPUT_ALIGNED_BSS(FILE, DECL, NAME, SIZE, ALIGN) \
+  asm_output_aligned_bss (FILE, DECL, NAME, SIZE, ALIGN)
+
 /* This says how to output an assembler line
    to define a local common symbol.  */
 
====================================================================


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14041

[Bug target/14041] H8300-elf unaligned word/longword access of zero initialized variables

[kazu at cs dot umass dot edu]

------- Additional Comments From kazu at cs dot umass dot edu  2004-02-11 01:54 -------
Subject: Re:  H8300-elf unaligned word/longword access of
 zero initialized variables

Hi Dhananjay,

> Updated patch - 
> 
> 2004-02-10  Dhananjay Deshpande  <dhananjayd@kpitcummins.com>
> 
>         PR target/14041
>         * config/h8300/h8300.h (ASM_OUTPUT_ALIGNED_BSS): Define.

Thanks.  Could you also post a testcase?  You will most likely find
the scan-assembler trick in gcc.dg useful.  Basically, you can search
for ".align 2" in the compiled version of the testcase in comment #4
of the PR.

Kazu Hirata


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14041

[Bug target/14041] H8300-elf unaligned word/longword access of zero initialized variables

[dhananjayd at kpitcummins dot com]

------- Additional Comments From dhananjayd at kpitcummins dot com  2004-02-11 08:53 -------
Subject: RE:  H8300-elf unaligned word/longword access of zero initialized variables

Hi,

Please find testcase below.
 
I have enabled testcase for h8300-*-elf only and passing -mh option. (For plain H8/300 it will generate .align 1 and test would fail)

-Dhananjay

Testsuite Changelog 

2004-02-11  Dhananjay Deshpande  <dhananjayd@kpitcummins.com>

        PR target/14041
        * gcc.dg/h8300-bss-align-1.c : New.

================================================================
--- /dev/null	Wed May  6 02:02:27 1998
+++ gcc.dg/h8300-bss-align-1.c	Wed Feb 11 18:06:42 2004
@@ -0,0 +1,13 @@
+/* Make sure that the H8 backend does align zero initialized variables. */
+/* { dg-do compile { target h8300-*-elf } } */
+/* { dg-options "-mh" } */
+
+struct s {
+  char a, b;
+  long c;
+};
+
+struct s s = {0};
+
+/* { dg-final { scan-assembler ".align 2" } } */
+

================================================================



> -----Original Message-----
> From: kazu at cs dot umass dot edu [mailto:gcc-bugzilla@gcc.gnu.org]
> Sent: Wednesday, February 11, 2004 7:24 AM
> To: Dhananjay R. Deshpande
> Subject: [Bug target/14041] H8300-elf unaligned word/longword 
> access of
> zero initialized variables
> 
> 
> 
> ------- Additional Comments From kazu at cs dot umass dot edu 
>  2004-02-11 01:54 -------
> Subject: Re:  H8300-elf unaligned word/longword access of
>  zero initialized variables
> 
> Hi Dhananjay,
> 
> > Updated patch - 
> > 
> > 2004-02-10  Dhananjay Deshpande  <dhananjayd@kpitcummins.com>
> > 
> >         PR target/14041
> >         * config/h8300/h8300.h (ASM_OUTPUT_ALIGNED_BSS): Define.
> 
> Thanks.  Could you also post a testcase?  You will most likely find
> the scan-assembler trick in gcc.dg useful.  Basically, you can search
> for ".align 2" in the compiled version of the testcase in comment #4
> of the PR.
> 
> Kazu Hirata
> 
> 
> -- 
> 
> 
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14041
> 
> ------- You are receiving this mail because: -------
> You reported the bug, or are watching the reporter.
> 


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14041

[Bug target/14041] H8300-elf unaligned word/longword access of zero initialized variables

[kazu at cs dot umass dot edu]

------- Additional Comments From kazu at cs dot umass dot edu  2004-02-11 15:17 -------
Subject: Re:  H8300-elf unaligned word/longword access of
 zero initialized variables

Hi Dhananjay,

> Please find testcase below.

Thanks.

> I have enabled testcase for h8300-*-elf only

Why not h8300-*?  We should care for the COFF target as long as it's
there.

> and passing -mh option.  (For plain H8/300 it will generate .align 1
> and test would fail)

Would the same problem exist on the plain H8/300 then?  IIRC, H8 is
pretty lenient about alignment, but I don't know how lenient it is.
Or is it the case that no plain H8/300 supports 16-bit data bus or
something?

By the way, which version of GCC did you run the testsuite for?

Currently, h8300-elf on mainline doesn't build, so I'll apply your
patch after the build is restored.  Meanwhile, you might want to post
a complete patch with the testcase and ChangeLog entries to
gcc-patches for the record.

Kazu Hirata


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14041

[Bug target/14041] H8300-elf unaligned word/longword access of zero initialized variables

[dhananjayd at kpitcummins dot com]

------- Additional Comments From dhananjayd at kpitcummins dot com  2004-02-16 09:34 -------
Subject: RE:  H8300-elf unaligned word/longword access of zero initialized variables


> 
> 
> Why not h8300-*?  We should care for the COFF target as long as it's
> there.

Initially the bug occurred only for elf target. Looking at generated code, it was due to linker script alignment. So I have now enabled test for h8300-*-*

> 
> Would the same problem exist on the plain H8/300 then?  IIRC, H8 is
> pretty lenient about alignment, but I don't know how lenient it is.
> Or is it the case that no plain H8/300 supports 16-bit data bus or
> something?
> 

Yes, the problem exists on plain H8/300 too. As I mentioned earlier, the compiler will generate ".align 1" for plain H8/300. I couldn't find how to check for ".align 1" when target is plain H8/300 and ".align 2" for -mh and -ms. So I had added -mh in options and checked for ".align 2"

I think it is better to scan only for ".align". Without this patch, .align is not generated. 

> By the way, which version of GCC did you run the testsuite for?
> 
> Currently, h8300-elf on mainline doesn't build, so I'll apply your
> patch after the build is restored.  Meanwhile, you might want to post
> a complete patch with the testcase and ChangeLog entries to
> gcc-patches for the record.

I tested it with 3.4 snapshot. Currently I am facing problems accessing sources using cvs  so can't use mainline.

Please find updated patch below - 

-Dhananjay

gcc/Changelog -

2004-02-16  Dhananjay Deshpande  <dhananjayd@kpitcummins.com>

        PR target/14041
        * config/h8300/h8300.h (ASM_OUTPUT_ALIGNED_BSS): Define.

==========================================================================
--- config/h8300/h8300.h.old	Tue Feb 10 15:51:47 2004
+++ config/h8300/h8300.h	Tue Feb 10 15:52:31 2004
@@ -1157,6 +1157,9 @@ struct cum_arg
 #define ASM_OUTPUT_BSS(FILE, DECL, NAME, SIZE, ROUNDED)		\
   asm_output_bss ((FILE), (DECL), (NAME), (SIZE), (ROUNDED))
 
+#define ASM_OUTPUT_ALIGNED_BSS(FILE, DECL, NAME, SIZE, ALIGN) \
+  asm_output_aligned_bss (FILE, DECL, NAME, SIZE, ALIGN)
+
 /* This says how to output an assembler line
    to define a local common symbol.  */
 
==========================================================================
testsuite/Changelog

2004-02-16  Dhananjay Deshpande  <dhananjayd@kpitcummins.com>

        PR target/14041
        * gcc.dg/h8300-bss-align-1.c : New.


==========================================================================
--- /dev/null	Wed May  6 02:02:27 1998
+++ gcc.dg/h8300-bss-align-1.c	Fri Feb 13 18:10:01 2004
@@ -0,0 +1,13 @@
+/* Make sure that the H8 backend does align zero initialized variables. */
+/* { dg-do compile { target h8300-*-* } } */
+/* { dg-options "" } */
+
+struct s {
+  char a, b;
+  long c;
+};
+
+struct s s = {0};
+
+/* { dg-final { scan-assembler ".align" } } */
+
==========================================================================


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14041

[Bug target/14041] H8300-elf unaligned word/longword access of zero initialized variables

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.5.0                       |---


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14041

[Bug target/14041] H8300-elf unaligned word/longword access of zero initialized variables

[law at gcc dot gnu dot org]

------- Additional Comments From law at gcc dot gnu dot org  2004-06-28 16:22 -------
Patch checked in.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14041

[Bug target/14041] H8300-elf unaligned word/longword access of zero initialized variables

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-06-28 16:23 -------
Subject: Bug 14041

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	law@gcc.gnu.org	2004-06-28 16:23:02

Modified files:
	gcc            : ChangeLog 
	gcc/config/h8300: h8300.h 
	gcc/testsuite  : ChangeLog 
Added files:
	gcc/testsuite/gcc.dg: h8300-bss-align-1.c 

Log message:
	PR target/14041
	* config/h8300/h8300.h (ASM_OUTPUT_ALIGNED_BSS): Define.
	
	PR target/14041
	* gcc.dg/h8300-bss-align-1.c : New.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.4177&r2=2.4178
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/h8300/h8300.h.diff?cvsroot=gcc&r1=1.175&r2=1.176
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.3909&r2=1.3910
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/h8300-bss-align-1.c.diff?cvsroot=gcc&r1=NONE&r2=1.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14041

[Bug target/14041] H8300-elf unaligned word/longword access of zero initialized variables

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |3.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14041