[Bug c++/14178] New: doc bug: -fabi-version=2 is now default (not 1)

[Bug c++/14178] New: doc bug: -fabi-version=2 is now default (not 1)

[thome at lix dot polytechnique dot fr]

gcc 3.4.0 cvs 20040211

According to c-common.c:617, -fabi-version=2 is now the default.
However doc/invoke.texi:1274 says ``The default is version 1.''

which is wrong.

-- 
           Summary: doc bug: -fabi-version=2 is now default (not 1)
           Product: gcc
           Version: 3.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: thome at lix dot polytechnique dot fr
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: any
  GCC host triplet: any
GCC target triplet: any


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14178

[Bug c++/14178] doc bug: -fabi-version=2 is now default (not 1)

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-02-17 16:46 -------
Subject: Bug 14178

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	pinskia@gcc.gnu.org	2004-02-17 16:46:26

Modified files:
	gcc            : ChangeLog 
	gcc/doc        : invoke.texi 

Log message:
	2004-02-17  Andrew Pinski  <pinskia@physics.uc.edu>
	
	PR c++/14178
	* doc/invoke.texi (fabi-version): The default is 2 now.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.2795&r2=2.2796
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/doc/invoke.texi.diff?cvsroot=gcc&r1=1.408&r2=1.409



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14178

[Bug c++/14178] doc bug: -fabi-version=2 is now default (not 1)

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-02-17 16:49 -------
Fix was just checked in.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |3.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14178

[Bug c++/14178] doc bug: -fabi-version=2 is now default (not 1)

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-02-17 16:49 -------
Subject: Bug 14178

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_4-branch
Changes by:	pinskia@gcc.gnu.org	2004-02-17 16:48:56

Modified files:
	gcc            : ChangeLog 
	gcc/doc        : invoke.texi 

Log message:
	2004-02-17  Andrew Pinski  <pinskia@physics.uc.edu>
	
	PR c++/14178
	* doc/invoke.texi (fabi-version): The default is 2 now.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=2.2326.2.205&r2=2.2326.2.206
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/doc/invoke.texi.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.390.2.15&r2=1.390.2.16



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14178

[Bug c++/14178] doc bug: -fabi-version=2 is now default (not 1)

[thome at lix dot polytechnique dot fr]

------- Additional Comments From thome at lix dot polytechnique dot fr  2004-02-18 12:55 -------

You may as well update the comment above the flag_abi_version definition in
c-common.h ; it's not in sync with c-common.c . For some reason these two files
have a whole bunch of comments duplicated, and a handful of them don't agree
(IMHO, only one place should contain those comments).

E.

(In reply to comment #3)
> Fix was just checked in.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14178

[Bug c++/14178] doc bug: -fabi-version=2 is now default (not 1)

[bangerth at dealii dot org]

------- Additional Comments From bangerth at dealii dot org  2004-02-18 21:53 -------
That's correct. On mainline, the flag is declared in flags.h, and initialized 
in toplev.c. The comments in the two places don't match. So this needs more 
patches -- I'll reopen the PR. 
 
W. 

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14178

[Bug c++/14178] doc bug: -fabi-version=2 is now default (not 1)

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-02-18 22:28 -------
Confirmed, but since you know what you want, can you supply a patch to gcc-patches@ with the fix.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2004-02-18 22:28:02
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14178

[Bug c++/14178] doc bug: -fabi-version=2 is now default (not 1)

[thome at lix dot polytechnique dot fr]

------- Additional Comments From thome at lix dot polytechnique dot fr  2004-02-19 14:32 -------

I would do more extensive cleanup, if there were a consensus on what to do with
these very scattered comments. Most (if not all) comments about flags are
duplicated (c-common.c , c-common.h, toplev.c, flags.h, only to mention those).

It would really be nicer if one single rule could determine where to find a
terse comment about some particular variable (.c or .h ? I vote for .c since
[ec]tags goes easier right to it). I've checked the sources, there seems to be
no such rule. Therefore, producing a patch which brings in sync the dozens of
disagreeing comments would be not very fascinating housekeeping job, and bound
to be somewhat useless (no reason to expect the situation would be any better 6
months from now).

I would prefer to decide that terse comments have no place in, say, the .h
files, and synchronize them in the .c files ; but doing such a thing requires a
consensus, I'm not going to submit anything on my own otherwise.

The previous patch updates the comment about abi_version for 3.4.0, which is
enough for the current PR. For the rest of the code cleanup, it certainly can wait.

E.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14178

[Bug other/14178] doc bug: -fabi-version=2 is now default (not 1)

[ian at wasabisystems dot com]

------- Additional Comments From ian at wasabisystems dot com  2004-03-27 03:46 -------
I'm retargeting this PR to 3.5.0 because the 3.4 issue has been fixed.  The PR
has become a request to fix and cleanup the comments in the code regarding
various flags.  I think this is a mainline issue, not a release branch issue. 
Please correct me if I am doing something wrong.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|c++                         |other
   Target Milestone|3.4.0                       |3.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14178

[Bug other/14178] doc bug: -fabi-version=2 is now default (not 1)

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |minor


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14178

[Bug other/14178] doc bug: -fabi-version=2 is now default (not 1)

[mmitchel at gcc dot gnu dot org]

------- Additional Comments From mmitchel at gcc dot gnu dot org  2004-10-08 21:35 -------
I've removed the target milestone for this PR.  Mistaken comments in the source
code are never release-critical.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.0.0                       |---


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14178