[Bug target/14202] New: [arm] Thumb __builtin_setjmp not interworking safe

[Bug target/14202] New: [arm] Thumb __builtin_setjmp not interworking safe

[drow at gcc dot gnu dot org]

There are two problems.  The first is simple, indirect jumps don't use bx.
arm_indirect_jump and thumb_indirect_jump are the only affected patterns,
the "fix" is obvious.

The second is triggered by that fix.  __builtin_setjmp works by saving
the address of a label, and later jumping to it in __builtin_longjmp.
The label has its low bit clear; if I fix the arm_indirect_jump to use bx, then
the bx will set us back into ARM mode.

So if the exception is thrown from ARM code and caught in Thumb code, we'll get
illegal instructions all over the place when we return to the Thumb code.  With
the use of bx this is probably true for exceptions within Thumb code also.

The obvious thing to do would be to mark the low bit of the label.  I couldn't
make gas do it; it explicitly rejects .thumb_func for local labels.  If I use
.thumb_set then it looks like the result will work, but the label becomes a symbol
and clutters up disassembly.

An alternative would be to explicitly or the lower bit of the label.  It could be
done at runtime in builtin_setjmp_setup or at compiletime by emitting
  .word L12 + 1
instead of
  .word L12
which would require a change to expand_builtin_setjmp.

Here's the trivial testcase I've been using.

int main ()
{
  try {
    throw 1;
  }
  catch (int)
    { return 0; }
  catch (...)
    { return 0; }
  return 1;
}

-- 
           Summary: [arm] Thumb __builtin_setjmp not interworking safe
           Product: gcc
           Version: 3.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: target
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: drow at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: i686-pc-linux-gnu
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: arm-elf


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14202

[Bug target/14202] [arm] Thumb __builtin_setjmp not interworking safe

[drow at gcc dot gnu dot org]

------- Additional Comments From drow at gcc dot gnu dot org  2004-02-19 00:15 -------
Created an attachment (id=5768)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=5768&action=view)
Ugly patch for Thumb interworking exceptions


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14202

[Bug target/14202] [arm] Thumb __builtin_setjmp not interworking safe

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
  GCC build triplet|i686-pc-linux-gnu           |
   GCC host triplet|i686-pc-linux-gnu           |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14202

[Bug target/14202] [arm] Thumb __builtin_setjmp not interworking safe

[rearnsha at gcc dot gnu dot org]

------- Additional Comments From rearnsha at gcc dot gnu dot org  2004-02-19 12:01 -------
I wonder whether it might be better to build unwind-sjlj.c with
DONT_USE_BUILTIN_SETJMP defined.  Not only should this fix the second problem
you are seeing, but it also fits in with the EABI philosopy, where only the
system library needs to know exactly which registers are available on the
machine at run time.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14202

[Bug target/14202] [arm] Thumb __builtin_setjmp not interworking safe

[rearnsha at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rearnsha at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14202

[Bug target/14202] [arm] Thumb __builtin_setjmp not interworking safe

[drow at gcc dot gnu dot org]

------- Additional Comments From drow at gcc dot gnu dot org  2004-02-19 14:56 -------
Subject: Re:  [arm] Thumb __builtin_setjmp not interworking safe

Won't that leave bits of GNAT broken?  I think it uses __builtin_setjmp
explicitly.

Also, it has occured to me that my solution does not fix the whole
problem.  Normally, emit_indirect_jump is used within a function (for
instance, TRY_FINALLY_EXPR, or computed goto).  For those mov pc is
appropriate.  But for __builtin_setjmp it isn't.  keep_stack_depressed
even has the hideous:
          jump_insn = emit_jump_insn (gen_indirect_jump (retaddr));



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14202

Re: [Bug target/14202] [arm] Thumb __builtin_setjmp not interworking safe

[Richard Earnshaw]

> 
> Won't that leave bits of GNAT broken?  I think it uses __builtin_setjmp
> explicitly.
> 

Possibly, but probably no more broken than it already is if it uses that 
routine.  How can the compiler know to restore registers it doesn't even 
know about?  The EABI has been carefully constructed to ensure that it 
needed care; but builtin_setjmp breaks that assumption.

The ultimate solution will be to convert the ARM port to use the EABI 
exception unwinding model, then most of this should be irrelevant from 
that point of view.

R.

[Bug target/14202] [arm] Thumb __builtin_setjmp not interworking safe

[rearnsha at arm dot com]

------- Additional Comments From rearnsha at arm dot com  2004-02-19 15:30 -------
Subject: Re:  [arm] Thumb __builtin_setjmp not 
 interworking safe

> 
> Won't that leave bits of GNAT broken?  I think it uses __builtin_setjmp
> explicitly.
> 

Possibly, but probably no more broken than it already is if it uses that 
routine.  How can the compiler know to restore registers it doesn't even 
know about?  The EABI has been carefully constructed to ensure that it 
needed care; but builtin_setjmp breaks that assumption.

The ultimate solution will be to convert the ARM port to use the EABI 
exception unwinding model, then most of this should be irrelevant from 
that point of view.

R.




-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14202

[Bug target/14202] [arm] Thumb __builtin_setjmp not interworking safe

[drow at gcc dot gnu dot org]

------- Additional Comments From drow at gcc dot gnu dot org  2004-02-19 17:51 -------
There are probably other affected bits of code.  As an alternate approach, I tried
emitting a +1 after all thumb-mode code labels output using arm_assemble_integer;
this results in working exceptions and working computed goto, and it even manages
not to mess up dwarf2 debug info (but only because dwarf2 bypasses
assemble_integer).
My assumption is that all such labels are being used to move into the PC
(in which case bx needs the bit and mov will ignore it); things in need of code
addresses
appear to go elsewhere.

I didn't test profiling, which may be broken by this approach.  I'd be amazed if
nothing
was.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14202

[Bug target/14202] [arm] Thumb __builtin_setjmp not interworking safe

[giovannibajo at libero dot it]

------- Additional Comments From giovannibajo at libero dot it  2004-10-11 10:57 -------
Daniel, Richard, is still bug still actual? Can we move this to confirmed 
status if you agree on the bug? Thanks.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14202

[Bug target/14202] [arm] Thumb __builtin_setjmp not interworking safe

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-07-02 01:31 -------
Confirmed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-07-02 01:31:50
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14202

[Bug target/14202] [arm] Thumb __builtin_setjmp not interworking safe

[drow at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14202

Daniel Jacobowitz <drow at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #16 from Daniel Jacobowitz <drow at gcc dot gnu.org> 2012-09-24 16:11:40 UTC ---
Obsolete without arm-elf.

[Bug target/14202] [arm] Thumb __builtin_setjmp not interworking safe

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14202

--- Comment #15 from Andrew Pinski <pinskia at gcc dot gnu.org> 2012-09-23 22:00:18 UTC ---
Can this be closed now that arm-elf has been removed?

[Bug target/14202] [arm] Thumb __builtin_setjmp not interworking safe

[ramana at gcc dot gnu dot org]

------- Comment #14 from ramana at gcc dot gnu dot org  2009-10-26 11:37 -------
Unassigning self. No longer working on this.


-- 

ramana at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|ramana at gcc dot gnu dot   |unassigned at gcc dot gnu
                   |org                         |dot org
             Status|ASSIGNED                    |NEW


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14202

[Bug target/14202] [arm] Thumb __builtin_setjmp not interworking safe

[ramana at gcc dot gnu dot org]

------- Comment #13 from ramana at gcc dot gnu dot org  2009-04-17 11:07 -------
Created an attachment (id=17650)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17650&action=view)
Patch being tested

Here is a rather hackish patch that I'm testing. It looks correct so far with
the case of builtin_setjmp and builtin_longjmp and works correctly in cases
where you have setjmp and longjmp across ARM and Thumb ISA states.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14202

[Bug target/14202] [arm] Thumb __builtin_setjmp not interworking safe

[ramana at gcc dot gnu dot org]

------- Comment #12 from ramana at gcc dot gnu dot org  2009-04-09 11:31 -------

For the record here's some more info on the problem. 

One part of the problem is as described in comment #1 about labels having the
right bit and the correct instruction being generated which I've achieved by a
method inspired by Richard to mark setjmp receiver labels as STT_FUNC.

 The other part of the problem however is that the frame pointer registers for
ARM state and Thumb state are different. Hence if you did a setjmp from an ARM
state function and you did a longjmp from a Thumb state function, the problem
would also be restoring the "correct" frame pointer. 

I've tried to solve this problem by storing r7 and r11 at fixed locations in
the jmpbuf and restoring them unconditionally from the "correct location" in
the corresponding builtin_longjmp pattern. I am currently testing a patch for
this.

The other idea I had was to check for the lower bit of the label being restored
for Thumb"ness" and then load the appropriate frame pointer. Kludgy but that
might be the path of least risk to get this truly fixed. 




-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14202

[Bug target/14202] [arm] Thumb __builtin_setjmp not interworking safe

[ramana at gcc dot gnu dot org]

------- Comment #11 from ramana at gcc dot gnu dot org  2009-04-03 23:26 -------
Taking this up.


-- 

ramana at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |ramana at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2009-01-05 18:34:01         |2009-04-03 23:26:55
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14202

[Bug target/14202] [arm] Thumb __builtin_setjmp not interworking safe

[drow at gcc dot gnu dot org]

------- Comment #10 from drow at gcc dot gnu dot org  2009-01-05 18:34 -------
Right.  You would need an arm-elf (not arm-eabi) or arm-linux (not
arm-linux-gnueabi) toolchain to test this.  Those are slowly becoming
obsolete...


-- 

drow at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW
   Last reconfirmed|2005-07-02 01:31:50         |2009-01-05 18:34:01
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14202

[Bug target/14202] [arm] Thumb __builtin_setjmp not interworking safe

[rearnsha at gcc dot gnu dot org]

------- Comment #9 from rearnsha at gcc dot gnu dot org  2009-01-05 17:52 -------
(In reply to comment #8)
> Seems to work on 4.3.2-1 Debian gnueabi
>
You didn't compile your testcase with -mthumb.  Also, that system should be
using unwinding tables for exceptions, rather than builtin_setjmp and friends,
so it's probably not relevant.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14202

[Bug target/14202] [arm] Thumb __builtin_setjmp not interworking safe

[laurent at guerby dot net]

------- Comment #8 from laurent at guerby dot net  2009-01-02 12:25 -------
Seems to work on 4.3.2-1 Debian gnueabi

guerby@gcc50:~$ g++ pr14202.c 
guerby@gcc50:~$ ./a.out
guerby@gcc50:~$ echo $?
0

Do you confirm?

Ada exceptions are not working on this target (neither sjlj nor unwind) but
this is for another report.


-- 

laurent at guerby dot net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |laurent at guerby dot net
             Status|NEW                         |WAITING


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14202