[Bug java/14231] New: Incorrect interface method called when compiling against .class files

[Bug java/14231] New: Incorrect interface method called when compiling against .class files

[daney at gcc dot gnu dot org]

$ mipsel-linux-gcj --version
mipsel-linux-gcj (GCC) 3.4.0 20040214 (prerelease)

Configured as:

../gcccvsw/gcc/configure  --host=i686-pc-linux-gnu --target=mipsel-linux
--enable-languages=c,c++,java
--with-headers=/home/mipsel-linux/mipsel-linux/include --with-arch=mips32
--with-float=soft --prefix=/home/testcvs

With the attached test case method calls via an interface call the wrong method
when the code is compiled against class files generated bu Sun's javac program.

When the code is compiled against only source file the correct methods are called.

Here is the output of my test program:

bash-2.04# good
m8(String)
m6(int)

bash-2.04# bad
m7(int)
m5(void)

I suspect that the same problem exists on i686-linux target as well, but I don't
have that built and thus cannot test it.

-- 
           Summary: Incorrect interface method called when compiling against
                    .class files
           Product: gcc
           Version: 3.4.0
            Status: UNCONFIRMED
          Keywords: wrong-code
          Severity: critical
          Priority: P2
         Component: java
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: daney at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: i686-pc-linux
  GCC host triplet: i686-pc-linux
GCC target triplet: mipsel-linux


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14231

[Bug java/14231] Incorrect interface method called when compiling against .class files

[daney at gcc dot gnu dot org]

------- Additional Comments From daney at gcc dot gnu dot org  2004-02-21 02:19 -------
Created an attachment (id=5779)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=5779&action=view)
Test case

Build the testcase by running make in the bugtest directory.  You will need
Sun's javac in your PATH for the build to work.

The "good" program illustrated correct behavior.

The "bad" program as its name implies shows the buggy behavior.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14231

[Bug java/14231] [Regression]Incorrect interface method called when compiling against .class files

[daney at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|                            |3.4.0
      Known to work|                            |3.3.1
            Summary|Incorrect interface method  |[Regression]Incorrect
                   |called when compiling       |interface method called when
                   |against .class files        |compiling against .class
                   |                            |files


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14231

[Bug java/14231] [Regression]Incorrect interface method called when compiling against .class files

[daney at gcc dot gnu dot org]

------- Additional Comments From daney at gcc dot gnu dot org  2004-02-21 02:35 -------
I should probably add that if the class files are generated by gcj -C instead of
Sun's javac that the problem does not occur.  So it would appear to be a problem
with the parsing of class files.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14231

[Bug java/14231] [3.4/3.5 Regression]Incorrect interface method called when compiling against .class files

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-02-23 02:36 -------
Confirmed on both powerpc-apple-darwin and i686-pc-linux-gnu and it worked with 3.3.1 so this is a 
regression.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
  GCC build triplet|i686-pc-linux               |
   GCC host triplet|i686-pc-linux               |
 GCC target triplet|mipsel-linux                |
   Last reconfirmed|0000-00-00 00:00:00         |2004-02-23 02:36:14
               date|                            |
            Summary|[Regression]Incorrect       |[3.4/3.5
                   |interface method called when|Regression]Incorrect
                   |compiling against .class    |interface method called when
                   |files                       |compiling against .class
                   |                            |files
   Target Milestone|---                         |3.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14231

[Bug java/14231] [3.4/3.5 Regression]Incorrect interface method called when compiling against .class files

[aph at gcc dot gnu dot org]

------- Additional Comments From aph at gcc dot gnu dot org  2004-02-23 21:03 -------
From: Andrew Haley <aph@redhat.com>
To: David Daney <ddaney@avtrex.com>
Cc: java@gcc.gnu.org
Subject: Method call via interface calls wrong method...
Date: Mon, 23 Feb 2004 21:00:34 +0000

David Daney writes:
 > I found a bug with GCJ 3.4.0 configured for mipsel-linux and would like 
 > someone to try the same thing on x86-linux to see if it is target dependent.
 > 
 > The bug report is here:
 > 
 > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14231
 > 
 > I think the test case is self explanatory.

Thanks for an excellent test case.

Joy!  Another Miranda bug: we mark interfaces as abstract, but Sun
don't.  Every interface is implicitly abstract, however.

Try this.  Let me know if it fixes your problem.

Andrew.

2004-02-23  Andrew Haley  <aph@redhat.com>

	* class.c (layout_class_methods): Check for CLASS_INTERFACE as
	well as CLASS_ABSTRACT.

Index: class.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/java/class.c,v
retrieving revision 1.176
diff -p -2 -c -r1.176 class.c
*** class.c	15 Jan 2004 10:24:25 -0000	1.176
--- class.c	23 Feb 2004 20:55:22 -0000
*************** layout_class_methods (tree this_class)
*** 2054,2058 ****
  {
    tree method_decl, dtable_count;
!   tree super_class;
  
    if (TYPE_NVIRTUALS (this_class))
--- 2074,2078 ----
  {
    tree method_decl, dtable_count;
!   tree super_class, type_name;
  
    if (TYPE_NVIRTUALS (this_class))
*************** layout_class_methods (tree this_class)
*** 2071,2075 ****
      dtable_count = integer_zero_node;
  
!   if (CLASS_ABSTRACT (TYPE_NAME (this_class)))
      {
        /* An abstract class can have methods which are declared only in
--- 2091,2096 ----
      dtable_count = integer_zero_node;
  
!   type_name = TYPE_NAME (this_class);
!   if (CLASS_ABSTRACT (type_name) || CLASS_INTERFACE (type_name))
      {
        /* An abstract class can have methods which are declared only in


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |aph at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14231

[Bug java/14231] [3.4/3.5 Regression]Incorrect interface method called when compiling against .class files

[daney at gcc dot gnu dot org]

------- Additional Comments From daney at gcc dot gnu dot org  2004-02-25 00:35 -------
I sent private e-mail, but I thought I would put the same thing here...

Sorry, with the patch, I cannot build libgcj.

I get these errors:
.
.
.
make[1]: Leaving directory `/home/daney/mipsel-gcccvs/mipsel-linux/boehm-gc'
make[1]: Entering directory `/home/daney/mipsel-gcccvs/mipsel-linux/libjava'
/home/daney/mipsel-gcccvs/gcc/gcj
-B/home/daney/mipsel-gcccvs/mipsel-linux/libjava/
-B/home/daney/mipsel-gcccvs/gcc/ --encoding=UTF-8 -Wno-deprecated -C -g
-classpath '' -bootclasspath
/home/daney/mipsel-gcccvs/mipsel-linux/libjava:../../../gcccvsw/gcc/libjava -d
/home/daney/mipsel-gcccvs/mipsel-linux/libjava
../../../gcccvsw/gcc/libjava/java/lang/Class.java
../../../gcccvsw/gcc/libjava/java/io/ObjectInputStream.java:832: error: Invalid
checked exception class `java.io.IOException' in `throws' clause.  The exception
must be a subclass of an exception thrown by `java.io.ObjectInput.readBoolean()'
from class `java.io.ObjectInput'.
    public boolean readBoolean() throws IOException
                   ^
../../../gcccvsw/gcc/libjava/java/io/ObjectInputStream.java:846: error: Invalid
checked exception class `java.io.IOException' in `throws' clause.  The exception
must be a subclass of an exception thrown by `java.io.ObjectInput.readByte()'
from class `java.io.ObjectInput'.
    public byte readByte() throws IOException
                ^
../../../gcccvsw/gcc/libjava/java/io/ObjectInputStream.java:860: error: Invalid
checked exception class `java.io.IOException' in `throws' clause.  The exception
must be a subclass of an exception thrown by
`java.io.ObjectInput.readUnsignedByte()' from class `java.io.ObjectInput'.
    public int readUnsignedByte() throws IOException
               ^
../../../gcccvsw/gcc/libjava/java/io/ObjectInputStream.java:902: error: Invalid
checked exception class `java.io.IOException' in `throws' clause.  The exception
must be a subclass of an exception thrown by `java.io.ObjectInput.readChar()'
from class `java.io.ObjectInput'.
    public char readChar() throws IOException
                ^
../../../gcccvsw/gcc/libjava/java/io/ObjectInputStream.java:874: error: Invalid
checked exception class `java.io.IOException' in `throws' clause.  The exception
must be a subclass of an exception thrown by `java.io.ObjectInput.readShort()'
from class `java.io.ObjectInput'.
    public short readShort() throws IOException
                 ^
../../../gcccvsw/gcc/libjava/java/io/ObjectInputStream.java:888: error: Invalid
checked exception class `java.io.IOException' in `throws' clause.  The exception
must be a subclass of an exception thrown by
`java.io.ObjectInput.readUnsignedShort()' from class `java.io.ObjectInput'.
    public int readUnsignedShort() throws IOException
               ^
../../../gcccvsw/gcc/libjava/java/io/ObjectInputStream.java:916: error: Invalid
checked exception class `java.io.IOException' in `throws' clause.  The exception
must be a subclass of an exception thrown by `java.io.ObjectInput.readInt()'
from class `java.io.ObjectInput'.
    public int readInt() throws IOException
               ^
../../../gcccvsw/gcc/libjava/java/io/ObjectInputStream.java:930: error: Invalid
checked exception class `java.io.IOException' in `throws' clause.  The exception
must be a subclass of an exception thrown by `java.io.ObjectInput.readLong()'
from class `java.io.ObjectInput'.
    public long readLong() throws IOException
                ^
../../../gcccvsw/gcc/libjava/java/io/ObjectInputStream.java:944: error: Invalid
checked exception class `java.io.IOException' in `throws' clause.  The exception
must be a subclass of an exception thrown by `java.io.ObjectInput.readFloat()'
from class `java.io.ObjectInput'.
    public float readFloat() throws IOException
                 ^
../../../gcccvsw/gcc/libjava/java/io/ObjectInputStream.java:958: error: Invalid
checked exception class `java.io.IOException' in `throws' clause.  The exception
must be a subclass of an exception thrown by `java.io.ObjectInput.readDouble()'
from class `java.io.ObjectInput'.
    public double readDouble() throws IOException
                  ^
../../../gcccvsw/gcc/libjava/java/io/ObjectInputStream.java:992: error: Invalid
checked exception class `java.io.IOException' in `throws' clause.  The exception
must be a subclass of an exception thrown by `java.io.ObjectInput.readLine()'
from class `java.io.ObjectInput'.
    public String readLine() throws IOException
                  ^
../../../gcccvsw/gcc/libjava/java/io/ObjectInputStream.java:997: error: Invalid
checked exception class `java.io.IOException' in `throws' clause.  The exception
must be a subclass of an exception thrown by `java.io.ObjectInput.readUTF()'
from class `java.io.ObjectInput'.
    public String readUTF() throws IOException
.
.
.



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14231

[Bug java/14231] [3.4/3.5 Regression]Incorrect interface method called when compiling against .class files

[aph at redhat dot com]

------- Additional Comments From aph at redhat dot com  2004-02-25 19:33 -------
Subject:  [3.4/3.5 Regression]Incorrect interface method called when compiling against .class files

daney at gcc dot gnu dot org writes:
 > 
 > ------- Additional Comments From daney at gcc dot gnu dot org  2004-02-25 00:35 -------
 > I sent private e-mail, but I thought I would put the same thing here...
 > 
 > Sorry, with the patch, I cannot build libgcj.
 > 
 > I get these errors:

Oh dear.  Sorry.  

Try this one:

2004-02-23  Andrew Haley  <aph@redhat.com>

	* class.c (layout_class_methods): Check for CLASS_INTERFACE as
	well as CLASS_ABSTRACT.

Index: gcc/java/class.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/java/class.c,v
retrieving revision 1.176
diff -p -2 -c -r1.176 class.c
*** gcc/java/class.c	15 Jan 2004 10:24:25 -0000	1.176
--- gcc/java/class.c	25 Feb 2004 19:31:00 -0000
*************** layout_class_methods (tree this_class)
*** 2054,2058 ****
  {
    tree method_decl, dtable_count;
!   tree super_class;
  
    if (TYPE_NVIRTUALS (this_class))
--- 2054,2058 ----
  {
    tree method_decl, dtable_count;
!   tree super_class, type_name;
  
    if (TYPE_NVIRTUALS (this_class))
*************** layout_class_methods (tree this_class)
*** 2071,2075 ****
      dtable_count = integer_zero_node;
  
!   if (CLASS_ABSTRACT (TYPE_NAME (this_class)))
      {
        /* An abstract class can have methods which are declared only in
--- 2071,2076 ----
      dtable_count = integer_zero_node;
  
!   type_name = TYPE_NAME (this_class);
!   if (CLASS_ABSTRACT (type_name) || CLASS_INTERFACE (type_name))
      {
        /* An abstract class can have methods which are declared only in
Index: gcc/java/parse.y
===================================================================
RCS file: /cvs/gcc/gcc/gcc/java/parse.y,v
retrieving revision 1.464.4.1
diff -p -2 -c -r1.464.4.1 parse.y
*** gcc/java/parse.y	27 Jan 2004 17:27:39 -0000	1.464.4.1
--- gcc/java/parse.y	25 Feb 2004 19:31:04 -0000
*************** check_interface_throws_clauses (tree che
*** 6525,6529 ****
  		 clauses is fine in the absence of a concrete
  		 implementation.  */
! 	      if (method != NULL_TREE && !METHOD_ABSTRACT (method))
  		{
  		  tree method_wfl = DECL_FUNCTION_WFL (method);
--- 6525,6530 ----
  		 clauses is fine in the absence of a concrete
  		 implementation.  */
! 	      if (method != NULL_TREE && !METHOD_ABSTRACT (method)
! 		  && !METHOD_INVISIBLE (iface_method))
  		{
  		  tree method_wfl = DECL_FUNCTION_WFL (method);


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14231

[Bug java/14231] [3.4/3.5 Regression]Incorrect interface method called when compiling against .class files

[daney at gcc dot gnu dot org]

------- Additional Comments From daney at gcc dot gnu dot org  2004-02-25 22:20 -------
The new patch lets me build and gets me past the point of failure demonstrated
by the test case.  However I am now having similar problems in a different place.

I am trying to generate a test case, but have not been able to reproduce outside
of my main application which is 160,000 lines of code across 600 java files.

I will try to describe it in hopes that you can either fix it or help me figure
out what is happening.

I get a NoSuchMethodError when calling through an interface.  The interface in
question extends java.lang.Comparable and the class of the object extends an
abstract base class that contains the implementation of compareTo(Object).

I get the NoSuchMethodError calling compareTo(Object) on the interface.

I have the same type of build environment as before, java.lang.Comparable being
part of the runtime is compiled with gcj in the libgcj build.  My code is
compiled to class files with Sun's javac and then each java file is compiled
(from java source) with gcj using the class files generated by Sun's javac as
the classpath.

I have never tried to take Sun's javac out of the equation.  The same build has
no problems when using gcj 3.3.1

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14231

[Bug java/14231] [3.4/3.5 Regression]Incorrect interface method called when compiling against .class files

[aph at gcc dot gnu dot org]

------- Additional Comments From aph at gcc dot gnu dot org  2004-02-26 13:58 -------
Please create another bug for this other problem, and I can close this one.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |WAITING


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14231

[Bug java/14231] [3.4/3.5 Regression]Incorrect interface method called when compiling against .class files

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-02-26 15:34 -------
Subject: Bug 14231

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	aph@gcc.gnu.org	2004-02-26 15:34:07

Modified files:
	gcc/java       : ChangeLog class.c parse.y 

Log message:
	2004-02-26  Andrew Haley  <aph@redhat.com>
	
	PR java/14231:
	* parse.y (check_interface_throws_clauses): Check for
	!METHOD_INVISIBLE (iface_method).
	* class.c (layout_class_methods): Check for CLASS_INTERFACE as
	well as CLASS_ABSTRACT.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/ChangeLog.diff?cvsroot=gcc&r1=1.1333&r2=1.1334
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/class.c.diff?cvsroot=gcc&r1=1.177&r2=1.178
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/java/parse.y.diff?cvsroot=gcc&r1=1.470&r2=1.471



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14231

[Bug java/14231] [3.4/3.5 Regression]Incorrect interface method called when compiling against .class files

[mmitchel at gcc dot gnu dot org]

------- Additional Comments From mmitchel at gcc dot gnu dot org  2004-03-01 02:07 -------
Java problems are not showstoppers, so I have moved the target milestone to 3.4.1.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.4.0                       |3.4.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14231

[Bug java/14231] [3.4/3.5 Regression]Incorrect interface method called when compiling against .class files

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-03-01 02:10 -------
Actually this one bug has been fixed for 3.4.0 and was waiting for a new bug to be filed, so I am closing 
this as fixed for 3.4.0.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|3.4.1                       |3.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14231