public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "mfhaigh at acm dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug other/13873] gcc/longlong.h uses test for PPC
Date: Fri, 05 Mar 2004 05:28:00 -0000 [thread overview]
Message-ID: <20040305052833.16260.qmail@sources.redhat.com> (raw)
In-Reply-To: <20040127015913.13873.sean@mcneil.com>
------- Additional Comments From mfhaigh at acm dot org 2004-03-05 05:28 -------
(In reply to comment #13)
> Subject: Re: gcc/longlong.h uses test for PPC
>
> Sorry, I take that back. I see that TARGET_OS_CPP_BUILTINS defines
> __PPC. It looks like the author of longlong.h didn't realize that
> builtin_define_std prepends __ to the string and thought it would be PPC
> instead of __PPC. And for vxWorks, a check for __ppc should be added.
>
Upon closer inspection, builtin_define_std will actually surround the macro with
leading and following __'s, if the macro is in the user namespace:
/* If it was in user's namespace... */
if (p != buff + 2)
{
/* Define the macro with leading and following __. */
The attached patch is against the 3.4 branch, and cleans up a couple of
testcases as well. It does what you suggested-- use __ppc for vxWorks, and
change PPC to __PPC__.
Mark F. Haigh
2004-03-04 Mark F. Haigh <mfhaigh@acm.org>
* longlong.h: PPC macro cleanup (fixes vxWorks targets)
* gcc/testsuite/gcc.dg/20020103-1.c: PPC macro usage changed to __PPC__
* gcc/testsuite/gcc.dg/20020919-1.c: Same as 20020103-1.c
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13873
next prev parent reply other threads:[~2004-03-05 5:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-27 1:59 [Bug c/13873] New: " sean at mcneil dot com
2004-01-27 5:53 ` [Bug other/13873] " pinskia at gcc dot gnu dot org
2004-01-27 14:11 ` sean at mcneil dot com
2004-01-27 22:20 ` rsandifo at gcc dot gnu dot org
2004-01-27 22:29 ` sean at mcneil dot com
2004-02-09 23:58 ` user42 at zip dot com dot au
2004-02-10 0:05 ` sean at mcneil dot com
2004-02-10 0:13 ` user42 at zip dot com dot au
2004-02-10 4:20 ` sean at mcneil dot com
2004-03-05 0:04 ` pinskia at gcc dot gnu dot org
2004-03-05 4:45 ` sean at mcneil dot com
2004-03-05 5:28 ` mfhaigh at acm dot org [this message]
[not found] <bug-13873-2430@http.gcc.gnu.org/bugzilla/>
2005-12-02 12:42 ` amodra at bigpond dot net dot au
2005-12-06 9:55 ` amodra at gcc dot gnu dot org
2005-12-06 10:03 ` amodra at gcc dot gnu dot org
2005-12-06 10:04 ` amodra at gcc dot gnu dot org
2005-12-06 10:05 ` amodra at gcc dot gnu dot org
2005-12-06 10:06 ` amodra at bigpond dot net dot au
2005-12-06 10:07 ` amodra at bigpond dot net dot au
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040305052833.16260.qmail@sources.redhat.com \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).