[Bug bootstrap/14465] New: [3.4 Regression] insn-output.c:790: error: `asm_out_file' undeclared

[Bug bootstrap/14465] New: [3.4 Regression] insn-output.c:790: error: `asm_out_file' undeclared

[danglin at gcc dot gnu dot org]

The following error occurs in stage2:

stage1/xgcc -Bstage1/ -B/opt/gnu/gcc/gcc-3.4.0/hppa2.0w-hp-hpux11.00/bin/   -g -
O2 -DIN_GCC   -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes
-pedantic -Wno-long-long -Wold-style-definition     -DHAVE_CONFIG_H    -I. -I. -
I../../gcc/gcc -I../../gcc/gcc/. -I../../gcc/gcc/../include  -c insn-output.c \
  -o insn-output.o
insn-output.c: In function `output_188':
insn-output.c:790: error: `asm_out_file' undeclared (first use in this function)
insn-output.c:790: error: (Each undeclared identifier is reported only once
insn-output.c:790: error: for each function it appears in.)
insn-output.c: In function `output_189':
insn-output.c:801: error: `asm_out_file' undeclared (first use in this function)

Looking at the preproccessed source for insn-output.c, I see the following:

# 385 "../../gcc/gcc/output.h"
extern FILE *asm_out_file;
...
static const char *
output_44 (rtx *operands __attribute__ ((__unused__)), rtx insn __attribute__ ((
__unused__)))
{

{
  rtx xoperands[3];
  extern FILE *asm_out_file;
...
static const char *
output_45 (rtx *operands __attribute__ ((__unused__)), rtx insn __attribute__ ((
__unused__)))
{

{
  rtx xoperands[3];
  extern FILE *asm_out_file;
...
static const char *
output_188 (rtx *operands __attribute__ ((__unused__)), rtx insn __attribute__ (
(__unused__)))
{

{
  output_asm_insn ("bl .+8,%0\n\tdepi 0,31,2,%0", operands);
  (*targetm.asm_out.internal_label) (asm_out_file, "L",
                                     (((operands[1])->u.fld[6]).rtint));
  return "";
}
}
...

If I remove the declations of asm_out_file from output_44 and output_45,
the file compiles.  These declarations appear to be reminants from an
earlier time when output.h was not included.

It seems a declaration in an inner scope now causes an earlier declaration
at file scope to be forgotten.

-- 
           Summary: [3.4 Regression] insn-output.c:790: error:
                    `asm_out_file' undeclared
           Product: gcc
           Version: 3.4.0
            Status: UNCONFIRMED
          Severity: critical
          Priority: P2
         Component: bootstrap
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: danglin at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: hppa2.0w-hp-hpux11.00
  GCC host triplet: hppa2.0w-hp-hpux11.00
GCC target triplet: hppa2.0w-hp-hpux11.00


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14465

[Bug c/14465] [3.4 Regression] insn-output.c:790: error: `asm_out_file' undeclared

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|bootstrap                   |c
           Keywords|                            |build, rejects-valid
   Target Milestone|---                         |3.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14465

[Bug c/14465] [3.4 Regression] insn-output.c:790: error: `asm_out_file' undeclared

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-03-06 23:46 -------
I almost think this is caused by:
2004-03-06  Eric Botcazou  <ebotcazou@libertysurf.fr>

        PR c/14114
        * c-decl (pushdecl): Do not record a previous, not-in-scope,
        external decl for restoration.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ebotcazou at libertysurf dot
                   |                            |fr


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14465

[Bug c/14465] [3.4 Regression] insn-output.c:790: error: `asm_out_file' undeclared

[dave at hiauly1 dot hia dot nrc dot ca]

------- Additional Comments From dave at hiauly1 dot hia dot nrc dot ca  2004-03-07 00:00 -------
Subject: Re:  [3.4 Regression] insn-output.c:790: error: `asm_out_file' undeclared

> I almost think this is caused by:
> 2004-03-06  Eric Botcazou  <ebotcazou@libertysurf.fr>
> 
>         PR c/14114
>         * c-decl (pushdecl): Do not record a previous, not-in-scope,
>         external decl for restoration.

The following change might also be the possible cause:

2004-03-03  Zack Weinberg  <zack@codesourcery.com>

	PR 13728
	* c-decl.c (diagnose_mismatched_decls): Issue an error for two
	parameters with the same name, unless one is a forward decl.
	Do not issue a redundant-redeclaration warning for forward
	decls of parameters.

Dave


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14465

[Bug c/14465] [3.4 Regression] insn-output.c:790: error: `asm_out_file' undeclared

[ebotcazou at gcc dot gnu dot org]

------- Additional Comments From ebotcazou at gcc dot gnu dot org  2004-03-07 00:01 -------
Yep, I think so too :-)

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |ebotcazou at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14465

[Bug c/14465] [3.4 Regression] insn-output.c:790: error: `asm_out_file' undeclared

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-03-07 00:33 -------
Subject: Bug 14465

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	ebotcazou@gcc.gnu.org	2004-03-07 00:33:46

Modified files:
	gcc/testsuite  : ChangeLog 
Added files:
	gcc/testsuite/gcc.dg: decl-6.c 

Log message:
	PR c/14465
	* gcc.dg/decl-6.c: New test.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.3575&r2=1.3576
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/decl-6.c.diff?cvsroot=gcc&r1=NONE&r2=1.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14465

[Bug c/14465] [3.4 Regression] insn-output.c:790: error: `asm_out_file' undeclared

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-03-07 00:39 -------
Subject: Bug 14465

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_4-branch
Changes by:	ebotcazou@gcc.gnu.org	2004-03-07 00:39:03

Modified files:
	gcc            : ChangeLog c-decl.c 
	gcc/testsuite  : ChangeLog 
Added files:
	gcc/testsuite/gcc.dg: decl-6.c 

Log message:
	PR c/14465
	PR c/14114
	* c-decl (pushdecl): Revert previous change.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=2.2326.2.297&r2=2.2326.2.298
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-decl.c.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.470.4.7&r2=1.470.4.8
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.3389.2.125&r2=1.3389.2.126
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/decl-6.c.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=NONE&r2=1.1.2.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14465

[Bug c/14465] [3.4 Regression] insn-output.c:790: error: `asm_out_file' undeclared

[ebotcazou at gcc dot gnu dot org]

------- Additional Comments From ebotcazou at gcc dot gnu dot org  2004-03-07 00:41 -------
Not far from the most broken patch of the year. *sigh*

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|ebotcazou at libertysurf dot|
                   |fr                          |
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14465