public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "bruno at clisp dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug optimization/6585] Redundant store/load instruction pairs on ix86
Date: Wed, 17 Mar 2004 12:10:00 -0000	[thread overview]
Message-ID: <20040317121030.26166.qmail@sources.redhat.com> (raw)
In-Reply-To: <20020506130600.6585.bruno@clisp.org>


------- Additional Comments From bruno at clisp dot org  2004-03-17 12:10 -------
This result is much better, indeed. Still there is room for two more optimizations: 
 
1) The final "movl %ebx, %edx" instruction could be removed if the preceding lea 
instruction would write its results into %edx, not into %ebx. 
 
2) Storing a0 and a1 in temporary stack locations is useless since a0 and a1 
already come from the stack, and data analysis could find out that they are 
read-only. 
 
Commented listing: 
 
mul: 
	subl	$20, %esp 
	movl	%esi, 12(%esp)				; save %esi 
	movl	24(%esp), %eax		a0 
	movl	32(%esp), %esi		b0 
	movl	28(%esp), %ecx		a1 
	movl	%edi, 16(%esp)				; save %edi 
	movl	36(%esp), %edi		b1 
	movl	%eax, (%esp)				USELESS! Use 24(%esp) instead 
	mull	%esi			%edx:%eax := a0*b0 
	movl	%ecx, 4(%esp)				USELESS! Use 28(%esp) instead 
	movl	%ebx, 8(%esp)				; save %ebx 
	movl	%eax, %ecx 
	movl	(%esp), %eax 
	imull	%eax, %edi		a0*b1 
	movl	4(%esp), %eax 
	imull	%esi, %eax		a1*b0 
	movl	12(%esp), %esi				; restore %esi 
	leal	(%edx,%edi), %edi	hi+a0*b1 
	leal	(%edi,%eax), %ebx	hi+a0*b1+a1*b0	COULD BE SIMPLIFIED 
	movl	16(%esp), %edi				; restore %edi 
	movl	%ecx, %eax		lo 
	movl	%ebx, %edx				USELESS! 
	movl	8(%esp), %ebx				; restore %ebx 
	addl	$20, %esp 
	ret 
 

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=6585


  parent reply	other threads:[~2004-03-17 12:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20020506130600.6585.bruno@clisp.org>
2003-07-04 11:09 ` [Bug optimization/6585] useless memory store instructions on x86 steven at gcc dot gnu dot org
2003-07-10 20:09 ` [Bug optimization/6585] Reduntant store/load instruction pairs on ix86 steven at gcc dot gnu dot org
2003-08-23  1:38 ` [Bug optimization/6585] Redundant " dhazeghi at yahoo dot com
2003-11-25  7:51 ` pinskia at gcc dot gnu dot org
2004-03-17  8:03 ` kazu at cs dot umass dot edu
2004-03-17 12:10 ` bruno at clisp dot org [this message]
2004-10-11  2:57 ` [Bug rtl-optimization/6585] " pinskia at gcc dot gnu dot org
2004-10-11 11:55 ` bruno at clisp dot org
2005-06-26 13:35 ` steven at gcc dot gnu dot org
2005-06-27 11:50 ` bruno at clisp dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040317121030.26166.qmail@sources.redhat.com \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).