public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libstdc++/14220] New: num_put::do_put() undesired float/double behavior
@ 2004-02-20 1:38 sadfate at yahoo dot com
2004-02-20 12:11 ` [Bug libstdc++/14220] " pcarlini at suse dot de
` (12 more replies)
0 siblings, 13 replies; 14+ messages in thread
From: sadfate at yahoo dot com @ 2004-02-20 1:38 UTC (permalink / raw)
To: gcc-bugs
When a float or double is streamed to output in fixed-point format, rounding up
occurs well before the precision specified by the stream.
5.55555555e-17, when streamed to a stream with the scientific flag set and a
precision of 25 will print 5.55555555[#'s-up-to-20]e-17. When streamed with the
fixed flag set, it will print out 0.0000000000000000560000000. If the number is
especially small (e-20+), it will print out as all zeroes.
I looked at the code in 3.2.3 and 3.4 versions of g++, and saw that it was
because the max_digits is being set from the numeric_limits<double>::digits10
field. The precision is then set to be less than or equal to the max_digits.
So on my platform, where digits10 is 16 (+2), the precision will get set to 18,
max. That works fine for scientific values, but I would argue that if I ask a
stream for 25 places of precision, and put a float/double into it that should be
represented by 0.0000000000000000555555555, that I would see that value, not a
rounded version.
My understanding is that the numeric_limits<double>::digits10 value for a
float/double amounts to the significant digits if it were in scientific
notation. If that is the case, then the max_digits for fixed number would be
digits10 + the number of preceding zeroes, which is probably max_exponent10.
This was seen on Solaris 8 and Irix 6.5.22.
--
Summary: num_put::do_put() undesired float/double behavior
Product: gcc
Version: 3.2.3
Status: UNCONFIRMED
Severity: minor
Priority: P3
Component: libstdc++
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: sadfate at yahoo dot com
CC: gcc-bugs at gcc dot gnu dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14220
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug libstdc++/14220] num_put::do_put() undesired float/double behavior
2004-02-20 1:38 [Bug libstdc++/14220] New: num_put::do_put() undesired float/double behavior sadfate at yahoo dot com
@ 2004-02-20 12:11 ` pcarlini at suse dot de
2004-02-20 17:08 ` pcarlini at suse dot de
` (11 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: pcarlini at suse dot de @ 2004-02-20 12:11 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pcarlini at suse dot de 2004-02-20 12:11 -------
Confirmed. Actually, basing on the standard (22.2.2.2.2, p8-11-13), I think that
simply the precision passed down to the printing code must not be clipped at all.
--
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|unassigned at gcc dot gnu |pcarlini at suse dot de
|dot org |
Status|UNCONFIRMED |ASSIGNED
Ever Confirmed| |1
Last reconfirmed|0000-00-00 00:00:00 |2004-02-20 12:11:22
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14220
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug libstdc++/14220] num_put::do_put() undesired float/double behavior
2004-02-20 1:38 [Bug libstdc++/14220] New: num_put::do_put() undesired float/double behavior sadfate at yahoo dot com
2004-02-20 12:11 ` [Bug libstdc++/14220] " pcarlini at suse dot de
@ 2004-02-20 17:08 ` pcarlini at suse dot de
2004-02-22 15:00 ` cvs-commit at gcc dot gnu dot org
` (10 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: pcarlini at suse dot de @ 2004-02-20 17:08 UTC (permalink / raw)
To: gcc-bugs
--
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |3.4.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14220
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug libstdc++/14220] num_put::do_put() undesired float/double behavior
2004-02-20 1:38 [Bug libstdc++/14220] New: num_put::do_put() undesired float/double behavior sadfate at yahoo dot com
2004-02-20 12:11 ` [Bug libstdc++/14220] " pcarlini at suse dot de
2004-02-20 17:08 ` pcarlini at suse dot de
@ 2004-02-22 15:00 ` cvs-commit at gcc dot gnu dot org
2004-02-22 15:33 ` cvs-commit at gcc dot gnu dot org
` (9 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2004-02-22 15:00 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2004-02-22 15:00 -------
Subject: Bug 14220
CVSROOT: /cvs/gcc
Module name: gcc
Branch: hammer-3_3-branch
Changes by: aj@gcc.gnu.org 2004-02-22 15:00:40
Modified files:
libstdc++-v3/include/bits: locale_facets.tcc
libstdc++-v3 : ChangeLog.hammer
Log message:
2004-02-22 Paolo Carlini <pcarlini@suse.de>
PR libstdc++/14220
* include/bits/locale_facets.tcc (num_put<>::_M_convert_float):
Don't clip the precision passed down to __convert_from_v:
22.2.2.2.2 nowhere says so.
2004-02-22 Paolo Carlini <pcarlini@suse.de>
* include/bits/locale_facets.tcc (_M_extract_float,
_M_extract_int): Remove a wrong comment and simplify
the corresponding code using char_traits::find().
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/bits/locale_facets.tcc.diff?cvsroot=gcc&only_with_tag=hammer-3_3-branch&r1=1.82.2.11&r2=1.82.2.12
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/ChangeLog.hammer.diff?cvsroot=gcc&only_with_tag=hammer-3_3-branch&r1=1.1.2.3&r2=1.1.2.4
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14220
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug libstdc++/14220] num_put::do_put() undesired float/double behavior
2004-02-20 1:38 [Bug libstdc++/14220] New: num_put::do_put() undesired float/double behavior sadfate at yahoo dot com
` (2 preceding siblings ...)
2004-02-22 15:00 ` cvs-commit at gcc dot gnu dot org
@ 2004-02-22 15:33 ` cvs-commit at gcc dot gnu dot org
2004-02-22 17:57 ` cvs-commit at gcc dot gnu dot org
` (8 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2004-02-22 15:33 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2004-02-22 15:33 -------
Subject: Bug 14220
CVSROOT: /cvs/gcc
Module name: gcc
Branch: hammer-3_3-branch
Changes by: aj@gcc.gnu.org 2004-02-22 15:33:00
Modified files:
libstdc++-v3/include/bits: locale_facets.tcc
libstdc++-v3 : ChangeLog.hammer
Log message:
2004-02-22 Paolo Carlini <pcarlini@suse.de>
PR libstdc++/14220
* include/bits/locale_facets.tcc (num_put<>::_M_convert_float):
Fix previous commit: in case of non-fixed outputs __max_digits
is still needed in order to upper bound the size of the buffer.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/bits/locale_facets.tcc.diff?cvsroot=gcc&only_with_tag=hammer-3_3-branch&r1=1.82.2.12&r2=1.82.2.13
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/ChangeLog.hammer.diff?cvsroot=gcc&only_with_tag=hammer-3_3-branch&r1=1.1.2.4&r2=1.1.2.5
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14220
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug libstdc++/14220] num_put::do_put() undesired float/double behavior
2004-02-20 1:38 [Bug libstdc++/14220] New: num_put::do_put() undesired float/double behavior sadfate at yahoo dot com
` (3 preceding siblings ...)
2004-02-22 15:33 ` cvs-commit at gcc dot gnu dot org
@ 2004-02-22 17:57 ` cvs-commit at gcc dot gnu dot org
2004-03-24 8:53 ` pcarlini at suse dot de
` (7 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2004-02-22 17:57 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2004-02-22 17:57 -------
Subject: Bug 14220
CVSROOT: /cvs/gcc
Module name: gcc
Branch: gcc-3_3-branch
Changes by: paolo@gcc.gnu.org 2004-02-22 17:57:21
Modified files:
libstdc++-v3 : ChangeLog
libstdc++-v3/include/bits: locale_facets.tcc
Log message:
2004-02-22 Paolo Carlini <pcarlini@suse.de>
PR libstdc++/14220
* include/bits/locale_facets.tcc (num_put<>::_M_convert_float):
Don't clip the precision passed down to __convert_from_v:
22.2.2.2.2 nowhere says so.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.1464.2.181&r2=1.1464.2.182
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/bits/locale_facets.tcc.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.82.4.18&r2=1.82.4.19
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14220
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug libstdc++/14220] num_put::do_put() undesired float/double behavior
2004-02-20 1:38 [Bug libstdc++/14220] New: num_put::do_put() undesired float/double behavior sadfate at yahoo dot com
` (4 preceding siblings ...)
2004-02-22 17:57 ` cvs-commit at gcc dot gnu dot org
@ 2004-03-24 8:53 ` pcarlini at suse dot de
2004-04-15 20:14 ` pcarlini at suse dot de
` (6 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: pcarlini at suse dot de @ 2004-03-24 8:53 UTC (permalink / raw)
To: gcc-bugs
--
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|3.4.0 |3.4.1
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14220
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug libstdc++/14220] num_put::do_put() undesired float/double behavior
2004-02-20 1:38 [Bug libstdc++/14220] New: num_put::do_put() undesired float/double behavior sadfate at yahoo dot com
` (5 preceding siblings ...)
2004-03-24 8:53 ` pcarlini at suse dot de
@ 2004-04-15 20:14 ` pcarlini at suse dot de
2004-04-30 18:24 ` cvs-commit at gcc dot gnu dot org
` (5 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: pcarlini at suse dot de @ 2004-04-15 20:14 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pcarlini at suse dot de 2004-04-15 19:39 -------
*** Bug 14969 has been marked as a duplicate of this bug. ***
--
What |Removed |Added
----------------------------------------------------------------------------
CC| |austern at apple dot com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14220
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug libstdc++/14220] num_put::do_put() undesired float/double behavior
2004-02-20 1:38 [Bug libstdc++/14220] New: num_put::do_put() undesired float/double behavior sadfate at yahoo dot com
` (6 preceding siblings ...)
2004-04-15 20:14 ` pcarlini at suse dot de
@ 2004-04-30 18:24 ` cvs-commit at gcc dot gnu dot org
2004-06-12 22:57 ` [Bug libstdc++/14220] [3.5 only] " mmitchel at gcc dot gnu dot org
` (4 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2004-04-30 18:24 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2004-04-30 17:46 -------
Subject: Bug 14220
CVSROOT: /cvs/gcc
Module name: gcc
Branch: gcc-3_4-branch
Changes by: paolo@gcc.gnu.org 2004-04-30 17:46:52
Modified files:
libstdc++-v3 : ChangeLog
libstdc++-v3/include/bits: locale_facets.tcc
Added files:
libstdc++-v3/testsuite/22_locale/num_put/put/char: 14220.cc
libstdc++-v3/testsuite/22_locale/num_put/put/wchar_t: 14220.cc
Log message:
2004-04-30 Paolo Carlini <pcarlini@suse.de>
PR libstdc++/14220
* include/bits/locale_facets.tcc (num_put<>::_M_insert_float):
Don't clip the precision passed down to __convert_from_v:
22.2.2.2.2 nowhere says so.
* testsuite/22_locale/num_put/put/char/14220.cc: New.
* testsuite/22_locale/num_put/put/wchar_t/14220.c: Likewise.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.2224.2.93&r2=1.2224.2.94
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/bits/locale_facets.tcc.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.166.2.10&r2=1.166.2.11
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/22_locale/num_put/put/char/14220.cc.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=NONE&r2=1.1.2.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/22_locale/num_put/put/wchar_t/14220.cc.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=NONE&r2=1.1.2.1
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14220
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug libstdc++/14220] [3.5 only] num_put::do_put() undesired float/double behavior
2004-02-20 1:38 [Bug libstdc++/14220] New: num_put::do_put() undesired float/double behavior sadfate at yahoo dot com
` (7 preceding siblings ...)
2004-04-30 18:24 ` cvs-commit at gcc dot gnu dot org
@ 2004-06-12 22:57 ` mmitchel at gcc dot gnu dot org
2004-06-13 8:34 ` [Bug libstdc++/14220] [3.5] " pcarlini at suse dot de
` (3 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: mmitchel at gcc dot gnu dot org @ 2004-06-12 22:57 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From mmitchel at gcc dot gnu dot org 2004-06-12 22:57 -------
Marked as 3.5 only, so retargeting at 3.5.0.
--
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|3.4.1 |3.5.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14220
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug libstdc++/14220] [3.5] num_put::do_put() undesired float/double behavior
2004-02-20 1:38 [Bug libstdc++/14220] New: num_put::do_put() undesired float/double behavior sadfate at yahoo dot com
` (8 preceding siblings ...)
2004-06-12 22:57 ` [Bug libstdc++/14220] [3.5 only] " mmitchel at gcc dot gnu dot org
@ 2004-06-13 8:34 ` pcarlini at suse dot de
2004-06-18 23:55 ` mmitchel at gcc dot gnu dot org
` (2 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: pcarlini at suse dot de @ 2004-06-13 8:34 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pcarlini at suse dot de 2004-06-13 08:34 -------
Actually, this is already fixed for 3.4.1. I want to put the fix on hold for 3.5
only because with Benjamin we have a plan to branch a separate 7.0 branch where a
pending invasive patch will interfere with this fix...
--
What |Removed |Added
----------------------------------------------------------------------------
Summary|[3.5 only] num_put::do_put()|[3.5] num_put::do_put()
|undesired float/double |undesired float/double
|behavior |behavior
Target Milestone|3.5.0 |3.4.1
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14220
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug libstdc++/14220] [3.5] num_put::do_put() undesired float/double behavior
2004-02-20 1:38 [Bug libstdc++/14220] New: num_put::do_put() undesired float/double behavior sadfate at yahoo dot com
` (9 preceding siblings ...)
2004-06-13 8:34 ` [Bug libstdc++/14220] [3.5] " pcarlini at suse dot de
@ 2004-06-18 23:55 ` mmitchel at gcc dot gnu dot org
2004-07-29 22:11 ` cvs-commit at gcc dot gnu dot org
2004-07-29 22:14 ` pcarlini at suse dot de
12 siblings, 0 replies; 14+ messages in thread
From: mmitchel at gcc dot gnu dot org @ 2004-06-18 23:55 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From mmitchel at gcc dot gnu dot org 2004-06-18 23:55 -------
Really retargeting at 3.5.0 this time.
--
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|3.4.1 |3.5.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14220
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug libstdc++/14220] [3.5] num_put::do_put() undesired float/double behavior
2004-02-20 1:38 [Bug libstdc++/14220] New: num_put::do_put() undesired float/double behavior sadfate at yahoo dot com
` (10 preceding siblings ...)
2004-06-18 23:55 ` mmitchel at gcc dot gnu dot org
@ 2004-07-29 22:11 ` cvs-commit at gcc dot gnu dot org
2004-07-29 22:14 ` pcarlini at suse dot de
12 siblings, 0 replies; 14+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2004-07-29 22:11 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2004-07-29 22:11 -------
Subject: Bug 14220
CVSROOT: /cvs/gcc
Module name: gcc
Changes by: paolo@gcc.gnu.org 2004-07-29 22:11:05
Modified files:
libstdc++-v3 : ChangeLog
libstdc++-v3/include/bits: locale_facets.tcc
Added files:
libstdc++-v3/testsuite/22_locale/num_put/put/char: 14220.cc
libstdc++-v3/testsuite/22_locale/num_put/put/wchar_t: 14220.cc
Log message:
2004-07-29 Paolo Carlini <pcarlini@suse.de>
PR libstdc++/14220
* include/bits/locale_facets.tcc (num_put<>::_M_insert_float):
Don't clip the precision passed down to __convert_from_v:
22.2.2.2.2 nowhere says so.
* testsuite/22_locale/num_put/put/char/14220.cc: New.
* testsuite/22_locale/num_put/put/wchar_t/14220.c: Likewise.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/ChangeLog.diff?cvsroot=gcc&r1=1.2592&r2=1.2593
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/bits/locale_facets.tcc.diff?cvsroot=gcc&r1=1.196&r2=1.197
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/22_locale/num_put/put/char/14220.cc.diff?cvsroot=gcc&r1=1.1&r2=1.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/22_locale/num_put/put/wchar_t/14220.cc.diff?cvsroot=gcc&r1=1.1&r2=1.2
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14220
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug libstdc++/14220] [3.5] num_put::do_put() undesired float/double behavior
2004-02-20 1:38 [Bug libstdc++/14220] New: num_put::do_put() undesired float/double behavior sadfate at yahoo dot com
` (11 preceding siblings ...)
2004-07-29 22:11 ` cvs-commit at gcc dot gnu dot org
@ 2004-07-29 22:14 ` pcarlini at suse dot de
12 siblings, 0 replies; 14+ messages in thread
From: pcarlini at suse dot de @ 2004-07-29 22:14 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pcarlini at suse dot de 2004-07-29 22:14 -------
Fixed everywhere.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14220
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2004-07-29 22:14 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-02-20 1:38 [Bug libstdc++/14220] New: num_put::do_put() undesired float/double behavior sadfate at yahoo dot com
2004-02-20 12:11 ` [Bug libstdc++/14220] " pcarlini at suse dot de
2004-02-20 17:08 ` pcarlini at suse dot de
2004-02-22 15:00 ` cvs-commit at gcc dot gnu dot org
2004-02-22 15:33 ` cvs-commit at gcc dot gnu dot org
2004-02-22 17:57 ` cvs-commit at gcc dot gnu dot org
2004-03-24 8:53 ` pcarlini at suse dot de
2004-04-15 20:14 ` pcarlini at suse dot de
2004-04-30 18:24 ` cvs-commit at gcc dot gnu dot org
2004-06-12 22:57 ` [Bug libstdc++/14220] [3.5 only] " mmitchel at gcc dot gnu dot org
2004-06-13 8:34 ` [Bug libstdc++/14220] [3.5] " pcarlini at suse dot de
2004-06-18 23:55 ` mmitchel at gcc dot gnu dot org
2004-07-29 22:11 ` cvs-commit at gcc dot gnu dot org
2004-07-29 22:14 ` pcarlini at suse dot de
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).