public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "dave at hiauly1 dot hia dot nrc dot ca" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/14671] [3.3/3.4 regression] caller-save.c:491: internal compiler error: Segmentation fault
Date: Wed, 07 Apr 2004 04:24:00 -0000	[thread overview]
Message-ID: <20040407042429.11499.qmail@sources.redhat.com> (raw)
In-Reply-To: <20040321182857.14671.danglin@gcc.gnu.org>


------- Additional Comments From dave at hiauly1 dot hia dot nrc dot ca  2004-04-07 04:24 -------
Subject: Re:  [3.3/3.4 regression] caller-save.c:491: int

> ------- Additional Comments From mmitchel at gcc dot gnu dot org  2004-04-04
> 23:05 -------
> Dave, can you confirm whether or not this PR is fixed?

I studied this problem further today.  The in_use flag for the node
that causes the segfault is being cleared by clear_marks.  clear_marks
is called from ggc_collect.  ggc_collect is called from loop_optimize.

It would appear that there are a few ggc objects created after the last
context push (possibly in init_alias_once).  These get garbage collected
and cause the segfault.

I believe that the enclosed patch will fix the problem.  The problem
affects 3.3 onward.

The patch is not fully tested.  I'm still struggling with bootstrap/14829.
CVS access for me has been terrible the last couple of days.

Dave
-- 
J. David Anglin                                  dave.anglin@nrc-cnrc.gc.ca
National Research Council of Canada              (613) 990-0752 (FAX: 952-6602)

2004-04-07  John David Anglin  <dave.anglin@nrc-cnrc.gc.ca>

	PR bootstrap/14671
	* loop.c (loop_optimize): Push and pop ggc context.

Index: loop.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/loop.c,v
retrieving revision 1.497
diff -u -3 -p -r1.497 loop.c
--- loop.c	18 Mar 2004 16:42:31 -0000	1.497
+++ loop.c	6 Apr 2004 23:27:05 -0000
@@ -498,6 +498,7 @@ loop_optimize (rtx f, FILE *dumpfile, in
      We could have added a call to reg_scan after gcse_main in toplev.c,
      but moving this call to init_alias_analysis is more efficient.  */
   init_alias_analysis ();
+  ggc_push_context ();
 
   /* See if we went too far.  Note that get_max_uid already returns
      one more that the maximum uid of all insn.  */
@@ -543,6 +544,7 @@ loop_optimize (rtx f, FILE *dumpfile, in
 	}
     }
 
+  ggc_pop_context ();
   end_alias_analysis ();
 
   /* Clean up.  */


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14671


  parent reply	other threads:[~2004-04-07  4:24 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-21 18:29 [Bug bootstrap/14671] New: [3.5 " danglin at gcc dot gnu dot org
2004-03-21 18:33 ` [Bug bootstrap/14671] " pinskia at gcc dot gnu dot org
2004-03-23  3:32 ` danglin at gcc dot gnu dot org
2004-03-23  3:40 ` pinskia at gcc dot gnu dot org
2004-03-23  4:20 ` danglin at gcc dot gnu dot org
2004-04-04  7:12 ` danglin at gcc dot gnu dot org
2004-04-04  7:23 ` pinskia at gcc dot gnu dot org
2004-04-04  7:54 ` dave at hiauly1 dot hia dot nrc dot ca
2004-04-04  8:08 ` dave at hiauly1 dot hia dot nrc dot ca
2004-04-04 16:06 ` [Bug bootstrap/14671] [3.3/3.4 " pinskia at gcc dot gnu dot org
2004-04-04 16:42 ` dave at hiauly1 dot hia dot nrc dot ca
2004-04-04 23:05 ` mmitchel at gcc dot gnu dot org
2004-04-04 23:31 ` dave at hiauly1 dot hia dot nrc dot ca
2004-04-07  4:24 ` dave at hiauly1 dot hia dot nrc dot ca [this message]
2004-04-21 20:04 ` cvs-commit at gcc dot gnu dot org
2004-04-21 20:31 ` danglin at gcc dot gnu dot org
2004-04-24 22:34 ` cvs-commit at gcc dot gnu dot org
2004-05-26 10:47 ` ebotcazou at gcc dot gnu dot org
2004-05-26 13:19 ` dave at hiauly1 dot hia dot nrc dot ca
2004-05-26 19:21 ` pinskia at gcc dot gnu dot org
2004-05-26 19:24 ` rguenth at tat dot physik dot uni-tuebingen dot de
2004-05-27  5:10 ` ebotcazou at gcc dot gnu dot org
2004-05-27 10:56 ` dave at hiauly1 dot hia dot nrc dot ca
2004-05-27 10:57 ` ebotcazou at gcc dot gnu dot org
2004-05-27 11:34 ` gdr at integrable-solutions dot net
2004-05-27 11:38 ` ebotcazou at gcc dot gnu dot org
2004-05-27 11:48 ` gdr at integrable-solutions dot net
2004-05-27 11:51 ` ebotcazou at gcc dot gnu dot org
2004-05-27 13:36 ` rguenth at tat dot physik dot uni-tuebingen dot de
2004-05-27 17:36 ` dave at hiauly1 dot hia dot nrc dot ca
2004-05-27 17:37 ` pinskia at physics dot uc dot edu
2004-05-27 17:38 ` gdr at integrable-solutions dot net
2004-05-27 17:42 ` pinskia at gcc dot gnu dot org
2004-05-27 18:37 ` rguenth at tat dot physik dot uni-tuebingen dot de
2004-05-27 18:44 ` rguenth at tat dot physik dot uni-tuebingen dot de
2004-05-27 19:12 ` rguenth at tat dot physik dot uni-tuebingen dot de
2004-05-28  1:24 ` dave at hiauly1 dot hia dot nrc dot ca
2004-05-28  1:34 ` rguenth at tat dot physik dot uni-tuebingen dot de
2004-05-28  4:24 ` dave at hiauly1 dot hia dot nrc dot ca
2004-05-28 10:17 ` dave at hiauly1 dot hia dot nrc dot ca
2004-05-28 11:25 ` ebotcazou at gcc dot gnu dot org
2004-05-28 13:09 ` dave at hiauly1 dot hia dot nrc dot ca
2004-05-28 15:55 ` dave at hiauly1 dot hia dot nrc dot ca
2004-05-28 17:34 ` gdr at integrable-solutions dot net
2004-05-28 18:58 ` dave at hiauly1 dot hia dot nrc dot ca
2004-05-28 20:01 ` gdr at integrable-solutions dot net
2004-05-28 21:38 ` rguenth at tat dot physik dot uni-tuebingen dot de
2004-05-28 21:39 ` rguenth at tat dot physik dot uni-tuebingen dot de
2004-05-28 22:17 ` rguenth at tat dot physik dot uni-tuebingen dot de
2004-05-28 22:29 ` ebotcazou at gcc dot gnu dot org
2004-05-28 22:29 ` gdr at integrable-solutions dot net
2004-05-29  1:25 ` cvs-commit at gcc dot gnu dot org
2004-05-29  1:44 ` pinskia at gcc dot gnu dot org
2004-05-29  1:50 ` [Bug bootstrap/14671] [3.4 " pinskia at gcc dot gnu dot org
2004-05-29  2:08 ` dave at hiauly1 dot hia dot nrc dot ca
2004-05-29 20:28 ` pinskia at gcc dot gnu dot org
2004-05-30  4:44 ` mmitchel at gcc dot gnu dot org
2004-05-30 11:51 ` cvs-commit at gcc dot gnu dot org
2004-05-30 12:58 ` dave at hiauly1 dot hia dot nrc dot ca
2004-05-30 13:07 ` pinskia at gcc dot gnu dot org
2004-05-30 13:17 ` dave at hiauly1 dot hia dot nrc dot ca

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040407042429.11499.qmail@sources.redhat.com \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).