[Bug other/14884] New: rpc/xdr.h should be fixincluded

[Bug other/14884] New: rpc/xdr.h should be fixincluded

[jsm28 at gcc dot gnu dot org]

glibc's <rpc/xdr.h> uses lvalue casts and should be fixincluded.

The patch <http://gcc.gnu.org/ml/gcc-patches/2004-03/msg02056.html>
is now on mainline but should go in 3.4.0 and 3.3.4, the releases
which introduce the deprecation of lvalue casts.  (glibc CVS has
also been fixed, using exactly the same definitions as the fixincludes
fixes use.)

OK for 3.4 branch?

-- 
           Summary: rpc/xdr.h should be fixincluded
           Product: gcc
           Version: 3.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: other
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: jsm28 at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org,mark at codesourcery dot
                    com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14884

[Bug other/14884] [3.3/3.4 only] rpc/xdr.h should be fixincluded

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-04-07 22:52 -------
Confirmed, GDR also okay for 3.3.4?

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gdr at gcc dot gnu dot org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2004-04-07 22:52:13
               date|                            |
            Summary|rpc/xdr.h should be         |[3.3/3.4 only] rpc/xdr.h
                   |fixincluded                 |should be fixincluded
   Target Milestone|---                         |3.3.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14884

[Bug other/14884] [3.3/3.4 only] rpc/xdr.h should be fixincluded

[mark at codesourcery dot com]

------- Additional Comments From mark at codesourcery dot com  2004-04-07 23:04 -------
Subject: Re:  New: rpc/xdr.h should be fixincluded

jsm28 at gcc dot gnu dot org wrote:

>glibc's <rpc/xdr.h> uses lvalue casts and should be fixincluded.
>
>The patch <http://gcc.gnu.org/ml/gcc-patches/2004-03/msg02056.html>
>is now on mainline but should go in 3.4.0 and 3.3.4, the releases
>which introduce the deprecation of lvalue casts.  (glibc CVS has
>also been fixed, using exactly the same definitions as the fixincludes
>fixes use.)
>
>OK for 3.4 branch?
>  
>
Yes.



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14884

[Bug other/14884] [3.3/3.4 only] rpc/xdr.h should be fixincluded

[gdr at integrable-solutions dot net]

------- Additional Comments From gdr at integrable-solutions dot net  2004-04-07 23:32 -------
Subject: Re:  New: rpc/xdr.h should be fixincluded

"jsm28 at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org> writes:

| The patch <http://gcc.gnu.org/ml/gcc-patches/2004-03/msg02056.html>
| is now on mainline but should go in 3.4.0 and 3.3.4, the releases
| which introduce the deprecation of lvalue casts.  (glibc CVS has
| also been fixed, using exactly the same definitions as the fixincludes
| fixes use.)
| 
| OK for 3.4 branch?

OK for 3.3.4.

Thanks,

-- Gaby


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14884

Re: [Bug other/14884] New: rpc/xdr.h should be fixincluded

[Gabriel Dos Reis]

"jsm28 at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org> writes:

| The patch <http://gcc.gnu.org/ml/gcc-patches/2004-03/msg02056.html>
| is now on mainline but should go in 3.4.0 and 3.3.4, the releases
| which introduce the deprecation of lvalue casts.  (glibc CVS has
| also been fixed, using exactly the same definitions as the fixincludes
| fixes use.)
| 
| OK for 3.4 branch?

OK for 3.3.4.

Thanks,

-- Gaby

[Bug other/14884] [3.3/3.4 only] rpc/xdr.h should be fixincluded

[jsm at polyomino dot org dot uk]

------- Additional Comments From jsm at polyomino dot org dot uk  2004-04-08 09:09 -------
Subject: Re:  [3.3/3.4 only] rpc/xdr.h should be fixincluded

On Wed, 7 Apr 2004, gdr at integrable-solutions dot net wrote:

> | The patch <http://gcc.gnu.org/ml/gcc-patches/2004-03/msg02056.html>
> | is now on mainline but should go in 3.4.0 and 3.3.4, the releases
> | which introduce the deprecation of lvalue casts.  (glibc CVS has
> | also been fixed, using exactly the same definitions as the fixincludes
> | fixes use.)
> | 
> | OK for 3.4 branch?
> 
> OK for 3.3.4.

I don't now have a 3.3 branch checkout, could you apply the patch (and
regenerate fixincl.x) there?



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14884

[Bug other/14884] [3.3/3.4 only] rpc/xdr.h should be fixincluded

[giovannibajo at libero dot it]

------- Additional Comments From giovannibajo at libero dot it  2004-06-06 03:51 -------
JSM did the patch for this went in on the 3.4 branch?
Gaby, did you commit this to the 3.3 branch?

Retargeting to 3.4.1, being a regression on that release branch.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.3.4                       |3.4.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14884

[Bug other/14884] [3.3/3.4 only] rpc/xdr.h should be fixincluded

[gdr at integrable-solutions dot net]

------- Additional Comments From gdr at integrable-solutions dot net  2004-06-06 04:00 -------
Subject: Re:  [3.3/3.4 only] rpc/xdr.h should be fixincluded

"giovannibajo at libero dot it" <gcc-bugzilla@gcc.gnu.org> writes:

| JSM did the patch for this went in on the 3.4 branch?
| Gaby, did you commit this to the 3.3 branch?

Unfortunately, I don't think I did :-(
Queued for 3.3.5.

-- Gaby


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14884

[Bug other/14884] [3.3/3.4 only] rpc/xdr.h should be fixincluded

[jsm at polyomino dot org dot uk]

------- Additional Comments From jsm at polyomino dot org dot uk  2004-06-06 11:41 -------
Subject: Re:  [3.3/3.4 only] rpc/xdr.h should be fixincluded

On Sun, 6 Jun 2004, giovannibajo at libero dot it wrote:

> JSM did the patch for this went in on the 3.4 branch?

The fix is in the 3.4.0 release.



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14884

[Bug other/14884] [3.3 only] rpc/xdr.h should be fixincluded

[mmitchel at gcc dot gnu dot org]

------- Additional Comments From mmitchel at gcc dot gnu dot org  2004-06-12 21:58 -------
Removing 3.4 markers since Joseph says this was fixed in 3.4.0.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[3.3/3.4 only] rpc/xdr.h    |[3.3 only] rpc/xdr.h should
                   |should be fixincluded       |be fixincluded
   Target Milestone|3.4.1                       |3.3.5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14884

[Bug other/14884] [3.3 only] rpc/xdr.h should be fixincluded

[gdr at gcc dot gnu dot org]

------- Additional Comments From gdr at gcc dot gnu dot org  2004-09-28 13:30 -------
Adjust milestone

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.3.5                       |3.3.6


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14884

[Bug other/14884] [3.3 only] rpc/xdr.h should be fixincluded

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-04-30 17:14 -------
Subject: Bug 14884

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_3-branch
Changes by:	gdr@gcc.gnu.org	2005-04-30 17:14:28

Modified files:
	gcc            : ChangeLog 
	gcc/fixinc     : inclhack.def 
	gcc/fixinc/tests/base/rpc: xdr.h 

Log message:
	PR 14884
	* Apply:
	2004-03-25  Joseph S. Myers  <jsm@polyomino.org.uk>
	
	* fixinc/inclhack.def (rpc_xdr_lvalue_cast_a,
	rpc_xdr_lvalue_cast_b): New fixes.
	* fixinc/tests/base/rpc/xdr.h: Add new tests.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.16114.2.1066&r2=1.16114.2.1067
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fixinc/inclhack.def.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.139.4.18&r2=1.139.4.19
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fixinc/tests/base/rpc/xdr.h.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.2&r2=1.2.56.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14884

[Bug other/14884] [3.3 only] rpc/xdr.h should be fixincluded

[gdr at gcc dot gnu dot org]

------- Additional Comments From gdr at gcc dot gnu dot org  2005-04-30 17:16 -------
Applied to 3.3.6 too.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14884