[Bug debug/14919] New: [3.3 Regression]: DW_AT_comp_dir is missing

[Bug debug/14919] New: [3.3 Regression]: DW_AT_comp_dir is missing

[hjl at lucon dot org]

Gcc 3.3 will not generate DW_AT_comp_dir under certain condition,
which makes it harder to debug. Gcc 3.2 and gcc 3.4 are OK.

-- 
           Summary: [3.3 Regression]: DW_AT_comp_dir is missing
           Product: gcc
           Version: 3.3.4
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: debug
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: hjl at lucon dot org
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: i686-pc-linux-gnu
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: i686-pc-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14919

[Bug debug/14919] [3.3 Regression]: DW_AT_comp_dir is missing

[hjl at lucon dot org]

------- Additional Comments From hjl at lucon dot org  2004-04-11 22:28 -------
Created an attachment (id=6076)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=6076&action=view)
A testcase

[hjl@gnu-psc debug]$ make CC=/usr/gcc-3.3/bin/gcc
/usr/gcc-3.3/bin/gcc -Iinc -g -c `pwd`/src/foo.c
readelf -w foo.o | grep AT_comp_dir
make: *** [all] Error 1
[hjl@gnu-psc debug]$


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14919

[Bug debug/14919] [3.3 Regression]: DW_AT_comp_dir is missing

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-04-11 23:04 -------
Nothing has changed in dwarf2-out.c in the 3.3 branch which could have caused this.  I think 
something has changed in the preprocessor though.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |wrong-debug


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14919

[Bug debug/14919] [3.3 Regression]: DW_AT_comp_dir is missing

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-04-11 23:17 -------
This has not changed since:
1.126        (jason    23-Nov-99):   if (wd != NULL && filename[0] != DIR_SEPARATOR)
1.126        (jason    23-Nov-99):     add_AT_string (die, DW_AT_comp_dir, wd);

So I do not know how 3.2 worked at all.

3.4 changed it to:
   if (filename[0] != DIR_SEPARATOR)
    add_comp_dir_attribute (comp_unit_die);
  else if (get_AT (comp_unit_die, DW_AT_comp_dir) == NULL)
    {
      size_t i;
      for (i = 1; i < VARRAY_ACTIVE_SIZE (file_table); i++)
        if (VARRAY_CHAR_PTR (file_table, i)[0] != DIR_SEPARATOR
            /* Don't add cwd for <built-in>.  */
            && VARRAY_CHAR_PTR (file_table, i)[0] != '<')
          {
            add_comp_dir_attribute (comp_unit_die);
            break;
          }
    }

This was changed with:
2003-01-16  Richard Henderson  <rth@redhat.com>

        * dwarf2out.c (struct file_table): Remove.
        (FILE_TABLE_INCREMENT): Remove.
        (file_table): Make a varray; mark for GC.  Update all users.
        (file_table_last_lookup_index): Extract from struct file_table.
        (output_file_names): Fix unsigned compare warnings.
        (add_name_attribute): Remove inline marker.
        (add_comp_dir_attribute): Split out from gen_compile_unit_die.
        (lookup_filename): Don't manage size of file_table.
        (init_file_table): Allocate file_table with GC.
        (dwarf2out_init): Don't record main_input_filename here.
        (dwarf2out_finish): Do it here instead.

See <http://gcc.gnu.org/ml/gcc-patches/2003-01/msg01195.html> for the patch but this was 
needed for PCH only so something else has changed in the compiler, I am starting to think the 
preprocessor changed.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14919

[Bug debug/14919] [3.3 Regression]: DW_AT_comp_dir is missing

[hjl at lucon dot org]

------- Additional Comments From hjl at lucon dot org  2004-04-12 00:21 -------
I will bet this patch:

http://gcc.gnu.org/ml/gcc-patches/2003-02/msg00012.html

will fix it. Can we move it to 3.3 branch?

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14919

[Bug debug/14919] [3.3 Regression]: DW_AT_comp_dir is missing

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-04-12 00:38 -------
Confirmed, you also need the patch which I said about too because the patch you 
mentioned depends on this one too.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2004-04-12 00:38:23
               date|                            |
   Target Milestone|---                         |3.3.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14919

[Bug debug/14919] [3.3 Regression]: DW_AT_comp_dir is missing

[hjl at lucon dot org]

------- Additional Comments From hjl at lucon dot org  2004-04-12 01:21 -------
We can use this one on 3.3 branch:

http://gcc.gnu.org/ml/gcc-cvs/2003-02/msg00130.html

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14919

[Bug debug/14919] [3.3]: DW_AT_comp_dir is missing

[hjl at lucon dot org]

------- Additional Comments From hjl at lucon dot org  2004-04-12 15:08 -------
Gaby, this bug is not a regression against 3.2. But it was fixed in the gcc 3.2
Red Hat branch more tha a year ago. I'd like to bring this bug fix up to gcc 3.3
branch.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[3.3 Regression]:           |[3.3]: DW_AT_comp_dir is
                   |DW_AT_comp_dir is missing   |missing


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14919

[Bug debug/14919] [3.3]: DW_AT_comp_dir is missing

[gdr at integrable-solutions dot net]

------- Additional Comments From gdr at integrable-solutions dot net  2004-04-12 15:32 -------
Subject: Re:  [3.3]: DW_AT_comp_dir is missing

"hjl at lucon dot org" <gcc-bugzilla@gcc.gnu.org> writes:

| Gaby, this bug is not a regression against 3.2. But it was fixed in the gcc 3.2
| Red Hat branch more tha a year ago. I'd like to bring this bug fix up to gcc 3.3
| branch.

Can you give me a sense of the effects of proposed patches (e.g. results of
testsuites on at least two major evaluation plateforms)?
This is going to be the last non-regression patches appalied to 3.3.4.
I'm going to announce that shortly.  Others would have to wait 3.3.5.

Thanks,

-- Gaby


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14919

[Bug debug/14919] [3.3]: DW_AT_comp_dir is missing

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-04-13 18:36 -------
Subject: Bug 14919

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_3-branch
Changes by:	hjl@gcc.gnu.org	2004-04-13 18:36:41

Modified files:
	gcc            : ChangeLog dwarf2out.c 

Log message:
	2004-04-13  H.J. Lu  <hongjiu.lu@intel.com>
	
	PR debug/14919
	
	From gcc-3_2-rhl8-branch:
	2003-02-04  Jakub Jelinek  <jakub@redhat.com>
	
	* dwarf2out.c (dwarf2out_finish): Add AT_comp_dir attribute
	even if input file name is absolute, but one of the includes
	is relative.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.16114.2.966&r2=1.16114.2.967
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/dwarf2out.c.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.390.2.13&r2=1.390.2.14



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14919

[Bug debug/14919] [3.3]: DW_AT_comp_dir is missing

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-04-13 18:41 -------
Fixed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14919