[Bug other/14918] New: -fprofile-generate should be documented as necessary for linking

[Bug other/14918] New: -fprofile-generate should be documented as necessary for linking

[bryner at brianryner dot com]

In gcc 3.4, -fprofile-generate needs to be given as part of the link command if
any of the object files being linked were built with that option (so that it
links to libgcov).  I'd like to request that this be documented in the
description for -fprofile-generate, since this is not typical of optimization
options (and is a change from the behavior of -fprofile-arcs in 3.3).

-- 
           Summary: -fprofile-generate should be documented as necessary for
                    linking
           Product: gcc
           Version: 3.4.0
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: other
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: bryner at brianryner dot com
                CC: gcc-bugs at gcc dot gnu dot org
  GCC host triplet: i686-pc-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14918

[Bug other/14918] -fprofile-generate should be documented as necessary for linking

[pinskia at gcc dot gnu dot org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 877 bytes --]


------- Additional Comments From pinskia at gcc dot gnu dot org  2004-04-11 22:13 -------
Confirmed, maybe a sentence like this is needed in the docs under -fprofile-generate:
	• 	Link your object files with -lgcov or -fprofile-generate (the latter implies the former).

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
           Keywords|                            |documentation
   Last reconfirmed|0000-00-00 00:00:00         |2004-04-11 22:13:26
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14918

[Bug other/14918] -fprofile-generate should be documented as necessary for linking

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-04-15 03:41 -------
Mine, patch here: <http://gcc.gnu.org/ml/gcc-patches/2004-04/msg00869.html>.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pinskia at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
           Keywords|                            |patch
   Target Milestone|---                         |3.4.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14918

[Bug other/14918] -fprofile-generate should be documented as necessary for linking

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-04-18 15:59 -------
Can this doc patch go into 3.4.0: <http://gcc.gnu.org/ml/gcc-patches/2004-04/
msg00869.html>?

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mmitchel at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14918

[Bug other/14918] -fprofile-generate should be documented as necessary for linking

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-04-18 23:05 -------
Subject: Bug 14918

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_4-branch
Changes by:	mmitchel@gcc.gnu.org	2004-04-18 23:05:37

Modified files:
	gcc            : ChangeLog 
	gcc/doc        : invoke.texi 

Log message:
	PR other/14918
	* doc/invoke.texi (-fprofile-generate): Document requirement to
	use -fprofile-generate when linking.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=2.2326.2.396&r2=2.2326.2.397
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/doc/invoke.texi.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.390.2.23&r2=1.390.2.24



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14918

[Bug other/14918] -fprofile-generate should be documented as necessary for linking

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-04-18 23:17 -------
Subject: Bug 14918

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	mmitchel@gcc.gnu.org	2004-04-18 23:17:29

Modified files:
	gcc            : ChangeLog 
	gcc/doc        : invoke.texi 

Log message:
	PR other/14918
	* doc/invoke.texi (-fprofile-generate): Document requirement to
	use -fprofile-generate when linking.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.3426&r2=2.3427
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/doc/invoke.texi.diff?cvsroot=gcc&r1=1.446&r2=1.447



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14918

[Bug other/14918] -fprofile-generate should be documented as necessary for linking

[mark at codesourcery dot com]

------- Additional Comments From mark at codesourcery dot com  2004-04-18 23:20 -------
Subject: Re:  -fprofile-generate should be documented as
 necessary for linking

pinskia at gcc dot gnu dot org wrote:

>------- Additional Comments From pinskia at gcc dot gnu dot org  2004-04-18 15:59 -------
>Can this doc patch go into 3.4.0: <http://gcc.gnu.org/ml/gcc-patches/2004-04/
>msg00869.html>?
>  
>
I checked in this variant on both the 3.4 branch and the mainline.  (I 
don't think we should explicitly encourage using -lgcov.)

(The docs in this area don't look very well written -- there are some 
grammar and typo issues.  But, that's for another day...)

Index: ChangeLog
===================================================================
RCS file: /cvs/gcc/gcc/gcc/ChangeLog,v
retrieving revision 2.3426
diff -c -5 -p -r2.3426 ChangeLog
*** ChangeLog	18 Apr 2004 22:01:09 -0000	2.3426
--- ChangeLog	18 Apr 2004 23:03:26 -0000
***************
*** 1,7 ****
--- 1,11 ----
  2004-04-18  Mark Mitchell  <mark@codesourcery.com>
  
+ 	PR other/14918
+ 	* doc/invoke.texi (-fprofile-generate): Document requirement to
+ 	use -fprofile-generate when linking.
+ 
  	* doc/extend.texi (Strong Using): Warn users against using this
  	feature.
  
  2004-04-18  Richard Sandiford  <rsandifo@redhat.com>
  
Index: doc/invoke.texi
===================================================================
RCS file: /cvs/gcc/gcc/gcc/doc/invoke.texi,v
retrieving revision 1.445
diff -c -5 -p -r1.445 invoke.texi
*** doc/invoke.texi	14 Apr 2004 08:36:55 -0000	1.445
--- doc/invoke.texi	18 Apr 2004 23:03:27 -0000
*************** and occasionally eliminate the copy.
*** 4371,4384 ****
  
  Disabled at levels @option{-O}, @option{-O2}, @option{-O3}, @option{-Os}.
  
  @item -fprofile-generate
  @opindex fprofile-generate
- Enable options usually used for instrumenting application to produce profile usefull
- for later recompilation profile feedback based optimization.
  
! The following options are enabled: @code{-fprofile-arcs}, @code{-fprofile-values}, @code{-fvpt}
  
  @item -fprofile-use
  @opindex fprofile-use
  Enable profile feedback directed optimizations, and optimizations
  generally profitable only with profile feedback available.
--- 4371,4387 ----
  
  Disabled at levels @option{-O}, @option{-O2}, @option{-O3}, @option{-Os}.
  
  @item -fprofile-generate
  @opindex fprofile-generate
  
! Enable options usually used for instrumenting application to produce
! profile useful for later recompilation with profile feedback based
! optimization.  You must use @code{-fprofile-generate} both when
! compiling and when linking your program.
! 
! The following options are enabled: @code{-fprofile-arcs}, @code{-fprofile-values}, @code{-fvpt}.
  
  @item -fprofile-use
  @opindex fprofile-use
  Enable profile feedback directed optimizations, and optimizations
  generally profitable only with profile feedback available.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14918

[Bug other/14918] -fprofile-generate should be documented as necessary for linking

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-04-18 23:44 -------
Thanks Mark to fix up my patch.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|3.4.1                       |3.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14918