[Bug pch/15007] New: crash when including precompiled header with -include

[Bug pch/15007] New: crash when including precompiled header with -include

[bryner at brianryner dot com]

Using a trunk gcc build pulled today, I get a crash if I include a precompiled
header with -include.  For example,

pchtest.h:
void foo (void);

pchtest.c:
<empty>

gcc -c -o pchtest.h.gch pchtest.h
gcc -c -o pchtest.o pchtest.c -include -pchtest.h
pchtest.c:1: internal compiler error: Segmentation fault
Please submit a full bug report,
with preprocessed source if appropriate.

cc1 backtrace:
#0  0x0806a580 in c_write_global_declarations () at ../../gcc/gcc/c-decl.c:6629
#1  0x082e28c4 in toplev_main (argc=0, argv=0x0) at ../../gcc/gcc/toplev.c:1608
#2  0x080a8d9e in main (argc=0, argv=0x0) at ../../gcc/gcc/main.c:35

-- 
           Summary: crash when including precompiled header with -include
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: critical
          Priority: P2
         Component: pch
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: bryner at brianryner dot com
                CC: gcc-bugs at gcc dot gnu dot org
  GCC host triplet: i686-pc-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15007

[Bug pch/15007] crash when including precompiled header with -include

[bryner at brianryner dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-valid-code


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15007

[Bug c/15007] [3.5 Regression] crash when including precompiled header with -include

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-04-18 21:23 -------
Confirmed, I think this is caused by Zack's rewrite of c-decl.

Zack,
  I know that you are help on the release of 3.4.0 but after the release could you look into this?
I almost think it is because c-decl creates a translation_unit_decl even if it does not need to but I have
not looked into it at all except that in the non PCH case there is only one translation_unit_decl while in 
the PCH case there are two.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zack at gcc dot gnu dot org
             Status|UNCONFIRMED                 |NEW
          Component|pch                         |c
     Ever Confirmed|                            |1
      Known to fail|                            |3.5.0
      Known to work|                            |3.4.0
   Last reconfirmed|0000-00-00 00:00:00         |2004-04-18 21:23:23
               date|                            |
            Summary|crash when including        |[3.5 Regression] crash when
                   |precompiled header with -   |including precompiled header
                   |include                     |with -include
   Target Milestone|---                         |3.5.0
            Version|unknown                     |3.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15007

[Bug pch/15007] crash when including precompiled header with -include

[bryner at brianryner dot com]

------- Additional Comments From bryner at brianryner dot com  2004-04-18 21:16 -------
(In reply to comment #0)
> gcc -c -o pchtest.o pchtest.c -include -pchtest.h
                                         ^^
That last dash is a typo in the bug report.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15007

[Bug c/15007] [3.5 Regression] crash when including precompiled header with -include

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-04-22 02:45 -------
*** Bug 15060 has been marked as a duplicate of this bug. ***

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |geoffk at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15007

[Bug c/15007] [3.5 Regression] crash when including precompiled header with -include

[geoffk at gcc dot gnu dot org]

------- Additional Comments From geoffk at gcc dot gnu dot org  2004-04-22 02:51 -------
See bug 15060 for more analysis.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |zack at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15007

[Bug c/15007] [3.5 Regression] crash when including precompiled header with -include

[geoffk at gcc dot gnu dot org]

------- Additional Comments From geoffk at gcc dot gnu dot org  2004-04-22 05:39 -------
The problem is that there are two TRANSLATION_UNIT_DECLs.  One appears to come from the PCH file, 
and is incomplete.  I am not sure where the other one comes from; possibly it is created after the PCH 
file is loaded.  There should, of course, be only one TRANSLATION_UNIT_DECL, since there is only one 
translation unit.  So, I suspect a problem with the timing of PCH saving and/or restoring.

I've confirmed that this crash does not happen immedately before Zack's 2004-03-23 patch, and does 
happen immediately after it was applied.  I find it particularly suspicious that this patch introduced a 
number of constructs of the form "if (pch_file) return;"; such constructs were not necessary before, and 
it is likely that these are bandaids for deeper problems.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15007

[Bug c/15007] [3.5 Regression] crash when including precompiled header with -include

[zack at gcc dot gnu dot org]

------- Additional Comments From zack at gcc dot gnu dot org  2004-05-01 05:26 -------
(From update of attachment 6204)
attachment tweak: fix mime type, mark patch


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #6204|pr15007.diff                |.
        description|                            |
   Attachment #6204|text/x-patch                |text/plain
          mime type|                            |
Attachment #6204 is|0                           |1
              patch|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15007

[Bug c/15007] [3.5 Regression] crash when including precompiled header with -include

[zack at gcc dot gnu dot org]

------- Additional Comments From zack at gcc dot gnu dot org  2004-05-01 05:26 -------
ve have ze patch.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15007

[Bug c/15007] [3.5 Regression] crash when including precompiled header with -include

[mrs at apple dot com]

------- Additional Comments From mrs at apple dot com  2004-05-04 17:54 -------
The patch seems to work as expected and fix this problem on powerpc-apple-darwin7.2.0.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15007

[Bug c/15007] [3.5 Regression] crash when including precompiled header with -include

[bowdidge at apple dot com]

------- Additional Comments From bowdidge at apple dot com  2004-05-05 23:10 -------
This bug would hit if I tried to build the Qt sources with the top-of-tree gcc in the FSF repository.  After 
applying the patch, Qt would no longer hit this bug.  Thanks!

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15007

[Bug c/15007] [3.5 Regression] crash when including precompiled header with -include

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-05-09 21:27 -------
Subject: Bug 15007

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	zack@gcc.gnu.org	2004-05-09 21:27:00

Modified files:
	gcc            : ChangeLog c-decl.c 

Log message:
	PR 15007
	* c-decl.c (current_file_decl): Rename to all_translation_units,
	adjust comment.
	(pop_scope): If popping file_scope, construct a
	TRANSLATION_UNIT_DECL and make it the context of all the
	symbols in the scope.
	(push_file_scope): Don't construct a TRANSLATION_UNIT_DECL here.
	(pushdecl): Clarify comment.  Do not set DECL_CONTEXT of
	anything to current_file_decl.
	(pushdecl_top_level): Likewise.
	(store_parm_decls_newstyle): Adjust check for nested function.
	(c_write_global_declarations): Update for renamed variable.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.3611&r2=2.3612
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-decl.c.diff?cvsroot=gcc&r1=1.496&r2=1.497



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15007

[Bug c/15007] [3.5 Regression] crash when including precompiled header with -include

[zack at gcc dot gnu dot org]

------- Additional Comments From zack at gcc dot gnu dot org  2004-05-09 21:28 -------
patch checked in

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15007