[Bug bootstrap/15156] New: gnatlink does not link due to undefined symbol _gnat__strings_E

[Bug bootstrap/15156] New: gnatlink does not link due to undefined symbol _gnat__strings_E

[awreynolds at mac dot com]

../../xgcc -B../../ -DIN_GCC   `echo -O2 -g -O2 -W -Wall -Wwrite-strings -Wstrict-prototypes 
-Wmissing-prototypes -fno-common |sed -e 's/-pedantic//g' -e 's/-Wtraditional//g'`   -o ../../
gnatlink b_gnatl.o gnatlink.o a-except.o ali.o alloc.o butil.o casing.o csets.o debug.o fmap.o fname.o 
gnatvsn.o hostparm.o interfac.o i-c.o i-cstrin.o namet.o opt.o osint.o output.o rident.o s-exctab.o s-
secsta.o s-stalib.o s-stoele.o sdefault.o stylesw.o switch.o system.o table.o tree_io.o types.o validsw.o 
widechar.o \
      ../rts/libgnat.a  ../../prefix.o ../../version.o link.o ../../../libiberty/libiberty.a  
/usr/bin/ld: Undefined symbols:
_gnat__strings_E
collect2: ld returned 1 exit status
make[4]: *** [../../gnatlink] Error 1
make[3]: *** [gnattools1] Error 2
make[2]: *** [gnattools-native] Error 2
make[1]: *** [all-target-libada] Error 2
make: *** [bootstrap] Error 2

[pbg4:gcc/ada/tools] drew% nm b_gnatl.o | grep _gnat__strings_E
         U _gnat__strings_E

[pbg4:gcc/ada/rts] drew% nm g-string.o | grep _gnat__strings_E
00000001 C _gnat__strings_E

[pbg4:gcc/ada/rts] drew% ar t libgnat.a | grep g-string.o
g-string.o

When I add ../g-string.o to the command and the program links correctly (see below). The remainder of 
the build continues without error.

pbg4:~/Developer/Compiler/fsf-gcc-obj/gcc/ada/tools drew$ ../../xgcc -B../../ -DIN_GCC   `echo 
-O2 -g -O2 -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -fno-common |sed 
-e 's/-pedantic//g' -e 's/-Wtraditional//g'`   -o ../../gnatlink b_gnatl.o gnatlink.o a-except.o ali.o 
alloc.o butil.o casing.o csets.o debug.o fmap.o fname.o gnatvsn.o hostparm.o interfac.o i-c.o i-cstrin.o 
namet.o opt.o osint.o output.o rident.o s-exctab.o s-secsta.o s-stalib.o s-stoele.o sdefault.o stylesw.o 
switch.o system.o table.o tree_io.o types.o validsw.o widechar.o ../g-string.o ../rts/libgnat.a  ../../
prefix.o ../../version.o link.o ../../../libiberty/libiberty.a
pbg4:~/Developer/Compiler/fsf-gcc-obj/gcc/ada/tools drew$

-- 
           Summary: gnatlink does not link due to undefined symbol
                    _gnat__strings_E
           Product: gcc
           Version: 3.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: bootstrap
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: awreynolds at mac dot com
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: powerpc-apple-darwin7.3.0
  GCC host triplet: powerpc-apple-darwin7.3.0
GCC target triplet: powerpc-apple-darwin7.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15156

[Bug bootstrap/15156] gnatlink does not link due to undefined symbol _gnat__strings_E

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-04-26 22:20 -------
Confirmed.

See <http://gcc.gnu.org/ml/gcc/2004-04/msg00990.html> for more infomation on what is going on 
here.


I think the proposed patch at <http://gcc.gnu.org/ml/gcc-patches/2004-04/msg01604.html> had 
fixed the problem but I have not tested yet.

The corresponding changeLog is:
2004-04-23  Laurent GUERBY <laurent@guerby.net>

        * Makefile.in: Remove RANLIB_TEST, use -$(RANLIB) including after
        install.

Did that fix it?

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
           Keywords|                            |build
   Last reconfirmed|0000-00-00 00:00:00         |2004-04-26 22:20:12
               date|                            |
   Target Milestone|---                         |3.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15156

[Bug bootstrap/15156] gnatlink does not link due to undefined symbol _gnat__strings_E

[laurent at guerby dot net]

------- Additional Comments From laurent at guerby dot net  2004-04-27 17:28 -------
The patch is in but unfortunately it does not cure the problem (at least for me).

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |laurent at guerby dot net


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15156

[Bug bootstrap/15156] [3.5 Regression] gnatlink does not link due to undefined symbol _gnat__strings_E

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-04-27 17:31 -------
I know that this is a regression as I could build an Ada compiler on the 3.4.0 branch on this target (with 
my patch yes).

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
           Severity|normal                      |critical
   Last reconfirmed|2004-04-26 22:20:12         |2004-04-27 17:31:15
               date|                            |
            Summary|gnatlink does not link due  |[3.5 Regression] gnatlink
                   |to undefined symbol         |does not link due to
                   |_gnat__strings_E            |undefined symbol
                   |                            |_gnat__strings_E


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15156

[Bug bootstrap/15156] [3.5 Regression] gnatlink does not link due to undefined symbol _gnat__strings_E

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |normal
  GCC build triplet|powerpc-apple-darwin7.3.0   |
   GCC host triplet|powerpc-apple-darwin7.3.0   |
 GCC target triplet|powerpc-apple-darwin7.3.0   |*-darwin


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15156

[Bug target/15156] gnatlink does not link due to undefined symbol _gnat__strings_E

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-07-02 19:16 -------
hmm, I think we hit this linker bug now with --disable-checking on powerpc-apple-darwin.  I will see 
if it is because there is no two stage linker on darwin at all.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|bootstrap                   |target
            Summary|[3.5 Regression] gnatlink   |gnatlink does not link due
                   |does not link due to        |to undefined symbol
                   |undefined symbol            |_gnat__strings_E
                   |_gnat__strings_E            |
   Target Milestone|3.5.0                       |---


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15156

[Bug target/15156] gnatlink does not link due to undefined symbol _gnat__strings_E

[charlet at gcc dot gnu dot org]

-- 
Bug 15156 depends on bug 15416, which changed state.

Bug 15416 Summary: Can't bootstrap the gcc-3.5 Ada compiler
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15416

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15156

[Bug ada/15156] gnatlink does not link due to undefined symbol _gnat__strings_E

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-10-01 21:56 -------
Semi-fixed on the mainline by:
2004-07-04  Mark Mitchell  <mark@codesourcery.com>
        
        * configure.ac (ranlib_flags): New variable.
        * Makefile.in (RANLIB_FLAGS): New variable.
        (libbackend.a): Use it.
        * configure: Regenerated.

All that needs to happen now is to use RANLIB_FLAGS while calling ranlib in the ada subdirectory.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|target                      |ada
   Last reconfirmed|2004-04-27 17:31:15         |2004-10-01 21:56:17
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15156

[Bug ada/15156] gnatlink does not link due to undefined symbol _gnat__strings_E

[laurent at guerby dot net]

------- Additional Comments From laurent at guerby dot net  2004-10-01 22:17 -------
Testing on x86 & x86_64

Index: Makefile.in
===================================================================
RCS file: /cvs/gcc/gcc/gcc/ada/Makefile.in,v
retrieving revision 1.95
diff -u -r1.95 Makefile.in
--- Makefile.in 13 Sep 2004 10:18:40 -0000      1.95
+++ Makefile.in 1 Oct 2004 22:15:41 -0000
@@ -106,6 +106,7 @@
 AR_FLAGS = rc
 LS = ls
 RANLIB = @RANLIB@
+RANLIB_FLAGS = @ranlib_flags@

 SHELL = @SHELL@
 PWD_COMMAND = $${PWDCMD-pwd}
@@ -1668,7 +1669,7 @@
        -$(INSTALL_DATA) rts/g-trasym$(objext) $(DESTDIR)$(ADA_RTL_OBJ_DIR)
        -cd rts; for file in *$(arext);do \
            $(INSTALL_DATA) $$file $(DESTDIR)$(ADA_RTL_OBJ_DIR); \
-           $(RANLIB) $(DESTDIR)$(ADA_RTL_OBJ_DIR)/$$file; \
+           -$(RANLIB) $(RANLIB_FLAGS) $(DESTDIR)$(ADA_RTL_OBJ_DIR)/$$file; \
        done
        -$(foreach file, $(EXTRA_ADALIB_FILES), \
            $(INSTALL_DATA_DATE) rts/$(file) $(DESTDIR)$(ADA_RTL_OBJ_DIR) && \
@@ -1760,13 +1761,13 @@
         ifneq ($(PREFIX_OBJS),)
                $(AR) $(AR_FLAGS) rts/libgccprefix$(arext) $(PREFIX_OBJS);
         endif
-       -$(RANLIB) rts/libgnat$(arext)
+       -$(RANLIB) $(RANLIB_FLAGS) rts/libgnat$(arext)
        $(AR) $(AR_FLAGS) rts/libgnarl$(arext) \
           $(addprefix rts/,$(GNATRTL_TASKING_OBJS))
-       -$(RANLIB) rts/libgnarl$(arext)
+       -$(RANLIB) $(RANLIB_FLAGS) rts/libgnarl$(arext)
         ifeq ($(GMEM_LIB),gmemlib)
                $(AR) $(AR_FLAGS) rts/libgmem$(arext) rts/memtrack.o
-               -$(RANLIB) rts/libgmem$(arext)
+               -$(RANLIB) $(RANLIB_FLAGS) rts/libgmem$(arext)
         endif
        $(CHMOD) a-wx rts/*.ali
        touch ../stamp-gnatlib

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15156

[Bug ada/15156] gnatlink does not link due to undefined symbol _gnat__strings_E

[laurent at guerby dot net]

------- Additional Comments From laurent at guerby dot net  2004-10-02 07:22 -------
Patch passes bootstrap and test on x86 and x86_64 linux, submitted:

http://gcc.gnu.org/ml/gcc-patches/2004-10/msg00127.html

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15156

[Bug ada/15156] gnatlink does not link due to undefined symbol _gnat__strings_E

[charlet at act-europe dot fr]

------- Additional Comments From charlet at act-europe dot fr  2004-10-04 09:14 -------
Subject: Re:  gnatlink does not link due to undefined symbol _gnat__strings_E

>  RANLIB = @RANLIB@
> +RANLIB_FLAGS = @ranlib_flags@

What about the following instead ? It has the advantage of having to modify
only one line, and prevents us fromm forgetting to use RANLIB_FLAGS in other
places in the future.

- RANLIB = @RANLIB@
+ RANLIB = @RANLIB@ @ranlib_flags@

Arno


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15156

[Bug ada/15156] gnatlink does not link due to undefined symbol _gnat__strings_E

[schwab at suse dot de]

------- Additional Comments From schwab at suse dot de  2004-10-04 09:25 -------
It has the disadvantage that "make RANLIB=foobar" breaks. 

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15156

[Bug ada/15156] gnatlink does not link due to undefined symbol _gnat__strings_E

[laurent at guerby dot net]

------- Additional Comments From laurent at guerby dot net  2004-10-04 09:52 -------
Arnaud, I choosed to be coherent with what other languages are doing vs these
variables, I've no real expertise on the area.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15156

[Bug ada/15156] gnatlink does not link due to undefined symbol _gnat__strings_E

[charlet at act-europe dot fr]

------- Additional Comments From charlet at act-europe dot fr  2004-10-04 10:03 -------
Subject: Re:  gnatlink does not link due to undefined symbol _gnat__strings_E

> Arnaud, I choosed to be coherent with what other languages are doing vs these
> variables, I've no real expertise on the area.

I see. I guess I have an aversion to code duplication, so I would probably
favor another approach, but given the comment about redefining RANLIB on
the command line, your patch seems fine after all.

Arno


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15156

[Bug ada/15156] gnatlink does not link due to undefined symbol _gnat__strings_E

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-10-04 19:10 -------
Subject: Bug 15156

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	guerby@gcc.gnu.org	2004-10-04 19:10:04

Modified files:
	gcc/ada        : ChangeLog Makefile.in 

Log message:
	2004-10-04  Laurent GUERBY <laurent@guerby.net>
	
	PR ada/15156
	* Makefile.in: Define and use RANLIB_FLAGS.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ada/ChangeLog.diff?cvsroot=gcc&r1=1.595&r2=1.596
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ada/Makefile.in.diff?cvsroot=gcc&r1=1.96&r2=1.97



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15156

[Bug ada/15156] gnatlink does not link due to undefined symbol _gnat__strings_E

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-11-24 20:23 -------
Yes this is fixed. Now thanks for fixing it.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.0.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15156