public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug bootstrap/15194] New: [3.3 Regression] Fastjar configure needlessly fails without long long
@ 2004-04-29 0:17 jones at ingate dot com
2004-04-29 0:25 ` [Bug bootstrap/15194] " jones at ingate dot com
` (17 more replies)
0 siblings, 18 replies; 19+ messages in thread
From: jones at ingate dot com @ 2004-04-29 0:17 UTC (permalink / raw)
To: gcc-bugs
Configure fails in the fastjar directory if the host compiler does not support
long long. Since long long is only needed if neither sizeof(int) nor
sizeof(long) is 4 (and sizeof(long long) is), this does not make much sense.
This did not happen in GCC 3.2(.3).
--
Summary: [3.3 Regression] Fastjar configure needlessly fails
without long long
Product: gcc
Version: 3.3.3
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: bootstrap
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: jones at ingate dot com
CC: gcc-bugs at gcc dot gnu dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15194
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Bug bootstrap/15194] [3.3 Regression] Fastjar configure needlessly fails without long long
2004-04-29 0:17 [Bug bootstrap/15194] New: [3.3 Regression] Fastjar configure needlessly fails without long long jones at ingate dot com
@ 2004-04-29 0:25 ` jones at ingate dot com
2004-04-29 0:34 ` [Bug other/15194] [3.3/3.4/3.5 " pinskia at gcc dot gnu dot org
` (16 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: jones at ingate dot com @ 2004-04-29 0:25 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From jones at ingate dot com 2004-04-28 23:45 -------
Created an attachment (id=6183)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=6183&action=view)
Trivial patch to GCC 3.3
Regenerate aclocal.m4, Makefile.in and configure after applying the patch.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15194
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Bug other/15194] [3.3/3.4/3.5 Regression] Fastjar configure needlessly fails without long long
2004-04-29 0:17 [Bug bootstrap/15194] New: [3.3 Regression] Fastjar configure needlessly fails without long long jones at ingate dot com
2004-04-29 0:25 ` [Bug bootstrap/15194] " jones at ingate dot com
@ 2004-04-29 0:34 ` pinskia at gcc dot gnu dot org
2004-04-29 0:52 ` hjl at lucon dot org
` (15 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-04-29 0:34 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pinskia at gcc dot gnu dot org 2004-04-28 23:54 -------
Was broken by:
2002-06-03 Geoffrey Keating <geoffk@redhat.com>
* configure.in: Support cross-compiling.
* configure: Regenerate.
* aclocal.m4 (gcc_AC_COMPILE_CHECK_SIZEOF): New.
(gcc_AC_EXAMINE_OBJECT): New.
(fastjar_AC_COMPILE_C_BIGENDIAN): New.
So it went from AC_CHECK_SIZEOF to gcc_AC_COMPILE_CHECK_SIZEOF and to
AC_COMPILE_CHECK_SIZEOF by
2002-11-23 H.J. Lu <hjl@gnu.org>
* acinclude.m4: Include ../config/accross.m4.
(gcc_AC_COMPILE_CHECK_SIZEOF): Removed.
(gcc_AC_EXAMINE_OBJECT): Removed.
(gcc_AC_C_COMPILE_ENDIAN): Removed.
* aclocal.m4; Rebuild.
* configure.in: Replace AC_C_BIGENDIAN with AC_C_BIGENDIAN_CROSS.
Replace AC_CHECK_SIZEOF with AC_COMPILE_CHECK_SIZEOF.
* configure: Likewise.
--
What |Removed |Added
----------------------------------------------------------------------------
CC| |hjl at gnu dot org, geoffk
| |at gcc dot gnu dot org
Status|UNCONFIRMED |NEW
Component|bootstrap |other
Ever Confirmed| |1
Keywords| |build
Last reconfirmed|0000-00-00 00:00:00 |2004-04-28 23:54:06
date| |
Summary|[3.3 Regression] Fastjar |[3.3/3.4/3.5 Regression]
|configure needlessly fails |Fastjar configure needlessly
|without long long |fails without long long
Target Milestone|--- |3.3.4
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15194
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Bug other/15194] [3.3/3.4/3.5 Regression] Fastjar configure needlessly fails without long long
2004-04-29 0:17 [Bug bootstrap/15194] New: [3.3 Regression] Fastjar configure needlessly fails without long long jones at ingate dot com
2004-04-29 0:25 ` [Bug bootstrap/15194] " jones at ingate dot com
2004-04-29 0:34 ` [Bug other/15194] [3.3/3.4/3.5 " pinskia at gcc dot gnu dot org
@ 2004-04-29 0:52 ` hjl at lucon dot org
2004-06-06 3:53 ` giovannibajo at libero dot it
` (14 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: hjl at lucon dot org @ 2004-04-29 0:52 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From hjl at lucon dot org 2004-04-29 00:35 -------
Why not check long long only when it is required?
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15194
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Bug other/15194] [3.3/3.4/3.5 Regression] Fastjar configure needlessly fails without long long
2004-04-29 0:17 [Bug bootstrap/15194] New: [3.3 Regression] Fastjar configure needlessly fails without long long jones at ingate dot com
` (2 preceding siblings ...)
2004-04-29 0:52 ` hjl at lucon dot org
@ 2004-06-06 3:53 ` giovannibajo at libero dot it
2004-06-21 21:20 ` mmitchel at gcc dot gnu dot org
` (13 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: giovannibajo at libero dot it @ 2004-06-06 3:53 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From giovannibajo at libero dot it 2004-06-06 03:53 -------
Retargeting to 3.4.1, being a regression on that release branch.
--
What |Removed |Added
----------------------------------------------------------------------------
CC| |gdr at gcc dot gnu dot org
Target Milestone|3.3.4 |3.4.1
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15194
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Bug other/15194] [3.3/3.4/3.5 Regression] Fastjar configure needlessly fails without long long
2004-04-29 0:17 [Bug bootstrap/15194] New: [3.3 Regression] Fastjar configure needlessly fails without long long jones at ingate dot com
` (3 preceding siblings ...)
2004-06-06 3:53 ` giovannibajo at libero dot it
@ 2004-06-21 21:20 ` mmitchel at gcc dot gnu dot org
2004-06-25 15:31 ` kcook at gcc dot gnu dot org
` (12 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: mmitchel at gcc dot gnu dot org @ 2004-06-21 21:20 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From mmitchel at gcc dot gnu dot org 2004-06-21 21:20 -------
Geoff --
Would you please fix this PR?
-- Mark
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15194
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Bug other/15194] [3.3/3.4/3.5 Regression] Fastjar configure needlessly fails without long long
2004-04-29 0:17 [Bug bootstrap/15194] New: [3.3 Regression] Fastjar configure needlessly fails without long long jones at ingate dot com
` (4 preceding siblings ...)
2004-06-21 21:20 ` mmitchel at gcc dot gnu dot org
@ 2004-06-25 15:31 ` kcook at gcc dot gnu dot org
2004-06-25 19:12 ` aoliva at redhat dot com
` (11 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: kcook at gcc dot gnu dot org @ 2004-06-25 15:31 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From kcook at gcc dot gnu dot org 2004-06-25 15:31 -------
Subject: [fastjar] Check for "long long" before using it
This trivial patch should fix PR/15194, which was a regression from 3.2
present on 3.[345].
It was bootstrapped (with no object code changes) on i686-pc-cygwin.
Unfortunately, I do not have ready access to a compiler without long
long support, so I cannot absolutely verify does fix the reporter's bug;
though, clearly, it cannot make things worse.
OK to install?
As an aside, I've come to believe that it would be appropriate to
arrange for the toplevel Makefile so that, unless requested with a
--without-system-jar, when bootstrapping only compile fastjar for the
*build* system if there is not already a suitable "jar" present. I
think that it currently gets built and goes unused.
Clearly in a cross compile you would need to build fastjar for the host
system.
I'll think through the logic of that over the weekend, but any comments
from the build experts would be welcome.
Kelley Cook
2004-06-25 Kelley Cook <kcook@gcc.gnu.org>
* configure.ac: Add check for long long.
* jartool.h: Check for long long before using it.
* configure: Regenerate
* config.h.in: Regenerate.
diff -prud /home/kcook34/gcc-orig/fastjar/configure.ac ./configure.ac
--- /home/kcook34/gcc-orig/fastjar/configure.ac 2004-04-12 16:29:49.000000000 -0400
+++ ./configure.ac 2004-06-25 10:41:12.919581100 -0400
@@ -39,7 +39,7 @@ AC_COMPILE_CHECK_SIZEOF(char)
AC_COMPILE_CHECK_SIZEOF(short)
AC_COMPILE_CHECK_SIZEOF(int)
AC_COMPILE_CHECK_SIZEOF(long)
-AC_COMPILE_CHECK_SIZEOF(long long)
+AC_CHECK_TYPES([long long],[AC_COMPILE_CHECK_SIZEOF(long long)])
dnl Check byte order
AC_C_BIGENDIAN_CROSS
diff -prud /home/kcook34/gcc-orig/fastjar/jartool.h ./jartool.h
--- /home/kcook34/gcc-orig/fastjar/jartool.h 2000-12-08 22:08:23.000000000 -0500
+++ ./jartool.h 2004-06-25 10:49:06.742005100 -0400
@@ -90,7 +90,7 @@ typedef u_int16_t ub2;
typedef unsigned int ub4;
#elif SIZEOF_LONG == 4
typedef unsigned long ub4;
-#elif SIZEOF_LONG_LONG == 4
+#elif defined(HAVE_LONG_LONG) && SIZEOF_LONG_LONG == 4
typedef unsigned long long ub4;
#else
typedef u_int32_t ub4;
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15194
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Bug other/15194] [3.3/3.4/3.5 Regression] Fastjar configure needlessly fails without long long
2004-04-29 0:17 [Bug bootstrap/15194] New: [3.3 Regression] Fastjar configure needlessly fails without long long jones at ingate dot com
` (5 preceding siblings ...)
2004-06-25 15:31 ` kcook at gcc dot gnu dot org
@ 2004-06-25 19:12 ` aoliva at redhat dot com
2004-06-25 23:07 ` cvs-commit at gcc dot gnu dot org
` (10 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: aoliva at redhat dot com @ 2004-06-25 19:12 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From aoliva at redhat dot com 2004-06-25 18:57 -------
Subject: Re: [fastjar] Check for "long long" before using it
On Jun 25, 2004, Kelley Cook <kcook@gcc.gnu.org> wrote:
> 2004-06-25 Kelley Cook <kcook@gcc.gnu.org>
> * configure.ac: Add check for long long.
> * jartool.h: Check for long long before using it.
> * configure: Regenerate
> * config.h.in: Regenerate.
Ok, thanks.
> -#elif SIZEOF_LONG_LONG == 4
> +#elif defined(HAVE_LONG_LONG) && SIZEOF_LONG_LONG == 4
You don't really need this, BTW. If an identifier referenced in a
preprocessor clause is undefined, it evaluates to 0. I'm told some
compilers issue gratuitous warnings for such cases, though, so the
change is good. Please check it in.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15194
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Bug other/15194] [3.3/3.4/3.5 Regression] Fastjar configure needlessly fails without long long
2004-04-29 0:17 [Bug bootstrap/15194] New: [3.3 Regression] Fastjar configure needlessly fails without long long jones at ingate dot com
` (6 preceding siblings ...)
2004-06-25 19:12 ` aoliva at redhat dot com
@ 2004-06-25 23:07 ` cvs-commit at gcc dot gnu dot org
2004-06-26 0:19 ` kcook at gcc dot gnu dot org
` (9 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2004-06-25 23:07 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2004-06-25 23:07 -------
Subject: Bug 15194
CVSROOT: /cvs/gcc
Module name: gcc
Changes by: kcook@gcc.gnu.org 2004-06-25 23:06:50
Modified files:
fastjar : ChangeLog config.h.in configure configure.ac
jartool.h
Log message:
2004-06-25 Kelley Cook <kcook@gcc.gnu.org>
PR other/15194
* configure.ac: Add check for long long.
* jartool.h: Check for long long before using it.
* configure: Regenerate
* config.h.in: Regenerate.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fastjar/ChangeLog.diff?cvsroot=gcc&r1=1.65&r2=1.66
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fastjar/config.h.in.diff?cvsroot=gcc&r1=1.10&r2=1.11
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fastjar/configure.diff?cvsroot=gcc&r1=1.18&r2=1.19
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fastjar/configure.ac.diff?cvsroot=gcc&r1=1.3&r2=1.4
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fastjar/jartool.h.diff?cvsroot=gcc&r1=1.1&r2=1.2
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15194
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Bug other/15194] [3.3/3.4/3.5 Regression] Fastjar configure needlessly fails without long long
2004-04-29 0:17 [Bug bootstrap/15194] New: [3.3 Regression] Fastjar configure needlessly fails without long long jones at ingate dot com
` (7 preceding siblings ...)
2004-06-25 23:07 ` cvs-commit at gcc dot gnu dot org
@ 2004-06-26 0:19 ` kcook at gcc dot gnu dot org
2004-06-26 18:03 ` [Bug other/15194] [3.3/3.4 " kcook at gcc dot gnu dot org
` (8 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: kcook at gcc dot gnu dot org @ 2004-06-26 0:19 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From kcook at gcc dot gnu dot org 2004-06-26 00:14 -------
Subject: Re: [fastjar] Check for "long long" before using
it
Alexandre Oliva wrote:
> On Jun 25, 2004, Kelley Cook <kcook@gcc.gnu.org> wrote:
>
>
>>2004-06-25 Kelley Cook <kcook@gcc.gnu.org>
>
>
>> * configure.ac: Add check for long long.
>> * jartool.h: Check for long long before using it.
>> * configure: Regenerate
>> * config.h.in: Regenerate.
>
>
> Ok, thanks.
Mark,
OK for 3.4?
Gaby,
OK for 3.3?
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15194
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Bug other/15194] [3.3/3.4 Regression] Fastjar configure needlessly fails without long long
2004-04-29 0:17 [Bug bootstrap/15194] New: [3.3 Regression] Fastjar configure needlessly fails without long long jones at ingate dot com
` (8 preceding siblings ...)
2004-06-26 0:19 ` kcook at gcc dot gnu dot org
@ 2004-06-26 18:03 ` kcook at gcc dot gnu dot org
2004-06-28 21:24 ` tromey at redhat dot com
` (7 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: kcook at gcc dot gnu dot org @ 2004-06-26 18:03 UTC (permalink / raw)
To: gcc-bugs
--
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Last reconfirmed|2004-04-28 23:54:06 |2004-06-26 17:50:08
date| |
Summary|[3.3/3.4/3.5 Regression] |[3.3/3.4 Regression] Fastjar
|Fastjar configure needlessly|configure needlessly fails
|fails without long long |without long long
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15194
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Bug other/15194] [3.3/3.4 Regression] Fastjar configure needlessly fails without long long
2004-04-29 0:17 [Bug bootstrap/15194] New: [3.3 Regression] Fastjar configure needlessly fails without long long jones at ingate dot com
` (9 preceding siblings ...)
2004-06-26 18:03 ` [Bug other/15194] [3.3/3.4 " kcook at gcc dot gnu dot org
@ 2004-06-28 21:24 ` tromey at redhat dot com
2004-06-30 22:12 ` aoliva at redhat dot com
` (6 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: tromey at redhat dot com @ 2004-06-28 21:24 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From tromey at redhat dot com 2004-06-28 21:23 -------
Subject: Re: [fastjar] Check for "long long" before using it
>>>>> "Kelley" == Kelley Cook <kcook@gcc.gnu.org> writes:
Kelley> As an aside, I've come to believe that it would be appropriate to
Kelley> arrange for the toplevel Makefile so that, unless requested with a
Kelley> --without-system-jar, when bootstrapping only compile fastjar for the
Kelley> *build* system if there is not already a suitable "jar" present. I
Kelley> think that it currently gets built and goes unused.
Yes, for a canadian cross we just assume there is a `jar' somewhere on
$PATH.
Tom
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15194
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Bug other/15194] [3.3/3.4 Regression] Fastjar configure needlessly fails without long long
2004-04-29 0:17 [Bug bootstrap/15194] New: [3.3 Regression] Fastjar configure needlessly fails without long long jones at ingate dot com
` (10 preceding siblings ...)
2004-06-28 21:24 ` tromey at redhat dot com
@ 2004-06-30 22:12 ` aoliva at redhat dot com
2004-07-02 16:44 ` mmitchel at gcc dot gnu dot org
` (5 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: aoliva at redhat dot com @ 2004-06-30 22:12 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From aoliva at redhat dot com 2004-06-30 22:11 -------
Subject: Re: [fastjar] Check for "long long" before using it
On Jun 28, 2004, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Kelley" == Kelley Cook <kcook@gcc.gnu.org> writes:
Kelley> As an aside, I've come to believe that it would be appropriate to
Kelley> arrange for the toplevel Makefile so that, unless requested with a
Kelley> --without-system-jar, when bootstrapping only compile fastjar for the
Kelley> *build* system if there is not already a suitable "jar" present. I
Kelley> think that it currently gets built and goes unused.
> Yes, for a canadian cross we just assume there is a `jar' somewhere on
> $PATH.
IIRC Paolo has a patch that gets more stuff compiled for the build
machine. jar could certainly be one of those.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15194
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Bug other/15194] [3.3/3.4 Regression] Fastjar configure needlessly fails without long long
2004-04-29 0:17 [Bug bootstrap/15194] New: [3.3 Regression] Fastjar configure needlessly fails without long long jones at ingate dot com
` (11 preceding siblings ...)
2004-06-30 22:12 ` aoliva at redhat dot com
@ 2004-07-02 16:44 ` mmitchel at gcc dot gnu dot org
2004-07-07 3:16 ` cvs-commit at gcc dot gnu dot org
` (4 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: mmitchel at gcc dot gnu dot org @ 2004-07-02 16:44 UTC (permalink / raw)
To: gcc-bugs
--
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|3.4.1 |3.4.2
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15194
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Bug other/15194] [3.3/3.4 Regression] Fastjar configure needlessly fails without long long
2004-04-29 0:17 [Bug bootstrap/15194] New: [3.3 Regression] Fastjar configure needlessly fails without long long jones at ingate dot com
` (12 preceding siblings ...)
2004-07-02 16:44 ` mmitchel at gcc dot gnu dot org
@ 2004-07-07 3:16 ` cvs-commit at gcc dot gnu dot org
2004-07-07 3:30 ` [Bug other/15194] [3.3 " pinskia at gcc dot gnu dot org
` (3 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2004-07-07 3:16 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2004-07-07 03:16 -------
Subject: Bug 15194
CVSROOT: /cvs/gcc
Module name: gcc
Branch: gcc-3_4-branch
Changes by: kcook@gcc.gnu.org 2004-07-07 03:16:28
Modified files:
fastjar : ChangeLog config.h.in configure configure.ac
jartool.h
Log message:
2004-07-07 Kelley Cook <kcook@gcc.gnu.org>
PR other/15194
* configure.ac: Add check for long long.
* jartool.h: Check for long long before using it.
* configure: Regenerate
* config.h.in: Regenerate.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fastjar/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.61.4.3&r2=1.61.4.4
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fastjar/config.h.in.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.10&r2=1.10.4.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fastjar/configure.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.14.4.1&r2=1.14.4.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fastjar/configure.ac.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.1.4.1&r2=1.1.4.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fastjar/jartool.h.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.1&r2=1.1.88.1
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15194
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Bug other/15194] [3.3 Regression] Fastjar configure needlessly fails without long long
2004-04-29 0:17 [Bug bootstrap/15194] New: [3.3 Regression] Fastjar configure needlessly fails without long long jones at ingate dot com
` (13 preceding siblings ...)
2004-07-07 3:16 ` cvs-commit at gcc dot gnu dot org
@ 2004-07-07 3:30 ` pinskia at gcc dot gnu dot org
2004-07-07 17:53 ` kcook at gcc dot gnu dot org
` (2 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-07-07 3:30 UTC (permalink / raw)
To: gcc-bugs
--
What |Removed |Added
----------------------------------------------------------------------------
Summary|[3.3/3.4 Regression] Fastjar|[3.3 Regression] Fastjar
|configure needlessly fails |configure needlessly fails
|without long long |without long long
Target Milestone|3.4.2 |3.3.5
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15194
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Bug other/15194] [3.3 Regression] Fastjar configure needlessly fails without long long
2004-04-29 0:17 [Bug bootstrap/15194] New: [3.3 Regression] Fastjar configure needlessly fails without long long jones at ingate dot com
` (14 preceding siblings ...)
2004-07-07 3:30 ` [Bug other/15194] [3.3 " pinskia at gcc dot gnu dot org
@ 2004-07-07 17:53 ` kcook at gcc dot gnu dot org
2004-07-27 22:50 ` cvs-commit at gcc dot gnu dot org
2004-07-29 12:45 ` kcook at gcc dot gnu dot org
17 siblings, 0 replies; 19+ messages in thread
From: kcook at gcc dot gnu dot org @ 2004-07-07 17:53 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From kcook at gcc dot gnu dot org 2004-07-07 17:53 -------
Subject: [bug bootstrap/15194] [3.3] Fastjar configure fails on build compilers
without long long
Due to the fact that GCC 3.3's fastjar still used autoconf 2.13, I think
using Jones idea is more prudent than a backport from 3.4.
When examining fastjar's use of SIZEOF_* macros we can always safely set
the size to zero if it doesn't exist which makes the changes even
simpler and less risky for 3.3.5.
Tested by building fastjar on i686-pc-cygwin which resulted in no
changes compared to previous the patch.
Then I reconfigured and built with CFLAGS="-O2 -pedantic-errors" which
after this patch sets SIZEOF_LONG_LONG=0. Prior to the patch it would
error out.
Gaby (or anyone else), would this be OK for 3.3? This bug is a
regression from 3.2.
2004-07-07 Jones Desougi <jones@ingate.com>
Kelley Cook <kcook@gcc.gnu.org>
PR bootstrap/15194
* acinclude.m4 (gcc_AC_COMPILE_CHECK_SIZEOF): Return 0 when type
doesn't exist.
* aclocal.m4: Regenerate.
* configure: Regenearate.
diff -prud ../fastjar.orig/acinclude.m4 ./acinclude.m4
--- ../fastjar.orig/acinclude.m4 2002-09-09 17:19:16.000000000 -0400
+++ ./acinclude.m4 2004-07-07 13:14:45.387812200 -0400
@@ -1,6 +1,7 @@
dnl Host type sizes probe.
dnl By Kaveh R. Ghazi. One typo fixed since.
+dnl Modified to return a size of 0 if type doesn't exist
dnl
AC_DEFUN([gcc_AC_COMPILE_CHECK_SIZEOF],
[changequote(<<, >>)dnl
@@ -20,7 +21,7 @@ $2
done
])
if test x$AC_CV_NAME = x ; then
- AC_MSG_ERROR([cannot determine a size for $1])
+ AC_CV_NAME=0
fi
AC_MSG_RESULT($AC_CV_NAME)
AC_DEFINE_UNQUOTED(AC_TYPE_NAME, $AC_CV_NAME, [The number of bytes in type $1])
diff -prud ../fastjar.orig/aclocal.m4 ./aclocal.m4
--- ../fastjar.orig/aclocal.m4 2004-06-30 18:53:03.000000000 -0400
+++ ./aclocal.m4 2004-07-07 13:13:19.967539200 -0400
@@ -13,6 +13,7 @@ dnl PARTICULAR PURPOSE.
dnl Host type sizes probe.
dnl By Kaveh R. Ghazi. One typo fixed since.
+dnl Modified to return a size of 0 if type doesn't exist
dnl
AC_DEFUN([gcc_AC_COMPILE_CHECK_SIZEOF],
[changequote(<<, >>)dnl
@@ -32,7 +33,7 @@ $2
done
])
if test x$AC_CV_NAME = x ; then
- AC_MSG_ERROR([cannot determine a size for $1])
+ AC_CV_NAME=0
fi
AC_MSG_RESULT($AC_CV_NAME)
AC_DEFINE_UNQUOTED(AC_TYPE_NAME, $AC_CV_NAME, [The number of bytes in type $1])
diff -prud ../fastjar.orig/configure ./configure
--- ../fastjar.orig/configure 2004-06-30 18:53:03.000000000 -0400
+++ ./configure 2004-07-07 13:24:32.644678500 -0400
@@ -1876,7 +1876,7 @@ done
fi
if test x$ac_cv_sizeof_char = x ; then
- { echo "configure: error: cannot determine a size for char" 1>&2; exit 1; }
+ ac_cv_sizeof_char=0
fi
echo "$ac_t""$ac_cv_sizeof_char" 1>&6
cat >> confdefs.h <<EOF
@@ -1915,7 +1915,7 @@ done
fi
if test x$ac_cv_sizeof_short = x ; then
- { echo "configure: error: cannot determine a size for short" 1>&2; exit 1; }
+ ac_cv_sizeof_short=0
fi
echo "$ac_t""$ac_cv_sizeof_short" 1>&6
cat >> confdefs.h <<EOF
@@ -1954,7 +1954,7 @@ done
fi
if test x$ac_cv_sizeof_int = x ; then
- { echo "configure: error: cannot determine a size for int" 1>&2; exit 1; }
+ ac_cv_sizeof_int=0
fi
echo "$ac_t""$ac_cv_sizeof_int" 1>&6
cat >> confdefs.h <<EOF
@@ -1993,7 +1993,7 @@ done
fi
if test x$ac_cv_sizeof_long = x ; then
- { echo "configure: error: cannot determine a size for long" 1>&2; exit 1; }
+ ac_cv_sizeof_long=0
fi
echo "$ac_t""$ac_cv_sizeof_long" 1>&6
cat >> confdefs.h <<EOF
@@ -2032,7 +2032,7 @@ done
fi
if test x$ac_cv_sizeof_long_long = x ; then
- { echo "configure: error: cannot determine a size for long long" 1>&2; exit 1; }
+ ac_cv_sizeof_long_long=0
fi
echo "$ac_t""$ac_cv_sizeof_long_long" 1>&6
cat >> confdefs.h <<EOF
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15194
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Bug other/15194] [3.3 Regression] Fastjar configure needlessly fails without long long
2004-04-29 0:17 [Bug bootstrap/15194] New: [3.3 Regression] Fastjar configure needlessly fails without long long jones at ingate dot com
` (15 preceding siblings ...)
2004-07-07 17:53 ` kcook at gcc dot gnu dot org
@ 2004-07-27 22:50 ` cvs-commit at gcc dot gnu dot org
2004-07-29 12:45 ` kcook at gcc dot gnu dot org
17 siblings, 0 replies; 19+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2004-07-27 22:50 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2004-07-27 22:50 -------
Subject: Bug 15194
CVSROOT: /cvs/gcc
Module name: gcc
Branch: gcc-3_3-branch
Changes by: kcook@gcc.gnu.org 2004-07-27 22:50:20
Modified files:
fastjar : ChangeLog acinclude.m4 aclocal.m4 configure
Log message:
2004-07-27 Jones Desougi <jones@ingate.com>
Kelley Cook <kcook@gcc.gnu.org>
PR bootstrap/15194
* acinclude.m4 (gcc_AC_COMPILE_CHECK_SIZEOF): Return 0 when type
doesn't exist.
* aclocal.m4: Regenerate.
* configure: Regenearate.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fastjar/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.39.2.20&r2=1.39.2.21
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fastjar/acinclude.m4.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.1&r2=1.1.22.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fastjar/aclocal.m4.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.4&r2=1.4.8.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fastjar/configure.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.12&r2=1.12.4.1
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15194
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Bug other/15194] [3.3 Regression] Fastjar configure needlessly fails without long long
2004-04-29 0:17 [Bug bootstrap/15194] New: [3.3 Regression] Fastjar configure needlessly fails without long long jones at ingate dot com
` (16 preceding siblings ...)
2004-07-27 22:50 ` cvs-commit at gcc dot gnu dot org
@ 2004-07-29 12:45 ` kcook at gcc dot gnu dot org
17 siblings, 0 replies; 19+ messages in thread
From: kcook at gcc dot gnu dot org @ 2004-07-29 12:45 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From kcook at gcc dot gnu dot org 2004-07-29 12:45 -------
After last checkin, bug is fixed on all branches
--
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Known to work|3.5.0 3.4.2 |3.5.0 3.4.2 3.3.5
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15194
^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2004-07-29 12:45 UTC | newest]
Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-04-29 0:17 [Bug bootstrap/15194] New: [3.3 Regression] Fastjar configure needlessly fails without long long jones at ingate dot com
2004-04-29 0:25 ` [Bug bootstrap/15194] " jones at ingate dot com
2004-04-29 0:34 ` [Bug other/15194] [3.3/3.4/3.5 " pinskia at gcc dot gnu dot org
2004-04-29 0:52 ` hjl at lucon dot org
2004-06-06 3:53 ` giovannibajo at libero dot it
2004-06-21 21:20 ` mmitchel at gcc dot gnu dot org
2004-06-25 15:31 ` kcook at gcc dot gnu dot org
2004-06-25 19:12 ` aoliva at redhat dot com
2004-06-25 23:07 ` cvs-commit at gcc dot gnu dot org
2004-06-26 0:19 ` kcook at gcc dot gnu dot org
2004-06-26 18:03 ` [Bug other/15194] [3.3/3.4 " kcook at gcc dot gnu dot org
2004-06-28 21:24 ` tromey at redhat dot com
2004-06-30 22:12 ` aoliva at redhat dot com
2004-07-02 16:44 ` mmitchel at gcc dot gnu dot org
2004-07-07 3:16 ` cvs-commit at gcc dot gnu dot org
2004-07-07 3:30 ` [Bug other/15194] [3.3 " pinskia at gcc dot gnu dot org
2004-07-07 17:53 ` kcook at gcc dot gnu dot org
2004-07-27 22:50 ` cvs-commit at gcc dot gnu dot org
2004-07-29 12:45 ` kcook at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).