[Bug libfortran/15292] New: libgfortran depends on c99 functionality round and roundf

[Bug libfortran/15292] New: libgfortran depends on c99 functionality round and roundf

[rearnsha at gcc dot gnu dot org]

Testsuite failures show that libfortran contains call to the c99 functions round
and roundf.  It's not safe to assume that the system runtime environment will be
fully c99 conforming (very few, if any, are).

/work/rearnsha/gnu/gcc-ssa/arm-netbsdelf/./libgfortran/.libs/libgfortran.so: und
efined reference to `round'
/work/rearnsha/gnu/gcc-ssa/arm-netbsdelf/./libgfortran/.libs/libgfortran.so: und
efined reference to `roundf'
collect2: ld returned 1 exit status

FAIL: gfortran.fortran-torture/execute/a_edit_1.f90 compilation,  -O2 -fno-repac
k-arrays

-- 
           Summary: libgfortran depends on c99 functionality round and
                    roundf
           Product: gcc
           Version: tree-ssa
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: libfortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: rearnsha at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: arm-unknown-netbsdelf
  GCC host triplet: arm-unknown-netbsdelf
GCC target triplet: arm-unknown-netbsdelf


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15292

[Bug fortran/15292] libgfortran depends on c99 functionality round and roundf

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-05-05 11:37 -------
Confirmed, this is a bug in the Fortran front-end:
  /* We define there seperately as the fortran versions have different
     semantics (they return an integer type) */
  gfc_define_builtin ("__builtin_round", mfunc_double[0],
                      BUILT_IN_ROUND, "round", true);
  gfc_define_builtin ("__builtin_roundf", mfunc_float[0],
                      BUILT_IN_ROUNDF, "roundf", true);

Maybe the library should provide them but than again C99 has been out of almost 5 years now, 
providing basic functions as such as round should be required now for some new languages.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
          Component|libfortran                  |fortran
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2004-05-05 11:37:12
               date|                            |
   Target Milestone|---                         |tree-ssa


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15292

[Bug fortran/15292] libgfortran depends on c99 functionality round and roundf

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-05-05 11:38 -------
By the way, I can say glibc has C99 functions included since at least 2.2.5 which was released back in 
2002.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15292

[Bug fortran/15292] libgfortran depends on c99 functionality round and roundf

[rearnsha at gcc dot gnu dot org]

------- Additional Comments From rearnsha at gcc dot gnu dot org  2004-05-05 12:14 -------
Subject: Re:  libgfortran depends on c99 functionality
	round and roundf

On Wed, 2004-05-05 at 12:38, pinskia at gcc dot gnu dot org wrote:
> ------- Additional Comments From pinskia at gcc dot gnu dot org  2004-05-05 11:38 -------
> By the way, I can say glibc has C99 functions included since at least 2.2.5 which was released back in 
> 2002.

Irrelevant.  NetBSD doesn't use glibc.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15292

[Bug fortran/15292] libgfortran depends on c99 functionality round and roundf

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-05-05 12:43 -------
I was just trying to make the point that glibc added the functions and was wondering why netbsd has 
not, that is all.  Maybe we should just document that gfortran requires a C99 math library to be present, 
I think that is a good idea.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15292

[Bug fortran/15292] libgfortran depends on c99 functionality round and roundf

[rearnsha at gcc dot gnu dot org]

------- Additional Comments From rearnsha at gcc dot gnu dot org  2004-05-05 12:45 -------
Subject: Re:  libgfortran depends on c99 functionality
	round and roundf

On Wed, 2004-05-05 at 13:43, pinskia at gcc dot gnu dot org wrote:
> ------- Additional Comments From pinskia at gcc dot gnu dot org  2004-05-05 12:43 -------
> I was just trying to make the point that glibc added the functions and was wondering why netbsd has 
> not, that is all.  Maybe we should just document that gfortran requires a C99 math library to be present, 
> I think that is a good idea.

And maybe we should fix gfortran so that it doesn't need c99. 
Personally, I think that's an even better idea :-)

R.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15292

[Bug fortran/15292] libgfortran depends on c99 functionality round and roundf

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-05-05 13:03 -------
On more thing, why has the bug in netbsd for adding these functions, round and roundf been ignored.
http://www.netbsd.org/cgi-bin/query-pr-single.pl?number=24252
In fact there is a patch in there to add them.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15292

[Bug fortran/15292] libgfortran depends on c99 functionality round and roundf

[rearnsha at gcc dot gnu dot org]

------- Additional Comments From rearnsha at gcc dot gnu dot org  2004-05-05 13:24 -------
Subject: Re:  libgfortran depends on c99 functionality
	round and roundf

On Wed, 2004-05-05 at 14:03, pinskia at gcc dot gnu dot org wrote:
> ------- Additional Comments From pinskia at gcc dot gnu dot org  2004-05-05 13:03 -------
> On more thing, why has the bug in netbsd for adding these functions, round and roundf been ignored.
> http://www.netbsd.org/cgi-bin/query-pr-single.pl?number=24252
> In fact there is a patch in there to add them.

Well, it's more likely that it's just not been processed yet, there's
currently >3000 bugs outstanding.  I don't know what, if any, effort is
being put into making the C library C99 conforming [A quick search of
the mailing lists suggests that there is some activity, but it's
probably not an all-out push at this time].

Sadly NetBSD doesn't have as many folks triaging the bug database as GCC
does (and in some cases OS bugs are far harder to pin down, due to
subtle differences in HW).

In any case, that wouldn't affect NetBSD 1.6.x which is the last public
release.  Nor is it likely now to affect 2.0 when that comes out (since
the release branch has now been cut).

R.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15292

[Bug libfortran/15292] libgfortran depends on c99 functionality round and roundf

[toon at moene dot indiv dot nluug dot nl]

------- Additional Comments From toon at moene dot indiv dot nluug dot nl  2004-05-29 13:32 -------
This is a libfortran problem, not a front end one.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|fortran                     |libfortran


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15292

[Bug libfortran/15292] libgfortran depends on c99 functionality round and roundf

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-06-12 17:59 -------
Subject: Bug 15292

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	pbrook@gcc.gnu.org	2004-06-12 17:59:31

Modified files:
	libgfortran    : ChangeLog Makefile.am Makefile.in config.h.in 
	                 configure configure.ac 
Added files:
	libgfortran/intrinsics: c99_functions.c 

Log message:
	PR gfortran/15292
	* intrinsics/c99_functions.c: New file.
	* Makefile.am: Add new file.
	* configure.ac: Added test for round/roundf.
	* Makefile.in: Regenerate.
	* configure: Regenerate.
	* configure.h.in: Regenerate.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/ChangeLog.diff?cvsroot=gcc&r1=1.31&r2=1.32
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/Makefile.am.diff?cvsroot=gcc&r1=1.9&r2=1.10
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/Makefile.in.diff?cvsroot=gcc&r1=1.9&r2=1.10
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/config.h.in.diff?cvsroot=gcc&r1=1.2&r2=1.3
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/configure.diff?cvsroot=gcc&r1=1.5&r2=1.6
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/configure.ac.diff?cvsroot=gcc&r1=1.1&r2=1.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/intrinsics/c99_functions.c.diff?cvsroot=gcc&r1=NONE&r2=1.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15292

[Bug libfortran/15292] libgfortran depends on c99 functionality round and roundf

[pbrook at gcc dot gnu dot org]

------- Additional Comments From pbrook at gcc dot gnu dot org  2004-06-12 18:01 -------
Should be fixed now. 

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15292

[Bug libfortran/15292] libgfortran depends on c99 functionality round and roundf

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-06-14 17:27 -------
Subject: Bug 15292

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	bdavis@gcc.gnu.org	2004-06-14 17:27:21

Modified files:
	libgfortran    : ChangeLog 
	libgfortran/intrinsics: c99_functions.c 

Log message:
	2004-06-14  Bud Davis  <bdavis9659@comcast.net>
	
	PR gfortran/15292
	* intrinsics/c99_functions.c: Use fpclassify if it exists.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/ChangeLog.diff?cvsroot=gcc&r1=1.35&r2=1.36
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/intrinsics/c99_functions.c.diff?cvsroot=gcc&r1=1.1&r2=1.2



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15292