[Bug libstdc++/15390] New: No DESTDIR for libstdc++ includes

[Bug libstdc++/15390] New: No DESTDIR for libstdc++ includes

[lloyd at must-have-coffee dot gen dot nz]

Files from libstdc++-v3/include/bits cannot be installed when DESTDIR is set.
The definition of DESTDIR is being ignored. This appears to be because even
though libstdc++-v3/include/Makefile.am doesn't recurse through subdirs, make
does call itself recursively and the definitions of AM_MAKEFLAGS and
FLAGS_TO_PASS aren't set up for this. The error messages are rather long, so
I'll add them as an attachment. I'm in the process of creating and testing a
patch but that may take several days.

-- 
           Summary: No DESTDIR for libstdc++ includes
           Product: gcc
           Version: 3.3.3
            Status: UNCONFIRMED
          Severity: critical
          Priority: P2
         Component: libstdc++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: lloyd at must-have-coffee dot gen dot nz
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: sparc-sun-solaris2.8
  GCC host triplet: sparc-sun-solaris2.8
GCC target triplet: sparc-sun-solaris2.8


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15390

[Bug libstdc++/15390] No DESTDIR for libstdc++ includes

[lloyd at must-have-coffee dot gen dot nz]

------- Additional Comments From lloyd at must-have-coffee dot gen dot nz  2004-05-12 04:07 -------
Created an attachment (id=6261)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=6261&action=view)
Error messages from make


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15390

[Bug libstdc++/15390] No DESTDIR for libstdc++ includes

[ebotcazou at gcc dot gnu dot org]

------- Additional Comments From ebotcazou at gcc dot gnu dot org  2004-05-12 06:12 -------
You also may want to test GCC 3.4.0 in order to see whether the problem has not
already been fixed.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ebotcazou at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15390

[Bug libstdc++/15390] No DESTDIR for libstdc++ includes

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-05-12 11:38 -------
Confirmed on the mainline:
install-am: all-am
        @$(MAKE) $(AM_MAKEFLAGS) install-exec-am install-data-am

AM_MAKEFLAGS is not set in listdc++/incude/Makefile.in at all but then again if I read why 
AM_MAKEFLAGS is set is to "work around what appears to be a GNU make bug handling MAKEFLAGS".

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |minor
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2004-05-12 11:38:42
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15390

[Bug libstdc++/15390] No DESTDIR for libstdc++ includes

[lloyd at must-have-coffee dot gen dot nz]

------- Additional Comments From lloyd at must-have-coffee dot gen dot nz  2004-05-13 05:24 -------
This also affects libstdc++-v3/libsupc++.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15390

[Bug libstdc++/15390] No DESTDIR for libstdc++ includes

[bkoz at gcc dot gnu dot org]

------- Additional Comments From bkoz at gcc dot gnu dot org  2004-05-13 16:03 -------

Let us know when you have a patch.

-benjamin

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15390

[Bug libstdc++/15390] No DESTDIR for libstdc++ includes

[bkoz at gcc dot gnu dot org]

------- Additional Comments From bkoz at gcc dot gnu dot org  2004-05-24 16:46 -------

Install log (working) was created with 3.4.0/3.5.0 sources. 

In the provided log that is not working, it looks like there is an issue with
permissions on the actual DESDIR argument provided.

-benjamin

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15390

[Bug libstdc++/15390] No DESTDIR for libstdc++ includes

[lloyd at must-have-coffee dot gen dot nz]

------- Additional Comments From lloyd at must-have-coffee dot gen dot nz  2004-05-25 06:06 -------
The permission denied message is because the DESTDIR is being thown away and make is trying to 
install gcc into the wrong directory. 
I tried adding a comment to say that GNU make doesn't suffer from this problem (only Solaris make) 
and so this problem can't occur in GCC 3.4.0 even though the Makefiles still contain the dodgy code.
That comment didn't make it into bugzilla for some reason.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15390

[Bug libstdc++/15390] [3.3.x] No DESTDIR for libstdc++ includes

[bkoz at gcc dot gnu dot org]

------- Additional Comments From bkoz at gcc dot gnu dot org  2004-05-27 18:37 -------

Modified the bug title.

Can you point out, exactly, where the makefiles are "dodgy?" I'm still unclear
on what the problem is, and how you propose to fix it. 

Providing a patch would be quite helpful, but if that doesn't happen, can you be
a bit more elaborate on where the problem is?

best,
benjamin

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|No DESTDIR for libstdc++    |[3.3.x] No DESTDIR for
                   |includes                    |libstdc++ includes


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15390

[Bug libstdc++/15390] [3.3.x] No DESTDIR for libstdc++ includes

[lloyd at must-have-coffee dot gen dot nz]

------- Additional Comments From lloyd at must-have-coffee dot gen dot nz  2004-06-03 00:59 -------
(In reply to comment #10)

> Providing a patch would be quite helpful, but if that doesn't happen, can you be
> a bit more elaborate on where the problem is?

A patch is not required because the problem doesn't happen with gmake and gmake
has already been made a requirement for any future release of GCC that a fix for
this bug might be targeted at. 

The recursive make problem is quite well known amongst people who know about it
(sic). When using make recursively you might have a rule like this

WORLD=Wellington
all: 
    $(MAKE) do-all
do-all:
    echo Hello $(WORLD)

When you type "make all", you get "Hello Wellington". Lovely. When you type
"make WORLD=World", you get "Hello Wellington". Oops. We just lost our $(WORLD).
 This is because Solaris (and probably most other) makes export the make
variables as environment variables, but those get overridden by the Makefile.

Some make commands do magic to work around this wart. They know that when the
user says "WORLD=World" on the command line, then they want the "World".The
NetBSD make examines its command line parameters and stores variable
assignments. Whenever it sees a rule trying to run make it rewrites the rule
internally to include these variable assignments on the command line. You can't
normally see it do this.

Some of the Makefiles in GCC have a workaround for makes that do not do this
variable assignment magic. All recipes that run $(MAKE) look like this

target: this that the-other
    $(MAKE) $(AM_MAKEFLAGS) build-target

And the the AM_MAKFLAGS variable is set to a series of variable assignments for
every variable that might be used on the command line. It's usually a fairly
long list. Something like this

AM_MAKEFLAGS="DESTDIR=$(DESTDIR)" "AR_FLAGS=$(AR_FLAGS)" ...

The dodgy Makefiles have $(AM_MAKEFLAGS) in recursive rules, but they never set
AM_MAKEFLAGS. As far as I can tell all the Makefiles use AM_MAKEFLAGS, but only
about half of them define the variable. 

But as I said, GNU make doesn't require this explicit support for setting make
variables on the command line and GNU make is now required.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15390

[Bug libstdc++/15390] [3.3.x] No DESTDIR for libstdc++ includes

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-06-03 01:02 -------
So closing will not fix.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WONTFIX
   Target Milestone|---                         |3.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15390