[Bug tree-optimization/15460] New: wrong code with -O2 -fno-tree-dominator-opts

[Bug tree-optimization/15460] New: wrong code with -O2 -fno-tree-dominator-opts

[belyshev at lubercy dot com]

$ gcc bug4.i -static -std=gnu99 -O2 -fno-tree-dominator-opts
$ ./a.out
Aborted

$ gcc bug4.i -static -std=gnu99 -O2
$ ./a.out
$

This testcase minimized from glibc/string/test-strpbrk.c

-- 
           Summary: wrong code with -O2 -fno-tree-dominator-opts
           Product: gcc
           Version: 3.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: tree-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: belyshev at lubercy dot com
                CC: gcc-bugs at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15460

[Bug tree-optimization/15460] wrong code with -O2 -fno-tree-dominator-opts

[belyshev at lubercy dot com]

------- Additional Comments From belyshev at lubercy dot com  2004-05-15 12:41 -------
Created an attachment (id=6300)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=6300&action=view)
testcase (7962 bytes)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15460

[Bug tree-optimization/15460] wrong code with -O2 -fno-tree-dominator-opts

[belyshev at lubercy dot com]

------- Additional Comments From belyshev at lubercy dot com  2004-05-15 15:46 -------
Minimized testcase:

cat > bug.i << EOF
static void do_random_tests(void)
{
	unsigned int pos, len;

	pos = random ();
	len = 4294967294;

	if (pos > len) {
		len = pos;
//		len = 0;
	}
	
	printf ("%u\n", pos < len ? pos : len);
	printf ("%u\n", pos < len ? pos : len);
}

int main(void)
{
	do_random_tests();
	return 0;
}
EOF
gcc bug.i -O -funit-at-a-time -fno-tree-dominator-opts
./a.out
1804289383
4294967294

After uncommenting:
4294967294
4294967294


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15460

[Bug tree-optimization/15460] wrong code with -O2 -fno-tree-dominator-opts

[belyshev at lubercy dot com]

------- Additional Comments From belyshev at lubercy dot com  2004-05-15 15:50 -------
Created an attachment (id=6303)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=6303&action=view)
minimized testcase (394 bytes)


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #6300 is|0                           |1
           obsolete|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15460

[Bug tree-optimization/15460] [3.5 Regression] [SSAPRE] wrong code with -O2 -fno-tree-dominator-opts

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-05-15 16:02 -------
Confirmed.  This is a dup with pre.

Danny, could you look at this or is this fixed with GVNPRE?

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dberlin at gcc dot gnu dot
                   |                            |org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
           Keywords|                            |wrong-code
   Last reconfirmed|0000-00-00 00:00:00         |2004-05-15 16:02:28
               date|                            |
            Summary|wrong code with -O2 -fno-   |[3.5 Regression] [SSAPRE]
                   |tree-dominator-opts         |wrong code with -O2 -fno-
                   |                            |tree-dominator-opts
   Target Milestone|---                         |3.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15460

[Bug tree-optimization/15460] [3.5 Regression] [SSAPRE] wrong code with -O2 -fno-tree-dominator-opts

[dberlin at gcc dot gnu dot org]

------- Additional Comments From dberlin at gcc dot gnu dot org  2004-06-10 16:18 -------
Fixed by GVNPRE

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2004-05-15 16:02:28         |2004-06-10 16:18:53
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15460

[Bug tree-optimization/15460] [3.5 Regression] [SSAPRE] wrong code with -O2 -fno-tree-dominator-opts

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-06-12 00:18 -------
Subject: Bug 15460

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	dberlin@gcc.gnu.org	2004-06-12 00:18:36

Modified files:
	gcc            : ChangeLog tree-dfa.c tree-flow-inline.h 
	                 tree-flow.h tree-ssa-dce.c tree-ssa-pre.c 
	                 tree.h 
	gcc/testsuite/gcc.dg/tree-ssa: ssa-pre-1.c ssa-pre-2.c 
Added files:
	gcc/testsuite/gcc.c-torture/compile: 20040611-1.c 

Log message:
	2004-06-11  Steven Bosscher <stevenb@suse.de>
	
	* tree-ssa-dce.c (mark_control_dependent_edges_necessary):
	Don't try to mark anything control dependent on the entry or
	exit blocks.
	
	2004-06-11  Daniel Berlin  <dberlin@dberlin.org>
	
	Fix Bug 15899
	Fix Bug 15460
	* tree.h (SSA_NAME_VALUE): New macro.
	(struct tree_ssa_name): Add value_handle member.
	* tree-ssa-pre.c: Replaced.
	* tree-flow.h (tree_ann_type): Add CST_ANN, EXPR_ANN.
	(struct cst_ann_d): New.
	(struct expr_ann_d): New.
	(union tree_ann_d): Add cst_ann, expr_ann.
	* tree-dfa.c (create_cst_ann): New function.
	(create_expr_ann): Ditto.
	* tree-flow-inline.h (cst_ann): New function.
	(expr_ann): Ditto.
	(get_cst_ann): Ditto.
	(get_expr_ann): Ditto..

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.3934&r2=2.3935
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/tree-dfa.c.diff?cvsroot=gcc&r1=2.7&r2=2.8
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/tree-flow-inline.h.diff?cvsroot=gcc&r1=2.4&r2=2.5
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/tree-flow.h.diff?cvsroot=gcc&r1=2.7&r2=2.8
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/tree-ssa-dce.c.diff?cvsroot=gcc&r1=2.5&r2=2.6
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/tree-ssa-pre.c.diff?cvsroot=gcc&r1=2.6&r2=2.7
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/tree.h.diff?cvsroot=gcc&r1=1.510&r2=1.511
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.c-torture/compile/20040611-1.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/tree-ssa/ssa-pre-1.c.diff?cvsroot=gcc&r1=1.2&r2=1.3
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/tree-ssa/ssa-pre-2.c.diff?cvsroot=gcc&r1=1.2&r2=1.3



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15460

[Bug tree-optimization/15460] [3.5 Regression] [SSAPRE] wrong code with -O2 -fno-tree-dominator-opts

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-06-12 03:31 -------
Fixed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15460