public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/15586] New: gfortran should support i18n
@ 2004-05-23 10:00 jsm28 at gcc dot gnu dot org
  2004-05-23 11:18 ` [Bug fortran/15586] " pinskia at gcc dot gnu dot org
                   ` (9 more replies)
  0 siblings, 10 replies; 11+ messages in thread
From: jsm28 at gcc dot gnu dot org @ 2004-05-23 10:00 UTC (permalink / raw)
  To: gcc-bugs

gfortran should support i18n by arranging for English-language
strings in messages to go in gcc.pot and get translated in output.

See <http://gcc.gnu.org/ml/fortran/2004-05/msg00165.html>
and ABOUT-GCC-NLS for more notes on what's involved.

(You could consider this a regression from g77, which did support i18n.)

-- 
           Summary: gfortran should support i18n
           Product: gcc
           Version: 3.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: jsm28 at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15586


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug fortran/15586] gfortran should support i18n
  2004-05-23 10:00 [Bug fortran/15586] New: gfortran should support i18n jsm28 at gcc dot gnu dot org
@ 2004-05-23 11:18 ` pinskia at gcc dot gnu dot org
  2004-05-26 20:06 ` [Bug fortran/15586] [3.5? Regression] " pinskia at gcc dot gnu dot org
                   ` (8 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-05-23 11:18 UTC (permalink / raw)
  To: gcc-bugs



-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |diagnostic


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15586


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug fortran/15586] [3.5? Regression] gfortran should support i18n
  2004-05-23 10:00 [Bug fortran/15586] New: gfortran should support i18n jsm28 at gcc dot gnu dot org
  2004-05-23 11:18 ` [Bug fortran/15586] " pinskia at gcc dot gnu dot org
@ 2004-05-26 20:06 ` pinskia at gcc dot gnu dot org
  2004-06-09 15:08 ` lennox at cs dot columbia dot edu
                   ` (7 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-05-26 20:06 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From pinskia at gcc dot gnu dot org  2004-05-26 13:40 -------
Confirmed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2004-05-26 13:40:09
               date|                            |
            Summary|gfortran should support i18n|[3.5? Regression] gfortran
                   |                            |should support i18n
   Target Milestone|---                         |3.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15586


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug fortran/15586] [3.5? Regression] gfortran should support i18n
  2004-05-23 10:00 [Bug fortran/15586] New: gfortran should support i18n jsm28 at gcc dot gnu dot org
  2004-05-23 11:18 ` [Bug fortran/15586] " pinskia at gcc dot gnu dot org
  2004-05-26 20:06 ` [Bug fortran/15586] [3.5? Regression] " pinskia at gcc dot gnu dot org
@ 2004-06-09 15:08 ` lennox at cs dot columbia dot edu
  2004-06-09 17:01 ` tobi at gcc dot gnu dot org
                   ` (6 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: lennox at cs dot columbia dot edu @ 2004-06-09 15:08 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From lennox at cs dot columbia dot edu  2004-06-09 15:07 -------
Also note that diagnostics can't be built up out of pieces, because different
languages have different word orders, conjugations, declensions, and the like. 
For example, this code in gcc/fortran/resolve.c:

      gfc_error ("Assumed %s array at %L must be a dummy argument",
                sym->as->type == AS_ASSUMED_SIZE ? "size" : "shape",
                 &sym->declared_at);

would need to be two different error messages, conditionalized on the value of
sym->as->type.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15586


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug fortran/15586] [3.5? Regression] gfortran should support i18n
  2004-05-23 10:00 [Bug fortran/15586] New: gfortran should support i18n jsm28 at gcc dot gnu dot org
                   ` (2 preceding siblings ...)
  2004-06-09 15:08 ` lennox at cs dot columbia dot edu
@ 2004-06-09 17:01 ` tobi at gcc dot gnu dot org
  2004-12-01 18:17 ` [Bug fortran/15586] [4.0 Regression] gfortran should support i18n in its compiler messages mmitchel at gcc dot gnu dot org
                   ` (5 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: tobi at gcc dot gnu dot org @ 2004-06-09 17:01 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From tobi at gcc dot gnu dot org  2004-06-09 17:01 -------
(In reply to comment #2) 
> For example, this code in gcc/fortran/resolve.c:
> 
>       gfc_error ("Assumed %s array at %L must be a dummy argument",
>                 sym->as->type == AS_ASSUMED_SIZE ? "size" : "shape",
>                  &sym->declared_at);
> 

A quick check for other such lines:
[tobi@marktplatz fortran]$ grep -n "[?] [\"]" *c
error.c:430:      error_string (have_l1 ? "(2)" : "(1)");
iresolve.c:804:  name = mask ? "mmaxloc" : "maxloc";
iresolve.c:825:    gfc_get_string ("__%s_%c%d", mask ? "mmaxval" : "maxval",
iresolve.c:867:  name = mask ? "mminloc" : "minloc";
iresolve.c:887:    gfc_get_string ("__%s_%c%d", mask ? "mminval" : "minval",
iresolve.c:976:    gfc_get_string ("__%s_%c%d", mask ? "mproduct" : "product",
iresolve.c:1207:    gfc_get_string ("__%s_%c%d", mask ? "msum" : "sum",
resolve.c:3740:          sym->as->type == AS_ASSUMED_SIZE ? "size" : "shape",
scanner.c:1098:                    (filename[0] == '\0') ? "<stdin>" : filename);
trans-intrinsic.c:521:          ts->type == BT_COMPLEX ? "c" : "",
trans-intrinsic.c:523:          ts->kind == 4 ? "f" : "");

The only other line which is related to error printing is the one in error.c. It
chooses between "(1)" and "(2)", which are used for designating source locations
in error messages. They should be the same in all locales, so this poses no
problem to i18n.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tobi at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15586


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug fortran/15586] [4.0 Regression] gfortran should support i18n in its compiler messages
  2004-05-23 10:00 [Bug fortran/15586] New: gfortran should support i18n jsm28 at gcc dot gnu dot org
                   ` (3 preceding siblings ...)
  2004-06-09 17:01 ` tobi at gcc dot gnu dot org
@ 2004-12-01 18:17 ` mmitchel at gcc dot gnu dot org
  2004-12-03 12:50 ` [Bug fortran/15586] " steven at gcc dot gnu dot org
                   ` (4 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: mmitchel at gcc dot gnu dot org @ 2004-12-01 18:17 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From mmitchel at gcc dot gnu dot org  2004-12-01 18:17 -------
I do not consider this a regression, as grotran is new, so I've removed the
target milestone.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.0.0                       |---


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15586


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug fortran/15586] gfortran should support i18n in its compiler messages
  2004-05-23 10:00 [Bug fortran/15586] New: gfortran should support i18n jsm28 at gcc dot gnu dot org
                   ` (4 preceding siblings ...)
  2004-12-01 18:17 ` [Bug fortran/15586] [4.0 Regression] gfortran should support i18n in its compiler messages mmitchel at gcc dot gnu dot org
@ 2004-12-03 12:50 ` steven at gcc dot gnu dot org
  2005-04-15  8:39 ` fxcoudert at gcc dot gnu dot org
                   ` (3 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: steven at gcc dot gnu dot org @ 2004-12-03 12:50 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From steven at gcc dot gnu dot org  2004-12-03 12:50 -------
Not a regression says the RM.

gfortran should move to the generic GCC diagnostics machinery anyway,
hopefully for GCC 4.1.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.0 Regression] gfortran   |gfortran should support i18n
                   |should support i18n in its  |in its compiler messages
                   |compiler messages           |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15586


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug fortran/15586] gfortran should support i18n in its compiler messages
  2004-05-23 10:00 [Bug fortran/15586] New: gfortran should support i18n jsm28 at gcc dot gnu dot org
                   ` (5 preceding siblings ...)
  2004-12-03 12:50 ` [Bug fortran/15586] " steven at gcc dot gnu dot org
@ 2005-04-15  8:39 ` fxcoudert at gcc dot gnu dot org
  2005-09-04 20:42 ` fxcoudert at gcc dot gnu dot org
                   ` (2 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: fxcoudert at gcc dot gnu dot org @ 2005-04-15  8:39 UTC (permalink / raw)
  To: gcc-bugs



-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fxcoudert at gcc dot gnu dot
                   |                            |org
   Last reconfirmed|2005-03-04 04:03:01         |2005-04-15 08:39:35
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15586


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug fortran/15586] gfortran should support i18n in its compiler messages
  2004-05-23 10:00 [Bug fortran/15586] New: gfortran should support i18n jsm28 at gcc dot gnu dot org
                   ` (6 preceding siblings ...)
  2005-04-15  8:39 ` fxcoudert at gcc dot gnu dot org
@ 2005-09-04 20:42 ` fxcoudert at gcc dot gnu dot org
  2005-09-17 18:58 ` cvs-commit at gcc dot gnu dot org
  2005-09-17 19:02 ` fxcoudert at gcc dot gnu dot org
  9 siblings, 0 replies; 11+ messages in thread
From: fxcoudert at gcc dot gnu dot org @ 2005-09-04 20:42 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From fxcoudert at gcc dot gnu dot org  2005-09-04 20:42 -------
Patch about that under review here:
http://gcc.gnu.org/ml/gcc-patches/2005-09/msg00062.html

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2005-
                   |                            |09/msg00062.html
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15586


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug fortran/15586] gfortran should support i18n in its compiler messages
  2004-05-23 10:00 [Bug fortran/15586] New: gfortran should support i18n jsm28 at gcc dot gnu dot org
                   ` (7 preceding siblings ...)
  2005-09-04 20:42 ` fxcoudert at gcc dot gnu dot org
@ 2005-09-17 18:58 ` cvs-commit at gcc dot gnu dot org
  2005-09-17 19:02 ` fxcoudert at gcc dot gnu dot org
  9 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-09-17 18:58 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-09-17 18:58 -------
Subject: Bug 15586

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	fxcoudert@gcc.gnu.org	2005-09-17 18:58:11

Modified files:
	gcc/fortran    : ChangeLog arith.c array.c check.c error.c 
	                 expr.c gfortran.h gfortranspec.c io.c 
	                 matchexp.c misc.c module.c parse.c primary.c 
	                 resolve.c symbol.c trans-const.c 
	gcc/po         : ChangeLog exgettext gcc.pot 

Log message:
	PR fortran/15586
	
	* arith.c (gfc_arith_error): Add translation support
	for error messages.
	* array.c (gfc_match_array_ref): Likewise.
	(gfc_match_array_spec): Likewise.
	* check.c (must_be): Add msgid convention to third argument.
	(same_type_check): Add translation support for error message.
	(rank_check): Likewise.
	(kind_value_check): Likewise.
	(gfc_check_associated): Correct typo.
	(gfc_check_reshape): Add translation support for error message.
	(gfc_check_spread): Likewise.
	* error.c (error_printf): Add nocmsgid convention to argument.
	(gfc_warning, gfc_notify_std, gfc_warning_now, gfc_warning_check)
	(gfc_error, gfc_error_now): Likewise.
	(gfc_status): Add cmsgid convention to argument.
	* expr.c (gfc_extract_int): Add translation support
	for error messages.
	(gfc_check_conformance): Add msgid convention to argument.
	(gfc_check_pointer_assign): Correct tabbing.
	* gfortran.h: Include intl.h header. Remove prototype
	for gfc_article.
	* gfortranspec.c: Include intl.h header.
	(lang_specific_driver): Add translation support for --version.
	* io.c (check_format): Add translation support for
	error message.
	(format_item_1): Likewise.
	(data_desc): Likewise.
	* matchexp.c: Likewise.
	* misc.c (gfc_article): Remove function.
	* module.c (bad_module): Use msgid convention. Add
	translation support for error messages.
	(require_atom): Add translation support for error messages.
	* parse.c (gfc_ascii_statement): Likewise.
	(gfc_state_name): Likewise.
	* primary.c (match_boz_constant): Reorganise error
	messages for translations.
	* resolve.c (resolve_entries): Likewise.
	(resolve_operator): Add translation support for error messages.
	(gfc_resolve_expr): Use msgid convention. Reorganise error
	messages for translations.
	(resolve_symbol): Add translation support for error messages.
	* symbol.c (gfc_add_procedure): Remove use of gfc_article function.
	* trans-const.c (gfc_build_string_const): Use msgid convention.
	
	* exgettext: Add a new nocmsgid convention for arguments
	that should be marked as no-c-format.
	* gcc.pot: Regenerate.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/ChangeLog.diff?cvsroot=gcc&r1=1.556&r2=1.557
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/arith.c.diff?cvsroot=gcc&r1=1.30&r2=1.31
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/array.c.diff?cvsroot=gcc&r1=1.19&r2=1.20
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/check.c.diff?cvsroot=gcc&r1=1.33&r2=1.34
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/error.c.diff?cvsroot=gcc&r1=1.15&r2=1.16
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/expr.c.diff?cvsroot=gcc&r1=1.28&r2=1.29
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/gfortran.h.diff?cvsroot=gcc&r1=1.86&r2=1.87
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/gfortranspec.c.diff?cvsroot=gcc&r1=1.9&r2=1.10
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/io.c.diff?cvsroot=gcc&r1=1.32&r2=1.33
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/matchexp.c.diff?cvsroot=gcc&r1=1.10&r2=1.11
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/misc.c.diff?cvsroot=gcc&r1=1.10&r2=1.11
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/module.c.diff?cvsroot=gcc&r1=1.36&r2=1.37
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/parse.c.diff?cvsroot=gcc&r1=1.30&r2=1.31
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/primary.c.diff?cvsroot=gcc&r1=1.36&r2=1.37
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/resolve.c.diff?cvsroot=gcc&r1=1.52&r2=1.53
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/symbol.c.diff?cvsroot=gcc&r1=1.33&r2=1.34
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/trans-const.c.diff?cvsroot=gcc&r1=1.30&r2=1.31
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/po/ChangeLog.diff?cvsroot=gcc&r1=1.167&r2=1.168
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/po/exgettext.diff?cvsroot=gcc&r1=1.13&r2=1.14
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/po/gcc.pot.diff?cvsroot=gcc&r1=1.37&r2=1.38



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15586


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug fortran/15586] gfortran should support i18n in its compiler messages
  2004-05-23 10:00 [Bug fortran/15586] New: gfortran should support i18n jsm28 at gcc dot gnu dot org
                   ` (8 preceding siblings ...)
  2005-09-17 18:58 ` cvs-commit at gcc dot gnu dot org
@ 2005-09-17 19:02 ` fxcoudert at gcc dot gnu dot org
  9 siblings, 0 replies; 11+ messages in thread
From: fxcoudert at gcc dot gnu dot org @ 2005-09-17 19:02 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From fxcoudert at gcc dot gnu dot org  2005-09-17 19:01 -------
Keeping open for translation problems remaining (diagnostics built from pieces).

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|19292                       |
              nThis|                            |
                URL|http://gcc.gnu.org/ml/gcc-  |
                   |patches/2005-               |
                   |09/msg00062.html            |
           Keywords|patch                       |
            Version|4.0.0                       |4.1.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15586


^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2005-09-17 19:02 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-05-23 10:00 [Bug fortran/15586] New: gfortran should support i18n jsm28 at gcc dot gnu dot org
2004-05-23 11:18 ` [Bug fortran/15586] " pinskia at gcc dot gnu dot org
2004-05-26 20:06 ` [Bug fortran/15586] [3.5? Regression] " pinskia at gcc dot gnu dot org
2004-06-09 15:08 ` lennox at cs dot columbia dot edu
2004-06-09 17:01 ` tobi at gcc dot gnu dot org
2004-12-01 18:17 ` [Bug fortran/15586] [4.0 Regression] gfortran should support i18n in its compiler messages mmitchel at gcc dot gnu dot org
2004-12-03 12:50 ` [Bug fortran/15586] " steven at gcc dot gnu dot org
2005-04-15  8:39 ` fxcoudert at gcc dot gnu dot org
2005-09-04 20:42 ` fxcoudert at gcc dot gnu dot org
2005-09-17 18:58 ` cvs-commit at gcc dot gnu dot org
2005-09-17 19:02 ` fxcoudert at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).