[Bug c/15698] New: wrong error in presence of builtin fn + K&R declaration.

[Bug c/15698] New: wrong error in presence of builtin fn + K&R declaration.

[cgd at broadcom dot com]

trunk srcs as of 2004-05-27 00:00 UTC.

attachment compiled like "gcc x.c" produces error like:

x.c: In function `rindex':
x.c:16: error: argument 'a' doesn't match prototype
x.c:2: error: prototype declaration

whereas the actual prototype declaration is is built-in.  I tried to
trim the test further, and that made it work as expected, producing:

x.c: In function `rindex':
x.c:16: error: argument 'a' doesn't match prototype
cc1: error: prototype declaration

-- 
           Summary: wrong error in presence of builtin fn + K&R declaration.
           Product: gcc
           Version: 3.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: c
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: cgd at broadcom dot com
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: mips64-unknown-linux-gnu
  GCC host triplet: mips64-unknown-linux-gnu
GCC target triplet: mips64-unknown-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15698

[Bug c/15698] wrong error in presence of builtin fn + K&R declaration.

[cgd at broadcom dot com]

------- Additional Comments From cgd at broadcom dot com  2004-05-28 05:26 -------
Created an attachment (id=6410)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=6410&action=view)
test case to trigger problem.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15698

[Bug c/15698] [3.5 Regression] wrong error in presence of builtin fn + K&R declaration.

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-05-28 11:22 -------
Confirmed, for some reason I can only confirm this with rindex, I tried to do the same for sqrt and exp 
but they would not cause the error.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zack at gcc dot gnu dot org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
           Keywords|                            |rejects-valid
   Last reconfirmed|0000-00-00 00:00:00         |2004-05-28 11:22:55
               date|                            |
            Summary|wrong error in presence of  |[3.5 Regression] wrong error
                   |builtin fn + K&R            |in presence of builtin fn +
                   |declaration.                |K&R declaration.
   Target Milestone|---                         |3.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15698

[Bug c/15698] [3.5 Regression] wrong error in presence of builtin fn + K&R declaration.

[cgd at broadcom dot com]

------- Additional Comments From cgd at broadcom dot com  2004-05-28 17:34 -------
Subject: Re:  [3.5 Regression] wrong error in presence of
 builtin fn + K&R declaration.

At 28 May 2004 11:22:58 -0000, pinskia at gcc dot gnu dot org wrote:
> Confirmed, for some reason I can only confirm this with rindex, I tried to do the same for sqrt and exp 
> but they would not cause the error.

yeah, it seemed very fragile.  Maybe something about argument types
or number of arguments, who knows.


chris




-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15698

[Bug c/15698] [3.5 Regression] wrong error in presence of builtin fn + K&R declaration.

[wilson at gcc dot gnu dot org]

------- Additional Comments From wilson at gcc dot gnu dot org  2004-06-01 02:00 -------
The problem is the variable current_function_prototype_locus in c-decl.c.  It is
set conditionally, but then used unconditionally for error messages.  The result
is that if it wasn't set before it was used, then you get an old incorrect
value.  You can potentially get an uninitialized value if it was never set, but
since it is a global that just gives a value of zero.  In this case, when foobar
is redeclared, it is set to line 2, then when rindex is redeclared, it is not
set because rindex is a builtin, and then later we print line 2 as if that was
where rindex was first declared.  It should be cleared if we don't set it, or
alternately, it shouldn't be used if it wasn't set.

I can reproduce the same problem with exp.  You have to change the return type
to match, i.e. change both decls to use double instead of char *.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15698

[Bug c/15698] [3.5 Regression] wrong error in presence of builtin fn + K&R declaration.

[zack at gcc dot gnu dot org]

------- Additional Comments From zack at gcc dot gnu dot org  2004-06-01 02:22 -------
current_function_prototype_locus should really be a property of the relevant
DECL.  The problem with that is, there's nowhere to put it.  We could enlarge
the  C lang_decl structure, but I hate chewing up more space on something that's
only ever used for error messages.  Ideas?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15698

[Bug c/15698] [4.0 Regression] wrong error in presence of builtin fn + K&R declaration.

[jsm28 at gcc dot gnu dot org]

------- Additional Comments From jsm28 at gcc dot gnu dot org  2004-10-15 21:25 -------
Now we don't get any diagnostic for the testcase at all.  From the
regression hunter I think my patch for bug 13801 is probably to blame for
that.  In formal terms a diagnostic isn't required here, but I'm inclined
to think the check of old-style definition against prototype should be
applied using the type in the external scope rather than just the visible
type - although information from an invisible prototype shouldn't be merged
into the subsequent function type.  (Incompatibility of any prototype,
anywhere in the program, with the definition, is compile-time undefined;
standard built-in functions are reserved with external linkage and defining
them is beyond the scope of the standard so errors make sense there too.)


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jsm28 at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15698

[Bug c/15698] [4.0 Regression] wrong error in presence of builtin fn + K&R declaration.

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-10-15 21:49 -------
: Search converges between 2004-08-26-trunk (#525) and 2004-08-27-trunk (#526).

Looking at the above date which is from using Phil's regression hunter, we can say almost definitely 
JSM's patch to fix bug 13801 is the patch which fixed this one too.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15698

[Bug c/15698] [4.0 Regression] wrong error in presence of builtin fn + K&R declaration.

[jsm at polyomino dot org dot uk]

------- Additional Comments From jsm at polyomino dot org dot uk  2004-10-15 21:55 -------
Subject: Re:  [4.0 Regression] wrong error in presence of builtin
 fn + K&R declaration.

On Fri, 15 Oct 2004, pinskia at gcc dot gnu dot org wrote:

> Looking at the above date which is from using Phil's regression hunter, 
> we can say almost definitely JSM's patch to fix bug 13801 is the patch 
> which fixed this one too.

I wouldn't say fixed; rather, hid.  There was a bug about the diagnostic 
referencing the wrong location.  The diagnostic was correct; the location 
was wrong.  Now there is a bug that the diagnostic is missing.  A fix 
should aim to fix both.



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15698

[Bug c/15698] [4.0/4.1 Regression] no error in presence of broken builtin fn + K&R declaration

[mmitchel at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.0.0                       |4.0.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15698

[Bug c/15698] [4.0/4.1 Regression] no error in presence of broken builtin fn + K&R declaration

[jsm28 at gcc dot gnu dot org]

-- 
Bug 15698 depends on bug 16666, which changed state.

Bug 16666 Summary: [3.4 regression] dremf type conflict
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16666

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15698

[Bug c/15698] [4.0/4.1 Regression] no error in presence of broken builtin fn + K&R declaration

[jsm28 at gcc dot gnu dot org]

------- Additional Comments From jsm28 at gcc dot gnu dot org  2005-05-02 01:55 -------
Working on a fix.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |jsm28 at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2004-05-28 11:22:55         |2005-05-02 01:55:46
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15698

[Bug c/15698] [4.0/4.1 Regression] no error in presence of broken builtin fn + K&R declaration

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-05-02 19:39 -------
Subject: Bug 15698

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	jsm28@gcc.gnu.org	2005-05-02 19:39:04

Modified files:
	gcc            : ChangeLog c-decl.c c-tree.h 
	gcc/testsuite  : ChangeLog 
	gcc/testsuite/gcc.dg: builtins-30.c 
Added files:
	gcc/testsuite/gcc.dg: pr15698-1.c pr15698-2.c pr15698-3.c 
	                      pr15698-4.c pr15698-5.c pr15698-6.c 
	                      pr15698-7.c pr15698-8.c 

Log message:
	PR c/15698
	* c-tree.h (C_DECL_BUILTIN_PROTOTYPE): New.
	* c-decl.c (current_function_prototype_built_in,
	current_function_prototype_arg_types): New.
	(merge_decls): Keep source location of prototype followed by
	nonprototype declaration.  Update C_DECL_BUILTIN_PROTOTYPE.
	(builtin_function): Set C_DECL_BUILTIN_PROTOTYPE.
	(start_function): Always set current_function_prototype_locus,
	current_function_prototype_built_in and
	current_function_prototype_arg_types.  Check for external
	prototype whether or not visible for external function and set
	current_function_prototype_arg_types accordingly.
	(store_parm_decls_oldstyle): Use
	current_function_prototype_arg_types for checking old-style
	definition against prototype.  Give warnings only if
	current_function_prototype_built_in).
	
	testsuite:
	* gcc.dg/builtins-30.c: Update expected messages.
	* gcc.dg/pr15698-1.c, gcc.dg/pr15698-2.c, gcc.dg/pr15698-3.c,
	gcc.dg/pr15698-4.c, gcc.dg/pr15698-5.c, gcc.dg/pr15698-6.c,
	gcc.dg/pr15698-7.c, pr15698-8.c: New tests.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.8565&r2=2.8566
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-decl.c.diff?cvsroot=gcc&r1=1.650&r2=1.651
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-tree.h.diff?cvsroot=gcc&r1=1.201&r2=1.202
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.5428&r2=1.5429
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pr15698-1.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pr15698-2.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pr15698-3.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pr15698-4.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pr15698-5.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pr15698-6.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pr15698-7.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pr15698-8.c.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/builtins-30.c.diff?cvsroot=gcc&r1=1.4&r2=1.5



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15698

[Bug c/15698] [4.0/4.1 Regression] no error in presence of broken builtin fn + K&R declaration

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-05-02 19:45 -------
Subject: Bug 15698

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-4_0-branch
Changes by:	jsm28@gcc.gnu.org	2005-05-02 19:45:27

Modified files:
	gcc            : ChangeLog c-decl.c c-tree.h 
	gcc/testsuite  : ChangeLog 
	gcc/testsuite/gcc.dg: builtins-30.c 
Added files:
	gcc/testsuite/gcc.dg: pr15698-1.c pr15698-2.c pr15698-3.c 
	                      pr15698-4.c pr15698-5.c pr15698-6.c 
	                      pr15698-7.c pr15698-8.c 

Log message:
	PR c/15698
	* c-tree.h (C_DECL_BUILTIN_PROTOTYPE): New.
	* c-decl.c (current_function_prototype_built_in,
	current_function_prototype_arg_types): New.
	(merge_decls): Keep source location of prototype followed by
	nonprototype declaration.  Update C_DECL_BUILTIN_PROTOTYPE.
	(builtin_function): Set C_DECL_BUILTIN_PROTOTYPE.
	(start_function): Always set current_function_prototype_locus,
	current_function_prototype_built_in and
	current_function_prototype_arg_types.  Check for external
	prototype whether or not visible for external function and set
	current_function_prototype_arg_types accordingly.
	(store_parm_decls_oldstyle): Use
	current_function_prototype_arg_types for checking old-style
	definition against prototype.  Give warnings only if
	current_function_prototype_built_in).
	
	testsuite:
	* gcc.dg/builtins-30.c: Update expected messages.
	* gcc.dg/pr15698-1.c, gcc.dg/pr15698-2.c, gcc.dg/pr15698-3.c,
	gcc.dg/pr15698-4.c, gcc.dg/pr15698-5.c, gcc.dg/pr15698-6.c,
	gcc.dg/pr15698-7.c, pr15698-8.c: New tests.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=2.7592.2.211&r2=2.7592.2.212
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-decl.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.630.6.8&r2=1.630.6.9
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-tree.h.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.193.4.3&r2=1.193.4.4
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.5084.2.153&r2=1.5084.2.154
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pr15698-1.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.2.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pr15698-2.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.2.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pr15698-3.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.2.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pr15698-4.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.2.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pr15698-5.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.2.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pr15698-6.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.2.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pr15698-7.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.2.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/pr15698-8.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.2.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/builtins-30.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.4&r2=1.4.48.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15698

[Bug c/15698] [4.0/4.1 Regression] no error in presence of broken builtin fn + K&R declaration

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-05-02 19:51 -------
Fixed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15698