public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/14018] New: m68k backend: -malign-loops/-malign-jumps broken
@ 2004-02-04 15:01 gcc-bugzilla at gcc dot gnu dot org
  2004-02-04 15:13 ` [Bug target/14018] " pinskia at gcc dot gnu dot org
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: gcc-bugzilla at gcc dot gnu dot org @ 2004-02-04 15:01 UTC (permalink / raw)
  To: gcc-bugs

The m68k backend has -malign-loops, -malign-jumps and -malign-functions
target options. The i386 backend has them too but warns when they are used
and suggest to use the corresponding -falign- option. Furthermore a comment
of i386.c states these options are scheduled for removal.
Then usage of m68k_align_loops and m68k_align_jumps is broken since both
values are passed as-is. However, the macros that use them as arguments
expect log2 arguments as stated in final.c for LABEL_ALIGN_AFTER_BARRIER
and LOOP_ALIGN.

How-To-Repeat:
Check m68k/m68k.h, m68k/m68k.c and final.c
------- Additional Comments From gni at gecko dot de  2004-02-04 15:01 -------
Fix:
These options should be removed.

-- 
           Summary: m68k backend: -malign-loops/-malign-jumps broken
           Product: gcc
           Version: 3.4
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: gni at gecko dot de
                CC: gcc-bugs at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14018


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug target/14018] m68k backend: -malign-loops/-malign-jumps broken
  2004-02-04 15:01 [Bug target/14018] New: m68k backend: -malign-loops/-malign-jumps broken gcc-bugzilla at gcc dot gnu dot org
@ 2004-02-04 15:13 ` pinskia at gcc dot gnu dot org
  2004-05-31  1:58 ` bernie at develer dot com
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-02-04 15:13 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From pinskia at gcc dot gnu dot org  2004-02-04 15:13 -------
Confirmed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
 GCC target triplet|                            |m68k-*-*
      Known to fail|                            |3.5.0
   Last reconfirmed|0000-00-00 00:00:00         |2004-02-04 15:13:10
               date|                            |
            Version|3.4                         |2.95


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14018


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug target/14018] m68k backend: -malign-loops/-malign-jumps broken
  2004-02-04 15:01 [Bug target/14018] New: m68k backend: -malign-loops/-malign-jumps broken gcc-bugzilla at gcc dot gnu dot org
  2004-02-04 15:13 ` [Bug target/14018] " pinskia at gcc dot gnu dot org
@ 2004-05-31  1:58 ` bernie at develer dot com
  2004-06-01 12:56 ` cvs-commit at gcc dot gnu dot org
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: bernie at develer dot com @ 2004-05-31  1:58 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From bernie at develer dot com  2004-05-30 03:58 -------
Patch submitted here: 
 
  http://gcc.gnu.org/ml/gcc-patches/2004-05/msg01967.html 
 

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2004-05-05 03:45:42         |2004-05-30 03:58:35
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14018


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug target/14018] m68k backend: -malign-loops/-malign-jumps broken
  2004-02-04 15:01 [Bug target/14018] New: m68k backend: -malign-loops/-malign-jumps broken gcc-bugzilla at gcc dot gnu dot org
  2004-02-04 15:13 ` [Bug target/14018] " pinskia at gcc dot gnu dot org
  2004-05-31  1:58 ` bernie at develer dot com
@ 2004-06-01 12:56 ` cvs-commit at gcc dot gnu dot org
  2004-06-01 13:23 ` bernie at develer dot com
  2004-06-04  6:23 ` pinskia at gcc dot gnu dot org
  4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2004-06-01 12:56 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-06-01 12:56 -------
Subject: Bug 14018

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	bernie@gcc.gnu.org	2004-06-01 12:56:50

Modified files:
	gcc            : ChangeLog 
	gcc/config/m68k: m68k.c m68k.h 

Log message:
	PR target/14018
	* config/m68k/m68k.c (m68k_align_loops_string, m68k_align_jumps_string,
	m68k_align_funcs_string, m68k_align_loops, m68k_align_jumps,
	m68k_align_funcs): Remove.
	(override_options): Remove code to handle -malign-* options.
	* config/m68k/m68k.h (TARGET_OPTIONS): Remove -malign-* options.
	(FUNCTION_BOUNDARY, LOOP_ALIGN, LOOP_ALIGN_AFTER_BARRIER): Remove.
	(m68k_align_loops_string, m68k_align_jumps_string,
	m68k_align_funcs_string, m68k_align_loops, m68k_align_jumps,
	m68k_align_funcs): Remove definitions.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.3814&r2=2.3815
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/m68k/m68k.c.diff?cvsroot=gcc&r1=1.131&r2=1.132
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/m68k/m68k.h.diff?cvsroot=gcc&r1=1.112&r2=1.113



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14018


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug target/14018] m68k backend: -malign-loops/-malign-jumps broken
  2004-02-04 15:01 [Bug target/14018] New: m68k backend: -malign-loops/-malign-jumps broken gcc-bugzilla at gcc dot gnu dot org
                   ` (2 preceding siblings ...)
  2004-06-01 12:56 ` cvs-commit at gcc dot gnu dot org
@ 2004-06-01 13:23 ` bernie at develer dot com
  2004-06-04  6:23 ` pinskia at gcc dot gnu dot org
  4 siblings, 0 replies; 6+ messages in thread
From: bernie at develer dot com @ 2004-06-01 13:23 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From bernie at develer dot com  2004-06-01 13:22 -------
Fixed.  Shall I backport to 3.4 too? 
 

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14018


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug target/14018] m68k backend: -malign-loops/-malign-jumps broken
  2004-02-04 15:01 [Bug target/14018] New: m68k backend: -malign-loops/-malign-jumps broken gcc-bugzilla at gcc dot gnu dot org
                   ` (3 preceding siblings ...)
  2004-06-01 13:23 ` bernie at develer dot com
@ 2004-06-04  6:23 ` pinskia at gcc dot gnu dot org
  4 siblings, 0 replies; 6+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-06-04  6:23 UTC (permalink / raw)
  To: gcc-bugs



-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |3.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14018


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2004-06-04  6:23 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-02-04 15:01 [Bug target/14018] New: m68k backend: -malign-loops/-malign-jumps broken gcc-bugzilla at gcc dot gnu dot org
2004-02-04 15:13 ` [Bug target/14018] " pinskia at gcc dot gnu dot org
2004-05-31  1:58 ` bernie at develer dot com
2004-06-01 12:56 ` cvs-commit at gcc dot gnu dot org
2004-06-01 13:23 ` bernie at develer dot com
2004-06-04  6:23 ` pinskia at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).