[Bug other/14884] New: rpc/xdr.h should be fixincluded

public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed

* [Bug other/14884] New: rpc/xdr.h should be fixincluded
@ 2004-04-07 22:32 jsm28 at gcc dot gnu dot org
  2004-04-07 22:52 ` [Bug other/14884] [3.3/3.4 only] " pinskia at gcc dot gnu dot org
                   ` (11 more replies)
  0 siblings, 12 replies; 13+ messages in thread
From: jsm28 at gcc dot gnu dot org @ 2004-04-07 22:32 UTC (permalink / raw)
  To: gcc-bugs

glibc's <rpc/xdr.h> uses lvalue casts and should be fixincluded.

The patch <http://gcc.gnu.org/ml/gcc-patches/2004-03/msg02056.html>
is now on mainline but should go in 3.4.0 and 3.3.4, the releases
which introduce the deprecation of lvalue casts.  (glibc CVS has
also been fixed, using exactly the same definitions as the fixincludes
fixes use.)

OK for 3.4 branch?

-- 
           Summary: rpc/xdr.h should be fixincluded
           Product: gcc
           Version: 3.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: other
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: jsm28 at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org,mark at codesourcery dot
                    com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14884


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug other/14884] [3.3/3.4 only] rpc/xdr.h should be fixincluded
  2004-04-07 22:32 [Bug other/14884] New: rpc/xdr.h should be fixincluded jsm28 at gcc dot gnu dot org
@ 2004-04-07 22:52 ` pinskia at gcc dot gnu dot org
  2004-04-07 23:04 ` mark at codesourcery dot com
                   ` (10 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-04-07 22:52 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From pinskia at gcc dot gnu dot org  2004-04-07 22:52 -------
Confirmed, GDR also okay for 3.3.4?

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gdr at gcc dot gnu dot org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2004-04-07 22:52:13
               date|                            |
            Summary|rpc/xdr.h should be         |[3.3/3.4 only] rpc/xdr.h
                   |fixincluded                 |should be fixincluded
   Target Milestone|---                         |3.3.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14884


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug other/14884] [3.3/3.4 only] rpc/xdr.h should be fixincluded
  2004-04-07 22:32 [Bug other/14884] New: rpc/xdr.h should be fixincluded jsm28 at gcc dot gnu dot org
  2004-04-07 22:52 ` [Bug other/14884] [3.3/3.4 only] " pinskia at gcc dot gnu dot org
@ 2004-04-07 23:04 ` mark at codesourcery dot com
  2004-04-07 23:32 ` [Bug other/14884] New: " Gabriel Dos Reis
                   ` (9 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: mark at codesourcery dot com @ 2004-04-07 23:04 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From mark at codesourcery dot com  2004-04-07 23:04 -------
Subject: Re:  New: rpc/xdr.h should be fixincluded

jsm28 at gcc dot gnu dot org wrote:

>glibc's <rpc/xdr.h> uses lvalue casts and should be fixincluded.
>
>The patch <http://gcc.gnu.org/ml/gcc-patches/2004-03/msg02056.html>
>is now on mainline but should go in 3.4.0 and 3.3.4, the releases
>which introduce the deprecation of lvalue casts.  (glibc CVS has
>also been fixed, using exactly the same definitions as the fixincludes
>fixes use.)
>
>OK for 3.4 branch?
>  
>
Yes.



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14884


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [Bug other/14884] New: rpc/xdr.h should be fixincluded
  2004-04-07 22:32 [Bug other/14884] New: rpc/xdr.h should be fixincluded jsm28 at gcc dot gnu dot org
  2004-04-07 22:52 ` [Bug other/14884] [3.3/3.4 only] " pinskia at gcc dot gnu dot org
  2004-04-07 23:04 ` mark at codesourcery dot com
@ 2004-04-07 23:32 ` Gabriel Dos Reis
  2004-04-07 23:32 ` [Bug other/14884] [3.3/3.4 only] " gdr at integrable-solutions dot net
                   ` (8 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: Gabriel Dos Reis @ 2004-04-07 23:32 UTC (permalink / raw)
  To: gcc-bugzilla; +Cc: gcc-bugs

"jsm28 at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org> writes:

| The patch <http://gcc.gnu.org/ml/gcc-patches/2004-03/msg02056.html>
| is now on mainline but should go in 3.4.0 and 3.3.4, the releases
| which introduce the deprecation of lvalue casts.  (glibc CVS has
| also been fixed, using exactly the same definitions as the fixincludes
| fixes use.)
| 
| OK for 3.4 branch?

OK for 3.3.4.

Thanks,

-- Gaby


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug other/14884] [3.3/3.4 only] rpc/xdr.h should be fixincluded
  2004-04-07 22:32 [Bug other/14884] New: rpc/xdr.h should be fixincluded jsm28 at gcc dot gnu dot org
                   ` (2 preceding siblings ...)
  2004-04-07 23:32 ` [Bug other/14884] New: " Gabriel Dos Reis
@ 2004-04-07 23:32 ` gdr at integrable-solutions dot net
  2004-04-08  9:09 ` jsm at polyomino dot org dot uk
                   ` (7 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: gdr at integrable-solutions dot net @ 2004-04-07 23:32 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From gdr at integrable-solutions dot net  2004-04-07 23:32 -------
Subject: Re:  New: rpc/xdr.h should be fixincluded

"jsm28 at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org> writes:

| The patch <http://gcc.gnu.org/ml/gcc-patches/2004-03/msg02056.html>
| is now on mainline but should go in 3.4.0 and 3.3.4, the releases
| which introduce the deprecation of lvalue casts.  (glibc CVS has
| also been fixed, using exactly the same definitions as the fixincludes
| fixes use.)
| 
| OK for 3.4 branch?

OK for 3.3.4.

Thanks,

-- Gaby


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14884


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug other/14884] [3.3/3.4 only] rpc/xdr.h should be fixincluded
  2004-04-07 22:32 [Bug other/14884] New: rpc/xdr.h should be fixincluded jsm28 at gcc dot gnu dot org
                   ` (3 preceding siblings ...)
  2004-04-07 23:32 ` [Bug other/14884] [3.3/3.4 only] " gdr at integrable-solutions dot net
@ 2004-04-08  9:09 ` jsm at polyomino dot org dot uk
  2004-06-06  3:51 ` giovannibajo at libero dot it
                   ` (6 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: jsm at polyomino dot org dot uk @ 2004-04-08  9:09 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From jsm at polyomino dot org dot uk  2004-04-08 09:09 -------
Subject: Re:  [3.3/3.4 only] rpc/xdr.h should be fixincluded

On Wed, 7 Apr 2004, gdr at integrable-solutions dot net wrote:

> | The patch <http://gcc.gnu.org/ml/gcc-patches/2004-03/msg02056.html>
> | is now on mainline but should go in 3.4.0 and 3.3.4, the releases
> | which introduce the deprecation of lvalue casts.  (glibc CVS has
> | also been fixed, using exactly the same definitions as the fixincludes
> | fixes use.)
> | 
> | OK for 3.4 branch?
> 
> OK for 3.3.4.

I don't now have a 3.3 branch checkout, could you apply the patch (and
regenerate fixincl.x) there?



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14884


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug other/14884] [3.3/3.4 only] rpc/xdr.h should be fixincluded
  2004-04-07 22:32 [Bug other/14884] New: rpc/xdr.h should be fixincluded jsm28 at gcc dot gnu dot org
                   ` (4 preceding siblings ...)
  2004-04-08  9:09 ` jsm at polyomino dot org dot uk
@ 2004-06-06  3:51 ` giovannibajo at libero dot it
  2004-06-06  4:00 ` gdr at integrable-solutions dot net
                   ` (5 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: giovannibajo at libero dot it @ 2004-06-06  3:51 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From giovannibajo at libero dot it  2004-06-06 03:51 -------
JSM did the patch for this went in on the 3.4 branch?
Gaby, did you commit this to the 3.3 branch?

Retargeting to 3.4.1, being a regression on that release branch.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.3.4                       |3.4.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14884


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug other/14884] [3.3/3.4 only] rpc/xdr.h should be fixincluded
  2004-04-07 22:32 [Bug other/14884] New: rpc/xdr.h should be fixincluded jsm28 at gcc dot gnu dot org
                   ` (5 preceding siblings ...)
  2004-06-06  3:51 ` giovannibajo at libero dot it
@ 2004-06-06  4:00 ` gdr at integrable-solutions dot net
  2004-06-06 11:41 ` jsm at polyomino dot org dot uk
                   ` (4 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: gdr at integrable-solutions dot net @ 2004-06-06  4:00 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From gdr at integrable-solutions dot net  2004-06-06 04:00 -------
Subject: Re:  [3.3/3.4 only] rpc/xdr.h should be fixincluded

"giovannibajo at libero dot it" <gcc-bugzilla@gcc.gnu.org> writes:

| JSM did the patch for this went in on the 3.4 branch?
| Gaby, did you commit this to the 3.3 branch?

Unfortunately, I don't think I did :-(
Queued for 3.3.5.

-- Gaby


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14884


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug other/14884] [3.3/3.4 only] rpc/xdr.h should be fixincluded
  2004-04-07 22:32 [Bug other/14884] New: rpc/xdr.h should be fixincluded jsm28 at gcc dot gnu dot org
                   ` (6 preceding siblings ...)
  2004-06-06  4:00 ` gdr at integrable-solutions dot net
@ 2004-06-06 11:41 ` jsm at polyomino dot org dot uk
  2004-06-12 21:58 ` [Bug other/14884] [3.3 " mmitchel at gcc dot gnu dot org
                   ` (3 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: jsm at polyomino dot org dot uk @ 2004-06-06 11:41 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From jsm at polyomino dot org dot uk  2004-06-06 11:41 -------
Subject: Re:  [3.3/3.4 only] rpc/xdr.h should be fixincluded

On Sun, 6 Jun 2004, giovannibajo at libero dot it wrote:

> JSM did the patch for this went in on the 3.4 branch?

The fix is in the 3.4.0 release.



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14884


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug other/14884] [3.3 only] rpc/xdr.h should be fixincluded
  2004-04-07 22:32 [Bug other/14884] New: rpc/xdr.h should be fixincluded jsm28 at gcc dot gnu dot org
                   ` (7 preceding siblings ...)
  2004-06-06 11:41 ` jsm at polyomino dot org dot uk
@ 2004-06-12 21:58 ` mmitchel at gcc dot gnu dot org
  2004-09-28 13:38 ` gdr at gcc dot gnu dot org
                   ` (2 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: mmitchel at gcc dot gnu dot org @ 2004-06-12 21:58 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From mmitchel at gcc dot gnu dot org  2004-06-12 21:58 -------
Removing 3.4 markers since Joseph says this was fixed in 3.4.0.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[3.3/3.4 only] rpc/xdr.h    |[3.3 only] rpc/xdr.h should
                   |should be fixincluded       |be fixincluded
   Target Milestone|3.4.1                       |3.3.5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14884


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug other/14884] [3.3 only] rpc/xdr.h should be fixincluded
  2004-04-07 22:32 [Bug other/14884] New: rpc/xdr.h should be fixincluded jsm28 at gcc dot gnu dot org
                   ` (8 preceding siblings ...)
  2004-06-12 21:58 ` [Bug other/14884] [3.3 " mmitchel at gcc dot gnu dot org
@ 2004-09-28 13:38 ` gdr at gcc dot gnu dot org
  2005-04-30 17:14 ` cvs-commit at gcc dot gnu dot org
  2005-04-30 17:16 ` gdr at gcc dot gnu dot org
  11 siblings, 0 replies; 13+ messages in thread
From: gdr at gcc dot gnu dot org @ 2004-09-28 13:38 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From gdr at gcc dot gnu dot org  2004-09-28 13:30 -------
Adjust milestone

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.3.5                       |3.3.6


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14884


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug other/14884] [3.3 only] rpc/xdr.h should be fixincluded
  2004-04-07 22:32 [Bug other/14884] New: rpc/xdr.h should be fixincluded jsm28 at gcc dot gnu dot org
                   ` (9 preceding siblings ...)
  2004-09-28 13:38 ` gdr at gcc dot gnu dot org
@ 2005-04-30 17:14 ` cvs-commit at gcc dot gnu dot org
  2005-04-30 17:16 ` gdr at gcc dot gnu dot org
  11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-04-30 17:14 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-04-30 17:14 -------
Subject: Bug 14884

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_3-branch
Changes by:	gdr@gcc.gnu.org	2005-04-30 17:14:28

Modified files:
	gcc            : ChangeLog 
	gcc/fixinc     : inclhack.def 
	gcc/fixinc/tests/base/rpc: xdr.h 

Log message:
	PR 14884
	* Apply:
	2004-03-25  Joseph S. Myers  <jsm@polyomino.org.uk>
	
	* fixinc/inclhack.def (rpc_xdr_lvalue_cast_a,
	rpc_xdr_lvalue_cast_b): New fixes.
	* fixinc/tests/base/rpc/xdr.h: Add new tests.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.16114.2.1066&r2=1.16114.2.1067
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fixinc/inclhack.def.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.139.4.18&r2=1.139.4.19
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fixinc/tests/base/rpc/xdr.h.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.2&r2=1.2.56.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14884


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug other/14884] [3.3 only] rpc/xdr.h should be fixincluded
  2004-04-07 22:32 [Bug other/14884] New: rpc/xdr.h should be fixincluded jsm28 at gcc dot gnu dot org
                   ` (10 preceding siblings ...)
  2005-04-30 17:14 ` cvs-commit at gcc dot gnu dot org
@ 2005-04-30 17:16 ` gdr at gcc dot gnu dot org
  11 siblings, 0 replies; 13+ messages in thread
From: gdr at gcc dot gnu dot org @ 2005-04-30 17:16 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From gdr at gcc dot gnu dot org  2005-04-30 17:16 -------
Applied to 3.3.6 too.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14884


^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2005-04-30 17:16 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-04-07 22:32 [Bug other/14884] New: rpc/xdr.h should be fixincluded jsm28 at gcc dot gnu dot org
2004-04-07 22:52 ` [Bug other/14884] [3.3/3.4 only] " pinskia at gcc dot gnu dot org
2004-04-07 23:04 ` mark at codesourcery dot com
2004-04-07 23:32 ` [Bug other/14884] New: " Gabriel Dos Reis
2004-04-07 23:32 ` [Bug other/14884] [3.3/3.4 only] " gdr at integrable-solutions dot net
2004-04-08  9:09 ` jsm at polyomino dot org dot uk
2004-06-06  3:51 ` giovannibajo at libero dot it
2004-06-06  4:00 ` gdr at integrable-solutions dot net
2004-06-06 11:41 ` jsm at polyomino dot org dot uk
2004-06-12 21:58 ` [Bug other/14884] [3.3 " mmitchel at gcc dot gnu dot org
2004-09-28 13:38 ` gdr at gcc dot gnu dot org
2005-04-30 17:14 ` cvs-commit at gcc dot gnu dot org
2005-04-30 17:16 ` gdr at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).