public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug c++/15815] New: Deprecate the #pragma interface and #pragma implementation
@ 2004-06-04 1:42 hattons at globalsymmetry dot com
2004-06-04 1:58 ` [Bug c++/15815] " pinskia at gcc dot gnu dot org
` (18 more replies)
0 siblings, 19 replies; 20+ messages in thread
From: hattons at globalsymmetry dot com @ 2004-06-04 1:42 UTC (permalink / raw)
To: gcc-bugs
This is a reminder to deprecate the features described at the followig link:
http://gcc.gnu.org/onlinedocs/gcc-3.4.0/gcc/C---Interface.html#C++%20Interface
The discussion can be reviewed in the following mailing list thread:
http://gcc.gnu.org/ml/gcc/2004-06/msg00074.html
Basically the feature is obsolete and the documentation is wrong.
--
Summary: Deprecate the #pragma interface and #pragma
implementation
Product: gcc
Version: 3.4.0
Status: UNCONFIRMED
Severity: minor
Priority: P2
Component: c++
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: hattons at globalsymmetry dot com
CC: gcc-bugs at gcc dot gnu dot org
GCC build triplet: N/A
GCC host triplet: All
GCC target triplet: Any
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15815
^ permalink raw reply [flat|nested] 20+ messages in thread
* [Bug c++/15815] Deprecate the #pragma interface and #pragma implementation
2004-06-04 1:42 [Bug c++/15815] New: Deprecate the #pragma interface and #pragma implementation hattons at globalsymmetry dot com
@ 2004-06-04 1:58 ` pinskia at gcc dot gnu dot org
2004-06-07 16:38 ` mmitchel at gcc dot gnu dot org
` (17 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-06-04 1:58 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pinskia at gcc dot gnu dot org 2004-06-04 01:58 -------
Confirmed.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Ever Confirmed| |1
Last reconfirmed|0000-00-00 00:00:00 |2004-06-04 01:58:36
date| |
Target Milestone|--- |3.4.1
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15815
^ permalink raw reply [flat|nested] 20+ messages in thread
* [Bug c++/15815] Deprecate the #pragma interface and #pragma implementation
2004-06-04 1:42 [Bug c++/15815] New: Deprecate the #pragma interface and #pragma implementation hattons at globalsymmetry dot com
2004-06-04 1:58 ` [Bug c++/15815] " pinskia at gcc dot gnu dot org
@ 2004-06-07 16:38 ` mmitchel at gcc dot gnu dot org
2004-06-07 19:21 ` cvs-commit at gcc dot gnu dot org
` (16 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: mmitchel at gcc dot gnu dot org @ 2004-06-07 16:38 UTC (permalink / raw)
To: gcc-bugs
--
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|unassigned at gcc dot gnu |mark at codesourcery dot com
|dot org |
Status|NEW |ASSIGNED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15815
^ permalink raw reply [flat|nested] 20+ messages in thread
* [Bug c++/15815] Deprecate the #pragma interface and #pragma implementation
2004-06-04 1:42 [Bug c++/15815] New: Deprecate the #pragma interface and #pragma implementation hattons at globalsymmetry dot com
2004-06-04 1:58 ` [Bug c++/15815] " pinskia at gcc dot gnu dot org
2004-06-07 16:38 ` mmitchel at gcc dot gnu dot org
@ 2004-06-07 19:21 ` cvs-commit at gcc dot gnu dot org
2004-06-07 19:23 ` cvs-commit at gcc dot gnu dot org
` (15 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2004-06-07 19:21 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2004-06-07 19:21 -------
Subject: Bug 15815
CVSROOT: /cvs/gcc
Module name: gcc
Branch: gcc-3_4-branch
Changes by: mmitchel@gcc.gnu.org 2004-06-07 19:21:08
Modified files:
gcc : ChangeLog
gcc/cp : ChangeLog lex.c
gcc/doc : extend.texi
Log message:
PR c++/15815
* lex.c (handle_pragma_interface): Deprecate.
(handle_pragma_implementation): Likewise.
PR c++/15815
* doc/extend.texi: Deprecate #pragma interface and #pragma
implementation.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=2.2326.2.473&r2=2.2326.2.474
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.3892.2.116&r2=1.3892.2.117
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/lex.c.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.323.2.2&r2=1.323.2.3
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/doc/extend.texi.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.177.4.9&r2=1.177.4.10
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15815
^ permalink raw reply [flat|nested] 20+ messages in thread
* [Bug c++/15815] Deprecate the #pragma interface and #pragma implementation
2004-06-04 1:42 [Bug c++/15815] New: Deprecate the #pragma interface and #pragma implementation hattons at globalsymmetry dot com
` (2 preceding siblings ...)
2004-06-07 19:21 ` cvs-commit at gcc dot gnu dot org
@ 2004-06-07 19:23 ` cvs-commit at gcc dot gnu dot org
2004-06-07 19:25 ` [Bug c++/15815] Remove " mmitchel at gcc dot gnu dot org
` (14 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2004-06-07 19:23 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2004-06-07 19:23 -------
Subject: Bug 15815
CVSROOT: /cvs/gcc
Module name: gcc
Changes by: mmitchel@gcc.gnu.org 2004-06-07 19:23:29
Modified files:
gcc : ChangeLog
gcc/cp : ChangeLog lex.c
gcc/doc : extend.texi
Log message:
PR c++/15815
* lex.c (handle_pragma_interface): Deprecate.
(handle_pragma_implementation): Likewise.
PR c++/15815
* doc/extend.texi: Deprecate #pragma interface and #pragma
implementation.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.3865&r2=2.3866
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/ChangeLog.diff?cvsroot=gcc&r1=1.4084&r2=1.4085
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/lex.c.diff?cvsroot=gcc&r1=1.327&r2=1.328
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/doc/extend.texi.diff?cvsroot=gcc&r1=1.194&r2=1.195
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15815
^ permalink raw reply [flat|nested] 20+ messages in thread
* [Bug c++/15815] Remove #pragma interface and #pragma implementation
2004-06-04 1:42 [Bug c++/15815] New: Deprecate the #pragma interface and #pragma implementation hattons at globalsymmetry dot com
` (3 preceding siblings ...)
2004-06-07 19:23 ` cvs-commit at gcc dot gnu dot org
@ 2004-06-07 19:25 ` mmitchel at gcc dot gnu dot org
2004-06-08 3:45 ` danglin at gcc dot gnu dot org
` (13 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: mmitchel at gcc dot gnu dot org @ 2004-06-07 19:25 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From mmitchel at gcc dot gnu dot org 2004-06-07 19:25 -------
I've deprecated these in 3.4.1. They should be removed completely before 3.5.0.
--
What |Removed |Added
----------------------------------------------------------------------------
Summary|Deprecate the #pragma |Remove #pragma interface and
|interface and #pragma |#pragma implementation
|implementation |
Target Milestone|3.4.1 |3.5.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15815
^ permalink raw reply [flat|nested] 20+ messages in thread
* [Bug c++/15815] Remove #pragma interface and #pragma implementation
2004-06-04 1:42 [Bug c++/15815] New: Deprecate the #pragma interface and #pragma implementation hattons at globalsymmetry dot com
` (4 preceding siblings ...)
2004-06-07 19:25 ` [Bug c++/15815] Remove " mmitchel at gcc dot gnu dot org
@ 2004-06-08 3:45 ` danglin at gcc dot gnu dot org
2004-06-08 3:47 ` pinskia at gcc dot gnu dot org
` (12 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: danglin at gcc dot gnu dot org @ 2004-06-08 3:45 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From danglin at gcc dot gnu dot org 2004-06-08 03:45 -------
The following tests need updating:
FAIL: g++.dg/other/cxa-atexit1.C (test for excess errors)
FAIL: g++.old-deja/g++.jason/2371.C (test for excess errors)
FAIL: g++.old-deja/g++.jason/c-inline.C (test for excess errors)
FAIL: g++.old-deja/g++.jason/context.C (test for excess errors)
FAIL: g++.old-deja/g++.jason/inline.C (test for excess errors)
FAIL: g++.old-deja/g++.jason/synth5.C (test for excess errors)
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15815
^ permalink raw reply [flat|nested] 20+ messages in thread
* [Bug c++/15815] Remove #pragma interface and #pragma implementation
2004-06-04 1:42 [Bug c++/15815] New: Deprecate the #pragma interface and #pragma implementation hattons at globalsymmetry dot com
` (5 preceding siblings ...)
2004-06-08 3:45 ` danglin at gcc dot gnu dot org
@ 2004-06-08 3:47 ` pinskia at gcc dot gnu dot org
2004-06-08 20:03 ` mark at codesourcery dot com
` (11 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-06-08 3:47 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pinskia at gcc dot gnu dot org 2004-06-08 03:47 -------
Plus you have to fix all of libjava not to use #pragma interface and #pragma implementation.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15815
^ permalink raw reply [flat|nested] 20+ messages in thread
* [Bug c++/15815] Remove #pragma interface and #pragma implementation
2004-06-04 1:42 [Bug c++/15815] New: Deprecate the #pragma interface and #pragma implementation hattons at globalsymmetry dot com
` (6 preceding siblings ...)
2004-06-08 3:47 ` pinskia at gcc dot gnu dot org
@ 2004-06-08 20:03 ` mark at codesourcery dot com
2004-06-09 18:32 ` cvs-commit at gcc dot gnu dot org
` (10 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: mark at codesourcery dot com @ 2004-06-08 20:03 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From mark at codesourcery dot com 2004-06-08 20:03 -------
Subject: Re: Remove #pragma interface and #pragma implementation
pinskia at gcc dot gnu dot org wrote:
> ------- Additional Comments From pinskia at gcc dot gnu dot org 2004-06-08 03:47 -------
> Plus you have to fix all of libjava not to use #pragma interface and #pragma implementation.
I am travelling and have only intermittent modem access.
Strangely, I did not see any failures with this patch -- which suggests
that I pressed the testing button very wrongly. If you would be so kind
as to revert my patch on both the mainline and the branch, I would be
most appreciative.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15815
^ permalink raw reply [flat|nested] 20+ messages in thread
* [Bug c++/15815] Remove #pragma interface and #pragma implementation
2004-06-04 1:42 [Bug c++/15815] New: Deprecate the #pragma interface and #pragma implementation hattons at globalsymmetry dot com
` (7 preceding siblings ...)
2004-06-08 20:03 ` mark at codesourcery dot com
@ 2004-06-09 18:32 ` cvs-commit at gcc dot gnu dot org
2004-06-09 18:34 ` cvs-commit at gcc dot gnu dot org
` (9 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2004-06-09 18:32 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2004-06-09 18:32 -------
Subject: Bug 15815
CVSROOT: /cvs/gcc
Module name: gcc
Branch: gcc-3_4-branch
Changes by: mmitchel@gcc.gnu.org 2004-06-09 18:32:05
Modified files:
gcc : ChangeLog
gcc/doc : extend.texi
gcc/cp : ChangeLog lex.c
Log message:
Revert:
PR c++/15815
2004-06-07 Mark Mitchell <mark@codesourcery.com>
* lex.c (handle_pragma_interface): Deprecate.
(handle_pragma_implementation): Likewise.
Revert:
PR c++/15815
2004-06-07 Mark Mitchell <mark@codesourcery.com>
* doc/extend.texi: Deprecate #pragma interface and #pragma
implementation.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=2.2326.2.484&r2=2.2326.2.485
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/doc/extend.texi.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.177.4.10&r2=1.177.4.11
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.3892.2.118&r2=1.3892.2.119
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/lex.c.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.323.2.3&r2=1.323.2.4
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15815
^ permalink raw reply [flat|nested] 20+ messages in thread
* [Bug c++/15815] Remove #pragma interface and #pragma implementation
2004-06-04 1:42 [Bug c++/15815] New: Deprecate the #pragma interface and #pragma implementation hattons at globalsymmetry dot com
` (8 preceding siblings ...)
2004-06-09 18:32 ` cvs-commit at gcc dot gnu dot org
@ 2004-06-09 18:34 ` cvs-commit at gcc dot gnu dot org
2004-06-09 18:35 ` [Bug c++/15815] Update #pragma interface and #pragma implementation documentation mmitchel at gcc dot gnu dot org
` (8 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2004-06-09 18:34 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2004-06-09 18:34 -------
Subject: Bug 15815
CVSROOT: /cvs/gcc
Module name: gcc
Changes by: mmitchel@gcc.gnu.org 2004-06-09 18:34:05
Modified files:
gcc : ChangeLog
gcc/doc : extend.texi
gcc/cp : ChangeLog lex.c
Log message:
Revert:
PR c++/15815
2004-06-07 Mark Mitchell <mark@codesourcery.com>
* doc/extend.texi: Deprecate #pragma interface and #pragma
implementation.
Revert:
PR c++/15815
2004-06-07 Mark Mitchell <mark@codesourcery.com>
* lex.c (handle_pragma_interface): Deprecate.
(handle_pragma_implementation): Likewise.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.3892&r2=2.3893
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/doc/extend.texi.diff?cvsroot=gcc&r1=1.195&r2=1.196
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/ChangeLog.diff?cvsroot=gcc&r1=1.4087&r2=1.4088
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/lex.c.diff?cvsroot=gcc&r1=1.328&r2=1.329
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15815
^ permalink raw reply [flat|nested] 20+ messages in thread
* [Bug c++/15815] Update #pragma interface and #pragma implementation documentation.
2004-06-04 1:42 [Bug c++/15815] New: Deprecate the #pragma interface and #pragma implementation hattons at globalsymmetry dot com
` (9 preceding siblings ...)
2004-06-09 18:34 ` cvs-commit at gcc dot gnu dot org
@ 2004-06-09 18:35 ` mmitchel at gcc dot gnu dot org
2004-06-09 19:03 ` bangerth at dealii dot org
` (7 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: mmitchel at gcc dot gnu dot org @ 2004-06-09 18:35 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From mmitchel at gcc dot gnu dot org 2004-06-09 18:35 -------
I've reverted the patch, per discussion on the gcc mailing lists:
http://gcc.gnu.org/ml/gcc-patches/2004-06/msg00509.html
I've also downgraded this PR, since it's been decided not to deprecate the feature.
--
What |Removed |Added
----------------------------------------------------------------------------
Summary|Remove #pragma interface and|Update #pragma interface and
|#pragma implementation |#pragma implementation
| |documentation.
Target Milestone|3.5.0 |---
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15815
^ permalink raw reply [flat|nested] 20+ messages in thread
* [Bug c++/15815] Update #pragma interface and #pragma implementation documentation.
2004-06-04 1:42 [Bug c++/15815] New: Deprecate the #pragma interface and #pragma implementation hattons at globalsymmetry dot com
` (10 preceding siblings ...)
2004-06-09 18:35 ` [Bug c++/15815] Update #pragma interface and #pragma implementation documentation mmitchel at gcc dot gnu dot org
@ 2004-06-09 19:03 ` bangerth at dealii dot org
2004-06-09 19:21 ` jason at redhat dot com
` (6 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: bangerth at dealii dot org @ 2004-06-09 19:03 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From bangerth at dealii dot org 2004-06-09 19:02 -------
This isn't Mark's fault, but I believe not to deprecate and remove
this (mis)feature is the wrong decision. The argument that was made
for keeping it was:
- assume there is an inline function
- it's address is taken in a number of translation units that end
up in a shared library and an application using it
- then it would be nice to have only one of them actually have a copy
of the body of this inline function, preferably the shared library
I don't buy this argument (and indeed the words that have been used in
cited threads are "would be nice" and "would like" when describing above).
I can't believe that there are many cases where out-of-line copies
of otherwise inlined functions take up a significant number of either
bytes on my harddisk or relocation entries in applications. Heck, my
application generates shared libraries on the order of 120MB, who cares
if a few small function bodies are there or not.
There must be a better argument for keeping this awkward feature if people
really want to cling on to it. I may buy that it shouldn't go away between
dot releases, but it should be possible to get rid of it at all, shouldn't
there?
W.
--
What |Removed |Added
----------------------------------------------------------------------------
CC| |jason at redhat dot com,
| |geoffk at geoffk dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15815
^ permalink raw reply [flat|nested] 20+ messages in thread
* [Bug c++/15815] Update #pragma interface and #pragma implementation documentation.
2004-06-04 1:42 [Bug c++/15815] New: Deprecate the #pragma interface and #pragma implementation hattons at globalsymmetry dot com
` (11 preceding siblings ...)
2004-06-09 19:03 ` bangerth at dealii dot org
@ 2004-06-09 19:21 ` jason at redhat dot com
2004-06-09 19:35 ` bangerth at dealii dot org
` (5 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: jason at redhat dot com @ 2004-06-09 19:21 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From jason at redhat dot com 2004-06-09 19:21 -------
Subject: Re: Update #pragma interface and #pragma
implementation documentation.
On 9 Jun 2004 19:03:04 -0000, "bangerth at dealii dot org" <gcc-bugzilla@gcc.gnu.org> wrote:
> This isn't Mark's fault, but I believe not to deprecate and remove
> this (mis)feature is the wrong decision. The argument that was made
> for keeping it was: [elided]
My argument for keeping it is that it's widely used, independent of any
technical merits. I agree that we should discourage its use, but the way
we've been aggressively removing extensions is putting a major maintenance
burden on users.
I would definitely support documentation changes telling people how to do
without the pragmas.
Jason
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15815
^ permalink raw reply [flat|nested] 20+ messages in thread
* [Bug c++/15815] Update #pragma interface and #pragma implementation documentation.
2004-06-04 1:42 [Bug c++/15815] New: Deprecate the #pragma interface and #pragma implementation hattons at globalsymmetry dot com
` (12 preceding siblings ...)
2004-06-09 19:21 ` jason at redhat dot com
@ 2004-06-09 19:35 ` bangerth at dealii dot org
2004-06-10 15:59 ` larsbj at gullik dot net
` (4 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: bangerth at dealii dot org @ 2004-06-09 19:35 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From bangerth at dealii dot org 2004-06-09 19:35 -------
Alright. Though the original claim of this PR was that we should first
describe in the docs _how_ to use this feature, not how _not_ to use it,
since apparently it has never really been described all that well. I can't
really believe that it is widely used.
W.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15815
^ permalink raw reply [flat|nested] 20+ messages in thread
* [Bug c++/15815] Update #pragma interface and #pragma implementation documentation.
2004-06-04 1:42 [Bug c++/15815] New: Deprecate the #pragma interface and #pragma implementation hattons at globalsymmetry dot com
` (13 preceding siblings ...)
2004-06-09 19:35 ` bangerth at dealii dot org
@ 2004-06-10 15:59 ` larsbj at gullik dot net
2004-06-10 17:35 ` jason at redhat dot com
` (3 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: larsbj at gullik dot net @ 2004-06-10 15:59 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From larsbj at gullik dot net 2004-06-10 15:59 -------
Just as a data point. In LyX we used to have those pragmas, then we checked if
they worked as expected:
gcc --version
gcc (GCC) 3.2 20020903 (Red Hat Linux 8.0 3.2-7)
All pragmas removed:
size src/lyx
text data bss dec hex filename
2792162 80600 48796 2921558 2c9456 src/lyx
ls -l src/lyx
-rwxrwxr-x 1 larsbj larsbj 74322762 Jan 4 00:14 src/lyx
Pragmas in place:
size src/lyx
text data bss dec hex filename
2812994 80600 48800 2942394 2ce5ba src/lyx
ls -l src/lyx
-rwxrwxr-x 1 larsbj larsbj 70111256 Jan 4 01:01 src/lyx
So we ended up with removing them from LyX.
LyX is a 150K+ LOC project.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15815
^ permalink raw reply [flat|nested] 20+ messages in thread
* [Bug c++/15815] Update #pragma interface and #pragma implementation documentation.
2004-06-04 1:42 [Bug c++/15815] New: Deprecate the #pragma interface and #pragma implementation hattons at globalsymmetry dot com
` (14 preceding siblings ...)
2004-06-10 15:59 ` larsbj at gullik dot net
@ 2004-06-10 17:35 ` jason at redhat dot com
2004-07-07 17:25 ` cvs-commit at gcc dot gnu dot org
` (2 subsequent siblings)
18 siblings, 0 replies; 20+ messages in thread
From: jason at redhat dot com @ 2004-06-10 17:35 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From jason at redhat dot com 2004-06-10 17:35 -------
Subject: Re: Update #pragma interface and #pragma
implementation documentation.
On 10 Jun 2004 15:59:03 -0000, "larsbj at gullik dot net" <gcc-bugzilla@gcc.gnu.org> wrote:
> All pragmas removed:
> text data bss dec hex filename
> 2792162 80600 48796 2921558 2c9456 src/lyx
> -rwxrwxr-x 1 larsbj larsbj 74322762 Jan 4 00:14 src/lyx
>
> Pragmas in place:
> text data bss dec hex filename
> 2812994 80600 48800 2942394 2ce5ba src/lyx
> -rwxrwxr-x 1 larsbj larsbj 70111256 Jan 4 01:01 src/lyx
Interesting that text size is smaller without the #pragmas, but file size
is larger. My guess is that the difference in text size is due to always
emitting an out-of-line version of functions which would otherwise always
be inlined, and that the difference in file size is due to debug info
following the #pragmas. I'm not sure why there would be so much difference
in debug info; perhaps there are a bunch of types which have no key method?
Or perhaps this is a case of duplicate debug info not being discarded. We
should really move debug info into a comdat group with the function it
corresponds to.
Jason
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15815
^ permalink raw reply [flat|nested] 20+ messages in thread
* [Bug c++/15815] Update #pragma interface and #pragma implementation documentation.
2004-06-04 1:42 [Bug c++/15815] New: Deprecate the #pragma interface and #pragma implementation hattons at globalsymmetry dot com
` (15 preceding siblings ...)
2004-06-10 17:35 ` jason at redhat dot com
@ 2004-07-07 17:25 ` cvs-commit at gcc dot gnu dot org
2004-07-07 17:38 ` cvs-commit at gcc dot gnu dot org
2004-09-09 3:54 ` pinskia at gcc dot gnu dot org
18 siblings, 0 replies; 20+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2004-07-07 17:25 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2004-07-07 17:25 -------
Subject: Bug 15815
CVSROOT: /cvs/gcc
Module name: gcc
Branch: gcc-3_4-branch
Changes by: jason@gcc.gnu.org 2004-07-07 17:25:05
Modified files:
gcc : ChangeLog
gcc/doc : extend.texi
Log message:
PR c++/15815
* doc/extend.texi (C++ Interface): Correct information and
discourage use.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=2.2326.2.538&r2=2.2326.2.539
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/doc/extend.texi.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.177.4.12&r2=1.177.4.13
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15815
^ permalink raw reply [flat|nested] 20+ messages in thread
* [Bug c++/15815] Update #pragma interface and #pragma implementation documentation.
2004-06-04 1:42 [Bug c++/15815] New: Deprecate the #pragma interface and #pragma implementation hattons at globalsymmetry dot com
` (16 preceding siblings ...)
2004-07-07 17:25 ` cvs-commit at gcc dot gnu dot org
@ 2004-07-07 17:38 ` cvs-commit at gcc dot gnu dot org
2004-09-09 3:54 ` pinskia at gcc dot gnu dot org
18 siblings, 0 replies; 20+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2004-07-07 17:38 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2004-07-07 17:38 -------
Subject: Bug 15815
CVSROOT: /cvs/gcc
Module name: gcc
Changes by: jason@gcc.gnu.org 2004-07-07 17:38:41
Modified files:
gcc : ChangeLog
gcc/doc : extend.texi
Log message:
PR c++/15815
* doc/extend.texi (C++ Interface): Correct information and
discourage use.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.4339&r2=2.4340
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/doc/extend.texi.diff?cvsroot=gcc&r1=1.199&r2=1.200
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15815
^ permalink raw reply [flat|nested] 20+ messages in thread
* [Bug c++/15815] Update #pragma interface and #pragma implementation documentation.
2004-06-04 1:42 [Bug c++/15815] New: Deprecate the #pragma interface and #pragma implementation hattons at globalsymmetry dot com
` (17 preceding siblings ...)
2004-07-07 17:38 ` cvs-commit at gcc dot gnu dot org
@ 2004-09-09 3:54 ` pinskia at gcc dot gnu dot org
18 siblings, 0 replies; 20+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-09-09 3:54 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pinskia at gcc dot gnu dot org 2004-09-09 03:54 -------
Fixed for 3.4.2.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
Target Milestone|--- |3.4.2
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15815
^ permalink raw reply [flat|nested] 20+ messages in thread
end of thread, other threads:[~2004-09-09 3:54 UTC | newest]
Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-06-04 1:42 [Bug c++/15815] New: Deprecate the #pragma interface and #pragma implementation hattons at globalsymmetry dot com
2004-06-04 1:58 ` [Bug c++/15815] " pinskia at gcc dot gnu dot org
2004-06-07 16:38 ` mmitchel at gcc dot gnu dot org
2004-06-07 19:21 ` cvs-commit at gcc dot gnu dot org
2004-06-07 19:23 ` cvs-commit at gcc dot gnu dot org
2004-06-07 19:25 ` [Bug c++/15815] Remove " mmitchel at gcc dot gnu dot org
2004-06-08 3:45 ` danglin at gcc dot gnu dot org
2004-06-08 3:47 ` pinskia at gcc dot gnu dot org
2004-06-08 20:03 ` mark at codesourcery dot com
2004-06-09 18:32 ` cvs-commit at gcc dot gnu dot org
2004-06-09 18:34 ` cvs-commit at gcc dot gnu dot org
2004-06-09 18:35 ` [Bug c++/15815] Update #pragma interface and #pragma implementation documentation mmitchel at gcc dot gnu dot org
2004-06-09 19:03 ` bangerth at dealii dot org
2004-06-09 19:21 ` jason at redhat dot com
2004-06-09 19:35 ` bangerth at dealii dot org
2004-06-10 15:59 ` larsbj at gullik dot net
2004-06-10 17:35 ` jason at redhat dot com
2004-07-07 17:25 ` cvs-commit at gcc dot gnu dot org
2004-07-07 17:38 ` cvs-commit at gcc dot gnu dot org
2004-09-09 3:54 ` pinskia at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).