[Bug bootstrap/16182] New: wctype.h not included by c++locale_internal.h

[Bug bootstrap/16182] New: wctype.h not included by c++locale_internal.h

[rearnsha at gcc dot gnu dot org]

Bootstrap on arm-linux fails in libstdc++ because of missing types.  It seems
that gnu/c++local_internal.h needs to pull in wctype.h first.

This is using the nw9 image for a netwinder (substantially RedHat 8.0 built for
ARM).

-- 
           Summary: wctype.h not included by c++locale_internal.h
           Product: gcc
           Version: 3.5.0
            Status: UNCONFIRMED
          Keywords: build
          Severity: critical
          Priority: P2
         Component: bootstrap
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: rearnsha at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: armv4l-unknown-linux-gnu
  GCC host triplet: armv4l-unknown-linux-gnu
GCC target triplet: armv4l-unknown-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16182

[Bug bootstrap/16182] wctype.h not included by c++locale_internal.h

[rearnsha at gcc dot gnu dot org]

------- Additional Comments From rearnsha at gcc dot gnu dot org  2004-06-24 19:17 -------
In file included from codecvt_members.cc:37:
/home/rearnsha/gnu/gcc-3.4-build/armv4l-unknown-linux-gnu/libstdc++-v3/include/armv4l-unknown-linux-gnu/bits/c++locale_internal.h:36:
error: `iswctype_l' was not declared in this scope
/home/rearnsha/gnu/gcc-3.4-build/armv4l-unknown-linux-gnu/libstdc++-v3/include/armv4l-unknown-linux-gnu/bits/c++locale_internal.h:36:
error: invalid type in declaration before ';' token
/home/rearnsha/gnu/gcc-3.4-build/armv4l-unknown-linux-gnu/libstdc++-v3/include/armv4l-unknown-linux-gnu/bits/c++locale_internal.h:44:
error: `towlower_l' was not declared in this scope
/home/rearnsha/gnu/gcc-3.4-build/armv4l-unknown-linux-gnu/libstdc++-v3/include/armv4l-unknown-linux-gnu/bits/c++locale_internal.h:44:
error: invalid type in declaration before ';' token
/home/rearnsha/gnu/gcc-3.4-build/armv4l-unknown-linux-gnu/libstdc++-v3/include/armv4l-unknown-linux-gnu/bits/c++locale_internal.h:45:
error: `towupper_l' was not declared in this scope
/home/rearnsha/gnu/gcc-3.4-build/armv4l-unknown-linux-gnu/libstdc++-v3/include/armv4l-unknown-linux-gnu/bits/c++locale_internal.h:45:
error: invalid type in declaration before ';' token


etc.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16182

[Bug libstdc++/16182] wctype.h not included by c++locale_internal.h

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|bootstrap                   |libstdc++
   Target Milestone|---                         |3.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16182

[Bug bootstrap/16182] wctype.h not included by c++locale_internal.h

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-06-24 19:22 -------
*** Bug 16183 has been marked as a duplicate of this bug. ***

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16182

[Bug libstdc++/16182] wctype.h not included by c++locale_internal.h

[pcarlini at suse dot de]

------- Additional Comments From pcarlini at suse dot de  2004-06-24 19:52 -------
Something that I don't understand is happening... codecvt_members.cc includes
<bits/c++locale_internal.h> *after* <locale>. The latter includes
<bits/locale_facets.h> which definitely includes <cwctype>!

Also, other linux platforms, configured in the same way (i.e., GNU locale model),
are not experiencing this problem...

Ideas?

Thanks, Paolo.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16182

[Bug libstdc++/16182] wctype.h not included by c++locale_internal.h

[pcarlini at suse dot de]

------- Additional Comments From pcarlini at suse dot de  2004-06-24 20:08 -------
Maybe _GLIBCXX_HAVE_WCTYPE_H is not defined in

 */libstdc++-v3/include/*/bits/c++config.h

??

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16182

[Bug libstdc++/16182] wctype.h not included by c++locale_internal.h

[rearnsha at gcc dot gnu dot org]

------- Additional Comments From rearnsha at gcc dot gnu dot org  2004-06-24 23:09 -------
Hmm, it seems that when checking for wctype.h configure has written the
following line into conftest.c

#define ${ac_tr_func} 1

That of course causes a failure when passed to the C++ compiler.

I'll investigate further.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16182

[Bug libstdc++/16182] [3.4.1, 3.5.0 regression] wctype.h not included by c++locale_internal.h

[rearnsha at gcc dot gnu dot org]

------- Additional Comments From rearnsha at gcc dot gnu dot org  2004-06-25 00:51 -------
This would appear to be a bug in configure.  Note that it also affects 3.4.1
since the change was installed there as well.

linkage.m4 defines a function to test for linkage of certain builtin functions,
for example __builtin_abs.  If the test succeeds, then AC_DEFINE is used to
generate an entry in configure to write to confdefs.h as follows:

cat >>confdefs.h <<\_ACEOF
#define ${ac_tr_func} 1
_ACEOF

Now my manual for bash says:

       The format of here-documents is:

              <<[-]word
                      here-document
              delimiter

       No parameter expansion, command substitution, arithmetic expansion,  or
       pathname expansion is performed on word.  If any characters in word are
       quoted, the delimiter is the result of quote removal on word,  and  the
       lines  in the here-document are not expanded.  If word is unquoted, all
       lines of the here-document are subjected to parameter  expansion,  com-
       mand  substitution,  and arithmetic expansion.  

So since _ACEOF is quoted the line is written without expansion directly into
confdefs.h.  When that is then compiled it causes the compiler to error out on
all subsequent tests.

The solution appears to be to use AC_DEFINE_UNQUOTED in linkage.m4, but that is
exactly what Ben removed in his patch of 10th June.  I don't understand why,
though it was done here:
http://gcc.gnu.org/ml/libstdc++/2004-06/msg00065.html

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bkoz at redhat dot com, mark
                   |                            |at codesourcery dot com
      Known to fail|                            |3.5.0 3.4.1
      Known to work|                            |3.4.0
            Summary|wctype.h not included by    |[3.4.1, 3.5.0 regression]
                   |c++locale_internal.h        |wctype.h not included by
                   |                            |c++locale_internal.h


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16182

[Bug libstdc++/16182] [3.4.1, 3.5.0 regression] wctype.h not included by c++locale_internal.h

[mark at codesourcery dot com]

------- Additional Comments From mark at codesourcery dot com  2004-06-25 04:48 -------
Subject: Re:  [3.4.1, 3.5.0 regression] wctype.h not
 included by c++locale_internal.h

rearnsha at gcc dot gnu dot org wrote:

>------- Additional Comments From rearnsha at gcc dot gnu dot org  2004-06-25 00:51 -------
>This would appear to be a bug in configure.  Note that it also affects 3.4.1
>since the change was installed there as well.
>
>linkage.m4 defines a function to test for linkage of certain builtin functions,
>for example __builtin_abs.  If the test succeeds, then AC_DEFINE is used to
>generate an entry in configure to write to confdefs.h as follows:
>
>  
>
...

>The solution appears to be to use AC_DEFINE_UNQUOTED in linkage.m4, but that is
>exactly what Ben removed in his patch of 10th June.  I don't understand why,
>though it was done here:
>http://gcc.gnu.org/ml/libstdc++/2004-06/msg00065.html
>  
>
Benjamin, would you please comment on this issue?

Thanks,



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16182

[Bug libstdc++/16182] [3.4.1, 3.5.0 regression] wctype.h not included by c++locale_internal.h

[bkoz at gcc dot gnu dot org]

------- Additional Comments From bkoz at gcc dot gnu dot org  2004-06-25 06:39 -------

This was done so cygwin/mingw cross compiling worked. The linkage.m4 bits are
cleanup, however. By using AC_DEFINE, the hacky bits WRT HAVE___BUILTIN_COSF et.
al. could be removed and autoheader would work. For whatever reason, it's not
working for Richard, and right ow I pretty much don't care how gross this file
is or becomes......

Reverting

* linkage.m4: Comment LIBMATHOBJS, tweak others.  AC_DEFINES for
	builtin math functions instead of AC_DEFINE_UNQUOTED.

Should fix this.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16182

[Bug libstdc++/16182] [3.4.1, 3.5.0 regression] wctype.h not included by c++locale_internal.h

[mark at codesourcery dot com]

------- Additional Comments From mark at codesourcery dot com  2004-06-25 17:01 -------
Subject: Re:  [3.4.1, 3.5.0 regression] wctype.h not
 included by c++locale_internal.h

rearnsha at gcc dot gnu dot org wrote:

>------- Additional Comments From rearnsha at gcc dot gnu dot org  2004-06-25 00:51 -------
>This would appear to be a bug in configure.  Note that it also affects 3.4.1
>since the change was installed there as well.
>  
>
Did Benjamin's patch solve your problem, Richard?



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16182

Re: [Bug libstdc++/16182] [3.4.1, 3.5.0 regression] wctype.h not included by c++locale_internal.h

[Richard Earnshaw]

On Fri, 2004-06-25 at 18:01, mark at codesourcery dot com wrote:
> Did Benjamin's patch solve your problem, Richard?

My arm-linux box is at home.  I can't finish testing until I get home
tonight.

[Bug libstdc++/16182] [3.4.1, 3.5.0 regression] wctype.h not included by c++locale_internal.h

[rearnsha at gcc dot gnu dot org]

------- Additional Comments From rearnsha at gcc dot gnu dot org  2004-06-25 17:08 -------
Subject: Re:  [3.4.1, 3.5.0 regression] wctype.h not
	included by c++locale_internal.h

On Fri, 2004-06-25 at 18:01, mark at codesourcery dot com wrote:
> Did Benjamin's patch solve your problem, Richard?

My arm-linux box is at home.  I can't finish testing until I get home
tonight.



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16182

[Bug libstdc++/16182] [3.4.1, 3.5.0 regression] wctype.h not included by c++locale_internal.h

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-06-25 17:46 -------
Subject: Bug 16182

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	bkoz@gcc.gnu.org	2004-06-25 17:45:43

Modified files:
	libstdc++-v3   : ChangeLog configure linkage.m4 

Log message:
	2004-06-25  Benjamin Kosnik  <bkoz@redhat.com>
	
	PR libstdc++/16182
	* linkage.m4 (GLIBCXX_CHECK_BUILTIN_MATH_DEC): Revert to
	AC_DEFINE_UNQUOTED.
	* configure: Regenerate.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/ChangeLog.diff?cvsroot=gcc&r1=1.2541&r2=1.2542
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/configure.diff?cvsroot=gcc&r1=1.392&r2=1.393
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/linkage.m4.diff?cvsroot=gcc&r1=1.9&r2=1.10



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16182

[Bug libstdc++/16182] [3.4.1, 3.5.0 regression] wctype.h not included by c++locale_internal.h

[rearnsha at gcc dot gnu dot org]

------- Additional Comments From rearnsha at gcc dot gnu dot org  2004-06-25 21:45 -------
I can now confirm that pulling up Ben's change onto the 3.4 branch allows
bootstrap on the branch to complete.

Mark, can you authorize the pull up there please.

R.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2004-06-25 21:45:03
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16182

[Bug libstdc++/16182] [3.4.1 Regression] wctype.h not included by c++locale_internal.h

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|3.5.0 3.4.1                 |3.4.1
      Known to work|3.4.0                       |3.4.0 3.5.0
            Summary|[3.4.1, 3.5.0 regression]   |[3.4.1 Regression] wctype.h
                   |wctype.h not included by    |not included by
                   |c++locale_internal.h        |c++locale_internal.h
   Target Milestone|3.5.0                       |3.4.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16182

[Bug libstdc++/16182] [3.4.1 Regression] wctype.h not included by c++locale_internal.h

[mmitchel at gcc dot gnu dot org]

------- Additional Comments From mmitchel at gcc dot gnu dot org  2004-06-25 22:02 -------
Applied.  Fixed in GCC 3.4.1.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|3.4.2                       |3.4.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16182

[Bug libstdc++/16182] [3.4.1 Regression] wctype.h not included by c++locale_internal.h

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-06-25 22:03 -------
Subject: Bug 16182

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_4-branch
Changes by:	mmitchel@gcc.gnu.org	2004-06-25 22:03:21

Modified files:
	libstdc++-v3   : ChangeLog linkage.m4 configure 

Log message:
	PR libstdc++/16182
	* linkage.m4 (GLIBCXX_CHECK_BUILTIN_MATH_DEC): Revert to
	AC_DEFINE_UNQUOTED.
	* configure: Regenerate.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.2224.2.132&r2=1.2224.2.133
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/linkage.m4.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.4.4.3&r2=1.4.4.4
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/configure.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.373.4.12&r2=1.373.4.13



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16182