public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rsandifo at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/16176] [3.4 Regression] Miscompilation of unaligned data in MIPS backend (SB1 flavor)
Date: Fri, 25 Jun 2004 18:52:00 -0000	[thread overview]
Message-ID: <20040625184250.23220.qmail@sourceware.org> (raw)
In-Reply-To: <20040624153824.16176.pkoning@equallogic.com>


------- Additional Comments From rsandifo at gcc dot gnu dot org  2004-06-25 18:42 -------
Patch applied:

    http://gcc.gnu.org/ml/gcc-patches/2004-06/msg02085.html

Mark, you know what I'm going to ask ;)  Is this OK for 3.4.1?  Or should
it wait until 3.4.2?

Perhaps the patch isn't quite as obvious as the one you approved earlier
today.  But IMO it _is_ still obvious.  And safe.  The bug here is also
much more serious, since it only shows up at run time (rather than
link time).

I suppose every patch carries some amount of risk.  But like I say,
I think the risk in this case is very small, and I think it's obvious
that the new code is theoretically more correct.  From that POV,
I'd imagine the risk is more of introducing an ICE than introducing
another wrong code bug.

Err... couldn't decide whether to delete that last paragraph or not ;)


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mmitchel at gcc dot gnu dot
                   |                            |org
      Known to work|                            |3.3.3 3.5.0
            Summary|Miscompilation of unaligned |[3.4 Regression]
                   |data in MIPS backend (SB1   |Miscompilation of unaligned
                   |flavor)                     |data in MIPS backend (SB1
                   |                            |flavor)
   Target Milestone|---                         |3.4.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16176


  parent reply	other threads:[~2004-06-25 18:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-24 15:38 [Bug target/16176] New: " pkoning at equallogic dot com
2004-06-24 15:56 ` [Bug target/16176] " pkoning at equallogic dot com
2004-06-24 17:26 ` pkoning at equallogic dot com
2004-06-24 18:26 ` rsandifo at gcc dot gnu dot org
2004-06-25 18:34 ` cvs-commit at gcc dot gnu dot org
2004-06-25 18:37 ` pkoning at equallogic dot com
2004-06-25 18:52 ` rsandifo at gcc dot gnu dot org [this message]
2004-06-25 18:56 ` [Bug target/16176] [3.4 Regression] " mark at codesourcery dot com
2004-06-28 14:00 ` cvs-commit at gcc dot gnu dot org
2004-06-28 14:17 ` rsandifo at gcc dot gnu dot org
2004-06-28 16:30 ` pinskia at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040625184250.23220.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).