public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "tim dot vanholder at anubex dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/16370] New: __attribute__((deprecated)) not useful on classes, and ugly function name listed for deperecation warnings on constructor
Date: Mon, 05 Jul 2004 13:44:00 -0000	[thread overview]
Message-ID: <20040705134454.16370.tim.vanholder@anubex.com> (raw)

When __attribute__((deprecated)) is applied to a class, gcc only warns when the
class name is used in a typedef, not when the class is instantiated or if static
class members are referenced.  This makes the attribute of limited use for
classes, requiring adding the attribute to every member as well.
On constructors, the warning that is given uses an uglified function name.

Simple test case:

class foo {
public:
  static const int something;
} __attribute__((deprecated));

typedef class foo FOO; // warns like it should

class foo2 {
  int value_;
public:
  foo2(void);
  foo2(int) __attribute__((deprecated));
  void bar(void) __attribute__((deprecated));
};

foo2::foo2(void) : value_(0) { }

foo2::foo2(int v) : value_(v) { }

void
foo2::bar(void)
{
  this->value_ += 42;
}

void
xyzzy(void)
{
  foo test1; // should warn, but doesn't
  foo* test2 = new foo; // should warn, but doesn't
  delete test2;
  FOO test3; // no warning, but that's ok, the typedef shows warning
  int test4 = foo::something; // should warn, but doesn't
  foo2 test5;
  test5.bar(); // warns like it should
  foo2 test6(foo::something); // should warn twice, but only warns once and
                              // uses ugly method name (__comp_ctor)
}

int
main(void)
{
  xyzzy();
  return 0;
}

Resulting output:

xxx.cc:6: warning: `foo' is deprecated (declared at xxx.cc:1)
xxx.cc: In function `void xyzzy()':
xxx.cc:35: warning: `bar' is deprecated (declared at xxx.cc:22)
xxx.cc:36: warning: `__comp_ctor' is deprecated (declared at xxx.cc:18)

Note that errors also refer to the last seen declaration or definition, and not
the declaration - but there already is a bug report for that.

-- 
           Summary: __attribute__((deprecated)) not useful on classes, and
                    ugly function name listed for deperecation warnings on
                    constructor
           Product: gcc
           Version: 3.4.0
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: tim dot vanholder at anubex dot com
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: i686-pc-linux-gnu
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: i686-pc-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16370


             reply	other threads:[~2004-07-05 13:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-05 13:44 tim dot vanholder at anubex dot com [this message]
2004-08-02  1:14 ` [Bug c++/16370] " pinskia at gcc dot gnu dot org
2004-11-01  0:28 ` pinskia at gcc dot gnu dot org
2005-05-01  3:41 ` pinskia at gcc dot gnu dot org
2005-05-01  5:21   ` Gabriel Dos Reis
2005-05-01  5:21 ` gdr at integrable-solutions dot net

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040705134454.16370.tim.vanholder@anubex.com \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).