public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ehrhardt at mathematik dot uni-ulm dot de" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/16443] [3.5 Regression] ICE during linux kernel compilation
Date: Tue, 13 Jul 2004 15:16:00 -0000	[thread overview]
Message-ID: <20040713151646.26448.qmail@sourceware.org> (raw)
In-Reply-To: <20040708212530.16443.ak@muc.de>


------- Additional Comments From ehrhardt at mathematik dot uni-ulm dot de  2004-07-13 15:16 -------
Hi,

the following part from the patch identified by Volker looks
very suspicious:

+		EXECUTE_IF_SET_IN_BITMAP (call_clobbered_vars, 0, i,
+		    {
+		      tree var = referenced_var (i);
+		      add_stmt_operand (&var, stmt, opf_is_def, prev_vops);
+		    });

We're passing the address of a local var down to add_stmt_operand.
add_stmt_operand will add this _address_, i.e. &var to the statement
operands. This is bound to fail as soon as we leave the scope of var.

The following might be a temporary solution:

Index: tree-ssa-operands.c
===================================================================
RCS file: /cvsroot/gcc/gcc/gcc/tree-ssa-operands.c,v
retrieving revision 2.15
diff -u -r2.15 tree-ssa-operands.c
--- tree-ssa-operands.c	8 Jul 2004 15:03:10 -0000	2.15
+++ tree-ssa-operands.c	13 Jul 2004 15:08:53 -0000
@@ -1229,36 +1229,7 @@
   for (link = ASM_CLOBBERS (stmt); link; link = TREE_CHAIN (link))
     if (strcmp (TREE_STRING_POINTER (TREE_VALUE (link)), "memory") == 0)
       {
-	size_t i;
-
-	/* If we still have not computed aliasing information, we
-	   won't know what variables are call-clobbered and/or
-	   addressable.  Just mark the statement as having volatile
-	   operands for now.  */
-	if (!aliases_computed_p)
-	  {
-	    stmt_ann (stmt)->has_volatile_ops = true;
-	    break;
-	  }
-
-	/* Clobber all call-clobbered variables (or .GLOBAL_VAR if we
-	   decided to group them).  */
-	if (global_var)
-	  add_stmt_operand (&global_var, stmt, opf_is_def, prev_vops);
-	else
-	  EXECUTE_IF_SET_IN_BITMAP (call_clobbered_vars, 0, i,
-	      {
-		tree var = referenced_var (i);
-		add_stmt_operand (&var, stmt, opf_is_def, prev_vops);
-	      });
-
-	/* Now clobber all addressables.  */
-	EXECUTE_IF_SET_IN_BITMAP (addressable_vars, 0, i,
-	    {
-	      tree var = referenced_var (i);
-	      add_stmt_operand (&var, stmt, opf_is_def, prev_vops);
-	    });
-
+	stmt_ann (stmt)->has_volatile_ops = true;
 	break;
       }
 }


     regards   Christian



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16443


  parent reply	other threads:[~2004-07-13 15:16 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-08 21:25 [Bug tree-optimization/16443] New: " ak at muc dot de
2004-07-08 21:30 ` [Bug tree-optimization/16443] " ak at muc dot de
2004-07-08 21:59 ` [Bug tree-optimization/16443] [3.5 Regression] " pinskia at gcc dot gnu dot org
2004-07-09  4:13 ` ak at muc dot de
2004-07-10  5:54 ` ak at muc dot de
2004-07-12  6:27 ` pinskia at gcc dot gnu dot org
2004-07-13  2:22 ` reichelt at gcc dot gnu dot org
2004-07-13  7:34 ` ak at muc dot de
2004-07-13  8:08 ` reichelt at gcc dot gnu dot org
2004-07-13  9:07 ` reichelt at gcc dot gnu dot org
2004-07-13 10:48 ` dnovillo at gcc dot gnu dot org
2004-07-13 15:16 ` ehrhardt at mathematik dot uni-ulm dot de [this message]
2004-07-13 15:44 ` dnovillo at redhat dot com
2004-07-13 18:14 ` dnovillo at gcc dot gnu dot org
2004-07-13 20:51 ` cvs-commit at gcc dot gnu dot org
2004-07-13 20:55 ` dnovillo at gcc dot gnu dot org
2004-07-14 14:23 ` ak at muc dot de

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040713151646.26448.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).