[Bug c++/16617] New: Fail to do access checking correctly for non-dependent qualified-id

[Bug c++/16617] New: Fail to do access checking correctly for non-dependent qualified-id

[lerdsuwa at gcc dot gnu dot org]

This is a spin out of a problem mentioned in PR13092.
The following testcase shouldn't compile because only
fr<int> is friend of class D.  But we are accessing
protected members from fr<char>.  GCC 3.4, 3.5 fail
to diagnose it.  Earlier GCC don't handle this properly
(checking access while parsing the template fr<T> which
is too early.)  So it's not a regression.


// Two-phase name lookup for address of member:
// Protected member access

class B
{
  protected:
  int i;			// { dg-error "protected" }
};

template <class T> void fr ();

class D2 : public B
{
  friend void fr<int> ();
};

template<int B::*> struct X
{};

template <class T> void fr ()
{
  X<&B::i> x1;			// { dg-error "context" }
  X<&D2::i> x2;			// { dg-error "context" }
}

template void fr<char>();	// { dg-error "instantiated" }

-- 
           Summary: Fail to do access checking correctly for non-dependent
                    qualified-id
           Product: gcc
           Version: 3.5.0
            Status: UNCONFIRMED
          Keywords: accepts-invalid
          Severity: normal
          Priority: P2
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: lerdsuwa at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16617

[Bug c++/16617] Fail to do access checking correctly for non-dependent qualified-id

[giovannibajo at libero dot it]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |giovannibajo at libero dot
                   |                            |it


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16617

[Bug c++/16617] Fail to do access checking correctly for non-dependent qualified-id

[bangerth at dealii dot org]

------- Additional Comments From bangerth at dealii dot org  2004-07-28 13:48 -------
Confirmed. 
W. 

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2004-07-28 13:48:57
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16617

[Bug c++/16617] Fail to do access checking correctly for non-dependent qualified-id

[lerdsuwa at gcc dot gnu dot org]

------- Additional Comments From lerdsuwa at gcc dot gnu dot org  2004-12-12 12:42 -------
Got it.  The target for this fix is GCC 4.1.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |lerdsuwa at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16617

[Bug c++/16617] Fail to do access checking correctly for non-dependent qualified-id

[lerdsuwa at gcc dot gnu dot org]

------- Additional Comments From lerdsuwa at gcc dot gnu dot org  2005-01-12 10:50 -------
May be fixed together with PR19311.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16617

[Bug c++/16617] Fail to do access checking correctly for non-dependent qualified-id

[lerdsuwa at gcc dot gnu dot org]

------- Additional Comments From lerdsuwa at gcc dot gnu dot org  2005-04-23 15:30 -------
This is a stage 2 project.  Likely to be fixed in a month or two.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16617

[Bug c++/16617] Fail to do access checking correctly for non-dependent qualified-id

[lerdsuwa at gcc dot gnu dot org]

------- Additional Comments From lerdsuwa at gcc dot gnu dot org  2005-05-19 17:09 -------
Patch using new approach for 4.1:
  http://gcc.gnu.org/ml/gcc-patches/2005-05/msg01992.html
(Note this is part 4 in a series, earlier parts are also required)


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2005-
                   |                            |05/msg01992.html
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16617

[Bug c++/16617] Fail to do access checking correctly for non-dependent qualified-id

[lerdsuwa at gcc dot gnu dot org]

------- Additional Comments From lerdsuwa at gcc dot gnu dot org  2005-06-07 14:58 -------
Patch withdrawn due to overlooking default function argument and default
template argument. No nice solution is found yet.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|lerdsuwa at gcc dot gnu dot |unassigned at gcc dot gnu
                   |org                         |dot org
             Status|ASSIGNED                    |NEW
           Keywords|patch                       |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16617

[Bug c++/16617] Fail to do access checking correctly for non-dependent qualified-id

[ppalka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=16617

Patrick Palka <ppalka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |ppalka at gcc dot gnu.org
   Target Milestone|---                         |11.0
         Resolution|---                         |FIXED

--- Comment #10 from Patrick Palka <ppalka at gcc dot gnu.org> ---
Fixed for GCC 11 by the patch for PR41437.

[Bug c++/16617] Fail to do access checking correctly for non-dependent qualified-id

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=16617

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:330cc29c06306ebf7bd3b2d37704cc69944923ff

commit r12-69-g330cc29c06306ebf7bd3b2d37704cc69944923ff
Author: Patrick Palka <ppalka@redhat.com>
Date:   Thu Apr 22 13:32:40 2021 -0400

    c++: Add testcase for already fixed PR [PR16617]

    We correctly diagnose the invalid access since r11-1350.

    gcc/testsuite/ChangeLog:

            PR c++/16617
            * g++.dg/template/access36.C: New test.

[Bug c++/16617] Fail to do access checking correctly for non-dependent qualified-id

[pinskia at gcc dot gnu dot org]

------- Comment #7 from pinskia at gcc dot gnu dot org  2009-04-29 07:05 -------
*** Bug 33934 has been marked as a duplicate of this bug. ***


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sutambe at yahoo dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16617

[Bug c++/16617] Fail to do access checking correctly for non-dependent qualified-id

[pinskia at gcc dot gnu dot org]

------- Comment #8 from pinskia at gcc dot gnu dot org  2009-04-29 07:05 -------
*** Bug 24118 has been marked as a duplicate of this bug. ***


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rguenth at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16617