[Bug preprocessor/16950] New: [3.5 regression]: -Wno-deprecated doesn't work

[Bug preprocessor/16950] New: [3.5 regression]: -Wno-deprecated doesn't work

[hjl at lucon dot org]

I got

FAIL: backward/11460.cc (test for excess errors)
FAIL: backward/header_deque_h.cc (test for excess errors)
FAIL: backward/header_hash_map_h.cc (test for excess errors)
FAIL: backward/header_hash_set_h.cc (test for excess errors)
FAIL: backward/header_hashtable_h.cc (test for excess errors)
FAIL: backward/header_iterator_h.cc (test for excess errors)
FAIL: backward/header_rope_h.cc (test for excess errors)
FAIL: backward/header_slist_h.cc (test for excess errors)
FAIL: backward/header_tempbuf_h.cc (test for excess errors)
FAIL: backward/strstream_members.cc (test for excess errors)

[hjl@gnu-20 gcc]$ cat /tmp/foo.cc
#ifdef __DEPRECATED
#warning To disable this warning use -Wno-deprecated.
#endif
[hjl@gnu-20 gcc]$ ./xgcc -B./ -c /tmp/foo.cc
/tmp/foo.cc:2:2: warning: #warning To disable this warning use -Wno-deprecated.
[hjl@gnu-20 gcc]$ ./xgcc -B./ -c /tmp/foo.cc -Wno-deprecated
/tmp/foo.cc:2:2: warning: #warning To disable this warning use -Wno-deprecated.

-- 
           Summary: [3.5 regression]: -Wno-deprecated doesn't work
           Product: gcc
           Version: 3.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: preprocessor
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: hjl at lucon dot org
                CC: gcc-bugs at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16950

[Bug preprocessor/16950] [3.5 regression] -Wno-deprecated doesn't work

[bangerth at dealii dot org]

------- Additional Comments From bangerth at dealii dot org  2004-08-09 20:05 -------
This works on my system with a snapshot from 2004-07-27. If it is broken 
now, it must have been broken after that. 
 
BTW: I can't seem to find any mention of the string "DEPRECATED" in the 
manuals. Shouldn't we document this? 
 
W. 

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[3.5 regression]: -Wno-     |[3.5 regression] -Wno-
                   |deprecated doesn't work     |deprecated doesn't work


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16950

[Bug c++/16950] [3.5 regression] -Wno-deprecated doesn't work

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-08-09 21:14 -------
Confirmed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
          Component|preprocessor                |c++
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2004-08-09 21:14:25
               date|                            |
   Target Milestone|---                         |3.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16950

[Bug c++/16950] [3.5 regression] -Wno-deprecated doesn't work

[bangerth at dealii dot org]

------- Additional Comments From bangerth at dealii dot org  2004-08-09 21:34 -------
Uhm, I can't confirm this with a compiler built only minutes ago: 
 
g/x> /home/bangerth/bin/gcc-3.5-pre/bin/c++ -c x.cc -Wno-deprecated 
 
g/x> /home/bangerth/bin/gcc-3.5-pre/bin/c++ -c x.cc 
x.cc:2:2: warning: #warning To disable this warning use -Wno-deprecated. 
 
g/x> /home/bangerth/bin/gcc-3.5-pre/bin/c++ -v 
Reading specs 
from /home/bangerth/bin/gcc-3.5-pre/lib/gcc/i686-pc-linux-gnu/3.5.0/specs 
Configured with: ../gcc-3.5/configure --prefix=/home/bangerth/bin/gcc-3.5-pre 
--enable-languages=c,c++ --enable-checking 
Thread model: posix 
gcc version 3.5.0 20040809 (experimental) 
 
What am I doing wrong? 
 
W. 

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16950

[Bug c++/16950] [3.5 regression] -Wno-deprecated doesn't work

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-08-09 21:36 -------
Hmm, I do see the failures though, see <http://gcc.gnu.org/ml/gcc-testresults/2004-08/
msg00367.html>.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16950

[Bug preprocessor/16950] [3.5 regression] -Wno-deprecated doesn't work

[hjl at lucon dot org]

------- Additional Comments From hjl at lucon dot org  2004-08-09 21:41 -------
Kelly, your patch

http://gcc.gnu.org/ml/gcc-patches/2004-07/msg02019.html

breaks -Wno-deprecated in C++. You can't define the same option in 2 opt files.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |kcook at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED
          Component|c++                         |preprocessor
   Target Milestone|3.5.0                       |---


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16950

[Bug c++/16950] [3.5 regression] -Wno-deprecated doesn't work

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-08-09 21:44 -------
First the flag has been in both files for a long time so ...

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|preprocessor                |c++
   Target Milestone|---                         |3.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16950

[Bug preprocessor/16950] [3.5 regression] -Wno-deprecated doesn't work

[hjl at lucon dot org]

------- Additional Comments From hjl at lucon dot org  2004-08-09 21:48 -------
Sure. Only of them used Var ().

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|c++                         |preprocessor
   Target Milestone|3.5.0                       |---


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16950

[Bug preprocessor/16950] [3.5 regression] -Wno-deprecated doesn't work

[hjl at lucon dot org]

------- Additional Comments From hjl at lucon dot org  2004-08-09 21:55 -------
BTW, you need to enable Java to see the bug.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16950

[Bug preprocessor/16950] [3.5 regression] -Wno-deprecated doesn't work

[hjl at lucon dot org]

------- Additional Comments From hjl at lucon dot org  2004-08-09 22:11 -------
I think this is one way to fix it:

--- gcc/java/java-tree.h.depre  2004-08-02 08:23:11.000000000 -0700
+++ gcc/java/java-tree.h        2004-08-09 15:05:20.524087846 -0700
@@ -180,9 +180,6 @@ extern int flag_jni;
                                                                               
       
 extern int flag_extraneous_semicolon;
                                                                               
       
-/* When nonzero, report use of deprecated classes, methods, or fields.  */
-extern int flag_deprecated;
-
 /* When nonzero, always check for a non gcj generated classes archive.  */
                                                                               
       
 extern int flag_force_classes_archive_check;
--- gcc/java/lang.opt.depre     2004-08-06 11:07:21.000000000 -0700
+++ gcc/java/lang.opt   2004-08-09 15:09:15.498749481 -0700
@@ -62,8 +62,8 @@ Java
 ; Documented for C
                                                                               
       
 Wdeprecated
-Java Var(flag_deprecated) Init(1)
-Warn if deprecated class, method, or field is used
+Java Var(warn_deprecated) VarExists
+Warn if deprecated compiler feature, class, method, or field is used
                                                                               
       
 Wextraneous-semicolon
 Java Var(flag_extraneous_semicolon)
--- gcc/java/parse.y.depre      2004-08-02 16:25:19.000000000 -0700
+++ gcc/java/parse.y    2004-08-09 15:05:37.170938516 -0700
@@ -10095,7 +10095,7 @@ check_deprecation (tree wfl, tree decl)
   const char *file;
   tree elt;
  
-  if (! flag_deprecated)
+  if (! warn_deprecated)
     return;
  
   /* We want to look at the element type of arrays here, so we strip


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16950

[Bug preprocessor/16950] [3.5 regression] -Wno-deprecated doesn't work

[bangerth at dealii dot org]

------- Additional Comments From bangerth at dealii dot org  2004-08-09 22:43 -------
> BTW, you need to enable Java to see the bug. 
  
Ah, that is subtle. I never enable it because it takes so long to build 
and I'm not a Java user... 
 
It seems odd to me that the presence of a java 
compiler has any significance on the C++ compiler. Is this just my 
view? 
 
W. 

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16950

[Bug preprocessor/16950] [3.5 regression] -Wno-deprecated doesn't work

[kcook at gcc dot gnu dot org]

------- Additional Comments From kcook at gcc dot gnu dot org  2004-08-10 01:05 -------
Yes this was caused by my patch.

Actually his entire patch was included in a yet to submitted followup patch
though I clearly didn't realize that I had caused a regression after I split out
just the lang.opt part.  As there weren't any new java errors, it never occurred
to me that the C++ regressions were mine.

I would recommend that H.J's patch be applied; a case could be easily made that
this falls under the obviously correct rule.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16950

[Bug c++/16950] [3.5 regression] -Wno-deprecated doesn't work

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-08-10 04:40 -------
Fixed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
          Component|preprocessor                |c++
         Resolution|                            |FIXED
   Target Milestone|---                         |3.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16950