[Bug c/15366] New: -fno-inline-functions ignored by tree inliner for static functions

[Bug c/15366] New: -fno-inline-functions ignored by tree inliner for static functions

[nigel at mips dot com]

The -fno-inline-functions option is ignored by the tree inliner in gcc-3.4 for
static functions, even at -O2 where according to the manual it shouldn't be
enabled in the first place. For example:

static int local (int a)
{
  return a;
}

int global (int a)
{
  return a;
}

int test (int a, int b)
{
  return local (a) * global (b);
}

Compile with "-O2" or "-O3 -fno-inline-functions" and see that local() is
inlined into test(), but global() is not. This may be intentional, but it is
confusing since the manual suggests it should be otherwise, in which case this
is a documentation bug.

-- 
           Summary: -fno-inline-functions ignored by tree inliner for static
                    functions
           Product: gcc
           Version: 3.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: c
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: nigel at mips dot com
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: i686-pc-linux-gnu
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: mipsisa32-unknown-elf


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15366

[Bug optimization/15366] [unit-at-a-time] -fno-inline-functions is ignored for static functions

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-05-10 15:27 -------
Confirmed, this is an intentional change with the new flag -funit-at-a-time.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hubicka at gcc dot gnu dot
                   |                            |org
             Status|UNCONFIRMED                 |NEW
          Component|c                           |optimization
     Ever Confirmed|                            |1
           Keywords|                            |documentation
   Last reconfirmed|0000-00-00 00:00:00         |2004-05-10 15:27:11
               date|                            |
            Summary|-fno-inline-functions       |[unit-at-a-time] -fno-
                   |ignored by tree inliner for |inline-functions is ignored
                   |static functions            |for static functions
   Target Milestone|---                         |3.4.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15366

[Bug rtl-optimization/15366] [unit-at-a-time] -fno-inline-functions is ignored for static functions

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.4.1                       |3.4.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15366

[Bug rtl-optimization/15366] [unit-at-a-time] -fno-inline-functions is ignored for static functions

[mmitchel at gcc dot gnu dot org]

------- Additional Comments From mmitchel at gcc dot gnu dot org  2004-08-19 21:12 -------
I'd like to know why this is considered a desirable feature.  

It changes long-standing behavior of GCC, and means that you now have to add
-fkeep-inlinine-functions if you need those static functions to be callable from
the debugger, etc.

Jan, at the very least, the documentation needs to change.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |jh at suse dot cz
                   |dot org                     |
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15366

[Bug rtl-optimization/15366] [unit-at-a-time] -fno-inline-functions is ignored for static functions

[jh at suse dot cz]

------- Additional Comments From jh at suse dot cz  2004-08-19 23:01 -------
Subject: Re:  [unit-at-a-time] -fno-inline-functions is ignored for static functions

> 
> ------- Additional Comments From mmitchel at gcc dot gnu dot org  2004-08-19 21:12 -------
> I'd like to know why this is considered a desirable feature.  
> 
> It changes long-standing behavior of GCC, and means that you now have to add
> -fkeep-inlinine-functions if you need those static functions to be callable from
> the debugger, etc.
> 
> Jan, at the very least, the documentation needs to change.

This is what we ended up after discussion with Richard.  Technically
inlining functions called once is different optimization than normal
inlining in a way that it can't lose code size (well except for
degenerating some optimizer).  I originally had separate flag for
handling that one, but I would be happy with any sollution
(ie updating documetnation, making -fno-inline-functions to disable the
inlininf called once too or having -fno-inline-functions-called-once)
What would be the preferrence?

Honza
> 
> -- 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>          AssignedTo|unassigned at gcc dot gnu   |jh at suse dot cz
>                    |dot org                     |
>              Status|NEW                         |ASSIGNED
> 
> 
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15366
> 
> ------- You are receiving this mail because: -------
> You are the assignee for the bug, or are watching the assignee.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15366

[Bug rtl-optimization/15366] [unit-at-a-time] -fno-inline-functions is ignored for static functions

[mmitchel at gcc dot gnu dot org]

------- Additional Comments From mmitchel at gcc dot gnu dot org  2004-08-29 19:02 -------
Postponed until GCC 3.4.3.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.4.2                       |3.4.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15366

[Bug rtl-optimization/15366] [unit-at-a-time] -fno-inline-functions is ignored for static functions

[mmitchel at gcc dot gnu dot org]

------- Additional Comments From mmitchel at gcc dot gnu dot org  2004-11-01 00:45 -------
Postponed until GCC 3.4.4.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.4.3                       |3.4.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15366

[Bug rtl-optimization/15366] [unit-at-a-time] -fno-inline-functions is ignored for static functions

[mmitchel at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.4.4                       |3.4.5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15366

[Bug rtl-optimization/15366] [unit-at-a-time] -fno-inline-functions is ignored for static functions

[nomura at netapp dot com]

------- Additional Comments From nomura at netapp dot com  2005-07-26 21:32 -------
The implications of a change like this go beyond the implementation detail that
it "can't lose code size".  In our product it resulted in 10,000 static
functions disappearing due to a compiler rev -- debugging became very difficult.
 Then it was hard to hunt down exactly what to turn off since
-fno-inline-functions had no effect.  I was thinking I had to open up the code
when thankfully I came across this bug.

Please add a way to disable this form of inlining in some way.  I'm not
criticizing the optimization, but rather the difficulty in maintaining
compatibility.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15366

[Bug tree-optimization/15366] [unit-at-a-time] -fno-inline-functions is ignored for static functions

[rguenth at gcc dot gnu dot org]

------- Additional Comments From rguenth at gcc dot gnu dot org  2005-08-31 12:54 -------
I have a patch for -fno-inline-functions-called-once.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|rtl-optimization            |tree-optimization


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15366

[Bug tree-optimization/15366] [unit-at-a-time] -fno-inline-functions is ignored for static functions

[rguenth at gcc dot gnu dot org]

------- Additional Comments From rguenth at gcc dot gnu dot org  2005-08-31 13:13 -------
Patches:

4.1:
http://gcc.gnu.org/ml/gcc-patches/2005-08/msg01837.html
4.0:
http://gcc.gnu.org/ml/gcc-patches/2005-08/msg01838.html
3.4:
http://gcc.gnu.org/ml/gcc-patches/2005-08/msg01839.html

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15366

[Bug tree-optimization/15366] [unit-at-a-time] -fno-inline-functions is ignored for static functions

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-09-01 08:55 -------
Subject: Bug 15366

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	rguenth@gcc.gnu.org	2005-09-01 08:54:45

Modified files:
	gcc            : common.opt ipa-inline.c ChangeLog 
	gcc/doc        : invoke.texi 

Log message:
	2005-09-01  Richard Guenther  <rguenther@suse.de>
	
	PR tree-optimization/15366
	* common.opt: Add -finline-functions-called-once.
	Put -fearly-inlining in alphabetically ordered place.
	* doc/invoke.texi: Document new option.
	* ipa-inline.c (cgraph_decide_inlining): Honour
	flag_inline_functions_called_once.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/common.opt.diff?cvsroot=gcc&r1=1.87&r2=1.88
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ipa-inline.c.diff?cvsroot=gcc&r1=2.16&r2=2.17
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.9872&r2=2.9873
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/doc/invoke.texi.diff?cvsroot=gcc&r1=1.673&r2=1.674



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15366

[Bug tree-optimization/15366] [unit-at-a-time] -fno-inline-functions is ignored for static functions

[bobbymcn at bellsouth dot net]

------- Additional Comments From bobbymcn at bellsouth dot net  2005-09-01 09:14 -------
Subject: Re:  [unit-at-a-time] -fno-inline-functions
 is ignored for static functions

cvs-commit at gcc dot gnu dot org wrote:

>------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-09-01 08:55 -------
>Subject: Bug 15366
>
>CVSROOT:	/cvs/gcc
>Module name:	gcc
>Changes by:	rguenth@gcc.gnu.org	2005-09-01 08:54:45
>
>Modified files:
>	gcc            : common.opt ipa-inline.c ChangeLog 
>	gcc/doc        : invoke.texi 
>
>Log message:
>	2005-09-01  Richard Guenther  <rguenther@suse.de>
>	
>	PR tree-optimization/15366
>	* common.opt: Add -finline-functions-called-once.
>	Put -fearly-inlining in alphabetically ordered place.
>	* doc/invoke.texi: Document new option.
>	* ipa-inline.c (cgraph_decide_inlining): Honour
>	flag_inline_functions_called_once.
>
>Patches:
>http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/common.opt.diff?cvsroot=gcc&r1=1.87&r2=1.88
>http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ipa-inline.c.diff?cvsroot=gcc&r1=2.16&r2=2.17
>http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.9872&r2=2.9873
>http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/doc/invoke.texi.diff?cvsroot=gcc&r1=1.673&r2=1.674
>
>
>
>  
>

Message-ID: <4316C647.1080701@bellsouth.net>
Date: Thu, 01 Sep 2005 04:13:43 -0500
From: Bobby McNulty <bobbymcn@bellsouth.net>
User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To:  gcc-bugzilla@gcc.gnu.org
Subject: Re: [Bug tree-optimization/15366] [unit-at-a-time] -fno-inline-functions
 is ignored for static functions
References: <20040510152002.15366.nigel@mips.com> <20050901085505.29832.qmail@sourceware.org>
In-Reply-To: <20050901085505.29832.qmail@sourceware.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

cvs-commit at gcc dot gnu dot org wrote:

>------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-09-01 08:55 -------
>Subject: Bug 15366
>
>CVSROOT:	/cvs/gcc
>Module name:	gcc
>Changes by:	rguenth@gcc.gnu.org	2005-09-01 08:54:45
>
>Modified files:
>	gcc            : common.opt ipa-inline.c ChangeLog 
>	gcc/doc        : invoke.texi 
>
>Log message:
>	2005-09-01  Richard Guenther  <rguenther@suse.de>
>	
>	PR tree-optimization/15366
>	* common.opt: Add -finline-functions-called-once.
>	Put -fearly-inlining in alphabetically ordered place.
>	* doc/invoke.texi: Document new option.
>	* ipa-inline.c (cgraph_decide_inlining): Honour
>	flag_inline_functions_called_once.
>
>Patches:
>http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/common.opt.diff?cvsroot=gcc&r1=1.87&r2=1.88
>http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ipa-inline.c.diff?cvsroot=gcc&r1=2.16&r2=2.17
>http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.9872&r2=2.9873
>http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/doc/invoke.texi.diff?cvsroot=gcc&r1=1.673&r2=1.674
>
>
>
>  
>




-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15366

[Bug tree-optimization/15366] [unit-at-a-time] -fno-inline-functions is ignored for static functions

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-09-02 08:12 -------
Subject: Bug 15366

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-4_0-branch
Changes by:	rguenth@gcc.gnu.org	2005-09-02 08:12:37

Modified files:
	gcc            : ChangeLog common.opt cgraphunit.c 
	gcc/doc        : invoke.texi 

Log message:
	2005-09-02  Richard Guenther  <rguenther@suse.de>
	
	PR tree-optimization/15366
	* common.opt: Add -finline-functions-called-once.
	* doc/invoke.texi: Document new option.
	* cgraphunit.c (cgraph_decide_inlining): Honour
	flag_inline_functions_called_once.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=2.7592.2.406&r2=2.7592.2.407
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/common.opt.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.62.2.1&r2=1.62.2.2
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cgraphunit.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.93.2.4&r2=1.93.2.5
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/doc/invoke.texi.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.583.2.24&r2=1.583.2.25



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15366

[Bug tree-optimization/15366] [3.4 only][unit-at-a-time] -fno-inline-functions is ignored for static functions

[rguenth at gcc dot gnu dot org]

------- Additional Comments From rguenth at gcc dot gnu dot org  2005-09-02 08:14 -------
4.0.2 and 4.1 got the new option, wether 3.4 will, too, is Gabys call.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |4.0.2 4.1.0
            Summary|[unit-at-a-time] -fno-      |[3.4 only][unit-at-a-time] -
                   |inline-functions is ignored |fno-inline-functions is
                   |for static functions        |ignored for static functions


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15366