public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/17192] New: Functions returning pointer via argument are broken
@ 2004-08-25 22:01 tobi at gcc dot gnu dot org
2004-08-25 22:10 ` [Bug fortran/17192] " tobi at gcc dot gnu dot org
` (10 more replies)
0 siblings, 11 replies; 12+ messages in thread
From: tobi at gcc dot gnu dot org @ 2004-08-25 22:01 UTC (permalink / raw)
To: gcc-bugs
Functions returning a pointer via an argument are broken. See the commented out
test in gfortran.dg/assignment_1.f90.
--
Summary: Functions returning pointer via argument are broken
Product: gcc
Version: 3.5.0
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: fortran
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: tobi at gcc dot gnu dot org
CC: gcc-bugs at gcc dot gnu dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17192
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/17192] Functions returning pointer via argument are broken
2004-08-25 22:01 [Bug fortran/17192] New: Functions returning pointer via argument are broken tobi at gcc dot gnu dot org
@ 2004-08-25 22:10 ` tobi at gcc dot gnu dot org
2004-08-25 22:56 ` tobi at gcc dot gnu dot org
` (9 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: tobi at gcc dot gnu dot org @ 2004-08-25 22:10 UTC (permalink / raw)
To: gcc-bugs
--
What |Removed |Added
----------------------------------------------------------------------------
BugsThisDependsOn| |17193
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17192
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/17192] Functions returning pointer via argument are broken
2004-08-25 22:01 [Bug fortran/17192] New: Functions returning pointer via argument are broken tobi at gcc dot gnu dot org
2004-08-25 22:10 ` [Bug fortran/17192] " tobi at gcc dot gnu dot org
@ 2004-08-25 22:56 ` tobi at gcc dot gnu dot org
2004-08-25 22:59 ` tobi at gcc dot gnu dot org
` (8 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: tobi at gcc dot gnu dot org @ 2004-08-25 22:56 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From tobi at gcc dot gnu dot org 2004-08-25 22:56 -------
Self-contained testcase:
character*5, pointer :: p
character*5, target :: c,e
c = "Hallo"
p => c
call s(p,c,p)
print *,p
contains
subroutine s(p,e,d)
character*5, pointer ::p
character*5 :: e, d
e = d
p=>c
end subroutine s
end
gives:
[tobi@marktplatz tests]$ gfortran assign.f90
assign.f90: In function `s':
assign.f90:13: internal compiler error: in gfc_build_indirect_ref, at
fortran/trans.c:296
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://gcc.gnu.org/bugs.html> for instructions.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17192
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/17192] Functions returning pointer via argument are broken
2004-08-25 22:01 [Bug fortran/17192] New: Functions returning pointer via argument are broken tobi at gcc dot gnu dot org
2004-08-25 22:10 ` [Bug fortran/17192] " tobi at gcc dot gnu dot org
2004-08-25 22:56 ` tobi at gcc dot gnu dot org
@ 2004-08-25 22:59 ` tobi at gcc dot gnu dot org
2004-08-25 23:29 ` pinskia at gcc dot gnu dot org
` (7 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: tobi at gcc dot gnu dot org @ 2004-08-25 22:59 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From tobi at gcc dot gnu dot org 2004-08-25 22:59 -------
well, that wasn't a function ... second try:
character*5, pointer :: p
character*5, target :: c,e
c = "Hallo"
p => c
c = s(c,p)
print *,p
contains
function s(e,d)
character*5, pointer ::s
character*5 :: e, d
e = d
s=>c
end function s
end
gives:
[tobi@marktplatz tests]$ gfortran assign.f90
assign.f90: In function `s':
assign.f90:13: internal compiler error: in gfc_build_indirect_ref, at
fortran/trans.c:296
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://gcc.gnu.org/bugs.html> for instructions.
[tobi@marktplatz tests]$
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17192
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/17192] Functions returning pointer via argument are broken
2004-08-25 22:01 [Bug fortran/17192] New: Functions returning pointer via argument are broken tobi at gcc dot gnu dot org
` (2 preceding siblings ...)
2004-08-25 22:59 ` tobi at gcc dot gnu dot org
@ 2004-08-25 23:29 ` pinskia at gcc dot gnu dot org
2004-09-08 19:05 ` toon at moene dot indiv dot nluug dot nl
` (6 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-08-25 23:29 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pinskia at gcc dot gnu dot org 2004-08-25 23:29 -------
Confirmed.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Ever Confirmed| |1
Keywords| |ice-on-valid-code
Last reconfirmed|0000-00-00 00:00:00 |2004-08-25 23:29:10
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17192
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/17192] Functions returning pointer via argument are broken
2004-08-25 22:01 [Bug fortran/17192] New: Functions returning pointer via argument are broken tobi at gcc dot gnu dot org
` (3 preceding siblings ...)
2004-08-25 23:29 ` pinskia at gcc dot gnu dot org
@ 2004-09-08 19:05 ` toon at moene dot indiv dot nluug dot nl
2005-05-11 8:11 ` [Bug fortran/17192] Functions returning character " fxcoudert at gcc dot gnu dot org
` (5 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: toon at moene dot indiv dot nluug dot nl @ 2004-09-08 19:05 UTC (permalink / raw)
To: gcc-bugs
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 377 bytes --]
------- Additional Comments From toon at moene dot indiv dot nluug dot nl 2004-09-08 19:05 -------
It compiles, but I doubt it returns the right answer:
toon@book:~/g95-bugs$ /usr/snp/bin/gfortran -static 17192.f90
toon@book:~/g95-bugs$ ./a.out
ìÿø
This is on powerpc-unknown-linux-gnu, using gcc-3.5-20040907.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17192
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/17192] Functions returning character pointer via argument are broken
2004-08-25 22:01 [Bug fortran/17192] New: Functions returning pointer via argument are broken tobi at gcc dot gnu dot org
` (4 preceding siblings ...)
2004-09-08 19:05 ` toon at moene dot indiv dot nluug dot nl
@ 2005-05-11 8:11 ` fxcoudert at gcc dot gnu dot org
2005-05-29 16:03 ` cvs-commit at gcc dot gnu dot org
` (4 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: fxcoudert at gcc dot gnu dot org @ 2005-05-11 8:11 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From fxcoudert at gcc dot gnu dot org 2005-05-11 08:10 -------
It does still compile, but does still not return the right answer. The problem
disappears if "integer" is used instead of "character*5". The tree dump
(obtained with -fdump-tree-original) is:
s (__result, .__result, e, d, _e, _d)
{
_gfortran_copy_string (5, e, 5, d);
__result = (char[1:5] * &) &c;
MAIN__ ()
{
char c[1:5];
char[1:5] * p;
static void s (char[1:5] * &, int4, char[1:5] &, char[1:5] &, int4, int4);
_gfortran_copy_string (5, &c, 5, "Hallo");
p = (char[1:5] *) &c;
{
char str.0[5];
s ((char[1:5] *) &str.0, 5, &c, p, 5, 5);
_gfortran_copy_string (5, &c, 5, (char[1:5] *) &str.0);
}
/* ...snip... call output routines */
}
--
What |Removed |Added
----------------------------------------------------------------------------
Keywords|ice-on-valid-code |
Last reconfirmed|2004-11-11 05:20:44 |2005-05-11 08:10:52
date| |
Summary|Functions returning pointer |Functions returning
|via argument are broken |character pointer via
| |argument are broken
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17192
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/17192] Functions returning character pointer via argument are broken
2004-08-25 22:01 [Bug fortran/17192] New: Functions returning pointer via argument are broken tobi at gcc dot gnu dot org
` (5 preceding siblings ...)
2005-05-11 8:11 ` [Bug fortran/17192] Functions returning character " fxcoudert at gcc dot gnu dot org
@ 2005-05-29 16:03 ` cvs-commit at gcc dot gnu dot org
2005-06-05 8:59 ` cvs-commit at gcc dot gnu dot org
` (3 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-05-29 16:03 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2005-05-29 16:02 -------
Subject: Bug 17192
CVSROOT: /cvs/gcc
Module name: gcc
Changes by: pault@gcc.gnu.org 2005-05-29 16:02:11
Modified files:
gcc/fortran : trans-array.c trans-expr.c
Log message:
2005-05-29 Paul Thomas <pault@gcc.gnu.org>
PR fortran/16939
PR fortran/17192
PR fortran/17193
PR fortran/17202
PR fortran/18689
PR fortran/18890
PR fortran/21297
* fortran/trans-array.c (gfc_conv_resolve_dependencies): Add string
length to temp_ss for character pointer array assignments.
* fortran/trans-expr.c (gfc_conv_variable): Correct errors in
dereferencing of characters and character pointers.
* fortran/trans-expr.c (gfc_conv_function_call): Provide string
length as return argument for various kinds of handling of return.
Return a char[]* temporary for character pointer functions and
dereference the temporary upon return.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/trans-array.c.diff?cvsroot=gcc&r1=1.45&r2=1.46
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/trans-expr.c.diff?cvsroot=gcc&r1=1.44&r2=1.45
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17192
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/17192] Functions returning character pointer via argument are broken
2004-08-25 22:01 [Bug fortran/17192] New: Functions returning pointer via argument are broken tobi at gcc dot gnu dot org
` (6 preceding siblings ...)
2005-05-29 16:03 ` cvs-commit at gcc dot gnu dot org
@ 2005-06-05 8:59 ` cvs-commit at gcc dot gnu dot org
2005-06-05 22:43 ` pault at gcc dot gnu dot org
` (2 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-06-05 8:59 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2005-06-05 08:59 -------
Subject: Bug 17192
CVSROOT: /cvs/gcc
Module name: gcc
Branch: gcc-4_0-branch
Changes by: pault@gcc.gnu.org 2005-06-05 08:59:18
Modified files:
gcc/fortran : ChangeLog trans-array.c trans-expr.c
Log message:
005-05-31 Paul Thomas <pault@gcc.gnu.org>
PR fortran/18109
PR fortran/18283
PR fortran/19107
PR fortran/16939
PR fortran/17192
PR fortran/17193
PR fortran/17202
PR fortran/18689
PR fortran/18890
* fortran/trans-array.c (gfc_conv_expr_descriptor): Obtain the
string length from the expression typespec character length value
and set temp_ss->stringlength and backend_decl. Obtain the
tree expression from gfc_conv_expr rather than gfc_conv_expr_val.
Dereference the expression to obtain the character.
* fortran/trans-array.c (gfc_conv_resolve_dependencies): Add string
length to temp_ss for character pointer array assignments.
* fortran/trans-expr.c (gfc_conv_component_ref): Remove the
dereference of scalar character pointer structure components.
* fortran/trans-expr.c (gfc_trans_subarray_assign): Obtain the
string length for the structure component from the component
expression.
* fortran/trans-expr.c (gfc_conv_variable): Correct errors in
dereferencing of characters and character pointers.
* fortran/trans-expr.c (gfc_conv_function_call): Provide string
length as return argument for various kinds of handling of return.
Return a char[]* temporary for character pointer functions and
dereference the temporary upon return.
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.335.2.66&r2=1.335.2.67
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/trans-array.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.39.2.3&r2=1.39.2.4
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/trans-expr.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.38.2.4&r2=1.38.2.5
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17192
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/17192] Functions returning character pointer via argument are broken
2004-08-25 22:01 [Bug fortran/17192] New: Functions returning pointer via argument are broken tobi at gcc dot gnu dot org
` (7 preceding siblings ...)
2005-06-05 8:59 ` cvs-commit at gcc dot gnu dot org
@ 2005-06-05 22:43 ` pault at gcc dot gnu dot org
2005-06-05 22:44 ` pault at gcc dot gnu dot org
2005-06-05 22:49 ` pinskia at gcc dot gnu dot org
10 siblings, 0 replies; 12+ messages in thread
From: pault at gcc dot gnu dot org @ 2005-06-05 22:43 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pault at gcc dot gnu dot org 2005-06-05 22:43 -------
Fixed in 4.0 and 4.1
--
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17192
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/17192] Functions returning character pointer via argument are broken
2004-08-25 22:01 [Bug fortran/17192] New: Functions returning pointer via argument are broken tobi at gcc dot gnu dot org
` (8 preceding siblings ...)
2005-06-05 22:43 ` pault at gcc dot gnu dot org
@ 2005-06-05 22:44 ` pault at gcc dot gnu dot org
2005-06-05 22:49 ` pinskia at gcc dot gnu dot org
10 siblings, 0 replies; 12+ messages in thread
From: pault at gcc dot gnu dot org @ 2005-06-05 22:44 UTC (permalink / raw)
To: gcc-bugs
--
Bug 17192 depends on bug 17193, which changed state.
Bug 17193 Summary: [meta-bug] Pointer arguments not working correctly
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17193
What |Old Value |New Value
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17192
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/17192] Functions returning character pointer via argument are broken
2004-08-25 22:01 [Bug fortran/17192] New: Functions returning pointer via argument are broken tobi at gcc dot gnu dot org
` (9 preceding siblings ...)
2005-06-05 22:44 ` pault at gcc dot gnu dot org
@ 2005-06-05 22:49 ` pinskia at gcc dot gnu dot org
10 siblings, 0 replies; 12+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-06-05 22:49 UTC (permalink / raw)
To: gcc-bugs
--
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |4.0.1
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17192
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2005-06-05 22:49 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-08-25 22:01 [Bug fortran/17192] New: Functions returning pointer via argument are broken tobi at gcc dot gnu dot org
2004-08-25 22:10 ` [Bug fortran/17192] " tobi at gcc dot gnu dot org
2004-08-25 22:56 ` tobi at gcc dot gnu dot org
2004-08-25 22:59 ` tobi at gcc dot gnu dot org
2004-08-25 23:29 ` pinskia at gcc dot gnu dot org
2004-09-08 19:05 ` toon at moene dot indiv dot nluug dot nl
2005-05-11 8:11 ` [Bug fortran/17192] Functions returning character " fxcoudert at gcc dot gnu dot org
2005-05-29 16:03 ` cvs-commit at gcc dot gnu dot org
2005-06-05 8:59 ` cvs-commit at gcc dot gnu dot org
2005-06-05 22:43 ` pault at gcc dot gnu dot org
2005-06-05 22:44 ` pault at gcc dot gnu dot org
2005-06-05 22:49 ` pinskia at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).