[Bug c/17408] New: [4.0 regression] ICE in verify_stmts with -O2

[Bug c/17408] New: [4.0 regression] ICE in verify_stmts with -O2

[pinskia at gcc dot gnu dot org]

extern int t;
extern int t = 0;
void f(){t =0;}
void g(){h(&t);}

-- 
           Summary: [4.0 regression] ICE in verify_stmts with -O2
           Product: gcc
           Version: 4.0.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: critical
          Priority: P2
         Component: c
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: pinskia at gcc dot gnu dot org
                CC: dnovillo at gcc dot gnu dot org,gcc-bugs at gcc dot gnu
                    dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17408

[Bug c/17408] [4.0 regression] ICE in verify_stmts with -O2

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-09-10 21:12 -------
: Search converges between 2004-07-21-trunk (#492) and 2004-07-23-trunk (#493).

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.0.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17408

[Bug c/17408] [4.0 regression] ICE in verify_stmts with -O2

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |17409
              nThis|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17408

[Bug c/17408] [4.0 regression] ICE in verify_stmts with -O2

[dalej at apple dot com]

------- Additional Comments From dalej at apple dot com  2004-09-10 21:25 -------
I believe the following is the fix (it has the effect of adding && !initialized to the existing test):

Index: c-decl.c
===============================================================
====
RCS file: /cvs/gcc/gcc/gcc/c-decl.c,v
retrieving revision 1.577
diff -u -d -b -w -p -r1.577 c-decl.c
--- c-decl.c    9 Sep 2004 01:25:46 -0000       1.577
+++ c-decl.c    10 Sep 2004 21:17:20 -0000
@@ -4642,7 +4642,7 @@ grokdeclarator (const struct c_declarato
        /* At file scope, an initialized extern declaration may follow
           a static declaration.  In that case, DECL_EXTERNAL will be
           reset later in start_decl.  */
-       DECL_EXTERNAL (decl) = !!(specbits & (1 << (int) RID_EXTERN));
+       DECL_EXTERNAL (decl) = extern_ref;
 
        /* At file scope, the presence of a `static' or `register' storage
           class specifier, or the absence of all storage class specifiers




-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17408

[Bug c/17408] [4.0 regression] ICE in verify_stmts with -O2

[jsm at polyomino dot org dot uk]

------- Additional Comments From jsm at polyomino dot org dot uk  2004-09-10 21:38 -------
Subject: Re:  [4.0 regression] ICE in verify_stmts with -O2

On Fri, 10 Sep 2004, dalej at apple dot com wrote:

> I believe the following is the fix (it has the effect of adding && 
> !initialized to the existing test):

This passes gcc.dg/pr15360-1.c?  I thought both parts of the fix to bug 
15360 were needed to fix it, but this patch reverts one part.

static int x;
extern int x = 1;

is valid; you can't treat the second declaration as "int x = 1;" because

static int x;
int x = 1;

is invalid.



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17408

[Bug c/17408] [4.0 regression] ICE in verify_stmts with -O2

[dalej at apple dot com]

------- Additional Comments From dalej at apple dot com  2004-09-13 01:46 -------
Indeed, my suggested patch breaks that testcase.  I'll look some more.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17408

[Bug c/17408] [4.0 regression] ICE in verify_stmts with -O2

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-09-14 00:35 -------
Subject: Bug 17408

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	dalej@gcc.gnu.org	2004-09-14 00:35:02

Modified files:
	gcc            : ChangeLog c-decl.c 
	gcc/testsuite  : ChangeLog 
Added files:
	gcc/testsuite/gcc.c-torture/compile: pr17408.c 

Log message:
	Fix PR 17408 and PR 17409.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.5431&r2=2.5432
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-decl.c.diff?cvsroot=gcc&r1=1.582&r2=1.583
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.4280&r2=1.4281
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.c-torture/compile/pr17408.c.diff?cvsroot=gcc&r1=NONE&r2=1.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17408

[Bug c/17408] [4.0 regression] ICE in verify_stmts with -O2

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-09-14 01:03 -------
Fixed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17408