public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "dnovillo at redhat dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug other/17437] [4.0 Regression] obscure GC problem
Date: Tue, 14 Sep 2004 19:07:00 -0000	[thread overview]
Message-ID: <20040914190737.29730.qmail@sourceware.org> (raw)
In-Reply-To: <20040912151302.17437.steven@gcc.gnu.org>


------- Additional Comments From dnovillo at redhat dot com  2004-09-14 19:07 -------
Subject: Re:  [4.0 Regression] obscure GC problem

On Tue, 2004-09-14 at 11:31, Jeffrey A Law wrote:

> What doesn't make sense to me is that the dataflow information isn't
> attached to SSA_NAMEs, it's attached to statement nodes and PHIs.
> So at least that part of my analysis is faulty.
> 
Because SSA_NAMEs store their defining statement in tree.common.chain
and gt_ggc_mx_lang_tree_node jumps from the SSA_NAME into its defining
statement.  From there, we start traversing the statement's DU chains
and end up in a statement whose basic block has been ggc_free'd already
by cfg.c:expunge_block.

This allows me to go past this failure and go into stage3, but I think
the real issue may be that somebody is holding on to DU chains too long.

I don't know what the right approach would be here.  Force people to
always flush out DU chains?  Maybe.  But then, why put these things on
GC memory to begin with?


Diego.

Index: cfg.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/cfg.c,v
retrieving revision 1.65
diff -d -u -p -r1.65 cfg.c
--- cfg.c       7 Sep 2004 15:46:46 -0000       1.65
+++ cfg.c       14 Sep 2004 19:03:02 -0000
@@ -266,7 +266,6 @@ expunge_block (basic_block b)
   unlink_block (b);
   BASIC_BLOCK (b->index) = NULL;
   n_basic_blocks--;
-  ggc_free (b);
 }

 /* Create an edge connecting SRC and DEST with flags FLAGS.  Return newly




-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17437


  parent reply	other threads:[~2004-09-14 19:07 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-12 15:13 [Bug other/17437] New: " steven at gcc dot gnu dot org
2004-09-12 15:14 ` [Bug other/17437] " steven at gcc dot gnu dot org
2004-09-12 17:30 ` [Bug other/17437] New: " Graham Stott
2004-09-12 17:30 ` [Bug other/17437] " graham dot stott at btinternet dot com
2004-09-12 17:35 ` pinskia at gcc dot gnu dot org
2004-09-14  3:12 ` [Bug other/17437] [4.0 Regression] " pinskia at gcc dot gnu dot org
2004-09-14  5:36 ` pinskia at gcc dot gnu dot org
2004-09-14  6:23 ` steven at gcc dot gnu dot org
2004-09-14  6:25 ` stevenb at suse dot de
2004-09-14 15:31 ` law at redhat dot com
2004-09-14 19:07 ` dnovillo at redhat dot com [this message]
2004-09-14 19:19 ` law at redhat dot com
2004-09-14 19:48 ` law at redhat dot com
2004-09-15  4:31 ` pinskia at gcc dot gnu dot org
2004-10-12 13:03 ` pinskia at gcc dot gnu dot org
2004-10-14 16:10 ` stevenb at novell dot com
2004-10-14 16:30 ` pinskia at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040914190737.29730.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).