[Bug other/17546] New: Compile Issue with util-linux-2.12d

[Bug other/17546] New: Compile Issue with util-linux-2.12d

[giffordj at linkline dot com]

Steps to recreate: after untaring util-linux-2.12d, ./configure
                   cd fdisk && make
                   After make is completed, issue ./sfdisk -l
                   errors will show up.

Attached are the sfdisk.s and sfdisk.i files, there is no difference on sfdisk.i
files, but the sfdisk.s had numerous differences.

I know you guys would like a test case, I tried figure out the offending code,
but had no luck. This issue happens under 3.4.1 and 3.4.2. 

Here is a compile that does not work
(root@server)-(11:35 PM Fri Sep 17)-(/usr/src/util-linux-2.12d/fdisk)
# ./sfdisk -l

Disk /dev/sda: 5461 cylinders, 255 heads, 63 sectors/track

sfdisk: seek error: wanted 0x0000000000000000, got 0x0000000000000000
 /dev/sda: unrecognized partition table type
No partitions found

Disk /dev/sdb: 3276 cylinders, 255 heads, 63 sectors/track

sfdisk: seek error: wanted 0x0000000000000000, got 0x0000000000000000
 /dev/sdb: unrecognized partition table type
No partitions found

Disk /dev/sdc: 3276 cylinders, 255 heads, 63 sectors/track

sfdisk: seek error: wanted 0x0000000000000000, got 0x0000000000000000
 /dev/sdc: unrecognized partition table type
No partitions found

Disk /dev/sdd: 243 cylinders, 255 heads, 63 sectors/track

sfdisk: seek error: wanted 0x0000000000000000, got 0x0000000000000000
 /dev/sdd: unrecognized partition table type
No partitions found


Here is a compile that does work, because -fno-unit-at-a-time was added to cc line
# ./sfdisk -l

Disk /dev/sda: 5461 cylinders, 255 heads, 63 sectors/track
Units = cylinders of 8225280 bytes, blocks of 1024 bytes, counting from 0

   Device Boot Start     End   #cyls    #blocks   Id  System
/dev/sda1          0+     12      13-    104391   83  Linux
/dev/sda2         13    5427    5415   43495987+  83  Linux
/dev/sda3       5428    5460      33     265072+  82  Linux swap / Solaris
/dev/sda4          0       -       0          0    0  Empty

Disk /dev/sdb: 3276 cylinders, 255 heads, 63 sectors/track
Units = cylinders of 8225280 bytes, blocks of 1024 bytes, counting from 0

   Device Boot Start     End   #cyls    #blocks   Id  System
/dev/sdb1          0+   3275    3276-  26314438+  83  Linux
/dev/sdb2          0       -       0          0    0  Empty
/dev/sdb3          0       -       0          0    0  Empty
/dev/sdb4          0       -       0          0    0  Empty

Disk /dev/sdc: 3276 cylinders, 255 heads, 63 sectors/track
Units = cylinders of 8225280 bytes, blocks of 1024 bytes, counting from 0

   Device Boot Start     End   #cyls    #blocks   Id  System
/dev/sdc1          0+   3275    3276-  26314438+  83  Linux
/dev/sdc2          0       -       0          0    0  Empty
/dev/sdc3          0       -       0          0    0  Empty
/dev/sdc4          0       -       0          0    0  Empty

Disk /dev/sdd: 243 cylinders, 255 heads, 63 sectors/track
Units = cylinders of 8225280 bytes, blocks of 1024 bytes, counting from 0

   Device Boot Start     End   #cyls    #blocks   Id  System
/dev/sdd1          0       -       0          0    0  Empty
/dev/sdd2          0       -       0          0    0  Empty
/dev/sdd3          0       -       0          0    0  Empty
/dev/sdd4   *      0+    242     243-   1951866    b  W95 FAT32

-- 
           Summary: Compile Issue with util-linux-2.12d
           Product: gcc
           Version: 3.4.2
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: other
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: giffordj at linkline dot com
                CC: gcc-bugs at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17546

[Bug other/17546] Compile Issue with util-linux-2.12d

[giffordj at linkline dot com]

------- Additional Comments From giffordj at linkline dot com  2004-09-18 06:45 -------
Created an attachment (id=7164)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=7164&action=view)
The .i and .s files


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17546

[Bug rtl-optimization/17546] Compile Issue with util-linux-2.12d

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-09-18 14:49 -------
unit-at-a-time only adds more inlining for 3.4.x.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|other                       |rtl-optimization
           Keywords|                            |wrong-code
   Target Milestone|---                         |3.4.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17546

[Bug rtl-optimization/17546] Compile Issue with util-linux-2.12d

[giffordj at linkline dot com]

------- Additional Comments From giffordj at linkline dot com  2004-09-23 17:02 -------
This issue does not happen with gcc 3.3.3 or 3.3.4. Only with gcc 3.4.x systems.
Some of one has suggested the issue is caused by the following code.

#if !defined (__alpha__) && !defined (__ia64__) && !defined (__x86_64__) &&
!defined (__s390x__)
static
_syscall5(int,  _llseek,  unsigned int,  fd, ulong, hi, ulong, lo,
       loff_t *, res, unsigned int, wh);
#endif

It has been suggested, that using __attribute__ ((used)) will fix the issue.

So the code should be changed to 
#if !defined (__alpha__) && !defined (__ia64__) && !defined (__x86_64__) &&
!defined (__s390x__)
static
__attribute__ ((used))
_syscall5(int,  _llseek,  unsigned int,  fd, ulong, hi, ulong, lo,
       loff_t *, res, unsigned int, wh);
#endif

If that's the case, we can close this ticket. Please validate the suggestion

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17546

[Bug rtl-optimization/17546] Compile Issue with util-linux-2.12d

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-09-23 17:08 -------
So I assume that sfdisk is using the function from assembly and unit-at-a-time removes the functions 
or changes the ABI for the function which means that the code is dependent on behavior which 
changed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17546