[Bug tree-optimization/17531] New: [ivopts] ICE compiling gzip deflate.c

[Bug tree-optimization/17531] New: [ivopts] ICE compiling gzip deflate.c

[dje at gcc dot gnu dot org]

In SPEC CPU2000 164.gzip does
not build due to an ICE in emit_move_insn() whose backtrace leads to
ivopts.  The same failure occurs with gzip-1.2.4a.

$ ./xgcc -B./ -O1 -fstrict-aliasing -S deflate.c
deflate.c: In function 'deflate_fast':
deflate.c:584: internal compiler error: in emit_move_insn, at expr.c:2485
$ ./xgcc -B./ -O1 -fstrict-aliasing -fno-ivopts -S deflate.c
$

Backtrace:
#0  fancy_abort (file=0x104bd158 "/farm/dje/src/src/gcc/expr.c",
line=2485, 
    function=0x104bd230 "emit_move_insn")
    at /farm/dje/src/src/gcc/diagnostic.c:591
#1  0x10139d94 in emit_move_insn (x=0x3020ec00, y=0x20035954)
    at /farm/dje/src/src/gcc/expr.c:2484
#2  0x100f127c in force_reg (mode=807463936, x=0x3020ebb8)
    at /farm/dje/src/src/gcc/explow.c:670
#3  0x1021a9e4 in expand_binop (mode=HImode, binoptab=0x3000f400, 
    op0=0x3020ebb8, op1=0x3020ebe8, target=0x0, unsignedp=1, 
    methods=OPTAB_LIB_WIDEN) at /farm/dje/src/src/gcc/optabs.c:741
#4  0x1014e0cc in expand_expr_addr_expr_1 (exp=0x302111e0, target=0x0, 
    tmode=HImode, modifier=EXPAND_NORMAL) at
    /farm/dje/src/src/gcc/expr.c:6165
#5  0x10144540 in expand_expr_real_1 (exp=0x3020f780, target=0x0, 
    tmode=HImode, modifier=EXPAND_NORMAL, alt_rtl=0x0)
    at /farm/dje/src/src/gcc/expr.c:6194
#6  0x1014b580 in expand_expr_real (exp=0x3020f780, target=0x0,
tmode=HImode, 
    modifier=EXPAND_NORMAL, alt_rtl=0x0) at
    /farm/dje/src/src/gcc/expr.c:6308
#7  0x101455e8 in expand_expr_real_1 (exp=0x3020f800, target=0x10483690, 
    tmode=VOIDmode, modifier=EXPAND_NORMAL, alt_rtl=0x0)
    at /farm/dje/src/src/gcc/expr.h:493
#8  0x1014b580 in expand_expr_real (exp=0x3020f800, target=0x0, 
    tmode=VOIDmode, modifier=EXPAND_NORMAL, alt_rtl=0x0)
    at /farm/dje/src/src/gcc/expr.c:6308
#9  0x1014dec0 in expand_operands (exp0=0x3020f720, exp1=0x3020f800, 
    target=0x0, op0=0x2ff215bc, op1=0x2ff215b0, modifier=EXPAND_NORMAL)
    at /farm/dje/src/src/gcc/expr.h:493
#10 0x10143bf4 in expand_expr_real_1 (exp=0x30210758, target=0x0, 
    tmode=VOIDmode, modifier=EXPAND_NORMAL, alt_rtl=0x0)
    at /farm/dje/src/src/gcc/expr.c:8207
#11 0x1014b580 in expand_expr_real (exp=0x30210758, target=0x0, 
    tmode=VOIDmode, modifier=EXPAND_NORMAL, alt_rtl=0x0)
    at /farm/dje/src/src/gcc/expr.c:6308
#12 0x1014dec0 in expand_operands (exp0=0x3020f7e0, exp1=0x30210758, 
    target=0x0, op0=0x2ff2173c, op1=0x2ff21730, modifier=EXPAND_NORMAL)
    at /farm/dje/src/src/gcc/expr.h:493
#13 0x10146ec8 in expand_expr_real_1 (exp=0x302107d0, target=0x2, 
    tmode=273168016, modifier=EXPAND_NORMAL, alt_rtl=0x0)
    at /farm/dje/src/src/gcc/expr.c:7493
#14 0x1014b580 in expand_expr_real (exp=0x302107d0, target=0x0, 
    tmode=VOIDmode, modifier=EXPAND_NORMAL, alt_rtl=0x0)
    at /farm/dje/src/src/gcc/expr.c:6308
#15 0x1014dea4 in expand_operands (exp0=0x302107d0, exp1=0x3020f740, 
    target=0x0, op0=0x2ff218bc, op1=0x2ff218b0, modifier=EXPAND_NORMAL)
    at /farm/dje/src/src/gcc/expr.h:493
#16 0x10146ec8 in expand_expr_real_1 (exp=0x302107f8, target=0x2, 
    tmode=273168016, modifier=EXPAND_NORMAL, alt_rtl=0x0)
    at /farm/dje/src/src/gcc/expr.c:7493
#17 0x1014b580 in expand_expr_real (exp=0x302107f8, target=0x0,
tmode=HImode, 
    modifier=EXPAND_NORMAL, alt_rtl=0x0) at
    /farm/dje/src/src/gcc/expr.c:6308
#18 0x103d276c in computation_cost (expr=0x302107f8)
    at /farm/dje/src/src/gcc/expr.h:493
#19 0x103d7ac4 in get_computation_cost_at (data=0x2ff21c38,
use=0x200e1588, 
    cand=0x200e26f8, address_p=0 '\0', depends_on=0x2ff21ad0,
    at=0x301e5b40)
    at /farm/dje/src/src/gcc/tree-ssa-loop-ivopts.c:2855
#20 0x103d7fc4 in determine_use_iv_cost_generic (data=0x2ff21c38, 
    use=0x200e1588, cand=0x200e26f8)
    at /farm/dje/src/src/gcc/tree-ssa-loop-ivopts.c:2882
#21 0x103d89b0 in determine_use_iv_cost (data=0x2ff21c38, use=0x200e1588, 
    cand=0x200e26f8) at /farm/dje/src/src/gcc/tree-ssa-loop-ivopts.c:3024
#22 0x103dd3d0 in tree_ssa_iv_optimize_loop (data=0x2ff21c38, loop=0x9b5)
    at /farm/dje/src/src/gcc/tree-ssa-loop-ivopts.c:271
#23 0x103dd874 in tree_ssa_iv_optimize (loops=0x200e0878)
    at /farm/dje/src/src/gcc/tree-ssa-loop-ivopts.c:4420
#24 0x103a8024 in tree_ssa_loop_ivopts ()
    at /farm/dje/src/src/gcc/tree-ssa-loop.c:308
#25 0x102ad77c in execute_pass_list (pass=0x20023f4c)
    at /farm/dje/src/src/gcc/tree-optimize.c:501
#26 0x102ad794 in execute_pass_list (pass=0x200240b8)
    at /farm/dje/src/src/gcc/tree-optimize.c:537
#27 0x102ad794 in execute_pass_list (pass=0x20020ae8)
    at /farm/dje/src/src/gcc/tree-optimize.c:537
#28 0x102ada78 in tree_rest_of_compilation (fndecl=0x300eaf80, nested_p=0
'\0')
    at /farm/dje/src/src/gcc/tree-optimize.c:618
#29 0x100385f8 in c_expand_body (fndecl=0x300eaf80)
    at /farm/dje/src/src/gcc/c-decl.c:6458
#30 0x10293064 in cgraph_expand_function (node=0x301e1900)
    at /farm/dje/src/src/gcc/cgraphunit.c:1040
#31 0x10293230 in cgraph_assemble_pending_functions ()
    at /farm/dje/src/src/gcc/cgraphunit.c:525
#32 0x10293ac0 in cgraph_finalize_function (decl=0x300eaf80, nested=0
'\0')
    at /farm/dje/src/src/gcc/cgraphunit.c:605
#33 0x1003885c in c_finalize (fndecl=0x300eaf80)
    at /farm/dje/src/src/gcc/c-decl.c:6325
#34 0x10038e3c in finish_function () at
/farm/dje/src/src/gcc/c-decl.c:6430
#35 0x1046cd34 in yyparse () at c-parse.y:407
#36 0x1046d9c4 in c_parse_file () at c-parse.y:2901
#37 0x10472598 in c_common_parse_file (set_yydebug=273404248)
    at /farm/dje/src/src/gcc/c-opts.c:1097
#38 0x100035f0 in toplev_main (argc=536887100, argv=0x2009a028)
    at /farm/dje/src/src/gcc/toplev.c:991
#39 0x10000390 in main (argc=273404248, argv=0x9b5)
    at /farm/dje/src/src/gcc/main.c:35
#40 0x10000204 in __start ()

-- 
           Summary: [ivopts] ICE compiling gzip deflate.c
           Product: gcc
           Version: 4.0.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: tree-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: dje at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: powerpc-*-*
  GCC host triplet: powerpc-*-*
GCC target triplet: powerpc-*-*


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17531

[Bug tree-optimization/17531] [ivopts] ICE compiling gzip deflate.c

[dberlin at gcc dot gnu dot org]

------- Additional Comments From dberlin at gcc dot gnu dot org  2004-09-17 03:02 -------
Created an attachment (id=7158)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=7158&action=view)
Minimized testcase

This is a minimized testcase.
Fails with -O1 -fstrict-aliasing, passes with -O1 -fstrict-aliasing -fno-ivopts

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17531

[Bug tree-optimization/17531] [4.0 Regression] [ivopts] ICE compiling gzip deflate.c

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-09-17 03:10 -------
Hmm, this was working on the lno, so maybe something changed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rakdver at gcc dot gnu dot
                   |                            |org
           Keywords|                            |ice-on-valid-code
            Summary|[ivopts] ICE compiling gzip |[4.0 Regression] [ivopts]
                   |deflate.c                   |ICE compiling gzip deflate.c
   Target Milestone|---                         |4.0.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17531

[Bug tree-optimization/17531] [4.0 Regression] [ivopts] ICE compiling gzip deflate.c

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-09-17 03:44 -------
Confirmed, the problem is that we are casting from a pointer to short int which you cannot do, you 
have to cast first to int.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |critical
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2004-09-17 03:44:03
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17531

[Bug tree-optimization/17531] [4.0 Regression] [ivopts] ICE compiling gzip deflate.c

[rakdver at gcc dot gnu dot org]

------- Additional Comments From rakdver at gcc dot gnu dot org  2004-09-17 09:09 -------
This patch should fix the problem; I will submit it once it passes regtesting.

Zdenek

Index: optabs.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/optabs.c,v
retrieving revision 1.241
diff -c -3 -p -r1.241 optabs.c
*** optabs.c	10 Sep 2004 11:02:24 -0000	1.241
--- optabs.c	17 Sep 2004 09:05:40 -0000
*************** expand_binop (enum machine_mode mode, op
*** 738,748 ****
       force expensive constants into a register.  */
    if (CONSTANT_P (op0) && optimize
        && rtx_cost (op0, binoptab->code) > COSTS_N_INSNS (1))
!     op0 = force_reg (mode, op0);
  
    if (CONSTANT_P (op1) && optimize
        && ! shift_op && rtx_cost (op1, binoptab->code) > COSTS_N_INSNS (1))
!     op1 = force_reg (mode, op1);
  
    /* Record where to delete back to if we backtrack.  */
    last = get_last_insn ();
--- 738,756 ----
       force expensive constants into a register.  */
    if (CONSTANT_P (op0) && optimize
        && rtx_cost (op0, binoptab->code) > COSTS_N_INSNS (1))
!     {
!       if (GET_MODE (op0) != VOIDmode)
! 	op0 = convert_modes (mode, VOIDmode, op0, unsignedp);
!       op0 = force_reg (mode, op0);
!     }
  
    if (CONSTANT_P (op1) && optimize
        && ! shift_op && rtx_cost (op1, binoptab->code) > COSTS_N_INSNS (1))
!     {
!       if (GET_MODE (op1) != VOIDmode)
! 	op1 = convert_modes (mode, VOIDmode, op1, unsignedp);
!       op1 = force_reg (mode, op1);
!     }
  
    /* Record where to delete back to if we backtrack.  */
    last = get_last_insn ();




-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17531

[Bug tree-optimization/17531] [4.0 Regression] [ivopts] ICE compiling gzip deflate.c

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-09-17 09:22 -------
Yes this works for me. thanks.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17531

[Bug tree-optimization/17531] [4.0 Regression] [ivopts] ICE compiling gzip deflate.c

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-09-18 16:31 -------
I should note that I also ran into this while adding a patch to a branch (apple-ppc-branch) which 
enables ivopts as it was disabled and the patch here fixes the bug.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
           Keywords|                            |build


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17531

[Bug tree-optimization/17531] [4.0 Regression] [ivopts] ICE compiling gzip deflate.c

[rakdver at gcc dot gnu dot org]

------- Additional Comments From rakdver at gcc dot gnu dot org  2004-09-23 12:18 -------
Patch:

http://gcc.gnu.org/ml/gcc-patches/2004-09/msg02371.html

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17531

[Bug tree-optimization/17531] [4.0 Regression] [ivopts] ICE compiling gzip deflate.c

[rth at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |rth at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17531

[Bug tree-optimization/17531] [4.0 Regression] [ivopts] ICE compiling gzip deflate.c

[rth at gcc dot gnu dot org]

------- Additional Comments From rth at gcc dot gnu dot org  2004-09-27 22:22 -------
Alternate patch: http://gcc.gnu.org/ml/gcc-patches/2004-09/msg02799.html

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |WAITING


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17531

[Bug tree-optimization/17531] [4.0 Regression] [ivopts] ICE compiling gzip deflate.c

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-09-28 11:43 -------
The patch was reported to fix the ICE in gzip.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW
   Last reconfirmed|2004-09-17 03:44:03         |2004-09-28 11:43:26
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17531

[Bug tree-optimization/17531] [4.0 Regression] [ivopts] ICE compiling gzip deflate.c

[matz at suse dot de]

------- Additional Comments From matz at suse dot de  2004-09-28 15:54 -------
During bootstrap of GCC on powerpc64-linux the same ICE occurs.  For 
completeness this is a reduced version of the breaking expr.c: 
------------------------- 
extern unsigned char rs6000_hard_regno_mode_ok_p[][113]; 
void 
f (int mode, int *out) 
{ 
  int regno; 
  for (regno = 0; regno < 113; regno++) 
    if (rs6000_hard_regno_mode_ok_p[mode][regno]) 
      *out = regno; 
} 
------------------------- 
 
Both proposed patches make the ICE go away. 

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17531

[Bug tree-optimization/17531] [4.0 Regression] [ivopts] ICE compiling gzip deflate.c

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-09-28 22:55 -------
Subject: Bug 17531

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	rth@gcc.gnu.org	2004-09-28 22:55:05

Modified files:
	gcc            : ChangeLog expr.c optabs.c 

Log message:
	PR 17531
	* expr.c (expand_expr_addr_expr_1): Only assemble_external for decls.
	Don't check VOIDmode here.  Force PLUS operands to common type.
	(expand_expr_addr_expr): Do VOIDmode check earlier.  Force use of
	Pmode if given a non pointer type.
	
	PR 17531
	* optabs.c (expand_binop): Force constants to the correct mode.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.5668&r2=2.5669
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/expr.c.diff?cvsroot=gcc&r1=1.724&r2=1.725
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/optabs.c.diff?cvsroot=gcc&r1=1.245&r2=1.246



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17531

[Bug tree-optimization/17531] [4.0 Regression] [ivopts] ICE compiling gzip deflate.c

[rth at gcc dot gnu dot org]

------- Additional Comments From rth at gcc dot gnu dot org  2004-09-28 23:12 -------
Fixed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17531