public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug tree-optimization/17687] New: [4.1] sincos can be folded at the tree level
@ 2004-09-27  9:12 bonzini at gcc dot gnu dot org
  2004-09-27  9:13 ` [Bug tree-optimization/17687] " bonzini at gcc dot gnu dot org
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: bonzini at gcc dot gnu dot org @ 2004-09-27  9:12 UTC (permalink / raw)
  To: gcc-bugs

If a sincos instruction is defined, it is profitable to introduce these foldings:

  sincos (x, &s, &c);
  sincos (-x, &s, &c);

to

  (*c = cos (x), *s = sin (x))
  (*c = cos (x), *s = -sin (x))

respectively.  This allows the sincos instruction to be used; the second folding
is necessary to avoid that the cos (x) = cos (-x) optimization kicks in, leaving
us with an unoptimizable

  (*c = cos (x), *s = sin (-x))

This patch is proposed for 4.1 through the 17652 metabug.

-- 
           Summary: [4.1] sincos can be folded at the tree level
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Keywords: missed-optimization
          Severity: enhancement
          Priority: P3
         Component: tree-optimization
        AssignedTo: bonzini at gcc dot gnu dot org
        ReportedBy: bonzini at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org,uros at kss-loka dot si


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17687


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug tree-optimization/17687] [4.1] sincos can be folded at the tree level
  2004-09-27  9:12 [Bug tree-optimization/17687] New: [4.1] sincos can be folded at the tree level bonzini at gcc dot gnu dot org
@ 2004-09-27  9:13 ` bonzini at gcc dot gnu dot org
  2004-09-27  9:13 ` bonzini at gcc dot gnu dot org
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: bonzini at gcc dot gnu dot org @ 2004-09-27  9:13 UTC (permalink / raw)
  To: gcc-bugs



-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |17652
              nThis|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17687


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug tree-optimization/17687] [4.1] sincos can be folded at the tree level
  2004-09-27  9:12 [Bug tree-optimization/17687] New: [4.1] sincos can be folded at the tree level bonzini at gcc dot gnu dot org
  2004-09-27  9:13 ` [Bug tree-optimization/17687] " bonzini at gcc dot gnu dot org
@ 2004-09-27  9:13 ` bonzini at gcc dot gnu dot org
  2004-09-27  9:14 ` bonzini at gcc dot gnu dot org
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: bonzini at gcc dot gnu dot org @ 2004-09-27  9:13 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From bonzini at gcc dot gnu dot org  2004-09-27 09:13 -------
*** Bug 17686 has been marked as a duplicate of this bug. ***

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17687


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug tree-optimization/17687] [4.1] sincos can be folded at the tree level
  2004-09-27  9:12 [Bug tree-optimization/17687] New: [4.1] sincos can be folded at the tree level bonzini at gcc dot gnu dot org
  2004-09-27  9:13 ` [Bug tree-optimization/17687] " bonzini at gcc dot gnu dot org
  2004-09-27  9:13 ` bonzini at gcc dot gnu dot org
@ 2004-09-27  9:14 ` bonzini at gcc dot gnu dot org
  2004-10-10  5:03 ` cvs-commit at gcc dot gnu dot org
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: bonzini at gcc dot gnu dot org @ 2004-09-27  9:14 UTC (permalink / raw)
  To: gcc-bugs



-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2004-09-27 09:14:46
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17687


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug tree-optimization/17687] [4.1] sincos can be folded at the tree level
  2004-09-27  9:12 [Bug tree-optimization/17687] New: [4.1] sincos can be folded at the tree level bonzini at gcc dot gnu dot org
                   ` (2 preceding siblings ...)
  2004-09-27  9:14 ` bonzini at gcc dot gnu dot org
@ 2004-10-10  5:03 ` cvs-commit at gcc dot gnu dot org
  2004-10-10  5:28 ` cvs-commit at gcc dot gnu dot org
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2004-10-10  5:03 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-10-10 05:03 -------
Subject: Bug 17687

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	mmitchel@gcc.gnu.org	2004-10-10 05:02:54

Modified files:
	gcc/testsuite  : ChangeLog 
	gcc/cp         : ChangeLog error.c init.c parser.c tree.c 
Added files:
	gcc/testsuite/g++.dg/init: new11.C 
	gcc/testsuite/g++.dg/parse: error19.C error20.C 
	gcc/testsuite/g++.dg/template: crash24.C 

Log message:
	PR c++/17867
	* error.c (dump_expr): Correct handling of AGGR_INIT_EXPRs using a
	constructor.
	
	PR c++/17670
	* init.c (build_new): Correct comments.
	* parser.c (cp_parser_new_expression): Use NULL_TREE for nelts in
	the non-array case.
	
	PR c++/17821
	* parser.c (cp_parser_postfix_dot_deref_expression): If the
	pseduo-destructor-name production does not work, fall back to the
	ordinary production.
	
	PR c++/17826
	* tree.c (cp_tree_equal): Handle a BASELINK.
	
	PR c++/17687
	* g++.dg/parse/error19.C: New test.
	
	PR c++/17670
	* g++.dg/init/new11.C: New test.
	
	PR c++/17821
	* g++.dg/parse/error20.C: New test.
	
	PR c++/17826
	* g++.dg/template/crash24.C: New test.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.4426&r2=1.4427
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/ChangeLog.diff?cvsroot=gcc&r1=1.4416&r2=1.4417
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/error.c.diff?cvsroot=gcc&r1=1.266&r2=1.267
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/init.c.diff?cvsroot=gcc&r1=1.398&r2=1.399
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/parser.c.diff?cvsroot=gcc&r1=1.261&r2=1.262
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/tree.c.diff?cvsroot=gcc&r1=1.413&r2=1.414
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/init/new11.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/parse/error19.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/parse/error20.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/template/crash24.C.diff?cvsroot=gcc&r1=NONE&r2=1.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17687


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug tree-optimization/17687] [4.1] sincos can be folded at the tree level
  2004-09-27  9:12 [Bug tree-optimization/17687] New: [4.1] sincos can be folded at the tree level bonzini at gcc dot gnu dot org
                   ` (3 preceding siblings ...)
  2004-10-10  5:03 ` cvs-commit at gcc dot gnu dot org
@ 2004-10-10  5:28 ` cvs-commit at gcc dot gnu dot org
  2005-03-05 19:49 ` pinskia at gcc dot gnu dot org
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2004-10-10  5:28 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-10-10 05:28 -------
Subject: Bug 17687

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_4-branch
Changes by:	mmitchel@gcc.gnu.org	2004-10-10 05:28:32

Modified files:
	gcc/testsuite  : ChangeLog 
	gcc/cp         : ChangeLog parser.c tree.c 
Added files:
	gcc/testsuite/g++.dg/parse: error20.C 
	gcc/testsuite/g++.dg/template: crash24.C 

Log message:
	PR c++/17867
	* error.c (dump_expr): Correct handling of AGGR_INIT_EXPRs using a
	constructor.
	
	PR c++/17670
	* init.c (build_new): Correct comments.
	* parser.c (cp_parser_new_expression): Use NULL_TREE for nelts in
	the non-array case.
	
	PR c++/17821
	* parser.c (cp_parser_postfix_dot_deref_expression): If the
	pseduo-destructor-name production does not work, fall back to the
	ordinary production.
	
	PR c++/17826
	* tree.c (cp_tree_equal): Handle a BASELINK.
	
	PR c++/17687
	* g++.dg/parse/error19.C: New test.
	
	PR c++/17670
	* g++.dg/init/new11.C: New test.
	
	PR c++/17821
	* g++.dg/parse/error20.C: New test.
	
	PR c++/17826
	* g++.dg/template/crash24.C: New test.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.3389.2.281&r2=1.3389.2.282
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.3892.2.165&r2=1.3892.2.166
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/parser.c.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.157.2.42&r2=1.157.2.43
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/tree.c.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.360.4.9&r2=1.360.4.10
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/parse/error20.C.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=NONE&r2=1.1.2.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/template/crash24.C.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=NONE&r2=1.1.2.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17687


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug tree-optimization/17687] [4.1] sincos can be folded at the tree level
  2004-09-27  9:12 [Bug tree-optimization/17687] New: [4.1] sincos can be folded at the tree level bonzini at gcc dot gnu dot org
                   ` (4 preceding siblings ...)
  2004-10-10  5:28 ` cvs-commit at gcc dot gnu dot org
@ 2005-03-05 19:49 ` pinskia at gcc dot gnu dot org
  2005-03-15  1:53 ` giovannibajo at libero dot it
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-03-05 19:49 UTC (permalink / raw)
  To: gcc-bugs



-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.1.0
            Version|unknown                     |4.0.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17687


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug tree-optimization/17687] [4.1] sincos can be folded at the tree level
  2004-09-27  9:12 [Bug tree-optimization/17687] New: [4.1] sincos can be folded at the tree level bonzini at gcc dot gnu dot org
                   ` (5 preceding siblings ...)
  2005-03-05 19:49 ` pinskia at gcc dot gnu dot org
@ 2005-03-15  1:53 ` giovannibajo at libero dot it
  2005-03-15  6:36 ` paolo dot bonzini at lu dot unisi dot ch
  2005-04-05  2:00 ` pinskia at gcc dot gnu dot org
  8 siblings, 0 replies; 10+ messages in thread
From: giovannibajo at libero dot it @ 2005-03-15  1:53 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From giovannibajo at libero dot it  2005-03-15 01:53 -------
Paolo, are you going to submit this one?

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17687


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug tree-optimization/17687] [4.1] sincos can be folded at the tree level
  2004-09-27  9:12 [Bug tree-optimization/17687] New: [4.1] sincos can be folded at the tree level bonzini at gcc dot gnu dot org
                   ` (6 preceding siblings ...)
  2005-03-15  1:53 ` giovannibajo at libero dot it
@ 2005-03-15  6:36 ` paolo dot bonzini at lu dot unisi dot ch
  2005-04-05  2:00 ` pinskia at gcc dot gnu dot org
  8 siblings, 0 replies; 10+ messages in thread
From: paolo dot bonzini at lu dot unisi dot ch @ 2005-03-15  6:36 UTC (permalink / raw)
  To: gcc-bugs


------- Additional Comments From paolo dot bonzini at lu dot unisi dot ch  2005-03-15 06:36 -------
Subject: Re:  [4.1] sincos can be folded at the
 tree level

> Paolo, are you going to submit this one?

Yes, but I am waaaay too busy at work now.  Maybe as soon as Thursday.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17687


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug tree-optimization/17687] [4.1] sincos can be folded at the tree level
  2004-09-27  9:12 [Bug tree-optimization/17687] New: [4.1] sincos can be folded at the tree level bonzini at gcc dot gnu dot org
                   ` (7 preceding siblings ...)
  2005-03-15  6:36 ` paolo dot bonzini at lu dot unisi dot ch
@ 2005-04-05  2:00 ` pinskia at gcc dot gnu dot org
  8 siblings, 0 replies; 10+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2005-04-05  2:00 UTC (permalink / raw)
  To: gcc-bugs



-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.1.0                       |---


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17687


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2005-04-05  2:00 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-09-27  9:12 [Bug tree-optimization/17687] New: [4.1] sincos can be folded at the tree level bonzini at gcc dot gnu dot org
2004-09-27  9:13 ` [Bug tree-optimization/17687] " bonzini at gcc dot gnu dot org
2004-09-27  9:13 ` bonzini at gcc dot gnu dot org
2004-09-27  9:14 ` bonzini at gcc dot gnu dot org
2004-10-10  5:03 ` cvs-commit at gcc dot gnu dot org
2004-10-10  5:28 ` cvs-commit at gcc dot gnu dot org
2005-03-05 19:49 ` pinskia at gcc dot gnu dot org
2005-03-15  1:53 ` giovannibajo at libero dot it
2005-03-15  6:36 ` paolo dot bonzini at lu dot unisi dot ch
2005-04-05  2:00 ` pinskia at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).