[Bug c++/9990] locale_facets.h contains invalid typedef

[Bug c++/9990] locale_facets.h contains invalid typedef

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |diagnostic
   Last reconfirmed|2003-08-02 03:25:34         |2003-11-25 01:31:48
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=9990

[Bug c++/9990] locale_facets.h contains invalid typedef

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-09-29 18:02 -------
I think this is related to PR 13095 or least the definition of what is a base class is.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=9990

[Bug c++/9990] locale_facets.h contains invalid typedef

[bangerth at gmail dot com]

------- Comment #14 from bangerth at gmail dot com  2010-02-19 00:56 -------
(In reply to comment #13)
> The library issue doesn't exist anymore ;) Thus, let's not be distracted by the
> trivial library case, ok?

I see, that's convenient :-)

In any case, in order to keep PRs focused on single issues, I have
opened PR 43117 to track the remaining language issue, and will make
the current PR a duplicate of that one.

Best
 W.




*** This bug has been marked as a duplicate of 43117 ***


-- 

bangerth at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |DUPLICATE


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=9990

[Bug c++/9990] locale_facets.h contains invalid typedef

[paolo dot carlini at oracle dot com]

------- Comment #13 from paolo dot carlini at oracle dot com  2010-02-18 20:57 -------
The library issue doesn't exist anymore ;) Thus, let's not be distracted by the
trivial library case, ok?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=9990

[Bug c++/9990] locale_facets.h contains invalid typedef

[paolo dot carlini at oracle dot com]

------- Comment #12 from paolo dot carlini at oracle dot com  2010-02-18 20:55 -------
Bah, I can do the change, sure, but if we are not resolving this issue, we are
not making progress on the number of open, long-standing, Bugzilla entries, and
that is *bad*.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=9990

[Bug c++/9990] locale_facets.h contains invalid typedef

[bangerth at gmail dot com]

------- Comment #11 from bangerth at gmail dot com  2010-02-18 20:53 -------
(In reply to comment #10)
> I'm not sure to fully understand, Wolfgang: you mean, we should change that
> line in the library instead of dealing with a possible C++ issue here? That
> would be easy to do, just tell me the exact form you would like to see, whose
> correctness you are 101% sure about, and let's close this PR!

I think there are two issues:
1/ A possible bug in the C++ front end, though from what I read Nathan felt
   unsure about it.
2/ A poorly written typedef that, depending on the outcome of 1/ may or may
   not be invalid, but in any case isn't easy to understand to the human
   reader.

Ideally, there would be separate PRs about these two issues. I was just
addressing the second point, which could be solved by replacing
  typedef typename ctype::mask      mask;
by
  typedef typename __ctype_abstract_base<_CharT>::mask mask;
which makes it abundantly clear that ctype::mask is not meant to be a 
reference to the typedef we are currently declaring.

Best
 W.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=9990

[Bug c++/9990] locale_facets.h contains invalid typedef

[paolo dot carlini at oracle dot com]

------- Comment #10 from paolo dot carlini at oracle dot com  2010-02-18 20:36 -------
I'm not sure to fully understand, Wolfgang: you mean, we should change that
line in the library instead of dealing with a possible C++ issue here? That
would be easy to do, just tell me the exact form you would like to see, whose
correctness you are 101% sure about, and let's close this PR!


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=9990

[Bug c++/9990] locale_facets.h contains invalid typedef

[bangerth at gmail dot com]

------- Comment #9 from bangerth at gmail dot com  2010-02-18 20:29 -------
(In reply to comment #8)
> For the record, all the compilers I have at hand, EDG based too, accept this in
> the most strict mode. I seriously doubt there is really something to fix here.

That said: if it is unclear to people well versed in the language standard
whether the code is correct or not (and does what it is supposed to do or not)
then one could argue that the code is also hard to read.

In other words: there may not be a need to change the code for *correctness
reasons*, but the *is* a need to change the code to make it more maintainable.
I believe that's a valid argument in software design to change things.

W.


-- 

bangerth at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bangerth at gmail dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=9990

[Bug c++/9990] locale_facets.h contains invalid typedef

[paolo dot carlini at oracle dot com]

------- Comment #8 from paolo dot carlini at oracle dot com  2010-02-18 16:56 -------
For the record, all the compilers I have at hand, EDG based too, accept this in
the most strict mode. I seriously doubt there is really something to fix here.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=9990

[Bug c++/9990] locale_facets.h contains invalid typedef

[gdr at gcc dot gnu dot org]

------- Comment #7 from gdr at gcc dot gnu dot org  2006-01-22 10:32 -------
(In reply to comment #6)
> I think this is related to PR 13095 or least the definition of what is a base
> class is.

That PR is different.  A using declaration must nominate a base class.
This PR is not about a using declaration.
I believe, however, that there is a core issue related to it.

-- Gaby


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=9990