[Bug libfortran/17748] New: libgfortran contains undefined references to _environ

[Bug libfortran/17748] New: libgfortran contains undefined references to _environ

[peter at pogma dot com]

libgfortran references environ which is not available to shared libraries directly on darwin. This means 
that we can not build fortran shared libraries without undefined symbols.

The solution is to use crt_externs.h and #define environ (*_NSGetEnviron()) in libgfortran/runtime/
environ.c.

-- 
           Summary: libgfortran contains undefined references to _environ
           Product: gcc
           Version: 4.0.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: libfortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: peter at pogma dot com
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: powerpc-apple-darwin
  GCC host triplet: powerpc-apple-darwin
GCC target triplet: powerpc-apple-darwin


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17748

[Bug libfortran/17748] libgfortran contains undefined references to _environ

[peter at pogma dot com]

------- Additional Comments From peter at pogma dot com  2004-09-30 13:43 -------
Created an attachment (id=7245)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=7245&action=view)
proposed patch


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17748

[Bug libfortran/17748] libgfortran contains undefined references to _environ

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-09-30 13:55 -------
all shared libraries in GCC are built with "-flat_namespace -undefined suppress" so ....

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
  GCC build triplet|powerpc-apple-darwin        |
   GCC host triplet|powerpc-apple-darwin        |
 GCC target triplet|powerpc-apple-darwin        |powerpc-darwin


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17748

[Bug libfortran/17748] libgfortran contains undefined references to _environ

[peter at pogma dot com]

------- Additional Comments From peter at pogma dot com  2004-09-30 14:04 -------
Yeah, but with undefined references in shared libraries in gfortran it means that it is impossible to 
create shared fortran libraries twolevel namespace on darwin. This was possible with f77.

In fact I see on closer inspection that libgcj.dylib has the same issue, I noticed the f77 issue by trying to 
run the libtool test suite with cvs gcc 4.0 and it skipped the f77 tests due to missing environ symbols.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17748

[Bug libfortran/17748] libgfortran contains undefined references to _environ

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-09-30 14:12 -------
This is still a bug as you cannot use the getenv intstricts on Darwin.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
 GCC target triplet|powerpc-darwin              |*-darwin
   Last reconfirmed|0000-00-00 00:00:00         |2004-09-30 14:12:28
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17748

[Bug libfortran/17748] libgfortran contains undefined references to _environ

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-10-14 14:26 -------
If I get some time, I will look into getting this done correctly, aka autoconf that we cannot use _environ 
and try to use _NSGetEnviron instead.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17748

[Bug libfortran/17748] libgfortran contains undefined references to _environ

[peter at pogma dot com]

------- Additional Comments From peter at pogma dot com  2004-10-15 13:04 -------
You want additional checks besides the crt_externs.h check in my patch? I think it highly unlikely that 
other platforms have this header, but if you like I can also check for the _NSGetEnviron function. It may 
take a little while though, I rm'ed the gcc tree I had checked out, was running out of disk space.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17748

[Bug libfortran/17748] libgfortran contains undefined references to _environ

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-10-27 14:49 -------
I basically just posted your patch with an addtional comment:
<http://gcc.gnu.org/ml/gcc-patches/2004-10/msg02341.html>.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pinskia at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17748

[Bug libfortran/17748] libgfortran contains undefined references to _environ

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-02-26 18:33 -------
Subject: Bug 17748

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	toon@gcc.gnu.org	2005-02-26 18:33:12

Modified files:
	libgfortran    : ChangeLog 
	libgfortran/runtime: environ.c 

Log message:
	2005-02-26  Peter O'Gorman  <peter@pogman.com>
	Toon Moene  <toon@moene.indiv.nluug.nl>
	
	PR libgfortran/17748
	* runtime/environ.c: Remove references to environ.
	(show_variables): remove GFORTRAN_UNBUFFERED_* and
	GFORTRAN_NAME_* because they require environ.
	(pattern_scan): Remove function.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/ChangeLog.diff?cvsroot=gcc&r1=1.163&r2=1.164
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/runtime/environ.c.diff?cvsroot=gcc&r1=1.7&r2=1.8



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17748

[Bug libfortran/17748] libgfortran contains undefined references to _environ

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-02-28 06:35 -------
Subject: Bug 17748

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-4_0-branch
Changes by:	toon@gcc.gnu.org	2005-02-28 06:34:55

Modified files:
	libgfortran    : ChangeLog 
	libgfortran/runtime: environ.c 

Log message:
	2005-02-25  Peter O'Gorman  <peter@pogma.com>
	Toon Moene  <toon@moene.indiv.nluug.nl>
	
	PR libgfortran/17748
	* runtime/environ.c: Remove references to environ.
	Update copyright years.
	(show_variables): remove GFORTRAN_UNBUFFERED_* and
	GFORTRAN_NAME_* because they require environ.
	(pattern_scan): Remove function.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.163.2.2&r2=1.163.2.3
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/runtime/environ.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.7&r2=1.7.10.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17748

[Bug libfortran/17748] libgfortran contains undefined references to _environ

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-02-28 13:16 -------
Fixed in 4.0.0.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.0.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17748