* [Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures
2004-10-05 2:18 [Bug bootstrap/17832] New: [4.0 Regression] Bootstrap broken by fixincludes failures aaronavay62 at aaronwl dot com
@ 2004-10-05 2:19 ` aaronavay62 at aaronwl dot com
2004-10-05 2:24 ` pinskia at gcc dot gnu dot org
` (16 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: aaronavay62 at aaronwl dot com @ 2004-10-05 2:19 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From aaronavay62 at aaronwl dot com 2004-10-05 02:19 -------
Patch here: <http://gcc.gnu.org/ml/gcc-patches/2004-09/msg02731.html>
--
What |Removed |Added
----------------------------------------------------------------------------
CC| |bonzini at gnu dot org
Keywords| |patch
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures
2004-10-05 2:18 [Bug bootstrap/17832] New: [4.0 Regression] Bootstrap broken by fixincludes failures aaronavay62 at aaronwl dot com
2004-10-05 2:19 ` [Bug bootstrap/17832] " aaronavay62 at aaronwl dot com
@ 2004-10-05 2:24 ` pinskia at gcc dot gnu dot org
2004-10-05 2:46 ` aaronavay62 at aaronwl dot com
` (15 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-10-05 2:24 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pinskia at gcc dot gnu dot org 2004-10-05 02:24 -------
Really fixinclude should just be fixed instead of working around the issue. See PR 14316.
The reason why fixinclude should be fixed instead of working around the issue is because really not
running it will make some targets not work correctly.
--
What |Removed |Added
----------------------------------------------------------------------------
Severity|critical |minor
Status|UNCONFIRMED |NEW
Ever Confirmed| |1
Last reconfirmed|0000-00-00 00:00:00 |2004-10-05 02:24:52
date| |
Target Milestone|--- |4.0.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures
2004-10-05 2:18 [Bug bootstrap/17832] New: [4.0 Regression] Bootstrap broken by fixincludes failures aaronavay62 at aaronwl dot com
2004-10-05 2:19 ` [Bug bootstrap/17832] " aaronavay62 at aaronwl dot com
2004-10-05 2:24 ` pinskia at gcc dot gnu dot org
@ 2004-10-05 2:46 ` aaronavay62 at aaronwl dot com
2004-10-14 8:16 ` bonzini at gcc dot gnu dot org
` (14 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: aaronavay62 at aaronwl dot com @ 2004-10-05 2:46 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From aaronavay62 at aaronwl dot com 2004-10-05 02:46 -------
I agree, but it in the meantime, it would be nice for mainline to bootstrap.
Since fixincludes has never built on Windows, this isn't a regression, but
bootstrap failing definitely is. When fixincludes has been fixed, presumably
after libiberty gets whatever changes needed to make collect2 work, mingw32 can
be removed from the list of targets to not build fixincludes for.
I don't know what the reason for disabling fixincludes on the other targets is,
though.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures
2004-10-05 2:18 [Bug bootstrap/17832] New: [4.0 Regression] Bootstrap broken by fixincludes failures aaronavay62 at aaronwl dot com
` (2 preceding siblings ...)
2004-10-05 2:46 ` aaronavay62 at aaronwl dot com
@ 2004-10-14 8:16 ` bonzini at gcc dot gnu dot org
2004-10-14 8:58 ` bonzini at gcc dot gnu dot org
` (13 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: bonzini at gcc dot gnu dot org @ 2004-10-14 8:16 UTC (permalink / raw)
To: gcc-bugs
--
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|unassigned at gcc dot gnu |bonzini at gcc dot gnu dot
|dot org |org
Status|NEW |ASSIGNED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures
2004-10-05 2:18 [Bug bootstrap/17832] New: [4.0 Regression] Bootstrap broken by fixincludes failures aaronavay62 at aaronwl dot com
` (3 preceding siblings ...)
2004-10-14 8:16 ` bonzini at gcc dot gnu dot org
@ 2004-10-14 8:58 ` bonzini at gcc dot gnu dot org
2004-10-14 9:17 ` aaronavay62 at aaronwl dot com
` (12 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: bonzini at gcc dot gnu dot org @ 2004-10-14 8:58 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From bonzini at gcc dot gnu dot org 2004-10-14 08:58 -------
Needs a configury maintainer. Bruce Korb said he's fine with it.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures
2004-10-05 2:18 [Bug bootstrap/17832] New: [4.0 Regression] Bootstrap broken by fixincludes failures aaronavay62 at aaronwl dot com
` (4 preceding siblings ...)
2004-10-14 8:58 ` bonzini at gcc dot gnu dot org
@ 2004-10-14 9:17 ` aaronavay62 at aaronwl dot com
2004-10-14 16:21 ` ericw at evcohs dot com
` (11 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: aaronavay62 at aaronwl dot com @ 2004-10-14 9:17 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From aaronavay62 at aaronwl dot com 2004-10-14 09:17 -------
I think fixincludes is very close to building on Windows, and so probably should
not be disabled after all for this target, since its needed in some
configurations. Presumably the other targets still should be disabled.
All that is needed to make it build is resolution to PR 17991, a patch to enable
two-process fixincludes for i?86-*-mingw32*, and a patch that does the
equivilent of <http://gcc.gnu.org/ml/gcc-patches/2004-09/msg01393.html>. I will
probably resubmit a version of the latter tomorrow that addresses the comments
here <http://gcc.gnu.org/ml/gcc-patches/2004-10/msg01045.html>.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures
2004-10-05 2:18 [Bug bootstrap/17832] New: [4.0 Regression] Bootstrap broken by fixincludes failures aaronavay62 at aaronwl dot com
` (5 preceding siblings ...)
2004-10-14 9:17 ` aaronavay62 at aaronwl dot com
@ 2004-10-14 16:21 ` ericw at evcohs dot com
2004-10-20 8:21 ` cvs-commit at gcc dot gnu dot org
` (10 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: ericw at evcohs dot com @ 2004-10-14 16:21 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From ericw at evcohs dot com 2004-10-14 16:21 -------
See related bug #17462.
--
What |Removed |Added
----------------------------------------------------------------------------
CC| |ericw at evcohs dot com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures
2004-10-05 2:18 [Bug bootstrap/17832] New: [4.0 Regression] Bootstrap broken by fixincludes failures aaronavay62 at aaronwl dot com
` (6 preceding siblings ...)
2004-10-14 16:21 ` ericw at evcohs dot com
@ 2004-10-20 8:21 ` cvs-commit at gcc dot gnu dot org
2004-10-20 8:39 ` aaronavay62 at aaronwl dot com
` (9 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2004-10-20 8:21 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2004-10-20 08:21 -------
Subject: Bug 17832
CVSROOT: /cvs/gcc
Module name: gcc
Changes by: aaronwl@gcc.gnu.org 2004-10-20 08:21:10
Modified files:
fixincludes : ChangeLog fixincl.c fixlib.h procopen.c
Log message:
PR bootstrap/17832
* fixincl.c (SIGCHLD): Remove definition.
(initialize): Remove SIGIOT and SIGPIPE checks.
(create_file): Fix mkdir() for Win32.
(internal_fix): Use dup2() instead of fcntl().
* fixlib.h (SIGQUIT): Define if undefined.
(SIGIOT): Same.
(SIGPIPE): Same.
(SIGALRM): Same.
(SIGKILL): Same.
* procopen.c (chain_open): Use dup2() instead of fcntl().
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fixincludes/ChangeLog.diff?cvsroot=gcc&r1=1.9&r2=1.10
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fixincludes/fixincl.c.diff?cvsroot=gcc&r1=1.2&r2=1.3
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fixincludes/fixlib.h.diff?cvsroot=gcc&r1=1.2&r2=1.3
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fixincludes/procopen.c.diff?cvsroot=gcc&r1=1.1&r2=1.2
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures
2004-10-05 2:18 [Bug bootstrap/17832] New: [4.0 Regression] Bootstrap broken by fixincludes failures aaronavay62 at aaronwl dot com
` (7 preceding siblings ...)
2004-10-20 8:21 ` cvs-commit at gcc dot gnu dot org
@ 2004-10-20 8:39 ` aaronavay62 at aaronwl dot com
2004-10-21 9:52 ` bonzini at gcc dot gnu dot org
` (8 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: aaronavay62 at aaronwl dot com @ 2004-10-20 8:39 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From aaronavay62 at aaronwl dot com 2004-10-20 08:39 -------
One more patch left to be reviewed, besides PR17991:
<http://gcc.gnu.org/ml/gcc-patches/2004-10/msg01618.html>.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures
2004-10-05 2:18 [Bug bootstrap/17832] New: [4.0 Regression] Bootstrap broken by fixincludes failures aaronavay62 at aaronwl dot com
` (8 preceding siblings ...)
2004-10-20 8:39 ` aaronavay62 at aaronwl dot com
@ 2004-10-21 9:52 ` bonzini at gcc dot gnu dot org
2004-10-21 21:28 ` aaronavay62 at aaronwl dot com
` (7 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: bonzini at gcc dot gnu dot org @ 2004-10-21 9:52 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From bonzini at gcc dot gnu dot org 2004-10-21 09:52 -------
Aaron, I'm assigning the PR to you because it is very close to being fixed, and
I think it is easier if it is assigned to the author of the patch. I hope you
don't mind.
PR17991 is still assigned to me and it covers the bugs in moving fixincludes to
the toplevel (hopefully the outstanding patch will be reviewed soon).
--
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|bonzini at gcc dot gnu dot |aaronavay62 at aaronwl dot
|org |com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures
2004-10-05 2:18 [Bug bootstrap/17832] New: [4.0 Regression] Bootstrap broken by fixincludes failures aaronavay62 at aaronwl dot com
` (9 preceding siblings ...)
2004-10-21 9:52 ` bonzini at gcc dot gnu dot org
@ 2004-10-21 21:28 ` aaronavay62 at aaronwl dot com
2004-10-22 5:18 ` aaronavay62 at aaronwl dot com
` (6 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: aaronavay62 at aaronwl dot com @ 2004-10-21 21:28 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From aaronavay62 at aaronwl dot com 2004-10-21 21:28 -------
Well, I was a little confused earlier, and perhaps I still am. Should
fixincludes be built on target=mingw bootstraps? I don't think so; as far as I
know, its only needed for crosses. But perhaps there might be some good reason
to enable it anyway?
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures
2004-10-05 2:18 [Bug bootstrap/17832] New: [4.0 Regression] Bootstrap broken by fixincludes failures aaronavay62 at aaronwl dot com
` (10 preceding siblings ...)
2004-10-21 21:28 ` aaronavay62 at aaronwl dot com
@ 2004-10-22 5:18 ` aaronavay62 at aaronwl dot com
2004-10-22 5:21 ` aaronavay62 at aaronwl dot com
` (5 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: aaronavay62 at aaronwl dot com @ 2004-10-22 5:18 UTC (permalink / raw)
To: gcc-bugs
--
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO| |18107
nThis| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures
2004-10-05 2:18 [Bug bootstrap/17832] New: [4.0 Regression] Bootstrap broken by fixincludes failures aaronavay62 at aaronwl dot com
` (11 preceding siblings ...)
2004-10-22 5:18 ` aaronavay62 at aaronwl dot com
@ 2004-10-22 5:21 ` aaronavay62 at aaronwl dot com
2004-10-26 21:40 ` pinskia at gcc dot gnu dot org
` (4 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: aaronavay62 at aaronwl dot com @ 2004-10-22 5:21 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From aaronavay62 at aaronwl dot com 2004-10-22 05:21 -------
*** Bug 17462 has been marked as a duplicate of this bug. ***
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures
2004-10-05 2:18 [Bug bootstrap/17832] New: [4.0 Regression] Bootstrap broken by fixincludes failures aaronavay62 at aaronwl dot com
` (12 preceding siblings ...)
2004-10-22 5:21 ` aaronavay62 at aaronwl dot com
@ 2004-10-26 21:40 ` pinskia at gcc dot gnu dot org
2004-10-26 21:51 ` aaronavay62 at aaronwl dot com
` (3 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2004-10-26 21:40 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pinskia at gcc dot gnu dot org 2004-10-26 21:40 -------
This is fixed now right?
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures
2004-10-05 2:18 [Bug bootstrap/17832] New: [4.0 Regression] Bootstrap broken by fixincludes failures aaronavay62 at aaronwl dot com
` (13 preceding siblings ...)
2004-10-26 21:40 ` pinskia at gcc dot gnu dot org
@ 2004-10-26 21:51 ` aaronavay62 at aaronwl dot com
2004-10-27 14:44 ` bonzini at gcc dot gnu dot org
` (2 subsequent siblings)
17 siblings, 0 replies; 19+ messages in thread
From: aaronavay62 at aaronwl dot com @ 2004-10-26 21:51 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From aaronavay62 at aaronwl dot com 2004-10-26 21:51 -------
Sorry, I missed putting the PR tag in the commit log. However, no, this bug
really should not be closed yet. That patch just disabled building fixincludes.
The real patch that needs to be committed is in #8, which will make fixincludes
build appropriately when its needed, such as in *-mingw32's case, when
crosscompiling. It needs to be reviewed by Bruce Korb, I think.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures
2004-10-05 2:18 [Bug bootstrap/17832] New: [4.0 Regression] Bootstrap broken by fixincludes failures aaronavay62 at aaronwl dot com
` (14 preceding siblings ...)
2004-10-26 21:51 ` aaronavay62 at aaronwl dot com
@ 2004-10-27 14:44 ` bonzini at gcc dot gnu dot org
2004-10-27 20:14 ` cvs-commit at gcc dot gnu dot org
2004-10-27 20:18 ` aaronavay62 at aaronwl dot com
17 siblings, 0 replies; 19+ messages in thread
From: bonzini at gcc dot gnu dot org @ 2004-10-27 14:44 UTC (permalink / raw)
To: gcc-bugs
--
Bug 17832 depends on bug 17991, which changed state.
Bug 17991 Summary: [4.0 Regression] Two-process fixincludes broken: pz_mn_name_pat undefined
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17991
What |Old Value |New Value
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures
2004-10-05 2:18 [Bug bootstrap/17832] New: [4.0 Regression] Bootstrap broken by fixincludes failures aaronavay62 at aaronwl dot com
` (15 preceding siblings ...)
2004-10-27 14:44 ` bonzini at gcc dot gnu dot org
@ 2004-10-27 20:14 ` cvs-commit at gcc dot gnu dot org
2004-10-27 20:18 ` aaronavay62 at aaronwl dot com
17 siblings, 0 replies; 19+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2004-10-27 20:14 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2004-10-27 20:14 -------
Subject: Bug 17832
CVSROOT: /cvs/gcc
Module name: gcc
Changes by: aaronwl@gcc.gnu.org 2004-10-27 20:13:58
Modified files:
fixincludes : ChangeLog fixfixes.c
Log message:
PR bootstrap/17832
* fixfixes.c (main): Check for _PC_NAME_MAX.
----------------------------------------------------------------------
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fixincludes/ChangeLog.diff?cvsroot=gcc&r1=1.11&r2=1.12
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/fixincludes/fixfixes.c.diff?cvsroot=gcc&r1=1.2&r2=1.3
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Bug bootstrap/17832] [4.0 Regression] Bootstrap broken by fixincludes failures
2004-10-05 2:18 [Bug bootstrap/17832] New: [4.0 Regression] Bootstrap broken by fixincludes failures aaronavay62 at aaronwl dot com
` (16 preceding siblings ...)
2004-10-27 20:14 ` cvs-commit at gcc dot gnu dot org
@ 2004-10-27 20:18 ` aaronavay62 at aaronwl dot com
17 siblings, 0 replies; 19+ messages in thread
From: aaronavay62 at aaronwl dot com @ 2004-10-27 20:18 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From aaronavay62 at aaronwl dot com 2004-10-27 20:17 -------
Fixed on mainline. I think this is the end of fixincludes problems for Windows.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17832
^ permalink raw reply [flat|nested] 19+ messages in thread